Commit graph

7 commits

Author SHA1 Message Date
Ryan Macnak 29c50c6ebe Fix list_files.py so it is python3-compatible.
Cf. 86fe7ca75c

Change-Id: I17bb00b6e39fe27c725a2026a4ced824ad360a4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135624
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-02-15 00:12:50 +00:00
Nate Bosch 55f81f2210 Mass format python with yapf
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.

Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-05 20:34:31 +00:00
Zachary Anderson ccfafee023 Make list_files.py and list_dart_files.py return absolute paths for GN
This makes doing an SDK build in the Fuchsia tree easier.

The previous attempt at this change failed in gyp builds targeting xcode.
They failed because input lists for actions of the same target (e.g. the
actions for dartanalyzer) are merged and de-duped when the lists contain
relative paths, but merged and *not* de-duped when the lists contain
absolute paths. gyp rejects xcode files that it generated itself
when they contain duplicate entries.

This CL works around that bug, by using absolute paths in the GN build
and keeping relative paths in the gyp build.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2567213002 .
2016-12-13 10:01:28 -08:00
Zachary Anderson b873e2b8e3 Revert "Make list_files.py and list_dart_files.py return absolute paths"
This reverts commit a858542c89.

mac gyp build fails.

Review-Url: https://codereview.chromium.org/2574523002 .
2016-12-12 13:14:53 -08:00
Zachary Anderson a858542c89 Make list_files.py and list_dart_files.py return absolute paths
This makes doing an SDK build in the Fuchsia tree easier

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2564413004 .
2016-12-12 13:09:26 -08:00
Adam Barth 0ea1c155ae Fix the Fuchsia build
Python scripts need to be marked executable to run in the Fuchsia build.

TBR=zra@google.com
2016-10-27 09:59:58 -07:00
Bob Nystrom 8b6ceefca8 Tweak how the pkg files timestamps are created.
The acute problem this solves is that hacking on DDC generates a large
number of files into its gen/ directory. It's enough files that once you
have done that, the SDK no longer builds successfully because it chokes
on them all.

To fix that, instead of using list_files.py, I made a little
list_dart_files.py that is explicitly for Dart files and knows to
exclude gen/ and tests. This also avoids needing the sort of hairy
regexes to match different sets of files.

As far as I can tell, this works, but GYP is pretty mysterious to me,
so let me know if I got something wrong or there is a better way to do
it.

R=whesse@google.com

Review URL: https://codereview.chromium.org/2391863002 .
2016-10-04 16:56:12 -07:00