pq
5619ec500e
prefer “exclude” language for excluded entities
...
See for example:
* https://9to5google.com/2020/06/12/google-android-chrome-blacklist-blocklist-more-inclusive/
* https://thenextweb.com/dd/2020/06/15/github-plans-to-replace-racially-insensitive-terms-like-master-and-whitelist/
Change-Id: I51fe56bb7a09c5cc3280119e2c121aac86e44f8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151303
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2020-06-15 18:48:06 +00:00
Parker Lougheed
ecce58c1e3
[vm/ffi] Remove documentation from setters
...
Now that bf7e9d13d7
has landed and the analysis
server can pull docs from corresponding getters, we can remove the extra
docs on the setters.
Fixes #38892
Bug: https://github.com/dart-lang/sdk/issues/38892
Change-Id: I0f96a1b1b1513706912c651e9d1d5b3da043a148
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148747
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2020-05-21 09:18:10 +00:00
Ben Konyi
7d7f7b5692
[ dartfuzz ] Regenerate type table now that TypeError does not implement AssertionError
...
Change-Id: I0863c47b1285b90da2f91e66b444d4b6b09727b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137042
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-02-24 21:49:08 +00:00
Daco Harkes
01f4479372
[vm/ffi] Change internal loads and stores to take byteOffesets
...
Change-Id: Iaff7aa9f158b3b168ccf2d7014a43b08afaa448e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136182
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-02-18 12:16:16 +00:00
Ben Konyi
aae3d0817f
Reland "[ DartFuzz ] Prevent generated programs from explicitly throwing OutOfMemoryError"
...
This reverts commit f120417ddb
.
Change-Id: Idcda5011952b0b3973d1cc2490db153ad741658b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135162
Reviewed-by: Siva Annamalai <asiva@google.com>
2020-02-10 23:57:21 +00:00
Siva Annamalai
f120417ddb
Revert "[ DartFuzz ] Prevent generated programs from explicitly throwing OutOfMemoryError"
...
This reverts commit 9464eb51f5
.
Reason for revert: Causes a failure in the Analyzer bot, some analysis errors.
Original change's description:
> [ DartFuzz ] Prevent generated programs from explicitly throwing OutOfMemoryError
>
> Programs generated by dartfuzz.dart explicitly look for OOM errors and
> return with a specific error code (254) to notify dartfuzz_test.dart
> that the program exited after running out of memory. If both
> configurations being tested return 254, the result for that fuzzing run
> is counted as "skipped", artificially inflating the "skipped" count.
>
> Fixes https://github.com/dart-lang/sdk/issues/40493
>
> Change-Id: I552dbd497fe514da929b08a7a523616d1d3db538
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134903
> Auto-Submit: Ben Konyi <bkonyi@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
TBR=bkonyi@google.com ,rmacnak@google.com,asiva@google.com
Change-Id: I23e286bb9c5aba1513fbc66bcb6d49221cbd4aba
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/135000
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Siva Annamalai <asiva@google.com>
2020-02-08 19:37:12 +00:00
Ben Konyi
9464eb51f5
[ DartFuzz ] Prevent generated programs from explicitly throwing OutOfMemoryError
...
Programs generated by dartfuzz.dart explicitly look for OOM errors and
return with a specific error code (254) to notify dartfuzz_test.dart
that the program exited after running out of memory. If both
configurations being tested return 254, the result for that fuzzing run
is counted as "skipped", artificially inflating the "skipped" count.
Fixes https://github.com/dart-lang/sdk/issues/40493
Change-Id: I552dbd497fe514da929b08a7a523616d1d3db538
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134903
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-02-08 01:03:39 +00:00
Ben Konyi
aadcb4418b
[ DartFuzz ] Disable floating point operations when comparing different architectures
...
Comparing floating point results from different architectures can lead
to false divergences due to floating point errors or slightly different
implementations of specific operations (e.g., Float32x4.clamp behaves
differently around 0.0 for ARM and x64).
Should fix false divergences related to https://github.com/dart-lang/sdk/issues/40426
Change-Id: Ife0ab07d20e87add4e754e328bb8f7389920021d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134573
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-02-06 02:00:49 +00:00
Ben Konyi
a9bc5edbae
[ dartfuzz ] Additional logging cleanup
...
Change-Id: I5bf18fb17089902b463ebb6561f40069047ee665
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134540
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-02-05 19:47:59 +00:00
Ben Konyi
bbe0e3b768
[ DartFuzz ] Quality of life improvements in log output
...
- Updated reproduction commands to not include bot paths (should be
copy-pasteable and runnable from $SDK_ROOT now).
- Fixed issue where Dart SDK revision wasn't being printed on the bots
Change-Id: Ia53986332eb7997d5b3911c5de4e5ce1d61e6eb3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134420
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-02-04 22:06:30 +00:00
Vyacheslav Egorov
ab56c2f841
[runtime/docs] Add custom lexer for shell sessions in runtime wiki.
...
This was missing from the previous wiki related commit.
TBR=aam@google.com
Change-Id: Ib68ead3bab2841bb8e02cb93fd71bce7515ff335
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134285
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2020-02-04 09:16:52 +00:00
Vyacheslav Egorov
857b911f3b
[vm/docs] Publish "Introduction to Dart VM" source and build tools.
...
Change-Id: I30068d6492bd6ec4ce42cc50d4a481960a0197fe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133985
Reviewed-by: Alexander Aprelev <aam@google.com>
2020-02-04 09:04:32 +00:00
Ben Konyi
d44c74cd5b
[ dartfuzz ] Fixed type table for sumManyDoubles
...
Parameter list was assumed to be 10 integers but should have been 10
doubles
Change-Id: Ie4e74b756a76decf8cf663d41a04a7e931fee16d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133156
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-01-24 01:27:02 +00:00
Ben Konyi
420c958333
[ dartfuzz ] Fixed DartFuzz collection script to reflect changes in infra pages
...
Change-Id: I6f3375cc5b013a02e40d235a8e2dcc2f69dbf25d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132747
Reviewed-by: Alexander Thomas <athom@google.com>
2020-01-22 18:21:03 +00:00
Ben Konyi
ab67e6045c
[ dartfuzz ] Disable operator / for Float64x2 and Float32x4
...
Seems to cause us to hit the ASSERT in https://github.com/dart-lang/sdk/issues/39890
Change-Id: Ibb08aeeac885d2a37e663eeaa8e47fd5d7fdf22a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130936
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-01-10 23:25:31 +00:00
Ben Konyi
ac2e24b514
[ dartfuzz ] Properly filter Float32x4.fromInt32x4Bits from being emitted in programs generated by DartFuzz
...
Change-Id: Ibb6caa1fcec540b7e07c2bc95fd202397490b225
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130884
Auto-Submit: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-01-09 19:29:56 +00:00
Ben Konyi
55a34f3392
[ dartfuzz ] Temporarily prevent Float32x4.fromInt32x4Bits from being emitted in generated programs.
...
Seems to be causing us to hit an ASSERT (see
https://github.com/dart-lang/sdk/issues/39890 ).
Change-Id: I8007a5356d21bf1f2615e6bee47cee01c50eadca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130736
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2020-01-08 22:54:16 +00:00
Ben Konyi
9a5161f8fe
[ dartfuzz ] Fix update_spreadsheet.py so it can be run from any directory.
...
Change-Id: I3867a633f254a992d2bef2a8adde886cf5e5261b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129580
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-12-26 22:21:04 +00:00
Fizaa Luthra
4dd9734b96
[dartfuzz] Disable stopwatch
...
Change-Id: I5fac0d3538ef6428bd9e90260032c69d89bb5679
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129204
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-20 01:19:57 +00:00
Fizaa Luthra
141fcfa610
[dartfuzz] Adding fuzzing support for more core types
...
Change-Id: Id377a58a54cb17cb3e7e337efb9de01d237aa5a3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128766
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-19 22:21:13 +00:00
Fizaa Luthra
aaff5b6951
[dartfuzz] Put gen_api_table.dart constants in alphabetical order
...
Change-Id: I07506be86e49cd8aaa4fcbe934cb8b706bf677c4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129000
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-18 22:14:31 +00:00
Ryan Macnak
83eeab1e63
Miscellaneous documentation updates.
...
Change-Id: I9cc022443ba70b0a450a86943f7636dc6f8c975c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128373
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-12-13 23:10:55 +00:00
Ben Konyi
df4a022b00
[ dartfuzz ] Output Dart SDK revision to logs during fuzz testing
...
Change-Id: Ic55b46198455cca399b17b873bfdda1b7efb6c09
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128374
Reviewed-by: Fizaa Luthra <fizaaluthra@google.com>
2019-12-13 21:24:23 +00:00
Fizaa Luthra
ea6fe62bb4
[dartfuzz] Refactoring gen_api_table.dart
...
This CL removes the character encoding for types in the fuzzer.
Change-Id: I00fd76158932d8b5723c3f760e2d6c71beb5e5cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127820
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-13 20:39:26 +00:00
Fizaa Luthra
0bc0531e6c
[dartfuzz] Add flag for displaying output divergence details
...
Change-Id: I2cbea08ca809092fad013cc20bb6bceeb4fa770d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128006
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-12 01:56:25 +00:00
Fizaa Luthra
bc40858f94
[dartfuzz] Re-enabling Int32x4
...
Re-enabling as we fixed https://github.com/dart-lang/sdk/issues/39518 .
Change-Id: I4fc2fdf4cbb0bd5dfec96616085c58590d0d87f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128000
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-12-12 00:37:10 +00:00
Ryan Macnak
3678a3bd42
[build] Use separate out directories for each sanitizer.
...
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: Ie0aeaff758234220c2f0267b462d14f4c076bdf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127821
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2019-12-11 18:12:47 +00:00
Fizaa Luthra
55f86c13cb
[dartfuzz] Fix infinite recursion
...
Change-Id: Ie758aae5bf2d455b3232eebfb5a2e960041a4520
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127581
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-12-09 19:29:29 +00:00
Fizaa Luthra
c31db57c97
[dartfuzz] Add support for simple recursion
...
Change-Id: I306d787dbcb154a3c51f13c9e01006d871a2213d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126611
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-12-07 01:36:34 +00:00
Fizaa Luthra
b8dbaaa527
[dartfuzz] Fix infinite recursion in call methods
...
Change-Id: Ia9add544bdb12fa806dbcfcedf41ccf023d48fa3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127204
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-12-05 00:24:08 +00:00
Fizaa Luthra
e25744c44e
[dartfuzz] Adding support for callable classes
...
Change-Id: I631820590faf714fa4f472ce4b78cea62621b2e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126086
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-12-03 00:25:50 +00:00
Fizaa Luthra
de36aa0f1a
[dartfuzz] Temporarily disable Float32x4.reciprocal() and Float32x4.reciprocalSqrt()
...
Will revert this change after we resolve https://github.com/dart-lang/sdk/issues/39551 .
Change-Id: Ic2b9b6a185c2b610f526187bf75d11ee229398f8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126608
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-11-29 23:38:26 +00:00
Fizaa Luthra
edf08f63ed
[dartfuzz] Temporarily disabling Int32x4
...
Change-Id: I5faf799a5e3567f3f95bf65c279d0ac95363e193
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126400
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-11-26 23:04:10 +00:00
Ben Konyi
1ecb8c7038
[ dartfuzz ] Added update_spreadsheet.py which automatically updates DartFuzzStats with latest fuzzing run results
...
Change-Id: I3352d27785cabd3052c8db458390277f768dd1c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126240
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Fizaa Luthra <fizaaluthra@google.com>
2019-11-26 22:16:30 +00:00
Fizaa Luthra
fc47953a1e
[dartfuzz] Adding library methods for TypedData types
...
Change-Id: I9df9a9c0b15adf281def748dc3bd15d62d6fa529
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125725
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-11-22 20:43:17 +00:00
Fizaa Luthra
4456d01a35
[dartfuzz] Fix ffi check in getMethods
...
Change-Id: Ib3818f7a05c5d0edc9491ef45d2162c6b8a1fa71
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125921
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-11-21 19:02:26 +00:00
Fizaa Luthra
5ec93e211f
[dartfuzz] Adding fuzzer support for extension methods on core library types
...
Change-Id: Ie0637917db86ca89ace40bba363ee12314c3b459
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125124
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-11-18 23:25:48 +00:00
Fizaa Luthra
ea6c7f29fa
[fuzzer] Added void functions to the API table
...
Change-Id: I048607903ba15f604a9d0784b75061ac0d0d397c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125305
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Aart Bik <ajcbik@google.com>
2019-11-15 19:07:54 +00:00
Fizaa Luthra
8eb13e5eda
[dartfuzz] Restrict size parameter to a small integer for List<int>.filled
...
Change-Id: I8ebb3167a4b9d7c81d8fe9d1a45df8fd53933741
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125301
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-11-14 22:54:12 +00:00
Fizaa Luthra
e5655d5cfe
[dartfuzz] Make generic types explicit when using API table
...
Bug: https://github.com/dart-lang/sdk/issues/39356
Change-Id: I04244bbac578dd6b399e664d381f1dab0a5852da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124910
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-11-14 01:19:15 +00:00
Wink Saville
bbdb7860f6
[build]: Build on Arch Linux with python 2.7-3.8
...
This change allow builds to succeed on Arch Linux with python 2.7, 3.7.4
and 3.8. Otherwise it fails with python 3.7.4 and 3.8.
- bin_to_assembly.py
Using ord(byte) here is an error on python 3.x use a conditional
expression instead.
- create_archive.py
Using ord(byte) here is an error on python 3.x use a conditional
expression instead.
Use `as inst` syntax which is required by 3.x
- create_string_literal.py
- gen_library_src_paths.py
Use `as inst` syntax which is required by 3.x
- make_version.py
print >> sys.stderr syntax is not supported by 3.x use file=sys.stderr
and add `from __future__ import print_function`
vmhash.update requires a string use encode('utf-8')
versopm+cc+text.replace requires a str so use `decode`.
Test: No added tests as there are no behavioral changes.
Change-Id: Id9b0a3187d06ad2b2dce3cf2244144393caddc9a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124211
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-11-10 21:09:58 +00:00
Fizaa Luthra
1b344fc77e
[dartfuzz] Add fuzzer support for extension methods for classes
...
Change-Id: I3843990921d93727e17dd2593177bdf7af740571
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123340
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Fizaa Luthra <fizaaluthra@google.com>
2019-11-09 01:26:59 +00:00
Konstantin Shcheglov
0804a6f260
Don't use deprecated analyzer elements in dartfuzz.
...
Change-Id: Ib6a1ddb831854c60604fa57aeac2103443ee8efe
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124101
Reviewed-by: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2019-11-04 22:37:45 +00:00
Samir Jindel
c885bdde1d
[vm] DBC is obsolete. Remove dead code.
...
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-27 18:18:29 +00:00
Aart Bik
5478c381db
[dart/fuzzer] Resort to constant collections inside subscripts
...
Rationale:
Using constant, small collections inside subscripts avoids
growing collections too much due to allocating new elements
for every literal. This also allows using non-flat data
structures again in our nightly testing.
https://github.com/dart-lang/sdk/issues/38710
Change-Id: If4bdc72f88f8c7d181709e829d35105a54cf8889
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122423
Commit-Queue: Aart Bik <ajcbik@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2019-10-22 20:22:26 +00:00
Aart Bik
f77d7197b8
[vm/fuzzer] add --enable-asserts to AOT step
...
Rationale:
This exposes certain bugs in a cleaner way
than just crashing. See bug for an example.
https://github.com/dart-lang/sdk/issues/38965
https://github.com/dart-lang/sdk/issues/38979
Change-Id: Ib6ce52e31d5ca539fb4aedab989638949751627f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122168
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2019-10-21 20:27:28 +00:00
Aart Bik
bf4d4b2461
[dart/fuzzer] re-enable spread at all depths in fuzzer
...
Rationale:
front end team fixed bug in parsing these constructs
https://github.com/dart-lang/sdk/issues/38874
Change-Id: I2bc812c1ae3e4465cac93111836a21875a89b527
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122420
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2019-10-21 18:55:24 +00:00
Ben Konyi
0b045aea2b
[ VM ] Removed tests/standalone along with any references in build bot / test runner configurations
...
Deleted irrelevant tests and migrated valid tests to Dart 2
Change-Id: If37611e051b7e2f128c53267f606d480d7fe23a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121902
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2019-10-17 00:41:16 +00:00
Aart Bik
01bd0ab62f
[vm/fuzzer] Always add OOM catch in try-catch-finally
...
Rationale:
OOM situations are treated as false divergences at
the test runner level. However, we still had a few
situations where the OOM was caught by a regular
exception handler and, thus, reported as an output
divergence. This fixes it. Also some formatting fixes.
https://github.com/dart-lang/sdk/issues/38871
Change-Id: Idb235cc4ed749c9f1384020dcc4a5739f5bc47e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121880
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Aart Bik <ajcbik@google.com>
2019-10-16 18:39:16 +00:00
Ben Konyi
438d3c154b
[ dartfuzz ] Only emit new
occasionally, replace rollDice(2) with coinFlip()
...
Bumped version to 1.61
Change-Id: If6f5a0417e4173cc256354d62a0405c4ddd2c44b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121761
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2019-10-15 18:52:59 +00:00