languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-22 06:21:17 +00:00
Code Issues Packages Projects Releases Wiki Activity
35061 commits 11 branches 6011 tags 1.4 GiB
Commit graph

110 commits

Author SHA1 Message Date
Konstantin Shcheglov 1933891bad Issue 25057. A static member cannot be implemented. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25057

Review URL: https://codereview.chromium.org/1488443002 .
 2015-11-29 19:20:25 -08:00
Konstantin Shcheglov c302b65584 Use async/await in all analysis domain tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1478513002 .
 2015-11-24 14:18:37 -08:00
Konstantin Shcheglov cfb7d61a9c Issue 25034. Record only the target source's errors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25034

Review URL: https://codereview.chromium.org/1477553002 .
 2015-11-24 14:00:00 -08:00
Konstantin Shcheglov 670db50707 Generate separate navigation regions for 'super' and optional 'name'. 
Also support for navigation regions for RedirectingConstructorInvocation.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1465303003 .
 2015-11-23 14:27:03 -08:00
Konstantin Shcheglov a689bf4180 Report error for ignored priority file. Ignore subscription for ignored files. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1462693002 .
 2015-11-18 17:31:58 -08:00
Konstantin Shcheglov abe8d87e0e Implement AnalysisServer.getContainingContext() using ContextManager. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1455163005 .
 2015-11-18 14:10:35 -08:00
Konstantin Shcheglov 03eed1c3c9 Fix for duplicate priority sources. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1408163008 .
 2015-10-29 17:46:00 -07:00
Konstantin Shcheglov 7b75a53fef Fix for regions reported with multiple targets. 
We should merge them into single NavigationRegion(s) with multiple targets.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1403373018 .
 2015-10-28 16:38:12 -07:00
pq 2f9c4af993 Error Suppression FTW. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1420363005 .
 2015-10-28 09:59:05 -07:00
pq 52fb3b3bab Introducing a lint server plugin. 
Avoids introducing an unwanted dependency on the options plugin to server (efects discovered: https://codereview.chromium.org/1411313005/). Also soon to be future home for fixes and completions.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1410553005 .
 2015-10-26 12:11:38 -07:00
Konstantin Shcheglov 289bd0a056 [Atom] Issue 424. Fix for 'getNavigation' and index expressions. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/424

Review URL: https://codereview.chromium.org/1402353009 .
 2015-10-25 11:29:54 -07:00
pq afa746230f Lint option change propagation test. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1417963004 .
 2015-10-21 15:22:13 -07:00
pq 6c85fe785a Analysis Options error notifications. 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1411013003 .
 2015-10-21 09:59:19 -07:00
Konstantin Shcheglov 18a29ba8a8 Tweak for make test passing with useTaskModel = true. 
A real fix after final actual switching.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1410493005 .
 2015-10-16 08:29:35 -07:00
pq 91e5facc0f Registry memory leak fixes. 
Fixes #24549.

A few notes:
  * does away with registry in favor of context-associated configurations
  * pulls in linter rev that does the context association
  * bumps analyzer version before publishing (needed to update analyzer_cli)

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1406043002 .
 2015-10-15 14:24:20 -07:00
Konstantin Shcheglov a30bcd7b97 Issue 24599. Fix for requesting navigation for directives. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24599

Review URL: https://codereview.chromium.org/1405033002 .
 2015-10-15 10:54:06 -07:00
pq cae05d6bd4 Context invalidation on option changes (Implements #24574). 
R=brianwilkerson@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1399893004 .
 2015-10-14 20:42:50 -07:00
Brian Wilkerson 9ad256cf18 Move the wire protocol support into the public API 
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/1398293002 .
 2015-10-11 07:34:28 -07:00
pq 695256d586 Linter hookup into AS. 
Note the TODO to fix the extension manager interaction hijinx.  Really we should ensure that we are only using the one in engine.  At the moment, it's easy to get this wrong (as the initialization heroics herein testify).

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1392683003 .
 2015-10-09 13:40:07 -07:00
pq 90e975b656 Suppress scanner errors for non-existent URIs. 
Fixes #23754.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1378503003 .
 2015-10-06 10:25:50 -07:00
Konstantin Shcheglov 0e7f4b5717 Fix hover documentation for parameters. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org/1384583007 .
 2015-10-05 07:04:20 -07:00
Brian Wilkerson 66a122a9db Stop defensively copying AST structures before resolution 
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1383043002 .
 2015-10-02 12:38:18 -07:00
Konstantin Shcheglov 62fd9ac787 Issue 24487. Annotations with constructor resolution should produce navigation reginos to constructors. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24487

Review URL: https://codereview.chromium.org/1378713004 .
 2015-10-02 10:44:58 -07:00
Konstantin Shcheglov 03e379de7a Compute Outline.kind/libraryName actually. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24279

Review URL: https://codereview.chromium.org/1380103005 .
 2015-10-01 13:09:38 -07:00
Florian Schneider c4d0ff8a4c pkg: Eliminate flaky analysis test failure. 
Running in debug mode (or any slower configuration) makes this test fail since
it waits for a max of 100 event loop iterations for the analysis results.

Instead wait without limit until results are ready, with checking every few milliseconds.

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1379153002 .
 2015-10-01 19:34:50 +02:00
Konstantin Shcheglov 1d28f99524 Fix for 'implemented' notification after an incremental change. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1374943005 .
 2015-09-30 11:08:41 -07:00
Konstantin Shcheglov 83f94a2114 Add navigation region for 'library' directives. 
Dart Editor uses presence of a navigation region as a sign that there is something that can be renamed, and enables the Rename action.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1373593002 .
 2015-09-25 12:35:51 -07:00
Konstantin Shcheglov df827a06ae The 'analysis.implemented' notification implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1368793003 .
 2015-09-25 12:33:02 -07:00
Konstantin Shcheglov 5fd8b38737 Tweak navigation for 'part of' directives. 
This makes it consistent with import/export/part directives, where only URIs are navigation sources.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1365663002 .
 2015-09-23 10:14:49 -07:00
Konstantin Shcheglov 4aa6466ccb Use IndexContributor(s) in LocalIndex. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1359113002 .
 2015-09-23 08:17:33 -07:00
Konstantin Shcheglov 75600fc162 Report UNRESOLVED_INSTANCE_MEMBER_REFERENCE for dynamicVar.member references. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1345943006 .
 2015-09-17 10:37:04 -07:00
Konstantin Shcheglov a01281370b Fix for dynamic instance field reference highlighting. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1349223002 .
 2015-09-17 09:25:22 -07:00
Konstantin Shcheglov d71bda7c05 Highlight library identifiers as LIBRARY_NAME. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1352843002 .
 2015-09-17 09:24:14 -07:00
Konstantin Shcheglov e090ff872e Issue 24277. Use node's offset as the source range start for the first unit node in Outline. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/24277

Review URL: https://codereview.chromium.org//1325143003 .
 2015-09-02 17:55:15 -07:00
Konstantin Shcheglov 7e99b8696e Support for analysis.setPriorityFiles for files in SDK. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-atom/dartlang/issues/215

Review URL: https://codereview.chromium.org//1289643003 .
 2015-08-17 10:48:38 -07:00
Konstantin Shcheglov 7ab954efb5 Remove debug output in getNavigation(). 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1288163003 .
 2015-08-12 14:02:07 -07:00
Konstantin Shcheglov e9d2f739ad More tweaks in attempt to debug the reason of failing getNavigation() tests. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1284933002 .
 2015-08-11 11:13:48 -07:00
Konstantin Shcheglov 089f84f6cd Keep only unique overridden elements. 
If the implemented interfaces don't declare an element, keep only a single copy of the element - from the superclass.

In Dart Editor we use any element, but in in IDEA we show all of them, and we don't want to have duplicates.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1273003005 .
 2015-08-10 16:13:43 -07:00
Brian Wilkerson 908708d655 More fixes for failures on the Windows bot 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1266923004 .
 2015-08-05 08:13:28 -07:00
Brian Wilkerson f909ed8adf Add test for references in comments 
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1256333008 .
 2015-07-30 11:20:00 -07:00
Konstantin Shcheglov 14e1cdc86c Fix for 'analysis.getNavigation' implementation. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1260503002 .
 2015-07-24 14:27:20 -07:00
Paul Berry 128dec84b5 Separate the API's used by ContextManager. 
Previously, ContextManager had two API's: one used by analysis server
to tell the ContextManager what to do, and one used by the
ContextManager to make callbacks to analysis server in response to its
requests.  The first API was implemented in the class
AbstractContextManager, which derived from ContextManager, and the
second API was implemented in ServerContextManager, which derived from
AbstractContextManager.

In addition to causing confusion, this made it impossible to provide
an alternate implementation of ContextManager as a plug-in, since the
plug in would have had to re-implement the second API, and that would
have required accessing private implementation details of the
ContextManager.

This CL separates the API's: the first API is specified in
ContextManager and implemented in ContextManagerImpl, and the second
API is specified in ContextManagerCallbacks and implemented in
ServerContextManagerCallbacks.

In the long run I hope to eliminate the ContextManagerCallbacks class
entirely, by having the ContextManager tell its client what to do
using return values rather than callbacks.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1243893002 .
 2015-07-21 10:40:57 -07:00
Konstantin Shcheglov d5d0017e21 Tweak for navigation for URIs. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1246833002 .
 2015-07-20 15:07:00 -07:00
Konstantin Shcheglov 55cb93b422 Add '--useAnalysisHighlight2' option to generate version 2 of semantic highlight. 
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1241193002 .
 2015-07-20 10:37:46 -07:00
Paul Berry 2f6ebaa774 Only send "analysis.analyzedFiles" notification when the set of files changes. 
R=jwren@google.com

Review URL: https://codereview.chromium.org//1233003002 .
 2015-07-13 15:52:28 -07:00
Brian Wilkerson 2ffa8de794 Add notification of analyzed files 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1232393005 .
 2015-07-13 15:07:33 -07:00
Brian Wilkerson 41f74711e0 (TBR) Fix a broken test 
Review URL: https://codereview.chromium.org//1232913002 .
 2015-07-13 12:45:56 -07:00
Brian Wilkerson 0c6872acef Hook for overriding the ContextManager and some code clean-up (with more to follow) 
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1223413003 .
 2015-07-13 10:20:13 -07:00
Brian Wilkerson 10b7db100f Revert "Update Analysis Server highlight API and implementation." 
This reverts commit 739847402b.

Rolling the wire protocol API version forward caused existing clients to break, so we're rolling it back until we can find a backward compatible way of adding the new functionality.

R=paulberry@google.com

Review URL: https://codereview.chromium.org//1236433003 .
 2015-07-13 09:49:55 -07:00
Konstantin Shcheglov 3f99fc1744 Add test for 'getNavigation'. 
R=paulberry@google.com
BUG=

Review URL: https://codereview.chromium.org//1229833004 .
 2015-07-13 07:46:07 -07:00