Commit graph

2207 commits

Author SHA1 Message Date
Oleh Prypin 47cfe5f97f Roll dart_style into the SDK
Includes just one more commit - "Enable support for inline class syntax"

Change-Id: Ie230fc72b7170d3610bdd7ed7ab8c193338f8a93
Bug: b/271244238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287020
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2023-03-07 16:29:09 +00:00
Janice Collins a899b17908 Update dartdoc to 6.2.0.
Change-Id: I10e37442904eb9161a98fb257696854be2412001
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286867
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2023-03-06 18:59:10 +00:00
Daco Harkes b1e59721d4 Revert "[vm] Remove tcmalloc and malloc profiler."
This reverts commit c67fac9cb4.

Reason for revert: Regresses `dart:io` performance and causes
failures.
https://github.com/dart-lang/sdk/issues/51639

Original change's description:
> [vm] Remove tcmalloc and malloc profiler.
>
> The standalone VM originally began statically linking tcmalloc to work around bugs in the system malloc for Fiber. Later it used tcmalloc's hooks to implement a profiler, but this is rarely used since it is only available in debug mode, misses early allocations, and often misses late allocations from an exhausted sample buffer. Removing it altogether avoids build complexity around which combinations of compiler/architecture/sysroot support tcmalloc, and reduces binary size.
>
> TEST=ci
> Change-Id: I4b259e18b82b2d12a2a60962aabf83bd8d997d19
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286120
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>

Change-Id: I4395edd6f5bd7e26b4e38f4d931ad2ea67afba18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286925
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
2023-03-06 10:28:33 +00:00
Ryan Macnak c67fac9cb4 [vm] Remove tcmalloc and malloc profiler.
The standalone VM originally began statically linking tcmalloc to work around bugs in the system malloc for Fiber. Later it used tcmalloc's hooks to implement a profiler, but this is rarely used since it is only available in debug mode, misses early allocations, and often misses late allocations from an exhausted sample buffer. Removing it altogether avoids build complexity around which combinations of compiler/architecture/sysroot support tcmalloc, and reduces binary size.

TEST=ci
Change-Id: I4b259e18b82b2d12a2a60962aabf83bd8d997d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286120
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-03 23:32:12 +00:00
Robert Nystrom c33ece3515 Roll dart_style into the SDK.
This contains support for all of the 3.0 language features. It also
contains a couple of very minor style changes. Unlike the previous
reverted roll (https://dart-review.googlesource.com/c/sdk/+/285460),
this does *not* contain the style change to support compact switch
statements. This should eliminate most of the style churn.

Change-Id: I95dd73a3a921b4a0cd278a7abb86daf8eea21397
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286701
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2023-03-03 18:53:20 +00:00
Ryan Macnak 3633ff4e71 Roll Clang from 20d06c833d83 to 28ee6040710f.
Address overflow warnings in ffi test library.

TEST=ci
Change-Id: I80e54d367532cbc392d6176dae97e9b545968de3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286660
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-03-03 18:22:32 +00:00
Devon Carew 008c7bc60c Bump cli_util to 91747f7dd9bdf2457f081d3cf035de5672dd4a02
Changes:
```
> git log --format="%C(auto) %h %s" 3851652..91747f7
 https://dart.googlesource.com/cli_util.git/+/91747f7 Update README.md (79)
 https://dart.googlesource.com/cli_util.git/+/525f2a8 remove getSdkDir; prep to publish 0.4.0 (78)

```

Diff: https://dart.googlesource.com/cli_util.git/+/3851652a72ee572ec7371942a658788c61847dea..91747f7dd9bdf2457f081d3cf035de5672dd4a02/
Change-Id: Ibc2330337b72023f8b0ae39fda6512a01532fc0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286702
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-03-03 17:53:17 +00:00
Ryan Macnak 2269ac16db Revert "Roll Clang from 20d06c833d83 to 28ee6040710f"
This reverts commit 69b9559caf.

Reason for revert: Windows error: overflow in expression

Original change's description:
> Roll Clang from 20d06c833d83 to 28ee6040710f
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/clang-dart-sdk
> Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
> To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
> Change-Id: I433a87e0b7a2f8407ea3b8e23a1894957cfa23ac
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286580
> Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

Change-Id: I09a090a33fb663327eb74e5a192714673bcd661f
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286608
Auto-Submit: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2023-03-02 22:56:27 +00:00
DEPS Autoroller 69b9559caf Roll Clang from 20d06c833d83 to 28ee6040710f
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: I433a87e0b7a2f8407ea3b8e23a1894957cfa23ac
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286580
Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2023-03-02 22:24:25 +00:00
Oleh Prypin 88ac4a27a1 Revert "Roll the latest dart_style into the SDK."
This reverts commit bbba3c9788.

Reason for revert: latest dart_style has a few bugs and overall the changes should be discussed more

Original change's description:
> Roll the latest dart_style into the SDK.
>
> This includes support for records, patterns, sealed classes, and class
> modifiers. It also includes a fairly small number of style changes. The
> one that will be most noticeable is more compact switch statements.
>
> Change-Id: I9e89ba82d52bfa451fc54f9dd59048d72db48377
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285460
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>

Change-Id: I12fad53bdc75dda349b9362aeb84e798983bfa25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286420
Reviewed-by: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
2023-03-02 13:16:36 +00:00
eliasyishak 638ca5cfd4 Updating the analytics package name
Change-Id: I586c244e9d88196f5dca56a6f83a9a5e661d078c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286281
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Elias Yishak <eliasyishak@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2023-03-01 22:31:47 +00:00
Robert Nystrom bbba3c9788 Roll the latest dart_style into the SDK.
This includes support for records, patterns, sealed classes, and class
modifiers. It also includes a fairly small number of style changes. The
one that will be most noticeable is more compact switch statements.

Change-Id: I9e89ba82d52bfa451fc54f9dd59048d72db48377
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285460
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2023-03-01 16:08:40 +00:00
eliasyishak 99658458d8 Updating version for tools package
Change-Id: I4d9b467f4ee7a3c1318ba0fa725dd5e22cde564f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286041
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Elias Yishak <eliasyishak@google.com>
2023-02-28 22:08:43 +00:00
Polina Cherkasova 7491995fd6 Bump DevTools DEP to 2.22.2
Change-Id: If77008721a0182977b44ae699b93405819295ce8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286063
Reviewed-by: Dan Chevalier <danchevalier@google.com>
Commit-Queue: Polina Cherkasova <polinach@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2023-02-28 21:20:27 +00:00
Devon Carew cf60e70356 [deps] rev cli_util, crypto, test, vector_math, webdev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

cli_util (fd38b5f..3851652):
  3851652  2023-02-24  Kevin Moore  Move to dart_flutter_team_lints, require Dart 2.19 (#77)
  705bb29  2023-02-24  Kevin Moore  blast_repo fixes (#76)

crypto (03eb2c9..9efb888):
  9efb888  2023-02-23  Kevin Moore  move to pkg:dart_flutter_team_lints, require Dart 2.19 (#141)

test (2cc4144..1307cc5):
  1307cc59  2023-02-23  Nate Bosch  Add ComparableChecks extension (#1960)
  66f2985c  2023-02-24  Pascal Welsch  Fix isNotEmpty rejection (#1959)
  cf10dc5b  2023-02-23  Nate Bosch  Condition must have dynamic generic in deepEquals (#1958)
  6fc48d03  2023-02-23  Nate Bosch  Fix timeouts when a predicate throws instead (#1957)

vector_math (920e9b6..1e4d000):
  1e4d000  2023-02-23  Kevin Moore  Move to latest team lints, require Dart 2.19 (#281)

webdev (1e7f9b7..deb801b):
  deb801b  2023-02-24  Devon Carew  contribute issue templates and pull request labeling (#1979)
  74a6520  2023-02-24  Elliott Brooks (she/her)  [MV3 Debug Extension] Use new Dart Debug Extension bug template (#1992)
  c1f325c  2023-02-24  Elliott Brooks (she/her)  [MV3 Debug Extension] Bolt debugging: can reload the page and continue to debug (#1991)
  057f598  2023-02-23  Elliott Brooks (she/her)  [MV3 Debug Extension] Small fixes for building the extension (#1990)
  28a090e  2023-02-23  Anna Gringauze  Run dwds tests in a copy of the sdk directory (#1989)
  b58d3eb  2023-02-23  Anna Gringauze  Run webdev tests in a copy of the sdk directory (#1987)

Change-Id: Iaad67eec68cf3cfeba832abbeb42728043e15b22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285760
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2023-02-27 21:07:29 +00:00
Sergey G. Grekhov 27cfabdac0 [co19] Roll co19 to 7b4f3e723211011878e185db6fa57fbafabd6bb7
2023-02-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1878. Fix type inference in type_inference_A26_t01.dart (dart-lang/co19#1892)
2023-02-23 sgrekhov22@gmail.com dart-lang/co19#1401. Patterns execution. Assignment and switch statement tests (dart-lang/co19#1857)
2023-02-23 sgrekhov22@gmail.com dart-lang/co19#1401. Test for relational pattern with nullable type added (dart-lang/co19#1887)
2023-02-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1890. Fix collection in scope_A02_t04.dart (dart-lang/co19#1891)
2023-02-23 sgrekhov22@gmail.com Fixes dart-lang/co19#1877. No compile-time error if type-test is failed in a refutable context (dart-lang/co19#1886)

Change-Id: I25d5fc2113bc1284bc5d90bd91874b77f541c472
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285260
Reviewed-by: Alexander Thomas <athom@google.com>
2023-02-24 09:51:28 +00:00
Brian Wilkerson fac43ed0ba Update the tools packages to the latest commit
Change-Id: I0c58a4a677b3c0bbfded304a69a5bfdfb6c2b441
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284960
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
2023-02-23 20:01:25 +00:00
Devon Carew ae2aaf83e9 [deps] rev dartdoc, http, markdown, shelf, test, tools, webdev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

dartdoc (dba6f94..e4cdbd6):
  e4cdbd6f  2023-02-21  Janice Collins  Record rendering simplification (#3344)

http (c13a3f8..1500a71):
  1500a71  2023-02-23  Devon Carew  contribute a pull request labeler workflow (#875)
  e2c4e6f  2023-02-21  Brian Quinlan  Add a link to cronet_http_embedded from cronet_http. (#874)

markdown (4befe66..ecbffa9):
  ecbffa9  2023-02-22  Kevin Moore  Use latest lints, require Dart 2.19 or later (#524)

shelf (707c8b2..e3cfe79):
  e3cfe79  2023-02-22  Devon Carew  contribute issue templates and a pull request labeler (#332)

test (e56c643..2cc4144):
  2cc4144e  2023-02-22  Nate Bosch  Avoid exceptions for iterable getters (#1954)
  f7fe4f06  2023-02-22  Nate Bosch  Include stack trace for exception in has (#1953)
  ba8e43af  2023-02-22  Nate Bosch  Only grab the first failure in softCheck (#1949)
  34df652b  2023-02-22  Nate Bosch  Flush stdin before test (#1950)
  ae015ef6  2023-02-22  Nidal Bakir  Add Concurrency Testing section to README (#1944)
  4e23d036  2023-02-21  Nate Bosch  Mention .having and .has in migration guide (#1948)
  438c2274  2023-02-21  Nate Bosch  Annotate `has` with `@useResult` (#1947)
  3ddecafd  2023-02-21  Nate Bosch  Add async examples to README (#1946)

tools (a53933c..c7518f7):
  c7518f7  2023-02-22  Elias Yishak  Update to regex to look for underscore delimited labels (#12)

webdev (ae7eb80..1e7f9b7):
  1e7f9b7  2023-02-22  Anna Gringauze  Create copying sdk configuration provider (#1984)
  26910ba  2023-02-22  Anna Gringauze  Pass SdkLayout to the frontend server (#1986)
  784e28b  2023-02-22  Anna Gringauze  Remove unnecessary awaits (#1982)
  3cbaf37  2023-02-22  Elliott Brooks (she/her)  [MV3 Debug Extension] Support Bolt workflow (#1983)
  0f893e6  2023-02-22  Anna Gringauze  Move project definitions into a separate class (#1975)
  a942b5f  2023-02-22  Anna Gringauze  Add unnecessary_lambdas lint (#1978)
  3774cf8  2023-02-21  Anna Gringauze  Add 'avoid_void_async' lint (#1977)
  705e0ac  2023-02-21  Elliott Brooks (she/her)  [MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page (#1976)

Change-Id: Iea264a18a154e71cd0990e1363951648bec5ceba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-02-23 17:02:53 +00:00
Sergey G. Grekhov 22f797b25a [co19] Roll co19 to 8db40c0c17735ac9f84cbc7d014bfde9f14240fd
2023-02-22 sgrekhov22@gmail.com Fixes dart-lang/co19#1884. Typo in scope_A02_t06.dart fixed (dart-lang/co19#1885)
2023-02-22 sgrekhov22@gmail.com dart-lang/co19#1401. Pattern type inference. Tests for Never added (dart-lang/co19#1883)
2023-02-22 sgrekhov22@gmail.com Fixes dart-lang/co19#1879. Wrong use of `var` and `final` fixed (dart-lang/co19#1882)
2023-02-21 sgrekhov22@gmail.com dart-lang/co19#1401. Type checking and pattern required type tests (dart-lang/co19#1855)
2023-02-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1865. Change expected error message in analyzer (dart-lang/co19#1866)
2023-02-21 asashour@yahoo.com Correct `a` and `an` (dart-lang/co19#1863)
2023-02-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1864. Fix shared_case_scope_A04_t01.dart to work on web-platforms (dart-lang/co19#1867)
2023-02-21 sgrekhov22@gmail.com Fixes dart-lang/co19#1868. Make switch statement exhaustive (dart-lang/co19#1869)

Change-Id: I67d1a9a992e0485cad649f9a64a5d554b4ac05a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284880
Reviewed-by: Alexander Thomas <athom@google.com>
2023-02-23 14:00:17 +00:00
Sam Rawlins 85154631c9 Bump linter to dcf3a079c573487b6ab64518604e5686be899601
We need the fix for https://github.com/dart-lang/linter/issues/4077 in
order to land https://dart-review.googlesource.com/c/sdk/+/282661

Change-Id: I472455dd24e6ef49095c20b1ab9912051a942d5e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284540
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2023-02-22 02:00:48 +00:00
Dan Chevalier 56b303e64b Bump DevTools DEP to 2.22.1
Change-Id: I6410ae9ad68151be5e50affd435d449ad43a125e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284460
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Dan Chevalier <danchevalier@google.com>
2023-02-21 21:49:23 +00:00
Sergey G. Grekhov 3424cc8db7 [co19] Roll co19 to f91e5d74f9f0444495ca961fa5dafacac9a6922a
2023-02-17 sgrekhov22@gmail.com dart-lang/co19#1399. [Records] Allow legacy libraries that don't support records to still be able to see the Record class in "dart:core" (dart-lang/co19#1571)
2023-02-17 sgrekhov22@gmail.com dart-lang/co19#1860. Fix type_inference_A12_t01.dart. Don't expect warning (dart-lang/co19#1862)
2023-02-17 sgrekhov22@gmail.com Fixes dart-lang/co19#1860. Fix roll failures (dart-lang/co19#1861)
2023-02-16 sgrekhov22@gmail.com dart-lang/co19#1401. Calculating the static type of the pattern tests added (dart-lang/co19#1847)
2023-02-16 sgrekhov22@gmail.com dart-lang/co19#1401. Shared case scope test with labels and default case added (dart-lang/co19#1858)
2023-02-15 sgrekhov22@gmail.com Fixes dart-lang/co19#1837. Add additional unnecessary null-ckeck warnings (dart-lang/co19#1842)

Change-Id: I3a1f5deafd4f2868574f085495417ed37fe845b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284080
Reviewed-by: Alexander Thomas <athom@google.com>
2023-02-21 08:58:26 +00:00
Devon Carew 9bc32f1914 [deps] rev args, characters, dartdoc, ffi, http, markdown, mockito, path, pool, source_maps, test, tools, webdev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (b08471e..9305d5a):
  9305d5a  2023-02-15  Naoto Kaneko  Update README.md (#236)

characters (29f3a3e..3281cc7):
  3281cc7  2023-02-16  Devon Carew  blast_repo fixes (#75)

dartdoc (3931595..dba6f94):
  dba6f946  2023-02-16  Janice Collins  Preserve type aliases for records in output (#3340)
  96e61903  2023-02-16  Sam Rawlins  Remove unused additionalOptions parameter, other little refactorings (#3339)
  f64290e1  2023-02-13  Devon Carew  remove an unused css attribute (#3335)
  c055526a  2023-02-13  Devon Carew  fix an issue where we created a temporary directory when performing a dry run (#3334)
  1f6c8db5  2023-02-13  dependabot[bot]  Bump github/codeql-action from 2.2.1 to 2.2.4 (#3337)
  f1fa0efc  2023-02-13  dependabot[bot]  Bump actions/cache from 3.2.4 to 3.2.5 (#3338)

ffi (69d7596..32f5eef):
  32f5eef  2023-02-20  Daco Harkes  Bump SDK constraint to 4.0.0 (#185)

http (f4b365e..c13a3f8):
  c13a3f8  2023-02-17  Alex Li   Add Cronet embedded tool (#853)

markdown (f51c24c..4befe66):
  4befe66  2023-02-16  Zhiguang Chen  Do not generate heading IDs for headings with no content in `HeaderWithIdSyntax` (#522)
  cae08af  2023-02-15  Kevin Moore  Prepare to release v7.0.1 (#520)
  bdbaf76  2023-02-15  Zhiguang Chen  Remove lookarounds from autolink extension patterns (#519)
  eb09fac  2023-02-14  Kevin Moore  Move to pkg:dart_flutter_team_lints (#518)
  51a6389  2023-02-15  Zhiguang Chen  Add line endings to HTML blocks (#512)
  a4cd7a0  2023-02-14  Kevin Moore  Label tests that only run on the VM: allows running tests with browser (#516)
  6788042  2023-02-14  Kevin Moore  CI: add publish and response workflows (#517)

mockito (d2a8df1..ed5bd84):
  ed5bd84  2023-01-09  Ross Wang  Relax mixin criteria
  781752c  2023-02-13  Sam Rawlins  Change `void` to `dynamic` when overriding method arguments
  71e41b9  2023-02-10  Sam Rawlins  Add `ignore_for_file: use_of_void_result`
  d5a25f8  2023-02-08  Sam Rawlins  Fix violations of `unnecessary_parenthesis` lint

path (a95f1e9..24b58a2):
  24b58a2  2023-02-20  Kevin Moore  Move to team lints, require Dart 2.19 (#138)
  8ec8ca0  2023-02-18  Kevin Moore  blast_repo fixes (#137)

pool (51f1131..694cfd8):
  694cfd8  2023-02-20  Kevin Moore  move to package:dart_flutter_team_lints, require Dart 2.19 (#65)
  40bf2af  2023-02-20  Kevin Moore  blast_repo fixes (#64)

source_maps (cf44db3..a112e98):
  a112e98  2023-02-16  Devon Carew  configure publishing automation (#74)

test (b5e70db..e56c643):
  e56c6439  2023-02-17  Jacob MacDonald  Add exe compiler, supports running tests compiled to native executables (#1941)
  f80dfa00  2023-02-16  Nate Bosch  Add note about why we are replacing matcher (#1940)
  732ae1de  2023-02-15  Nate Bosch  Add `because` usage in examples (#1939)
  f6df9756  2023-02-15  Jacob MacDonald  Fix typo in readme (#1937)
  aca53419  2023-02-14  Nate Bosch  Add a caret constraint for matcher (#1927)
  f7f3a019  2023-02-14  Jacob MacDonald  use test_api/backend.dart instead of test_core/backend.dart (#1936)
  de40c1c0  2023-02-14  Jacob MacDonald  Add support for `--compiler` flag (#1903)
  1f42db8c  2023-02-13  Devon Carew  updates to package:checks docs (#1933)

tools (48a544b..a53933c):
  a53933c  2023-02-17  Elias Yishak  [package:dash_analytics] Tests for conforming to GA4 Measurement Protocol limitations (#9)
  c54430b  2023-02-17  Devon Carew  add some clarification to the top-level readme (#8)

webdev (0bae2be..ae7eb80):
  ae7eb80  2023-02-17  Anna Gringauze  Add tests for object inspection (#1973)
  7d80a2c  2023-02-17  Elliott Brooks (she/her)  Ignore offset / count if an instance has no `length`  (#1972)
  cd66172  2023-02-17  Elliott Brooks (she/her)  [MV3 Debug Extension] User can reload app and continue to debug (#1968)
  8b7f9d3  2023-02-16  Anna Gringauze  Re-enable weak webdev tests (#1960)
  83d8e47  2023-02-16  Elliott Brooks (she/her)  [MV3 Debug Extension] Variables in panel.dart should be private (#1969)
  4e85e74  2023-02-16  Elliott Brooks (she/her)  [MV3 Debug Extension] The new debug extension can be run on Manifest V3 or Manifest V2 (#1966)
  3982f5f  2023-02-15  Elliott Brooks (she/her)  [MV3 Debug Extension] Clean up tests in preparation for supporting compiling to MV2  (#1964)
  3ad544e  2023-02-15  Elliott Brooks (she/her)  [MV3 Debug Extension] Remove isMV3Extension field from DevtoolsRequest (#1963)
  c77043e  2023-02-14  Elliott Brooks (she/her)  [MV3 Debug Extension] Fix isDevMode getter (#1962)
  a761125  2023-02-14  Elliott Brooks (she/her)  [MV3 Debug Extension] Print `console` messages on test failure (#1961)
  41e92be  2023-02-14  Anna Gringauze  Create test_common package (#1945)
  443f820  2023-02-14  Anna Gringauze  Re-enable skipped reload test (#1958)
  a7bc3fc  2023-02-14  Anna Gringauze  Make dart-uri-file-uri test use sound null safety (#1959)
  464a8eb  2023-02-14  Elliott Brooks (she/her)  [MV3 Debug Extension] Compile extension with Dart instead of shell script (#1954)
  7cf8fe2  2023-02-13  Anna Gringauze  Fix asset handler tests (#1956)
  c371ad7  2023-02-13  Anna Gringauze  Fix chrome_proxy_service tests broken after switch to null safety by default (#1957)
  d6ec127  2023-02-13  Anna Gringauze  Move test-only code from the SdkLayout (#1955)
  35fa34b  2023-02-13  Elliott Brooks (she/her)  [MV3 Debug Extension] Update Chrome APIs to be backwards compatible with MV2 (#1951)

Change-Id: I4250594d0fa775d07cb3a0f8594e634552de452b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284240
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-02-20 20:09:45 +00:00
Devon Carew e004a9b6f6 [deps] add a dep on the dart-lang/tools repo
Bug: https://github.com/dart-lang/sdk/issues/51425
Change-Id: Ief12c163b19b6a36121b6863b7c35ba06bc0aff3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283921
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2023-02-17 18:47:49 +00:00
Derek Xu 1bf4dd4595 Bump protobuf-gn version to eliminate need for custom_options.proto stub
Change-Id: Id155ffd82e68fffa29bb6270a7d2ec377f4a2f05
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283704
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
2023-02-17 15:11:43 +00:00
Sam Rawlins 4e614d299c Bump linter to 85d62c18e2a353abd4905aaf86e05dd1fc9d7b9a
Brings in support for https://github.com/dart-lang/sdk/issues/50796

Change-Id: Ifd6f20760e0cb8e1a4090e0f36d9a0d68d867f76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283401
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
2023-02-16 23:19:10 +00:00
Devon Carew 8af34bdb58 Bump csslib to b671738dc6de7d212b5f943b4258f9bb099d3e83
Changes:
```
> git log --format="%C(auto) %h %s" 45264a8..b671738
 https://dart.googlesource.com/csslib.git/+/b671738 Add support for CSS `lh` and `rlh` units. (173)

```

Diff: https://dart.googlesource.com/csslib.git/+/45264a876d090f441d2bdacc1bb30afa52a0b8ec..b671738dc6de7d212b5f943b4258f9bb099d3e83/
Change-Id: Ib439faae442e24bd9f2cb71e782e85c6a7b21524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283342
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2023-02-15 19:18:38 +00:00
Sergey G. Grekhov 51a29c1218 [co19] Roll co19 to 0230e6a44d8b6c26921567383d80b9e1a0cf527f
2023-02-14 sgrekhov22@gmail.com Fixes dart-lang/co19#1851. Roll failures fixed (dart-lang/co19#1852)
2023-02-14 49699333+dependabot[bot]@users.noreply.github.com Bump actions/setup-java from 3.9.0 to 3.10.0 (dart-lang/co19#1853)
2023-02-13 sgrekhov22@gmail.com Fixes dart-lang/co19#1846. Update tests to avoid unintended warnings (dart-lang/co19#1850)
2023-02-10 sgrekhov22@gmail.com Fixes dart-lang/co19#1848. Runtime errors fixed, few test cases added (dart-lang/co19#1849)
2023-02-10 sgrekhov22@gmail.com dart-lang/co19#1401. Pattern type schema tests added (dart-lang/co19#1825)
2023-02-09 sgrekhov22@gmail.com dart-lang/co19#1401. Pattern uses (static semantics) tests added (dart-lang/co19#1796)
2023-02-09 sgrekhov22@gmail.com Fixes dart-lang/co19#1797. Expect compile-time error in case of nullable Struct member (dart-lang/co19#1845)
2023-02-09 sgrekhov22@gmail.com dart-lang/co19#1401. Shared case scope tests (dart-lang/co19#1832)
2023-02-08 sgrekhov22@gmail.com dart-lang/co19#1401. Scope tests added for pattern-for and pattern-for-in statement and element (dart-lang/co19#1835)
2023-02-08 sgrekhov22@gmail.com Fixes dart-lang/co19#1840. Don't use var Object(: var x) (dart-lang/co19#1844)
2023-02-08 sgrekhov22@gmail.com Fixes dart-lang/co19#1838. Add missing errors expectations (dart-lang/co19#1843)
2023-02-08 sgrekhov22@gmail.com Fixes dart-lang/co19#1828. Missed experimental flag added (dart-lang/co19#1830)
2023-02-08 sgrekhov22@gmail.com Fixes dart-lang/co19#1836. Don't use _ in a guard clause (dart-lang/co19#1841)
2023-02-07 sgrekhov22@gmail.com Fixes dart-lang/co19#1833. Fix null-assert pattern tests to not produce false warnings (dart-lang/co19#1834)
2023-02-06 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Pattern context tests added (dart-lang/co19#1783)
2023-02-06 sgrekhov22@gmail.com Fixes dart-lang/co19#1827. scope_A01_t01.dart. Removed wrong error expectations (dart-lang/co19#1831)
2023-02-03 sgrekhov22@gmail.com Fixes dart-lang/co19#1826. Typo fixed (dart-lang/co19#1829)
2023-02-03 sgrekhov22@gmail.com Fixes dart-lang/co19#1823. Typo fixed (dart-lang/co19#1824)

Change-Id: Ib3085d180dd4bc27ccb177b26a76aa4fdc520279
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/283181
Reviewed-by: Alexander Thomas <athom@google.com>
2023-02-15 09:00:39 +00:00
Devon Carew 21ab29fef6 [deps] rev package:source_maps to the latest
Change-Id: Ic0926143ea98bc3bc1eebfaca0d20c3f5578154a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282808
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-13 21:18:37 +00:00
Devon Carew 938b2fc5d1 [deps] rev args, bazel_worker, benchmark_harness, dartdoc, glob, http, http_parser, pub_semver, shelf, term_glyph, test, typed_data, webdev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (bd3ac85..b08471e):
  b08471e  2023-02-09  Sigurd Meldgaard  Suggest command based on aliases (#235)

bazel_worker (1124692..53871c5):
  53871c5  2023-02-09  Kevin Moore  Migrate to dart_flutter_team_lints, cleanup (#69)

benchmark_harness (b1efcf7..a6a0891):
  a6a0891  2023-02-09  Kevin Moore  Require Dart 2.19, update lints to dart_flutter_team_lints (#84)

dartdoc (494a6be..3931595):
  39315954  2023-02-13  Devon Carew  enable additional lints (#3336)
  a52639e7  2023-02-10  Sam Rawlins  Use markdown 7 (#3332)

glob (a828420..f378dc8):
  f378dc8  2023-02-13  Kevin Moore  Update to dart_flutter_team_lints, also cleaned up markdown (#71)

http (8386923..f4b365e):
  f4b365e  2023-02-07  Sigurd Meldgaard  Remove dependency on package:path (#865)

http_parser (1c0c17a..b3b283b):
  b3b283b  2023-02-08  Kevin Moore  Bump min SDK to 2.17 (#69)

pub_semver (e9c600c..c0e6ea7):
  c0e6ea7  2023-02-12  Devon Carew  Update CHANGELOG.md (#81)
  0d62000  2023-02-12  Kevin Moore  Fix new type error, use dart_flutter_team_lints (#80)

shelf (9d1fb8a..707c8b2):
  707c8b2  2023-02-07  Kevin Moore  move to pkg:dart_flutter_team_lints (#330)

term_glyph (520784d..d275a8f):
  d275a8f  2023-02-12  Kevin Moore  Fix CI, update lints (#34)

test (da7c667..b5e70db):
  b5e70db5  2023-02-10  Jacob MacDonald  Add notes about versioning and publishing to CONTRIBUTING.md (#1929)
  2773daa6  2023-02-09  Jacob MacDonald  update changelog version in test to use ## (#1926)
  9e3072e1  2023-02-09  Danny Tuppeny  Handle absolute paths on Windows (#1923)
  07380027  2023-02-09  Nicholas Shahan  Fix typo in migration doc (#1924)
  f49fc16a  2023-02-09  Kevin Moore  Add auto-publish configuration (#1922)
  5bf28959  2023-02-08  Nate Bosch  Add link to file issue on README (#1921)
  ef81f471  2023-02-08  Nate Bosch  Fix directory name for issue templates (#1920)
  f3bfda9d  2023-02-08  Nate Bosch  Add issue templates (#1919)
  a80f4fd0  2023-02-08  Devon Carew  Refactor top level and package README files (#1918)
  0f4558fe  2023-02-07  Nate Bosch  Prepare to publish test_core and test (#1917)
  39f498c8  2023-02-06  Nate Bosch  Minor readme improvements (#1913)
  2cb07a3f  2023-02-06  Nate Bosch  Rename matches to matchesPattern, accept Pattern (#1907)
  ba6fb1c9  2023-02-06  Jacob MacDonald  Support running tests by absolute file: uri (#1893)
  ffeaec66  2023-02-06  Nate Bosch  Take Condition for async nesting expectations (#1896)
  cdd8c395  2023-02-06  Daniel Chevalier  update vm_service to support 11.0.0 (#1910)
  f2d97bf2  2023-02-06  Nate Bosch  Expand the doc comment for Context (#1902)

typed_data (6fbbd95..f858046):
  f858046  2023-02-12  Kevin Moore  fix ci, update analysis options (#61)

webdev (6255c85..0bae2be):
  0bae2be  2023-02-10  Elliott Brooks (she/her)  Fix lifeline connection logic (#1952)
  4a41cf9  2023-02-10  Anna Gringauze  Support records (#1919)
  d6229e3  2023-02-09  Anna Gringauze  Fix failure on getting a list with out of range offset (#1947)
  f1b15e8  2023-02-09  Anna Gringauze  Fix incorrect list element count (#1944)
  fff4865  2023-02-09  Elliott Brooks (she/her)  Add missing IDs to inspector panel (#1946)
  47287e3  2023-02-08  Elliott Brooks (she/her)  [MV3 Debug Extension] Extension sets the `ide` query parameter for the DevTools URI (#1943)
  1136d51  2023-02-08  Elliott Brooks (she/her)  Catch exceptions in unawaited `Futures` (#1938)
  2cad786  2023-02-07  Anna Gringauze  Cleanup getObject logic for handling offsets and counts (#1936)
  b399e94  2023-02-06  Elliott Brooks (she/her)  Pull out `dart:io`-dependent functions from`/src/utilities/shared.dart` into
`/src/utilities/server.dart` (#1942)

Change-Id: I64bdc5485665ca4c13a331ae7a6c77b1cd3208d8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282802
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2023-02-13 20:15:10 +00:00
Derek Xu 50289563b7 [VM/Timeline] Bump protobuf-gn version to fix protos on Windows
protobuf-gn was missing logic for adding .exe to executable paths on
Windows. I submitted https://fuchsia.googlesource.com/protobuf-gn/+/ac7e0cda633a58077684439111675e2d9460d5bf
to fix this, and now we need to bump our protobuf-gn dep to this revision.

Change-Id: I3ad44094e653c595c17029f73296a08f25866056
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282521
Commit-Queue: Derek Xu <derekx@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2023-02-13 19:41:48 +00:00
DEPS Autoroller f0362507f0 Roll Fuchsia SDK from 11.20230209.2.1 to 11.20230210.1.1
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/fuchsia-sdk-dart-sdk
Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Fuchsia SDK: https://bugs.fuchsia.dev/p/fuchsia/issues/list
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:vm-fuchsia-release-x64-try
Change-Id: Ib16848f7d52c7911ccd69a3359d319f3ff15fd94
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282420
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2023-02-10 17:56:58 +00:00
Ryan Macnak 384394b4a3 Roll Fuchsia SDK to 7b3b23b2c0da59b3aceab6c49fbe7d9ed34d7382.
Avoid sharing manifests between components, which confuses `fuchsia_component`.

Change-Id: I2a035e6257284a9e8ff5da18f7c2e212e0a9091f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282120
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-02-09 22:43:36 +00:00
Devon Carew 403d5c93c3 Bump csslib to 45264a876d090f441d2bdacc1bb30afa52a0b8ec
Changes:
```
> git log --format="%C(auto) %h %s" f33d632..45264a8
 https://dart.googlesource.com/csslib.git/+/45264a8 fixed a regression parsing declaration values containing spaces (172)
 https://dart.googlesource.com/csslib.git/+/e6c8308 fix the reported span for expressions (167)
 https://dart.googlesource.com/csslib.git/+/a190358 add a repro for 136 (160)
 https://dart.googlesource.com/csslib.git/+/fa3e221 correct the logic in isPredefinedName (166)

```

Diff: https://dart.googlesource.com/csslib.git/+/f33d63211f77e2a895b90bcf22508ab7a0af4466..45264a876d090f441d2bdacc1bb30afa52a0b8ec/
Change-Id: I0e9e27f7f096c88c60309d389e20090c64add4fd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/282041
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
2023-02-09 18:37:33 +00:00
pq 0e8d367238 integrate new lint: invalid_case_patterns
See: https://github.com/dart-lang/linter/issues/4044

Change-Id: Ifdf36b66221e322f262ff683eb46073cb69bf12b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281784
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2023-02-09 00:23:48 +00:00
Devon Carew 1fc33f7c63 [deps] rev markdown and dartdoc
dartdoc:
494a6bed  2023-02-02  Sam Rawlins  Bump markdown dep to a pre-release of 7.0.0 (#3321)
ad6f1612  2023-02-02  Devon Carew  introduce an environmentProvider abstraction (#3324)
d0b73000  2023-02-02  Sam Rawlins  Prepare testing code for some upcoming Warnings (#3322)
936a7888  2023-02-01  Sam Rawlins  Add text about front-end manual testing (#3286)
cbee812d  2023-02-01  Sam Rawlins  Avoid renaming generator params (#3316)
bcaa0349  2023-02-01  Sam Rawlins  Privatize Library.sdkLib and move getClassByName (#3317)
af32def5  2023-01-31  dependabot[bot]  Bump github/codeql-action from 2.1.39 to 2.2.1 (#3313)
528e97da  2023-01-31  dependabot[bot]  Bump actions/cache from 3.2.3 to 3.2.4 (#3312)
54020672  2023-02-01  Parker Lougheed  Begin changelog for next release after 6.1.5 (#3315)

markdown:
f51c24c  2023-02-01  Zhiguang Chen  Prepend a line ending if the p tag is removed and there is an element before it in a *tight* list (#513)
dd3e3a1  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#510)
5f25fc9  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#511)
54266b2  2023-01-31  Kevin Moore  Prepare to release v7.0.0 (#509)
d6ceff9  2023-01-31  Zhiguang Chen  Add line endings before HTML blocks (#508)
ccd3c8b  2023-01-29  Zhiguang Chen  Rewrite link reference definitions (#506)
e8f84dc  2023-01-24  Kevin Moore  Update GFM to 0.29.0.gfm.7 (#507)
93f67b0  2023-01-20  Zhiguang Chen  Add an `enableTagfilter` option to `HtmlRenderer` to eanble GFM `tagfilter` extension (#447)
d110770  2023-01-13  Zhiguang Chen  Rewrite SetextHeaderSyntax (#500)
c1b9bc6  2023-01-09  Sam Rawlins  Migrate from no-implicit-casts to strict-casts (#504)
3e78c08  2023-01-01  dependabot[bot]  Bump actions/checkout from 3.0.2 to 3.2.0 (#501)
417747f  2022-12-15  Zhiguang Chen  Refactor list syntax (#499)
30ec05f  2022-11-29  Zhiguang Chen  Do not escape single quote(apostrophe) inside code (#498)
c3d1136  2022-11-29  Zhiguang Chen  introduce a Line class (#494)
Change-Id: I9d971b927b72500ab84cce461a60fe1a86818e2e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281543
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-08 01:20:08 +00:00
pq ad2da86f18 linter 1.33.0 rc
Some notes.

* There are a number of tests that should get decoupled from the linter being pulled into `DEPS`.  Instead of depending on the state of lints there, we should update the tests instead to use a more hermetic environment.  (See for example `options_rule_validator_test.dart` for how that might look.)


Downstream (blocking) fixes:

* https://github.com/flutter/flutter/pull/119736
* https://github.com/flutter/gallery/pull/878


Change-Id: I5671b0abde3eeda75513abaaf9fef3bcd5115f9b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280054
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2023-02-07 20:56:35 +00:00
Devon Carew 145b6c4a8c [deps] revert the recent roll of package:csslib
Change-Id: Ifa857de259f8ee4750bcdfa8c63f5c9a72322d1a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281341
Reviewed-by: Oleh Prypin <oprypin@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-07 17:25:13 +00:00
Sigurd Meldgaard 39136c1501 Bump pub to 048e3ad2b5e1b4ebe6883addbc95722be6904a7b
Changes:
```
> git log --format="%C(auto) %h %s" 0cbaf7a..048e3ad
 https://dart.googlesource.com/pub.git/+/048e3ad2 Add a spinner while validating before publishing (3776)
 https://dart.googlesource.com/pub.git/+/e5fdcf81 Fix terminal-detection logic for progress bar (3775)
 https://dart.googlesource.com/pub.git/+/16a79e2a Fix `global deactivate` on case-insensitive but case-preserving file systems (3774)
 https://dart.googlesource.com/pub.git/+/7493fad6 Updated documentation on entrypoint.acquireDependencies (3771)
 https://dart.googlesource.com/pub.git/+/faf9fa7e Info when publishing <3.0.0 constraint that is interpreted as <4.0.0 (3752)
 https://dart.googlesource.com/pub.git/+/bfaf3585 Validate package name in `pub global activate` (3735)
 https://dart.googlesource.com/pub.git/+/e84eefea Verify token characters when added and when used (3732)
 https://dart.googlesource.com/pub.git/+/60576f89 Correct spelling of 'publishing' (3767)
 https://dart.googlesource.com/pub.git/+/cb2f4b34 Bump actions/checkout from 3.2.0 to 3.3.0 (3763)
 https://dart.googlesource.com/pub.git/+/fc06561d Bump dart-lang/setup-dart from 1.3 to 1.4 (3764)
 https://dart.googlesource.com/pub.git/+/c6af8ff0 `dart pub remove`: Remove top-level key if empty after operation. (3758)
 https://dart.googlesource.com/pub.git/+/37692d8d Stop using always_throws (3765)
 https://dart.googlesource.com/pub.git/+/3ce46a32 Normalize pub.dartlang.org to pub.dev when reading lockfile (3754)
 https://dart.googlesource.com/pub.git/+/ab86f1e0 Add missing space in directory help text (3756)
 https://dart.googlesource.com/pub.git/+/14b13103 Fix `outdated`s handling of non-existent packages (3751)
 https://dart.googlesource.com/pub.git/+/56be1ca4 Fix typos in `dart pub add --help` (3750)
 https://dart.googlesource.com/pub.git/+/f698c43d Merge pull request 3746 from dart-lang/cherry_pick_conditional_sdk_rewrite
 https://dart.googlesource.com/pub.git/+/1bfb295d Merge branch 'master' into cherry_pick_conditional_sdk_rewrite
 https://dart.googlesource.com/pub.git/+/20f7daa9 Validate files don't differ in case only (3740)
 https://dart.googlesource.com/pub.git/+/9f41ae10 Only rewrite sdk constraints after dart 3
 https://dart.googlesource.com/pub.git/+/ea11b0d2 Only rewrite sdk constraints after dart 3 (3739)
 https://dart.googlesource.com/pub.git/+/12a2af4d Add and enforce require_trailing_commas (3728)
 https://dart.googlesource.com/pub.git/+/27c5cbd5 Only output errors during implicit resolution (3689)
 https://dart.googlesource.com/pub.git/+/e51b160b Remove features for migrating to null safety (3713)
 https://dart.googlesource.com/pub.git/+/f3cf3ac9 Add dependency kind information to `outdated --json` (3714)
 https://dart.googlesource.com/pub.git/+/0ee46ee0 Don't warn about overrides (3684)

```

Diff: https://dart.googlesource.com/pub.git/+/0cbaf7a2fb8c8ca543c6f222bf25d5f5c63abbf3..048e3ad2b5e1b4ebe6883addbc95722be6904a7b/
Change-Id: I9558072f3057c028f94c786f1dcdd8f48f42f39b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281400
Reviewed-by: Sarah Zakarias <zarah@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2023-02-07 15:01:53 +00:00
Devon Carew 059634a18d [deps] sse, stack_trace, stream_channel, string_scanner, sync_http, term_glyph, test, test_descriptor, test_process, test_reflective_loader, typed_data, usage, vector_math, watcher, web_components, web_socket_channel, webdev, webdriver, webkit_inspection_protocol, yaml, yaml_edit
Change-Id: I8b34b03b9666d4513e11bae387b57af187ba2ca9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281281
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2023-02-07 01:44:33 +00:00
Devon Carew 2e90d39487 [deps] ffi_rev, file_rev, fixnum_rev, glob_rev, html_rev, http_rev, http_multi_server_rev, http_parser_rev, intl_rev, json_rpc_2_rev, logging_rev, matcher_rev, mime_rev, package_config_rev, path_rev, pool_rev, protobuf_rev, pub_semver_rev, shelf_rev, source_map_stack_trace_rev, source_maps_rev, source_span_rev
Change-Id: I4b806532e30a6f0617add767da2556972ca6cea9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281280
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2023-02-07 00:33:33 +00:00
Devon Carew fdfe613c17 [deps] rev args_rev, async_rev, bazel_worker_rev, benchmark_harness_rev, boolean_selector_rev, browser_launcher_rev, characters_rev, cli_util_rev, clock_rev, collection_rev, convert_rev, crypto_rev, csslib_rev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

args (a23ea85..bd3ac85):
  bd3ac85  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#234)
  86dacb3  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#233)

async (f700e9a..8deaa40):
  8deaa40  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#234)
  b28604f  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#233)

bazel_worker (b35c25e..1124692):
  1124692  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#67)
  1e57757  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#68)

benchmark_harness (76881df..b1efcf7):
  b1efcf7  2023-02-02  Devon Carew  add a publishing workflow action to dart-lang/benchmark_harness (#81)
  4e0c4e8  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#83)
  010ea89  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#82)

boolean_selector (ba7d86b..16e6ad3):
  16e6ad3  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#42)
  c8874cc  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#43)

browser_launcher (f2f01e4..bc2dc4e):
  bc2dc4e  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#38)
  00a57fa  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#39)

characters (4526aa8..29f3a3e):
  29f3a3e  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#73)
  6516030  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#74)

cli_util (32bc077..fd38b5f):
  fd38b5f  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#74)
  166fbac  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#75)

clock (65e8a13..5abb481):
  5abb481  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#43)
  11b18ed  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#44)

collection (a566328..0d0e184):
  0d0e184  2023-02-01  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#268)
  d0897af  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#269)

convert (20d136c..83886e3):
  83886e3  2023-02-01  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#75)
  a522506  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#74)

crypto (f854f2f..03eb2c9):
  03eb2c9  2023-01-31  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#139)
  b6d6b33  2023-01-31  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#140)

csslib (f33d632..e6c8308):
  e6c8308  2023-01-31  Devon Carew  fix the reported span for expressions (#167)
  a190358  2023-01-31  Devon Carew  add a repro for #136 (#160)
  fa3e221  2023-01-31  Devon Carew  correct the logic in isPredefinedName (#166)

Change-Id: I68bc236d4e0b5c31b5d629f2b89f82f56d30a28e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/281260
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2023-02-06 22:31:48 +00:00
Devon Carew c84d0376cd [deps] update the rev script to handle 'main' branches
Also rev package:csslib and package:html.


csslib (7054945..f33d632):
  f33d632  2023-01-28  Devon Carew  switch to using package:dart_flutter_team_lints (#161)
  c0097a0  2023-01-28  Devon Carew  Update README.md (#158)
  0d985fb  2023-01-28  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#164)
  56d1152  2023-01-28  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#163)
  46d2c57  2023-01-28  Devon Carew  Update test-package.yml (#165)
  a7d17bc  2023-01-26  Kevin Moore  all the cleanup (#155)

html (3dd00b0..f118e00):
  f118e00  2023-01-30  Devon Carew  lint with dart_flutter_team_lints (#201)
  52d9185  2023-01-30  Devon Carew  updates from #158 (#202)
  71d3e71  2023-01-30  Ron Booth  fixed issue #157 (querySelector fails), and added test for it (#158)
  9ab8b28  2023-01-30  dependabot[bot]  Bump actions/checkout from 3.2.0 to 3.3.0 (#200)
  fe3fbf6  2023-01-30  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#199)
  776daf5  2023-01-30  Devon Carew  Update test-package.yml (#198)
  a5be27f  2023-01-27  Devon Carew  finish work for avoid_dynamic_calls (#196)

Change-Id: If03552028f30b8dfd6a227674aa161e43a05e11f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280129
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Sigurd Meldgaard <sigurdm@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2023-02-06 18:04:11 +00:00
Sergey G. Grekhov adb32493cb [co19] Roll co19 to 2caa480b5ecfee3c8b052af006e9108183be3844
2023-02-02 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Scope tests added (dart-lang/co19#1800)
2023-02-02 sgrekhov22@gmail.com Fixes dart-lang/co19#1820. Fix object type in Object-pattern test (dart-lang/co19#1822)
2023-02-02 sgrekhov22@gmail.com Fixes dart-lang/co19#1819. Use correct map type, fix a typo (dart-lang/co19#1821)
2023-02-01 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns] Pattern variable declaration tests (dart-lang/co19#1610)
2023-02-01 sgrekhov22@gmail.com Fixes dart-lang/co19#1814. Return type changed to void (dart-lang/co19#1816)
2023-02-01 sgrekhov22@gmail.com dart-lang/co19#1401. [Patterns]. Added tests, expecting warnings in case of unnecessary null check/assert pattern (dart-lang/co19#1807)
2023-02-01 sgrekhov22@gmail.com Fixes dart-lang/co19#1815. Several typos fixed (dart-lang/co19#1817)
2023-02-01 asashour@yahoo.com Fix year in header. (dart-lang/co19#1818)
2023-01-31 sgrekhov22@gmail.com Fixes dart-lang/co19#1810. switch_expression_A02_t01.dart. Fix static and runtime failures (dart-lang/co19#1813)
2023-01-31 sgrekhov22@gmail.com Fixes dart-lang/co19#1801. Improve sandbox objects logging (dart-lang/co19#1804)
2023-01-31 sgrekhov22@gmail.com Fixes dart-lang/co19#1809. pattern_assignment_A07_t01.dart. Variable type fixed (dart-lang/co19#1812)
2023-01-31 sgrekhov22@gmail.com Fixes dart-lang/co19#1808. object_A02_t09.dart. Missed var/final/type added (dart-lang/co19#1811)
2023-01-30 sgrekhov22@gmail.com dart-lang/co19#1401. Pattern variable sets tests (dart-lang/co19#1798)
2023-01-27 sgrekhov22@gmail.com Fixes dart-lang/co19#1803. wildcards_A01_t04.dart. Use correct getter (dart-lang/co19#1806)
2023-01-27 sgrekhov22@gmail.com Fixes dart-lang/co19#1802. list_A05_t02.dart fix test failure (dart-lang/co19#1805)
2023-01-26 asashour@yahoo.com Remove superfluous `the`. (dart-lang/co19#1799)
2023-01-26 sgrekhov22@gmail.com Fixes dart-lang/co19#1792. Update object_A02_t10.dart not to fail in a weak mode (dart-lang/co19#1794)
2023-01-26 sgrekhov22@gmail.com Fixes dart-lang/co19#1793. Update switch_expression_A03_t02.dart not to fail on Web platforms (dart-lang/co19#1795)

Change-Id: Ia9ec7af1bd90209886694c0044ac179746a7dbc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280640
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-02-06 08:58:25 +00:00
Alexander Thomas 8598180662 [infra] Update checked-in SDKs to 3.0.0-187.0.dev
Bug: https://github.com/dart-lang/sdk/issues/51168
Change-Id: I0128e08189a1b4a022333bfad286c1067733b1cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280400
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2023-02-03 09:32:02 +00:00
Kenzie Schmoll 101738ee72 bump the DevTools dep to version 2.21.1
Change-Id: I8f245cd0d8bfd1dd9ccd2d036dbe77f58d4c79e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280135
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
2023-01-31 23:58:51 +00:00
Devon Carew 24e75cb421 [deps] rev async, characters, collection, dartdoc, json_rpc_2, logging, mockito, package_config, shelf, string_scanner, test, webdev
Revisions updated by `dart tools/rev_sdk_deps.dart`.

async (f700e9a..f700e9a):
  f700e9a  2023-01-27  Devon Carew  blast_repo fixes (#231)

characters (4526aa8..4526aa8):
  4526aa8  2023-01-30  Lasse R.H. Nielsen  Update tables to Unicode 15.0. (#71)

collection (a566328..a566328):
  a566328  2023-01-26  Devon Carew  add a publish script; prep to publish (#267)

dartdoc (bc7bdc4..bc7bdc4):
  bc7bdc44  2023-01-30  dependabot[bot]  Bump js from 0.6.5 to 0.6.7 (#3310)

json_rpc_2 (e73c4ad..e73c4ad):
  e73c4ad  2023-01-26  Devon Carew  blast_repo fixes (#89)

logging (399100a..399100a):
  399100a  2023-01-26  Devon Carew  add a publish script; prep to publish 1.1.1 (#128)

mockito (d2a8df1..d2a8df1):
  d2a8df1  2023-01-30  Kevin Moore  Latest build_web_compilers, move to pkg:lints, fix breaks (#605)
  13340b5  2023-01-30  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#600)

package_config (3fe81c4..3fe81c4):
  3fe81c4  2023-01-30  Kevin Moore  Support latest pkg:build_web_compilers, lints. Update min SDK (#129)

shelf (8fca9d9..8fca9d9):
  8fca9d9  2023-01-26  Devon Carew  blast_repo fixes (#326)

string_scanner (29e471e..29e471e):
  29e471e  2023-01-30  dependabot[bot]  Bump dart-lang/setup-dart from 1.3 to 1.4 (#53)

test (cec47c1..cec47c1):
  cec47c1c  2023-01-27  Nate Bosch  Add missing pub requirements (#1878)
  c99d455e  2023-01-27  Nate Bosch  Prepare to publish (#1877)
  0e7ec6a7  2023-01-27  Nate Bosch  Rename `Check` to `Subject` (#1875)
  78382731  2023-01-27  Nate Bosch  Add String.matches condition (#1874)
  26e0e87b  2023-01-27  Nate Bosch  Add Iterable.containsInOrder condition (#1873)
  c9232d6b  2023-01-27  Nate Bosch  Rename `that` to `which` (#1872)
  457166b3  2023-01-26  Nate Bosch  Add missing dependency on package:lints (#1876)
  193f2a0b  2023-01-26  Nate Bosch  Retry instead of extend timeout for flaky Node tests (#1871)
  7ad9b2c3  2023-01-26  Nate Bosch  Overhaul async matchers (#1868)
  ca254546  2023-01-26  Nate Bosch  Add a withQueue utility (#1870)
  6ae2e5e9  2023-01-26  Nate Bosch  Refactor tests to a new isRejectedBy utility (#1867)
  5aeba66d  2023-01-26  Nate Bosch  Use pubspec_overrides.yaml files (#1869)

webdev (ce9c581..ce9c581):
  ce9c581  2023-01-29  Anna Gringauze  Validate only needed summaries in expression_compiler_service (#1920)

Change-Id: I3ddb0ddeb3b989f6f9e78cd8aa6327aba5899018
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280078
Commit-Queue: Devon Carew <devoncarew@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2023-01-31 02:13:06 +00:00
DEPS Autoroller 1e934307b4 Roll Clang from ca6196138012 to 20d06c833d83
If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/clang-dart-sdk
Please CC dart-vm-gardener@grotations.appspotmail.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md

Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
Change-Id: I7c28885f64bf1f16feebc751d1ef934fe89bf08d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279600
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2023-01-31 02:01:22 +00:00
Sergey G. Grekhov 9fe2529b21 [co19] Roll co19 to abb96bbca3fc36e6a594967509687431d138e998
2023-01-24 lrn@google.com Make record positional field getters start at `$1`. (dart-lang/co19#1759)
2023-01-23 asashour@yahoo.com Remove superfluous words. (dart-lang/co19#1790)
2023-01-23 asashour@yahoo.com Remove redundant words. (dart-lang/co19#1788)

Change-Id: I2ec57a2ecfd922aa5d044dbb710727f40867557a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/279516
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2023-01-30 08:14:28 +00:00
Sergey G. Grekhov 5e24ca9d79 [co19] Roll co19_2 to 93b818c9cf570a63cbea56508e393770787fd5ab
2023-01-23 asashour@yahoo.com Remove superfluous words (dart-lang/co19#1791)
2023-01-23 asashour@yahoo.com . (dart-lang/co19#1789)

Change-Id: I773d0d88757f40f9d97b18153219421634823f48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/280085
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2023-01-30 06:44:28 +00:00