Change-Id: I718a5d70874e7090cb42f1d452cd8dcf020d337e
Reviewed-on: https://dart-review.googlesource.com/c/84631
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This reverts commit 9ed26558f1.
Reason for revert: Failing builds due to missing gn runs
Original change's description:
> [infra] Add back generate_buildfiles.py to gclient hooks
>
> Omitting this was a little fragile. We can add it back following the
> fix in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1255446
>
> Change-Id: Idfa0a08674bc1ea7ef19d7c9a96e17e6da293297
> Reviewed-on: https://dart-review.googlesource.com/c/84280
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>
TBR=whesse@google.com,sortie@google.com,zra@google.com,athom@google.com
Change-Id: I87cd9ddf5eca2e2a247a74eb1e666aa40bae7a48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/84281
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Change-Id: I8e37c6dc29dc5ee00525364bfdb6eaee02a37416
Reviewed-on: https://dart-review.googlesource.com/c/82202
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
TBR=kevmoo@google.com
Change-Id: Ib4b89f95beae38ec0fc0697cedd2fb1474ebb0ef
Reviewed-on: https://dart-review.googlesource.com/c/83320
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
* new lint: `prefer_int_literals`
* update `await_only_futures` to allow awaiting on `null`
* update `use_setters_to_change_properties` to work with `=>` short-hand
Change-Id: Iafc46bb9c02675b47bda9b4d4124a8efc76584d8
Reviewed-on: https://dart-review.googlesource.com/c/81881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
dart binary would instantiate CrashpadClient if DART_CRASHPAD_HANDLER
and DART_CRASHPAD_CRASHES_DIR environment variables are set.
- DART_CRASHPAD_HANDLER should contain the path to the crashpad_handler
binary that would handle the crash and write minidump;
- DART_CRASHPAD_CRASHES_DIR should contain the path to the crashpad database
which would be used to store minidumps.
Rewrite --copy-crash-dumps support on windows to use Crashpad integration
instead of editing Windows registry.
Embedding crashpad required to roll a new zlib version because Crashpad
depends on the zlib. This version of zlib is buildable with its own
BUILD.gn so our custom BUILD.gn is removed.
Change-Id: I048aad16b234e1d750f0a24782b04e3b6e19703d
Reviewed-on: https://dart-review.googlesource.com/c/81007
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: If0747db4bd02d31814b407970b11d16519329625
Reviewed-on: https://dart-review.googlesource.com/c/79661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK
Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This reverts commit 787194e738.
Reason for revert: Broke windows bots.
Original change's description:
> [infra] Upgrade gsutil to a new version (#31065)
>
> Change-Id: Ie78c6295a5b11cc12adc07a65f716638bcc71495
> Reviewed-on: https://dart-review.googlesource.com/c/79208
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,athom@google.com
Change-Id: I75c0a2731f80e969fdcd06a6ca2ed72a0407dfbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/79214
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* Use 64bit d8 on Windows & Mac.
* Default to 64bit d8 on Linux.
Change-Id: Ia03275e48ed0e30bcb2a7b390e7007e34e92cfc5
Reviewed-on: https://dart-review.googlesource.com/c/78640
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
* co19_2 tests enabled for vm-kernel CQ builders.
Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* miscellaneous mixin support fixes
* update to `sort_constructors_first` to apply to all members
* update `unnecessary_this` to work on field initializers
Change-Id: If0578fb3dd67d8f746044e8bbc21e166cd43e4ef
Reviewed-on: https://dart-review.googlesource.com/c/77984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: I91fe0da8595ddf07c5b0a345ac9417730b6f964f
Reviewed-on: https://dart-review.googlesource.com/77542
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
* fix cast exceptions related to mixin support
Change-Id: I26361e41f9dee940c462558b6d8251a93f351ecb
Reviewed-on: https://dart-review.googlesource.com/77227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
There is a race with downloading the prebuilt Dart SDK from CIPD
introduced by:
647e1e79eb
If the prebuilt Dart SDK isn't there, then generate_buildfiles.py will
fail. Instead check whether generate_buildfiles.py should be run
right before we try to build.
Change-Id: I1e25e5280075f9d1c7d96877602617ddfb40291e
Reviewed-on: https://dart-review.googlesource.com/77160
Reviewed-by: Jonas Termansen <sortie@google.com>
* fixes to better support mixins
Change-Id: Ibc67ec7b98d8bc478b0343335e40974b385da152
Reviewed-on: https://dart-review.googlesource.com/76565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* updated `unawaited_futures` to ignore assignments within cascades
* new lint: `sort_dependencies`
Change-Id: Iec39fce58d4c6230613f947ed6fc99fec516c722
Reviewed-on: https://dart-review.googlesource.com/75942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This is safe to do without also rebuilding the checked in SDK because
it doesn't affect any existing formatted code.
Change-Id: I615c1145c2343da54b7a532ff3f5d077e63cb7ed
Reviewed-on: https://dart-review.googlesource.com/75563
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
* new lint: `prefer_mixin`
* new lint: `avoid_implementing_value_types`
Change-Id: Iaba2d1dd50511db935cf050ba49e7d10746be8cb
Reviewed-on: https://dart-review.googlesource.com/74880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* new lint: `flutter_style_todos`
* improved handling of constant expressions with generic type params
* NPE fix for `invariant_booleans`
* Google lints example moved to `package:pedantic`
* improved docs for `unawaited_futures`
Change-Id: Ie0eb779f8cb98aaa67674ecfd17baf12445a5934
Reviewed-on: https://dart-review.googlesource.com/74340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: Ib37f2f5fd6aec3b86677b5f1c51f6ec6147069a7
Reviewed-on: https://dart-review.googlesource.com/74280
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: I72b493a65ef5c854b122d76d80549d30141157fd
Reviewed-on: https://dart-review.googlesource.com/71243
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: Iff7d207cda2a88c0f51135a56aec78eed0935d0a
Reviewed-on: https://dart-review.googlesource.com/69461
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* relaxed `void_checks` (allowing `T Function()` to be assigned to `void Function()`)
* test and build improvements
* introduced Effective Dart rule set
* Google ruleset updates
* (internal cleanup): move cli main into `lib/`
* fixed false positives in `lines_longer_than_80_chars`
* new lint: `prefer_void_to_null`
Change-Id: I374197f09701041fd0b507062a3ad903f731656a
Reviewed-on: https://dart-review.googlesource.com/69382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This reverts commit f99b9b80ff.
Reason for revert: Rolls in a version of co19_2 that contains two files whose name differs only by case and whose content is not the same. This breaks "gclient sync" on machines with case-insensitive filesystems (e.g. macs).
Original change's description:
> [co19] co19_2 tests roll (DEPS and .status files update)
>
> Closes#33894
>
> Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
> Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
> Reviewed-on: https://dart-review.googlesource.com/68860
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com,eernst@google.com,sgrekhov@unipro.ru
Change-Id: Icd6d8d763c8baff2b82bd15c6b28c56591b7431e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Reviewed-on: https://dart-review.googlesource.com/69340
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Closes#33894
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
Reviewed-on: https://dart-review.googlesource.com/68860
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Closes#33878
Change-Id: Id4687f59c31adb1338643f86909bc5b6b7afb88a
Reviewed-on: https://dart-review.googlesource.com/68040
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This may impact other parts of the SDK who share dartdoc's dependencies.
Change-Id: I5ec19aabcca78c373386dff3c194108b6586841f
Reviewed-on: https://dart-review.googlesource.com/66702
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
These where the last two uses of sunflower in the repo. Sunflower sources have
been deleted from the public github repo. We can alternatively copy them here,
but for these tests it doesn't really matter what code we use.
A benefit of using swarm: this will test compiling swarm, so we detect breakages
early (and not when they hit the perf bots). A drawback of using swarm: it is
bigger and these tests will take longer. For dump-info that might be a good
thing, though.
TBR
Change-Id: Ie976cf4250f5f7ce17147ba8b166e7a6bd429425
Reviewed-on: https://dart-review.googlesource.com/65784
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* roll-back to explicit uses of `new` and `const` to be compatible w/ VMs running `--no-preview-dart-2`
# 0.1.57
* fix to `lines_longer_than_80_chars` to handle CRLF endings
* doc improvements
* set max SDK version to <3.0.0
* fix to `non_constant_identifier_names` to better handle invalid code
* new lint: `curly_braces_in_flow_control_structures`
Change-Id: I1fd3c9b3892f377c634057451ea0938347ef4e9a
Reviewed-on: https://dart-review.googlesource.com/65573
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
We also need to update the prebuilt SDK to keep it in sync with this
change so the presubmit doesn't get wonky. But, in this case, it should
be fine. The change affects a rare case that I don't think occurs in
the SDK: a multi-line string inside a string interpolation, inside
another string. If that does occur, it's easy to just change that code.
Change-Id: Icdfdfb0b2e1359005d88d983e9a3cf05b0e91e48
Reviewed-on: https://dart-review.googlesource.com/65280
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
* fix to `avoid_positional_boolean_parameters` to ignore overridden methods
* fix to `prefer_is_empty` to not evaluate constants beyond int literals
* new lint: `null_closures`
* new lint: `lines_longer_than_80_chars`
Change-Id: Id11694d65091de6f26f521d62f3c5fb1921f58af
Reviewed-on: https://dart-review.googlesource.com/63271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
#33659
Change-Id: I94fccf4bbce2f0140bf0d6efa953d44b290df856
Reviewed-on: https://dart-review.googlesource.com/62840
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: I42a5c41394226f6ddc9c0608c6d688ae683ffdea
Reviewed-on: https://dart-review.googlesource.com/62680
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed an issue in `const` error handling
* updated `linter` binary to use `previewDart2`
Change-Id: Ic46df8fc248c241b9ecc71e180ae3adb2238546a
Reviewed-on: https://dart-review.googlesource.com/62641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Update Changelog to add this info, and to prepare for releasing -dev.65.0
Change-Id: Iaa6c0d917acb1132227352b422ef3939cda2a9f4
Reviewed-on: https://dart-review.googlesource.com/61926
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Closes#33187
Brings in the latest version of pub. There is still an issue with
invaliding old snapshots, but this version works better than the current
synced version.
Change-Id: I5c98b0277ea769baa83c3fee7ebfff2034ba9920
Reviewed-on: https://dart-review.googlesource.com/61983
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
https://github.com/dart-lang/dartdoc/releases/tag/v0.20.1
Updates dartdoc and its dependency "quiver" to new versions (dartdoc
ran into a type problem with the older quiver).
Because of the quiver change this could affect more than just dartdoc.
Change-Id: I9b0bbb3d4b222f605d7ac5cafc641b5da0c02d20
Reviewed-on: https://dart-review.googlesource.com/61912
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
New version avoids literals that are not exact in JavaScript.
Change-Id: I38fa0d6132b9006f361b01e3e691b5a672584e98
Reviewed-on: https://dart-review.googlesource.com/61741
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This fixes precompiling snapshots when running pub get/upgrade which
broke when the VM removed support for "--preview-dart-2".
Change-Id: I70fe2241f85cf5e8cdf447387df92ea47d398c57
Reviewed-on: https://dart-review.googlesource.com/61440
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
* new `unnecessary_const` lint
* new `unnecessary_new` lint
* fixed errors in `use_to_and_as_if_applicable`
* new `file_names` lint
Change-Id: Ic461249050277ea81ade7a90b92506c6041ac480
Reviewed-on: https://dart-review.googlesource.com/61280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* updated `unnecessary_statements` to ignore getters (as they may be side-effecting).
Change-Id: I2019d1c2c49224525ac066a8f44c6da301dbfd91
Reviewed-on: https://dart-review.googlesource.com/60180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed `void_checks` to handle arguments not resolved to a parameter
* fixed exceptions produced by `prefer_const_literals_to_create_immutables`
Change-Id: Ia25fe8e432ee7717cfe289bce4515481e801c4f8
Reviewed-on: https://dart-review.googlesource.com/59201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Change-Id: If1705ac18715876fc5c1325dab4c3dda42b8d2b9
Reviewed-on: https://dart-review.googlesource.com/56580
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
* `unrelated_type_equality_checks` now allows comparison between `Int64` or `Int32` and `int`
* `unnecessary_parenthesis` improved to handle cascades _in_ cascades
Change-Id: I588893132e04a706e9fc93a7a16a07005465eb1f
Reviewed-on: https://dart-review.googlesource.com/55914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: I6843981cda8e0dc7936271bcc019ab9571b15d67
Reviewed-on: https://dart-review.googlesource.com/55321
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
This should be safe to do without rolling the prebuilt SDK since it
makes no changes to existing formatted code.
Change-Id: I3420698b5dac94ab04ee7908940ace70936a3e5b
Reviewed-on: https://dart-review.googlesource.com/55269
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
It hasn't been updated in nearly 2 years. This update adds support for
more modern C++'s.
Change-Id: Ie3cbf95db6073d838a3a4cdbb72c3f50e0777c01
Reviewed-on: https://dart-review.googlesource.com/55265
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
* migration of rules to use analyzer package `NodeLintRule` and `UnitLintRule` yielding significant performance gains all around
* specific performance improvements for `prefer_final_fields` (~6x)
* addressed no such method calls in `void_checks`
* improved lint reporting for various lints
Change-Id: I63896a5367e27241ef596408aea44830c8067c75
Reviewed-on: https://dart-review.googlesource.com/53861
Reviewed-by: Devon Carew <devoncarew@google.com>
Bug: #33030
Change-Id: I7155482cbba12e9e5501feebac8ff31c6d8071ff
Reviewed-on: https://dart-review.googlesource.com/54140
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Bug: None
Change-Id: I5627ac27907acfa5e304e47720758383a2e6376a
Reviewed-on: https://dart-review.googlesource.com/53166
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This has no formatting changes, so is safe to roll without coordinating
with a new prebuilt SDK.
Change-Id: If8b966a7fd402909f82aa016ee9958672a275e8b
Reviewed-on: https://dart-review.googlesource.com/53161
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
* Fix a runtime error when dart_style is itself run in Dart 2.
* Force splitting an empty block as the then body of an if with an else.
* Use the new lowercase Dart 2 constant names.
https://github.com/dart-lang/sdk/issues/32961
Change-Id: I283f28a5e75016528093358a899b7f983ae1445e
Reviewed-on: https://dart-review.googlesource.com/52760
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
* new `avoid_double_and_int_checks` lint
* fix to handle uninitialized vars in `prefer_const_declarations`
* fix for generic function type handling in `avoid_types_as_parameter_names`
* new `prefer_iterable_whereType` lint
* new `prefer_generic_function_type_aliases` lint
* Dart 2 compatibility fixes
Change-Id: Ie871c0dd20933d700ab8a77724b7a6d4ee044cdd
Reviewed-on: https://dart-review.googlesource.com/50022
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Last usage was removed
Change-Id: Ib8c6d67f22c514c8f706c2c4a683c7022a05ea87
Reviewed-on: https://dart-review.googlesource.com/49000
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This fixes a couple edge cases in the new version solver.
Change-Id: I70cf03790f5adbb5ec4f3ddddf42f9c798d7d3c5
Reviewed-on: https://dart-review.googlesource.com/48888
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
Updated version of dart-lang/observatory_pub_packages in DEPS
Updated generated pubspec.yaml file after removing web_components from
third_party/observatory_pub_packages
This should fix part of issue https://github.com/dart-lang/sdk/issues/32539
Bug: 32539
Change-Id: I3d48fd59f1fedc9d64a652cde7d0229c0a7ace28
Reviewed-on: https://dart-review.googlesource.com/48804
Commit-Queue: Siva Annamalai <asiva@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Change-Id: I79e86ef8681b0b169b0b40da26a5834eaace66a3
Reviewed-on: https://dart-review.googlesource.com/47580
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
* fix for `invariant_booleans` when analyzing for loops with no condition
* new `avoid_types_as_parameter_names` lint
* new `avoid_renaming_method_parameters` lint
Change-Id: Iaafceba24f1b049a132464b78588d57e621c85d4
Reviewed-on: https://dart-review.googlesource.com/47300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
This will force pub-build to continue using the old dart2js frontend until we
fix the uses of package-root
Change-Id: I3e8d73b4c0586e3af77d665b407f2bb3bf94029d
Reviewed-on: https://dart-review.googlesource.com/46573
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* new `avoid_relative_lib_imports` lint
* new `unnecessary_parenthesis` lint
* fix to `prefer_const_literals_to_create_immutables` to handle undefined classes gracefully
* updates to `prefer_const_declarations` to support optional `new` and `const`
* `prefer_const_declarations` updated to check locals
* fixes to `invariant_booleans`
* bumped SDK lower bound to `2.0.0-dev`
* build and workflow improvements: rule template fixes; formatting and header validation
* miscellaneous documentation fixes
Change-Id: I999891b61c19e602eded4b43449f7d6d96f102e7
Reviewed-on: https://dart-review.googlesource.com/46305
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
There was only 1 change since the last roll.
Change-Id: I44a8ef56bc16d4bc4616480025125f1ca64beff8
Reviewed-on: https://dart-review.googlesource.com/46221
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Change-Id: I9de7d0c936b31f1365fc6cd9099a87fa42798aaf
Reviewed-on: https://dart-review.googlesource.com/46001
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
Last roll was >1yr ago.
Change-Id: I9b641b9cff4b8b53887fe0ad1615bb9085ae9717
Reviewed-on: https://dart-review.googlesource.com/44381
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This is for consistency; v0.15.1 and v0.16.0 behave identically when
using the analyzer built in to the SDK.
Change-Id: I50d4bab8eade1cbc9f6537712805fa868af3f573
Reviewed-on: https://dart-review.googlesource.com/40468
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Roll in versions of third_party packages which have been updated to
use StreamTransformerBase and forward compatible method signatures
on classes implementing Stream.
Change-Id: Ie366174bf09f9268a7f1476387c124cb3ea474f6
Reviewed-on: https://dart-review.googlesource.com/38680
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
This is a branch of co19 tests where the tests have been
made strong mode compliant. A co19_2_analyzer.status file
has been added with the current statuses of the tests when
run on dartanalyzer --strong. We expect more Dart 2 configurations
to start running these tests and adding status files.
Change-Id: I22077272707620b92dd1092c38bbb4f3d5964493
Reviewed-on: https://dart-review.googlesource.com/37743
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This brings package:http_io into third_party/pkg_tested so that its
migrated tests will run on sdk commits.
Change-Id: I516152747cdaeb1e874a900cb8ad57d84594ed6c
Reviewed-on: https://dart-review.googlesource.com/36842
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Change-Id: I45874e2826bb347637997f773c0ac1cf05a7af27
Reviewed-on: https://dart-review.googlesource.com/34383
Commit-Queue: Jakob Roland Andersen <jakobr@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
This is needed for fuzzy arrow and assert-closure fixes.
Change-Id: I34884e89094f2b88b12fbfdfcddc6cbcd4683bb4
Reviewed-on: https://dart-review.googlesource.com/34221
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
* added support for external constructors in `avoid_unused_constructor_parameters`
* added code reference resolution docs for `comment_references`
Bug:
Change-Id: I844d7a50de557afe35cf9580ad06f31308359e0a
Reviewed-on: https://dart-review.googlesource.com/34220
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
This required some changes to analysis_server, since analysis_server
used to have its own version of pumpEventQueue(). Since
pumpEventQueue() is now provided by the test package, I've removed
analysis_server's version, and I've updated some of the call sites to
pass in "times: 5000" to replicate the old analysis_server behavior.
This also required some changes to analyzer, since the fail() method
is now marked as @alwaysThrows, so no code may follow it without
producing a dead code hint.
Change-Id: Ie5ef3a5cc685c18da02de699e59f63f3bb8865f7
Reviewed-on: https://dart-review.googlesource.com/32683
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
This reverts commit 8ee7a97651.
Reason for revert: lld optimization level -Wl,-O1 appears to either
have a regression or to confuse Golem binary comparison tool.
Original change's description:
> [infra] Roll clang toolchain forward
>
> Change-Id: I41afe48f2fdc056436b58dc8158c62e9207cc43f
> Reviewed-on: https://dart-review.googlesource.com/32140
> Commit-Queue: Zach Anderson <zra@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,rmacnak@google.com,zra@google.com,athom@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I36ec03150a22f89c4cb5371dd1bf43df8a6f16f6
Reviewed-on: https://dart-review.googlesource.com/32800
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
This removes scheduled_test which is important for rolling other
packages. In return, it brings in two new packages, test_descriptor and
test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1c81e157c32326801985615abc353f2239fe2470
Reviewed-on: https://dart-review.googlesource.com/32664
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This reverts commit 8b8d9b08e1.
Reason for revert: Github mirrors need to be created *before* landing.
Original change's description:
> Update dart_style to 1.0.9 and bring in its new dependencies.
>
> This removes the dependency on scheduled_test which is important for
> rolling other packages. In return, it brings in two new packages,
> test_descriptor and test_process.
>
> There are no changes in the formatter's actual output. All of the
> differences are in tests or internal dependencies, so I don't think we
> need to worry about coordinating this with the PRESUBMIT version of
> dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
>
> Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
> Reviewed-on: https://dart-review.googlesource.com/32445
> Reviewed-by: Kevin Moore <kevmoo@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
TBR=kevmoo@google.com,rnystrom@google.com
Change-Id: I3af883a6f41339e3cc79096e0f61639c11af1e20
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/32640
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This removes the dependency on scheduled_test which is important for
rolling other packages. In return, it brings in two new packages,
test_descriptor and test_process.
There are no changes in the formatter's actual output. All of the
differences are in tests or internal dependencies, so I don't think we
need to worry about coordinating this with the PRESUBMIT version of
dartfmt as in https://github.com/dart-lang/sdk/issues/30164.
Change-Id: I1d6426303055a4400a0ca3d16965a3e05ab39cf7
Reviewed-on: https://dart-review.googlesource.com/32445
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Change-Id: I41afe48f2fdc056436b58dc8158c62e9207cc43f
Reviewed-on: https://dart-review.googlesource.com/32140
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This bump is primarily to remove the dependency on scheduled_test. (The
dependents only include barback, shelf_static, and watcher.)
Change-Id: I1e40da2798a539d596b99688150d74934a0626e4
Reviewed-on: https://dart-review.googlesource.com/30980
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This CL switches the ia32 and arm64 builds to use clang by default.
The arm build can't be switched at least until we roll clang to
pick up the fix for https://reviews.llvm.org/D34691.
This CL also changes to use the sysroots from wheezy (and jessie
for arm64) by default so that we can be building/testing locally with
the same setup as we are shipping in the SDK.
Change-Id: I09a1907ee7f78c3f4bb8d56ffdbbd6107ed054d9
Reviewed-on: https://dart-review.googlesource.com/25160
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
* `prefer_interpolation_to_compose_strings` update to allow concatenation of two non-literal strings
* `prefer_interpolation_to_compose_strings` updated to allow `+=`
* lots of rule documentation fixes and enhancements
* fix for `prefer_const_constructors_in_immutables` false positive with redirecting factory constructors
Bug:
Change-Id: I6c095567ef92ad47fc57cbcbfb6745d0173043c4
Reviewed-on: https://dart-review.googlesource.com/18380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>