Commit graph

35269 commits

Author SHA1 Message Date
Ivan Posva
6d0453594a - Prevent running of the dart_bootstrap script by default.
- Fix argument handling in Python: argparse does not properly handle booleans.

BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1519063004 .
2015-12-11 13:23:12 -08:00
Ryan Macnak
fc551b6f33 Remove stray copy of OS::AlignedAllocate.
Review URL: https://codereview.chromium.org/1518113002 .
2015-12-11 13:13:52 -08:00
Ryan Macnak
9387fead15 Use a monotonic clock in the implementation of Timer.
Ask the embedder for the current time, since it is the embedder who later compares the deadline with current time when deciding when to send a wake up message.

BUG=http://dartbug.com/25055
BUG=http://dartbug.com/25216
R=iposva@google.com, zra@google.com

Review URL: https://codereview.chromium.org/1519563003 .
2015-12-11 12:39:56 -08:00
Stephen Adams
04e3f8520c Don't constant fold large strings.
This fixes a 10k regression in swarm.  Marked with appropriate TODOs.

R=asgerf@google.com

Review URL: https://codereview.chromium.org/1519773002 .
2015-12-11 11:33:00 -08:00
pq
63f24be16c Update server/cli linter pubspec deps.
* bumps lower-bound to grab a `0.27.0`-compatible linter.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1520973002 .
2015-12-11 10:51:50 -08:00
pq
9f91ef8080 ErrorCode enum update.
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1518923002 .
2015-12-11 10:11:49 -08:00
keertip
c88841c041 use bot_utils.run to run dartdoc so that the bot will fail if there are errors when dartdoc is run. This will catch failures to generate docs.
BUG=https://github.com/dart-lang/sdk/issues/25015
R=whesse@google.com

Review URL: https://codereview.chromium.org/1514193002 .
2015-12-11 08:03:48 -08:00
Kevin Millikin
ff12f5ddd0 Remove a couple of unnecessary lines from test status files.
The test runner will generate a filename from the test name in the status
file.  If the status file contains a filename, it does not match any test.

R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1510943005 .
2015-12-11 14:19:58 +01:00
Asger Feldthaus
c5539316fb dart2js cps: Add instruction for null checks.
Currently we only instantiate the instruction for the null
checks inserted for numeric operators.

The corresponding instruction also exists in the tree IR,
partly because there is no way to say "x.toString" with the
current instruction set.

BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1507313006 .
2015-12-11 14:17:59 +01:00
Lasse R.H. Nielsen
ed0bc43158 Make chained futures point to their source instead of opposite.
This means that a chained future that nobody cares about will
not be kept alive by the source.
Any listeners added to the chained future is forwarded to the
source. If the chained source notices that the source has completed,
it copies the values and drops the link completely.

This should allow some unused futures to be GC'ed earlier than
otherwise.

R=floitsch@google.com

Review URL: https://codereview.chromium.org/1516783003.
2015-12-11 11:13:39 +01:00
Lasse R.H. Nielsen
ea55dc9bec Rewrite IOSink documentation, plus some clean-up.
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1517173002.
2015-12-11 10:10:29 +01:00
Florian Loitsch
1ffc230bf0 Update status file.
Review URL: https://codereview.chromium.org/1520703004 .
2015-12-11 09:47:52 +01:00
Florian Loitsch
be8c141e75 Dartium and the VM don't report the same error.
Just fail instead of specifying compile/runtime error.

Review URL: https://codereview.chromium.org/1518753004 .
2015-12-11 07:36:59 +01:00
Florian Loitsch
ca1c5ebe6b Enable conditional imports in unparser test.
Review URL: https://codereview.chromium.org/1517873004 .
2015-12-11 06:44:06 +01:00
Florian Loitsch
af4983c6b2 dart2js: add support for configuration-specific imports.
R=johnniwinther@google.com, rnystrom@google.com

Committed: 64edfaf21a
Reverted: f38b810d33

Review URL: https://codereview.chromium.org/1388523002 .
2015-12-11 06:17:15 +01:00
Dan Rubel
7ad6c0f1f9 extract LibraryPrefixContributor from imported reference contributor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1517693004 .
2015-12-10 22:42:53 -05:00
Sigmund Cherem
30c4c2b86e Change default dom.py to use ReleaseX64 (matching the default vm/dart2js arch)
BUG=
R=alanknight@google.com

Review URL: https://codereview.chromium.org/1514243002 .
2015-12-10 16:41:15 -08:00
John Messerly
b2d7ebe56c fix #25171, clear "hasBeenInferred" flag when re-running resolution
TypeResolverVisitor undoes the work of InstanceMemberInferrer, so it should also unset the flag.

R=leafp@google.com

Review URL: https://codereview.chromium.org/1513143004 .
2015-12-10 16:16:52 -08:00
Sigmund Cherem
e6f6ce9743 fix safari test
Apparently my approach to use wss didn't work to exercise the error codepath. This change makes us excersize errors. After testing this in Safari though, I coudln't reproduce the issue, so I remove the note about this being a regression test for the original issue.

Review URL: https://codereview.chromium.org/1513363003 .
2015-12-10 16:02:27 -08:00
Florian Loitsch
f38b810d33 Revert "dart2js: add support for configuration-specific imports."
This reverts commit 64edfaf21a.

Review URL: https://codereview.chromium.org/1517013003 .
2015-12-11 00:49:38 +01:00
Florian Loitsch
64edfaf21a dart2js: add support for configuration-specific imports.
R=johnniwinther@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org/1388523002 .
2015-12-11 00:25:01 +01:00
Dan Rubel
ac21fdda66 simplify library element accessor
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1516963002 .
2015-12-10 17:47:45 -05:00
Dan Rubel
59c3ed6ded simplify contributors by resolving declarations in scope
once rather than requiring each contributor to do so.

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1520613003 .
2015-12-10 17:41:03 -05:00
Sigmund Cherem
05ce49f009 stop skipping dummy_compiler_test: the test appears to be passing.
BUG=
R=sra@google.com

Review URL: https://codereview.chromium.org/1513653006 .
2015-12-10 14:39:30 -08:00
pq
56650e6bfe More mock cleanup.
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1520673002 .
2015-12-10 14:37:22 -08:00
pq
ad7c566e04 Driver test fixes.
* Updates to use new CONFIGURED_ERROR_PROCESSORS (rather than defunct CONFIGURED_ERROR_FILTERS).

BUG=
R=keertip@google.com

Review URL: https://codereview.chromium.org/1520663002 .
2015-12-10 14:22:16 -08:00
Florian Loitsch
f8b7d8d752 Fix typo in stream.dart.
BUG= #25223

Review URL: https://codereview.chromium.org/1517843002 .
2015-12-10 23:10:03 +01:00
Ryan Macnak
5111482ab9 Fix stack overflow check in InvokeClosure.
Isolate::saved_stack_limit() answers the limit of the Dart stack, which
is different from the C stack when using the simulators. Since we are
recursing in C, we want to check against the C stack's limit.

This overflow check is only needed to support --no-lazy-dispatchers,
which is part of precompilation.

BUG=http://dartbug.com/24659
R=regis@google.com

Review URL: https://codereview.chromium.org/1513993004 .
2015-12-10 14:06:19 -08:00
Brian Slesinsky
f0eb582d49 A class that's only used as a field type should be considered used
BUG=https://github.com/dart-lang/sdk/issues/25184
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1512833007 .
2015-12-10 13:52:41 -08:00
Konstantin Shcheglov
e94ec76865 Parse HTML files with keeping original attributes case.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1516073002 .
2015-12-10 13:51:48 -08:00
pq
62656833d4 Wraps up the server-side of the 'Allow a user to configure which hints are "fatal"' ask (#24452).
* migrates error filtering from a predicate to a process that can customize severities.
* moves filtering/processing from the `dart` task into the `getErrors` request and the errors notification.

See: https://github.com/dart-lang/sdk/issues/24452

(Pending a thumbs-up, support for CLI to follow.)

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/1517723002 .
2015-12-10 13:35:11 -08:00
Stephen Adams
5d74a7a958 Upgrade confuse() function in corelib tests
TBD=floitsch@google.com

Review URL: https://codereview.chromium.org/1513373002 .
2015-12-10 12:59:31 -08:00
Sigmund Cherem
18299203bb Update issue number
Review URL: https://codereview.chromium.org/1518873002 .
2015-12-10 12:51:06 -08:00
Stephen Adams
51b3b98bb9 Upgrade more confuse() functions
Verified generated code has no material changes.

TBR=floitsch@google.com

Review URL: https://codereview.chromium.org/1519563004 .
2015-12-10 12:49:20 -08:00
Sigmund Cherem
db4195c752 Fix #19137: handle when regexp doesn't match in constructorNameFallback
R=sra@google.com

Review URL: https://codereview.chromium.org/1510763006 .
2015-12-10 12:28:12 -08:00
Stephen Adams
dfc9ad2630 Test for consistent errors for optimized forms of '-'.
BUG=
R=sigmund@google.com

Review URL: https://codereview.chromium.org/1516723002 .
2015-12-10 11:32:22 -08:00
Paul Berry
1e0f112666 Update pkg.status to work around https://github.com/dart-lang/http_parser/issues/6
TBR=nweiz@google.com

Review URL: https://codereview.chromium.org/1513643011 .
2015-12-10 11:18:27 -08:00
Florian Loitsch
c95b4e46ff Enable more DateTime tests on dart2js.
Review URL: https://codereview.chromium.org/1520613002 .
2015-12-10 19:49:30 +01:00
Konstantin Shcheglov
eb6da55838 Paths where '..' is not right between separators are normalized.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org/1512363002 .
2015-12-10 10:39:53 -08:00
Paul Berry
2956d5d69b Roll back convert to version 1.0.0.
This should help fix analyzer buildbot warnings.  See #25221 for a more
detailed explanation.

Note that a few analyzer buildbot warnings remain, which I haven't yet
investigated.

TBR=nweiz@google.com

Review URL: https://codereview.chromium.org/1513103003 .
2015-12-10 10:33:20 -08:00
Stephen Adams
ae0da7de9c Canonical output ordering for constants.
Fix for: http://dartbug.com/24920

R=sigmund@google.com

Committed: d15e5d5192

Reverted.

Review URL: https://codereview.chromium.org/1491413008 .
2015-12-10 10:32:20 -08:00
Konstantin Shcheglov
0f95992770 Issue 25218. The reference type of 'A' in 'A..foo' is 'Type'.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25218

Review URL: https://codereview.chromium.org/1519583002 .
2015-12-10 10:20:40 -08:00
Brian Wilkerson
1a5a9a7247 Clean up syntax in generic method comments
R=jmesserly@google.com

Review URL: https://codereview.chromium.org/1515533004 .
2015-12-10 10:19:15 -08:00
Alan Knight
027b9ec164 Update Intl version in DEPS
BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org/1511103006 .
2015-12-10 10:12:51 -08:00
Konstantin Shcheglov
f93d4fde97 Issue 25219. Fix for RangeError during converting empty lines in /// comments.
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/25219

Review URL: https://codereview.chromium.org/1518723002 .
2015-12-10 10:08:07 -08:00
Florian Schneider
12155b1920 VM: Add missing source line info in await-for statements.
When an exception occurs in the constructor of the steam iterator, the
stack trace was missing the source position.

BUG=#24084
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/1516493002 .
2015-12-10 18:58:12 +01:00
Ryan Macnak
dfa715727b Record OSThread::trace_id() instead of OSThread::id() in profile samples.
The profiler only uses the thread id to check if two samples with the
same timestamp belong to the same thread. Using trace_id() allows
profile samples to be correctly grouped with timeline events.

R=iposva@google.com

Review URL: https://codereview.chromium.org/1508233003 .
2015-12-10 09:46:42 -08:00
Dan Rubel
37d52a5d1c do not suggest completions for cascade on library prefix - fixes #25215
add CompletionRequest dotTarget
add CompletionTarget offset and isCascade

R=scheglov@google.com

Review URL: https://codereview.chromium.org/1516883002 .
2015-12-10 11:57:26 -05:00
Brian Wilkerson
f0d249e269 Clean up package imports and library names
R=scheglov@google.com

Review URL: https://codereview.chromium.org/1513643009 .
2015-12-10 08:11:56 -08:00
William Hesse
eab11aaac5 Split up list of package files in build process, to work around xcode limits.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org/1516803002 .
2015-12-10 13:29:10 +01:00