This should fix the Windows failures from the 1.3.5 roll.
Change-Id: If0470b63ae301b5ce3a8a92458cf7388d5b5ddf6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144686
Commit-Queue: William Hesse <whesse@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit 334dd63dac.
Reason for revert: There are unit test failures on Windows, including crashes of the formatter.
Original change's description:
> Update dart_style to 1.3.5.
>
> The main change is not directly user visible: it brings in the new
> Command used by the new "dart" tool to invoke the formatter. But there
> are also a handful of minor formatting changes.
>
> Change-Id: If7ce92e5a97d527749030714397b7b56773d9987
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142541
> Commit-Queue: William Hesse <whesse@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
TBR=whesse@google.com,rnystrom@google.com,athom@google.com
Change-Id: If6afb82e83c2e491c63e5fa0859b10daaa7d4f33
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144563
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
The main change is not directly user visible: it brings in the new
Command used by the new "dart" tool to invoke the formatter. But there
are also a handful of minor formatting changes.
Change-Id: If7ce92e5a97d527749030714397b7b56773d9987
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142541
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Change-Id: I0bf0e145727c668f19bdec55b7e11f5709b20cf3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144487
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Fixes buildbot failures by running VM service and DDS service tests in
separate test processes.
This reverts commit 1f0c90868c.
Change-Id: I0ad9b2e6ccea4d5468dd4dcdde0e286bcbf820ff
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142902
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Once upon a time, Observatory was built via pub and needed to cache the result of `pub get` to have stable / reproducible builds. Now it is built directly with dart2js and no longer uses any old packages, so the copies of packages brought in via DEPS are fine.
Change-Id: I7b32910570cd21fbf42cae6ac25b57c72a134c81
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143403
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
This bit is required to support synthesized field used for the late
lowering. These fields should not be seen as part of the interface,
that is, classes that implement the class declaring the late field should
not be required to override these fields.
Closes#41436
Change-Id: I9a98322bdd1842b46bde34fff1176a7577672e0f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142998
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2020-04-13 irina.arkhipets@gmail.com Fixed issue 607: Simple-bounds tests adopted for nnbd mode, new tests added.
2020-04-13 sgrekhov@unipro.ru 608. Check that on-catch variables are final
2020-04-10 irina.arkhipets@gmail.com Fixed issue 603: expected result upated according to the issue 41437 evaluation.
2020-04-10 irina.arkhipets@gmail.com Added SharedOptions=--enable-experiment=non-nullable flag to Simple-bounds tests.
2020-04-10 sgrekhov@unipro.ru Fixes 606. Requirements=nnbd-weak added to tests which use legacy libraries
2020-04-09 sgrekhov@unipro.ru 606. Requirements=nnbd-weak added to tests which use legacy libraries
2020-04-08 sgrekhov@unipro.ru Fixes 605. Type normalization tests added
2020-04-06 sgrekhov@unipro.ru Fixes 600. NNBD. Extension method resolution tests added
2020-04-06 irina.arkhipets@gmail.com Fixed issue 604: missung return added.
2020-04-05 irina.arkhipets@gmail.com Fixed issue 577: new tests for future flattening added.
2020-04-05 irina.arkhipets@gmail.com Fixed issue 577: new tests for future flattening added.
2020-04-05 irina.arkhipets@gmail.com Fixed issue 577: new tests for future flattening added.
2020-04-03 irina.arkhipets@gmail.com Fixed issue 577: new tests fir future flattening added.
2020-04-02 irina.arkhipets@gmail.com Fixed issue 593: check gor runtime exception added.
2020-04-02 sgrekhov@unipro.ru Fixes 549. Split line with two expected errors to two lines
2020-04-02 sgrekhov@unipro.ru Fixes 598. There must be two error expectations if an error is reported twice on the same line
2020-04-02 sgrekhov@unipro.ru Fixes 599. Move error expectations to different lines of code
2020-04-02 sgrekhov@unipro.ru Fixes 597. Const objects test added
2020-04-01 askesc@google.com Skip surrogates in decode test (592)
2020-04-01 sgrekhov@unipro.ru Issue numbers added
2020-04-01 sgrekhov@unipro.ru Additional fix for 542. Change expected result according to the changed behavior
2020-04-01 sgrekhov@unipro.ru Fixes 479. NNBD assignability tests added for type aliases
2020-04-01 irina.arkhipets@gmail.com Fixed issue 577: new tests for future flattening added.
2020-03-31 irina.arkhipets@gmail.com Fixed issue 577: new tests for future flattening added.
Failures will be triaged on https://github.com/dart-lang/co19/issues/609.
Change-Id: I05fc52c5ded52da6cd587a6f995f03a9382100e7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142990
Reviewed-by: William Hesse <whesse@google.com>
This reverts commit b41f7dd1d9.
Reason for revert: Too many new analyzer issues to land in google3.
Original change's description:
> bump to linter 0.1.115
>
> Change-Id: Ib20ee6049ce1155a5ba36664f607b09a502f0340
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143186
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
TBR=brianwilkerson@google.com,pquitslund@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: Icad6d31d19e64444c94fabd9d851c2a6bd03a820
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142989
Reviewed-by: David Morgan <davidmorgan@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: David Morgan <davidmorgan@google.com>
The one we're using is over a year older than the one they're using,
so let's try to limit any discrepancies that might happen between
our uses and theirs.
Bug: https://github.com/dart-lang/sdk/issues/40850
Change-Id: I0e89c821470ea46e2bc807d33c7f1b6a24aa1e65
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142840
Auto-Submit: Tess Strickland <sstrickl@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This reverts commit 6b2419ddaf.
Reason for revert: Failures on bots. Reverting.
Original change's description:
> [ Service / package:dds ] Add stream support to package:dds and enable DDS for VM service tests
>
> This change adds stream forwarding to the Dart Development Service,
> allowing for clients to subscribe to service protocol streams with DDS
> instead of the VM service directly. DDS will maintain a single
> subscription for each stream as long as at least one client is listening
> to that stream. A DDS stream subscription will be closed when the last
> client listening to that stream either disconnects or calls
> streamCancel.
>
> This change also enables DDS for most of the Observatory services tests,
> excluding thoses which utilize:
>
> - Service extensions
> - Client naming
> - Client isolate resume synchronization
>
> Change-Id: I5641e879a7626fcd5e4d28434ed480dd72fc7659
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142083
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Ben Konyi <bkonyi@google.com>
TBR=bkonyi@google.com,rmacnak@google.com,asiva@google.com
Change-Id: I185e63eabca54a3dff49d4f5a8a126795cadfa80
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142820
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This change adds stream forwarding to the Dart Development Service,
allowing for clients to subscribe to service protocol streams with DDS
instead of the VM service directly. DDS will maintain a single
subscription for each stream as long as at least one client is listening
to that stream. A DDS stream subscription will be closed when the last
client listening to that stream either disconnects or calls
streamCancel.
This change also enables DDS for most of the Observatory services tests,
excluding thoses which utilize:
- Service extensions
- Client naming
- Client isolate resume synchronization
Change-Id: I5641e879a7626fcd5e4d28434ed480dd72fc7659
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142083
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
Change-Id: I6d978829cd5ef6277ce511721dfccc593ad01a93
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141582
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
git log --pretty=oneline
978cc9c4be7d8978348e56d4ae82be8257a59579 Normalize command names when invoked via alias (#2425)
Change-Id: I134e981402ece9632c786655c85401afb5b17551
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141900
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Michael Thomsen <mit@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
git log --pretty=oneline 737f055d0a1cfb348178dbde6bd13f06704bf6d4..f87c05da8cd049efa26891f1e6927dcfe30777f2
f87c05da8cd049efa26891f1e6927dcfe30777f2 (HEAD -> master, origin/master, origin/HEAD) Always normalize paths before they are passed to the analyzer (#2409)
58bd44b5a46f27eae80cb2ec79af2b3f55faf291 hide mark option from outdated (#2403)
395f644e44c5d7d432623fb1ea74948bf05889db Fix pub outdated help messages consistency (#2408)
1b558f251b9b1d990015260ff9819160956c8093 Use different language version API. (#2400)
a9fdf9ff61f01507bbc9bcecc075f11dc09c13b9 Output a summary when there are newer version, but they cannot resolv… (#2387)
e0e396bf2aadbe21be5174784c6f37de87d34493 Outdated fix messages (#2401)
Change-Id: Icf5a6b8ec9ae50148689cac7bfe5fca33043a70a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141246
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Change-Id: Ia94a551c7f45c833ab1a6e9ba6b56bc237b1cd42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141248
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
```
737f055d0a1cfb348178dbde6bd13f06704bf6d4 Fix NPE during language version analysis (#2398)
```
Change-Id: I83a3110a64e8db9c576a5a52d53688ea392e1b33
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141060
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
New commits
```
ab109723d9eb782c2ea4cce68c044da40403a652 Include telemetry headers when sending any request to the pub site (#2389)
```
No user visible changes
Change-Id: Ifec77d1724b888b0a3375538331c3724edf8ad87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140860
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
