languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 09:43:08 +00:00
Code Issues Projects Releases Packages Wiki Activity
66526 commits 11 branches 6011 tags 1.4 GiB
Commit graph

24 commits

Author SHA1 Message Date
Zach Anderson
825d03c585 [vm] Remove malloc_hooks support for jemalloc 
Fuchsia is switching/has switched to scudo.

Change-Id: I0c829518652053243bf3f8db675e562ccfb448f9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/95663
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-03-06 19:16:27 +00:00
Ben Konyi
07852532e3 [ VM ] Additional cleanup in Dart_Initialize and Dart_Cleanup 
Change-Id: I6dc02b3d9de16cc176eb97613bc0c7f0bb9b16eb
Reviewed-on: https://dart-review.googlesource.com/77013
Commit-Queue: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Ben Konyi <bkonyi@google.com>
 2018-09-28 23:18:59 +00:00
Zachary Anderson
6cd8a79078 VM: Re-format to use at most one newline between functions 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2974233002 .
 2017-07-13 08:08:37 -07:00
Ryan Macnak
dca21921fb When collecting traces for native allocation, we depend on the architecture the native code is running, not the Dart code. 
R=zra@google.com

Review-Url: https://codereview.chromium.org/2828383002 .
 2017-04-21 13:34:51 -07:00
Zachary Anderson
135b1907ee [Fuchsia] Grab the number of malloc'd bytes from jemalloc 
This allows us to report the "native heap memory" value in
the Observatory for VMs running on Fuchsia.

This change also renames the flag --enable-malloc-hooks to
--profiler-native-memory to better reflect what the flag
does. (In the future we may also want to rename
--profiler to --profiler-cpu.)

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2829833003 .
 2017-04-19 15:51:02 -07:00
Ben Konyi
7c820f4363 Resubmission of native memory allocation info surfacing in Observatory. Fixed crashing tests and stack trace collection skip counts for different configurations. 
Fixed missing method referenced when MallocHooks is unsupported.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2771293003 .
 2017-03-27 13:25:26 -07:00
Ben Konyi
9ea672efc0 Revert "Added page to Observatory to display native memory allocation information." 
This reverts commit f30f312b48.

Revert "Fixed missing method referenced when MallocHooks is unsupported."

This reverts commit a0b9c5a178.

TBR=johnmccutchan@google.com

BUG=

Review-Url: https://codereview.chromium.org/2773073003 .
 2017-03-24 09:47:29 -07:00
Ben Konyi
a0b9c5a178 Fixed missing method referenced when MallocHooks is unsupported. 
Added page to Observatory to display native memory allocation information.

BUG=

Review-Url: https://codereview.chromium.org/2778463002 .
 2017-03-24 09:34:48 -07:00
Ryan Macnak
877284947b Rename TARGET_OS_* to HOST_OS_*. 
Like HOST_ARCH_*, HOST_OS_* describes the OS the VM is running on, which may be different from the OS the VM is generating code for during AOT compilation.

Currently we conflate the two when emitting AOT as assembly, and we get away with it because Flutter only uses assembly for targeting iOS and one can only target iOS from a Mac, but we expect to use assembly for Android as well so native tools can unwind Dart frames.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2750843003 .
 2017-03-15 13:11:05 -07:00
Ben Konyi
68a102cab2 Fixed tests not having MallocHooks initialized for tests in release mode. 
Revert "Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection.""

This reverts commit 1a5b555aa9.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2711353003 .
 2017-02-24 13:56:06 -08:00
Ben Konyi
1a5b555aa9 Revert "Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection." 
This reverts commit 44a9a4ede3.

BUG=

Review-Url: https://codereview.chromium.org/2714083002 .
 2017-02-23 19:21:00 -08:00
Ben Konyi
44a9a4ede3 Fixed issue in MallocHooks where a MallocHookScope was accidentally removed during a merge, causing a deadlock in the hooks. Also turned off stack trace collection in a test that was timing out as a result of the stack trace collection. 
Updated MallocHooks to collect stack traces when memory is allocated.

BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2718523003 .
 2017-02-23 18:58:50 -08:00
Ben Konyi
d4f026c2e0 Revert "Updated MallocHooks to collect stack traces when memory is allocated." 
This reverts commit a486a8a26b51dce728373183ab02aeda70e6f2d0.

R=johnmccutchan@google.com
TBR=johnmccutchan@google.com
BUG=

Review-Url: https://codereview.chromium.org/2713803003 .
 2017-02-23 13:13:44 -08:00
Ben Konyi
47f0da9cd7 Updated MallocHooks to collect stack traces when memory is allocated. 
BUG=
R=johnmccutchan@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2680213002 .
 2017-02-23 12:42:18 -08:00
Siva Annamalai
84e95a971f Fix for issue 28638 - flakiness on dartkp-dart-precompiled caused by MallocHooks 
BUG=#28638
R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2678313003 .
 2017-02-08 13:45:05 -08:00
Ben Konyi
c8e275537d Surfaced native heap memory allocation information to the Observatory 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2667743004 .
 2017-01-31 16:09:49 -08:00
Ben Konyi
f679b3c3e5 Reintroducing MallocHooks changes with fix for hooks being called when in execvpe after a fork while the MallocHooks lock is held by a thread that may no longer exist. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2647283004 .
 2017-01-30 09:55:20 -08:00
Zach Anderson
7730809f36 Revert "Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Exit." 
This reverts commit 7bf5d87017.

The lock introduced by this change in MallocHooksState is held across
a fork(), which causes deadlock in the child when execvpe() fails and
tries to acquire the lock when freeing memory.

Review-Url: https://codereview.chromium.org/2647793005 .
 2017-01-20 23:52:31 -08:00
Ben Konyi
7bf5d87017 Reintroducing MallocHooks changes with fix for infinite loop in MallocHooks on Platform::Exit. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2643303003 .
 2017-01-20 15:26:58 -08:00
Ben Konyi
c9a4374ed9 Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project." 
This reverts commit 5290052550.

Revert "Fixed segfault in Remove method."

This reverts commit 203f1ba222.

BUG=
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2647763003 .
 2017-01-19 15:17:29 -08:00
Ben Konyi
5290052550 Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project. 
Fixed build issues from original submission.

BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2623613003 .
Review-Url: https://codereview.chromium.org/2644903003 .
 2017-01-19 13:15:56 -08:00
Ben Konyi
10686766cd Revert "Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project." 
This reverts commit bcd7ba1056.

TBR=zra@google.com

BUG=

Review-Url: https://codereview.chromium.org/2645973002 .
 2017-01-19 12:14:19 -08:00
Ben Konyi
bcd7ba1056 Implemented basic heap memory allocation tracking in MallocHooks using hooks registered with tcmalloc. Also updated BUILD.gn files to account for include paths within the tcmalloc project. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2623613003 .
 2017-01-19 12:09:07 -08:00
Ben Konyi
9ff7ee6132 Created placeholders for MallocHooks implementation and added define DART_USE_TCMALLOC to specifiy when tcmalloc is available. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2619443002 .
 2017-01-06 12:38:11 -08:00