Fixes#36072
Change-Id: I1abc4dd293ac15327f458d0f0676067bf57c0a39
Reviewed-on: https://dart-review.googlesource.com/c/95181
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
The 7zip dependency is only used on Windows. Use gclient's OS-specific
hook feature to only download it while on Windows. This avoids the
download from google cloud storage from needlessly saying it is doing
nothing.
There's no reason to point out the sysroot is already up to date as this
makes gclient output several lines of text with zero information.
Change-Id: Id1c212c8a951612c413e9834867fe90f6dca6a20
Reviewed-on: https://dart-review.googlesource.com/c/94752
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Change-Id: I18b8268e7ad5c211f83f323957440e29b50ec0d7
Reviewed-on: https://dart-review.googlesource.com/c/94805
Commit-Queue: Alexander Thomas <athom@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
```
git log --oneline --no-decorate 980fc947db32bca6ae7d07fbb4ad0fcdba0050ec..3c060aae47985e9a248b850f1d0450304a5c97e3
3c060aae Usage: pub global activate <package> [version-constraint] (#2051)
93783b60 Improve the error when encountering a non-local package with a path dep
2b4056b0 Lint tweaks for Dart 2.2
135e10af Update last modified date directly in `touch` (#2014)
```
No relevant changes for the changelog
Bug: https://github.com/dart-lang/sdk/issues/36026
Change-Id: I2dcaad614f5fbd511712d4713c7b008d7ff710f1
Reviewed-on: https://dart-review.googlesource.com/c/94744
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
New in this update:
```
git log --oneline --no-decorate 9f00679ef47bc79cadc18e143720ade6c06c0100..980fc947db32bca6ae7d07fbb4ad0fcdba0050ec
980fc947 Add support for global activating package from a custom pub URL (#2041)
605cafb1 "features" is not a completely implemented or documented – hide flags (#2045)
73b66cd3 Merge pull request #2035 from sigurdm/logout_command
2b03587d dartfmt again
ea805dfb Fix help-expectation
6f759c1f gitfmt
90079421 deps: move package_resolver to a dev dependency
297f017a enable and fix a number of lints
f70ee39b Update to latest dependencies, require dart 2.1, fix lints
3446fb0d Add logout command
283471e7 Merge pull request #2016 from RedBrogdon/changelog
4c00f413 Update/add www.dartlang.org URLs (#2021)
f7b147f9 Correcting nerfed changelog test.
b9308223 Edited warning messages, addressed review issues.
9e9c8ed7 Fixed race conditions in test case. (#2020)
ec972168 Removed references to gitsubmodules (#2019)
ac8ad792 Copyright dates.
f9d35d34 Formatted via dartfmt.
a3351369 Adding ChangelogValidator to the list of validators.
a826b121 Adds changelog validator and its tests.
2233e3d5 Update the required pkg:http (#1996)
75d8453a Update all of the obvious dependencies
d07dafa5 Fix unnecessary `this` lints
43a91d12 Update to latest build_runner (#1966)
b3a2cfb7 Add check for a scheme on PUB_HOSTED_URL (#1972)
6626bda3 Update tests for SDK constraint validation (#1968)
```
Change-Id: Ib7c5ec86e5a6d67094b8e70a32ff41efe571c074
Reviewed-on: https://dart-review.googlesource.com/c/94380
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
The large application is from an internal customer.
Change-Id: I670180a85ca402a34f99493d05de0124f8f89701
Reviewed-on: https://dart-review.googlesource.com/c/94296
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
We continue to accept `--dump-info`, but now also accept `--dump-info=binary` so
we can use the new cheaper encoding.
Change-Id: I971cb9a3634ae1a333cfee14b2927c0e25000a01
Reviewed-on: https://dart-review.googlesource.com/c/93823
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
The Set literals support in 0.1.82 looks good for Flutter after a test migration
(https://github.com/flutter/flutter/pull/27811).
flutter-analyze-try is meant to break but only flag legitimate opportunities to migrate (validated in PR above).
Change-Id: Ie63d00cd006a96cd7f2df44b82ff8a82cf73b6bc
Reviewed-on: https://dart-review.googlesource.com/c/92761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* updated `prefer_collection_literals` to support Set literals
* deprecated `super_goes_last`
* (internal) migrations to analyzer's preferred `InheritanceManager2` API
Change-Id: I9491c2128dd0360cd1d768242c3d1aac10687d08
Reviewed-on: https://dart-review.googlesource.com/c/92406
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
pkg:platform is no longer useds. process and file were only needed by platform
pkg:func is no longer used
Also removed non-existent entries in .packages
Change-Id: I927856efa0f6fc49676885616c3ecd5183250454
Reviewed-on: https://dart-review.googlesource.com/c/91101
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Change-Id: Id353fa11a8f86415569a505ef5ecd7bf03fb51e1
Reviewed-on: https://dart-review.googlesource.com/c/90487
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
This allows developers to have more fine grained control over socket
options supported by their platforms, particularly when there is not a
nice way to encapsulate differences between IPv4 and IPv6 options (as
with IP_MULTICAST_IF and IPV6_MULTICAST_IF). It also begins the work
of exposing socket level and option values, although keeping it for now
only to a minimum necessary to assist with setting the multicast
interface for datagram sockets.
This CL also marks `multicastInterface` as deprecated.
Bug: https://github.com/dart-lang/sdk/issues/17057
Change-Id: I39b3bf3d32d39de1c777acea4425d6eb2226355d
Reviewed-on: https://dart-review.googlesource.com/c/89164
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: Id4f4b664b58d10d1a7325923cd5fb42481ce7c66
Reviewed-on: https://dart-review.googlesource.com/c/87968
Commit-Queue: William Hesse <whesse@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Auto-Submit: William Hesse <whesse@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
* `unnecessary_parenthesis` updated to allow wrapping a `!` argument
* miscellaneous documentation grammar and spelling fixes
* improved error messages for `always_declare_return_types`
* fix `prefer_final_fields ` to work with classes that have generic type arguments
* (internal): deprecated code cleanup
* fixed false positives in `unrelated_type_equality_checks`
Change-Id: I375a70aa86d5816881ea5d8faac65e5c3e72c80b
Reviewed-on: https://dart-review.googlesource.com/c/87422
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Was needed for pkg:dartdoc, but that dependency has been removed
Change-Id: I2d314f8400e3ea5d905864e8728384dd3dc86800
Reviewed-on: https://dart-review.googlesource.com/c/87263
Reviewed-by: Janice Collins <jcollins@google.com>
Change-Id: I101eae9189848a699e4b186f363d9a684d7b2d02
Reviewed-on: https://dart-review.googlesource.com/c/85703
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This adds support for set literals. It doesn't change any other
formatting, so it should be safe to land this without rebuilding the
checked-in SDK.
Change-Id: I7be9802b0ce81f32fd1023cd0ed08995ed8203cb
Reviewed-on: https://dart-review.googlesource.com/c/86581
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
(note that https://github.com/dart-lang/linter/pull/1296 needs to land first and 0.1.75 tagged in GH)
Change-Id: Icf022f60c1b2f6cf2371ea24036649ac4df1b1d5
Reviewed-on: https://dart-review.googlesource.com/c/86081
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
There are no formatting changes, so this is safe to do without also
updating the pre-built SDK.
Change-Id: I78c961acc181bb8d4456dc49fecf485d33a93582
Reviewed-on: https://dart-review.googlesource.com/c/85820
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
We no longer rely on Fuchsia's buildtools, instead we directly fetch
Clang and GN packages from CIPD using gclient support.
Change-Id: I8995d89babf9c3c6b30214a1133e7b0a1cb9a796
Reviewed-on: https://dart-review.googlesource.com/c/85416
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
This reverts commit ad69aaef62.
Reason for revert: <INSERT REASONING HERE>
Original change's description:
> Reland: [infra] Roll buildtools to c72a1c5aadde06505b7bb4641720880f3db28ff9
>
> Tries to work around update.py race by setting up symlinks for 'git cl format'
> instead of copying.
>
> Change-Id: I4ed9b99254803feea5ea0e8d30db23fc982e9562
> Reviewed-on: https://dart-review.googlesource.com/c/85427
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>
TBR=rmacnak@google.com,zra@google.com
Change-Id: Ida584adda37cd3e2dac16654eb1e81e92f123f88
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/85467
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Tries to work around update.py race by setting up symlinks for 'git cl format'
instead of copying.
Change-Id: I4ed9b99254803feea5ea0e8d30db23fc982e9562
Reviewed-on: https://dart-review.googlesource.com/c/85427
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Change-Id: I718a5d70874e7090cb42f1d452cd8dcf020d337e
Reviewed-on: https://dart-review.googlesource.com/c/84631
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This reverts commit 9ed26558f1.
Reason for revert: Failing builds due to missing gn runs
Original change's description:
> [infra] Add back generate_buildfiles.py to gclient hooks
>
> Omitting this was a little fragile. We can add it back following the
> fix in https://chromium-review.googlesource.com/c/chromium/tools/depot_tools/+/1255446
>
> Change-Id: Idfa0a08674bc1ea7ef19d7c9a96e17e6da293297
> Reviewed-on: https://dart-review.googlesource.com/c/84280
> Reviewed-by: Alexander Thomas <athom@google.com>
> Commit-Queue: Zach Anderson <zra@google.com>
TBR=whesse@google.com,sortie@google.com,zra@google.com,athom@google.com
Change-Id: I87cd9ddf5eca2e2a247a74eb1e666aa40bae7a48
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/84281
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
Change-Id: I8e37c6dc29dc5ee00525364bfdb6eaee02a37416
Reviewed-on: https://dart-review.googlesource.com/c/82202
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
TBR=kevmoo@google.com
Change-Id: Ib4b89f95beae38ec0fc0697cedd2fb1474ebb0ef
Reviewed-on: https://dart-review.googlesource.com/c/83320
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
* new lint: `prefer_int_literals`
* update `await_only_futures` to allow awaiting on `null`
* update `use_setters_to_change_properties` to work with `=>` short-hand
Change-Id: Iafc46bb9c02675b47bda9b4d4124a8efc76584d8
Reviewed-on: https://dart-review.googlesource.com/c/81881
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
dart binary would instantiate CrashpadClient if DART_CRASHPAD_HANDLER
and DART_CRASHPAD_CRASHES_DIR environment variables are set.
- DART_CRASHPAD_HANDLER should contain the path to the crashpad_handler
binary that would handle the crash and write minidump;
- DART_CRASHPAD_CRASHES_DIR should contain the path to the crashpad database
which would be used to store minidumps.
Rewrite --copy-crash-dumps support on windows to use Crashpad integration
instead of editing Windows registry.
Embedding crashpad required to roll a new zlib version because Crashpad
depends on the zlib. This version of zlib is buildable with its own
BUILD.gn so our custom BUILD.gn is removed.
Change-Id: I048aad16b234e1d750f0a24782b04e3b6e19703d
Reviewed-on: https://dart-review.googlesource.com/c/81007
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Change-Id: If0747db4bd02d31814b407970b11d16519329625
Reviewed-on: https://dart-review.googlesource.com/c/79661
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Also updated the package references in a number of pubspecs to
more closely align with the package versions that are in the SDK
Change-Id: I061951587befa4211ac7455cf1179911eb07efc0
Reviewed-on: https://dart-review.googlesource.com/c/79920
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
This deletes:
tests/co19
tests/corelib
tests/html
tests/isolate
tests/language
tests/lib
It does not delete tests/standalone because apparently there are tests
in there that are not in standalone_2. (I assume they were added after
the test migration. I don't know why they were added there.)
I have tried to remove references to the old tests from various scripts
and tools but may have missed some. (As you can imagine, grepping for
"lib" does not have the best signal-to-noise ratio.)
"It was a pleasure to burn. It was a special pleasure to see things
eaten, to see things blackened and changed. With the brass nozzle in his
fists, with this great python spitting its venomous kerosene upon the
world, the blood pounded in his head, and his hands were the hands of
some amazing conductor playing all the symphonies of blazing and burning
to bring down the tatters and charcoal ruins of history."
- Ray Bradbury, Fahrenheit 451
Change-Id: If3db4a50e7a5ee25aff8058b1483e2ce8e68424e
Reviewed-on: https://dart-review.googlesource.com/c/75420
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
This reverts commit 787194e738.
Reason for revert: Broke windows bots.
Original change's description:
> [infra] Upgrade gsutil to a new version (#31065)
>
> Change-Id: Ie78c6295a5b11cc12adc07a65f716638bcc71495
> Reviewed-on: https://dart-review.googlesource.com/c/79208
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Commit-Queue: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,athom@google.com
Change-Id: I75c0a2731f80e969fdcd06a6ca2ed72a0407dfbc
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/79214
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* Use 64bit d8 on Windows & Mac.
* Default to 64bit d8 on Linux.
Change-Id: Ia03275e48ed0e30bcb2a7b390e7007e34e92cfc5
Reviewed-on: https://dart-review.googlesource.com/c/78640
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
* co19_2 tests enabled for vm-kernel CQ builders.
Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* miscellaneous mixin support fixes
* update to `sort_constructors_first` to apply to all members
* update `unnecessary_this` to work on field initializers
Change-Id: If0578fb3dd67d8f746044e8bbc21e166cd43e4ef
Reviewed-on: https://dart-review.googlesource.com/c/77984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: I91fe0da8595ddf07c5b0a345ac9417730b6f964f
Reviewed-on: https://dart-review.googlesource.com/77542
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
* fix cast exceptions related to mixin support
Change-Id: I26361e41f9dee940c462558b6d8251a93f351ecb
Reviewed-on: https://dart-review.googlesource.com/77227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
There is a race with downloading the prebuilt Dart SDK from CIPD
introduced by:
647e1e79eb
If the prebuilt Dart SDK isn't there, then generate_buildfiles.py will
fail. Instead check whether generate_buildfiles.py should be run
right before we try to build.
Change-Id: I1e25e5280075f9d1c7d96877602617ddfb40291e
Reviewed-on: https://dart-review.googlesource.com/77160
Reviewed-by: Jonas Termansen <sortie@google.com>
* fixes to better support mixins
Change-Id: Ibc67ec7b98d8bc478b0343335e40974b385da152
Reviewed-on: https://dart-review.googlesource.com/76565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* updated `unawaited_futures` to ignore assignments within cascades
* new lint: `sort_dependencies`
Change-Id: Iec39fce58d4c6230613f947ed6fc99fec516c722
Reviewed-on: https://dart-review.googlesource.com/75942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This is safe to do without also rebuilding the checked in SDK because
it doesn't affect any existing formatted code.
Change-Id: I615c1145c2343da54b7a532ff3f5d077e63cb7ed
Reviewed-on: https://dart-review.googlesource.com/75563
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
* new lint: `prefer_mixin`
* new lint: `avoid_implementing_value_types`
Change-Id: Iaba2d1dd50511db935cf050ba49e7d10746be8cb
Reviewed-on: https://dart-review.googlesource.com/74880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
* new lint: `flutter_style_todos`
* improved handling of constant expressions with generic type params
* NPE fix for `invariant_booleans`
* Google lints example moved to `package:pedantic`
* improved docs for `unawaited_futures`
Change-Id: Ie0eb779f8cb98aaa67674ecfd17baf12445a5934
Reviewed-on: https://dart-review.googlesource.com/74340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Change-Id: Ib37f2f5fd6aec3b86677b5f1c51f6ec6147069a7
Reviewed-on: https://dart-review.googlesource.com/74280
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: I72b493a65ef5c854b122d76d80549d30141157fd
Reviewed-on: https://dart-review.googlesource.com/71243
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Change-Id: Iff7d207cda2a88c0f51135a56aec78eed0935d0a
Reviewed-on: https://dart-review.googlesource.com/69461
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
* relaxed `void_checks` (allowing `T Function()` to be assigned to `void Function()`)
* test and build improvements
* introduced Effective Dart rule set
* Google ruleset updates
* (internal cleanup): move cli main into `lib/`
* fixed false positives in `lines_longer_than_80_chars`
* new lint: `prefer_void_to_null`
Change-Id: I374197f09701041fd0b507062a3ad903f731656a
Reviewed-on: https://dart-review.googlesource.com/69382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
This reverts commit f99b9b80ff.
Reason for revert: Rolls in a version of co19_2 that contains two files whose name differs only by case and whose content is not the same. This breaks "gclient sync" on machines with case-insensitive filesystems (e.g. macs).
Original change's description:
> [co19] co19_2 tests roll (DEPS and .status files update)
>
> Closes#33894
>
> Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
> Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
> Reviewed-on: https://dart-review.googlesource.com/68860
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
TBR=whesse@google.com,athom@google.com,eernst@google.com,sgrekhov@unipro.ru
Change-Id: Icd6d8d763c8baff2b82bd15c6b28c56591b7431e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Reviewed-on: https://dart-review.googlesource.com/69340
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Closes#33894
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
Reviewed-on: https://dart-review.googlesource.com/68860
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Closes#33878
Change-Id: Id4687f59c31adb1338643f86909bc5b6b7afb88a
Reviewed-on: https://dart-review.googlesource.com/68040
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This may impact other parts of the SDK who share dartdoc's dependencies.
Change-Id: I5ec19aabcca78c373386dff3c194108b6586841f
Reviewed-on: https://dart-review.googlesource.com/66702
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
These where the last two uses of sunflower in the repo. Sunflower sources have
been deleted from the public github repo. We can alternatively copy them here,
but for these tests it doesn't really matter what code we use.
A benefit of using swarm: this will test compiling swarm, so we detect breakages
early (and not when they hit the perf bots). A drawback of using swarm: it is
bigger and these tests will take longer. For dump-info that might be a good
thing, though.
TBR
Change-Id: Ie976cf4250f5f7ce17147ba8b166e7a6bd429425
Reviewed-on: https://dart-review.googlesource.com/65784
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
* roll-back to explicit uses of `new` and `const` to be compatible w/ VMs running `--no-preview-dart-2`
# 0.1.57
* fix to `lines_longer_than_80_chars` to handle CRLF endings
* doc improvements
* set max SDK version to <3.0.0
* fix to `non_constant_identifier_names` to better handle invalid code
* new lint: `curly_braces_in_flow_control_structures`
Change-Id: I1fd3c9b3892f377c634057451ea0938347ef4e9a
Reviewed-on: https://dart-review.googlesource.com/65573
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
We also need to update the prebuilt SDK to keep it in sync with this
change so the presubmit doesn't get wonky. But, in this case, it should
be fine. The change affects a rare case that I don't think occurs in
the SDK: a multi-line string inside a string interpolation, inside
another string. If that does occur, it's easy to just change that code.
Change-Id: Icdfdfb0b2e1359005d88d983e9a3cf05b0e91e48
Reviewed-on: https://dart-review.googlesource.com/65280
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
* fix to `avoid_positional_boolean_parameters` to ignore overridden methods
* fix to `prefer_is_empty` to not evaluate constants beyond int literals
* new lint: `null_closures`
* new lint: `lines_longer_than_80_chars`
Change-Id: Id11694d65091de6f26f521d62f3c5fb1921f58af
Reviewed-on: https://dart-review.googlesource.com/63271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
#33659
Change-Id: I94fccf4bbce2f0140bf0d6efa953d44b290df856
Reviewed-on: https://dart-review.googlesource.com/62840
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
Change-Id: I42a5c41394226f6ddc9c0608c6d688ae683ffdea
Reviewed-on: https://dart-review.googlesource.com/62680
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed an issue in `const` error handling
* updated `linter` binary to use `previewDart2`
Change-Id: Ic46df8fc248c241b9ecc71e180ae3adb2238546a
Reviewed-on: https://dart-review.googlesource.com/62641
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Update Changelog to add this info, and to prepare for releasing -dev.65.0
Change-Id: Iaa6c0d917acb1132227352b422ef3939cda2a9f4
Reviewed-on: https://dart-review.googlesource.com/61926
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Closes#33187
Brings in the latest version of pub. There is still an issue with
invaliding old snapshots, but this version works better than the current
synced version.
Change-Id: I5c98b0277ea769baa83c3fee7ebfff2034ba9920
Reviewed-on: https://dart-review.googlesource.com/61983
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
https://github.com/dart-lang/dartdoc/releases/tag/v0.20.1
Updates dartdoc and its dependency "quiver" to new versions (dartdoc
ran into a type problem with the older quiver).
Because of the quiver change this could affect more than just dartdoc.
Change-Id: I9b0bbb3d4b222f605d7ac5cafc641b5da0c02d20
Reviewed-on: https://dart-review.googlesource.com/61912
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
New version avoids literals that are not exact in JavaScript.
Change-Id: I38fa0d6132b9006f361b01e3e691b5a672584e98
Reviewed-on: https://dart-review.googlesource.com/61741
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This fixes precompiling snapshots when running pub get/upgrade which
broke when the VM removed support for "--preview-dart-2".
Change-Id: I70fe2241f85cf5e8cdf447387df92ea47d398c57
Reviewed-on: https://dart-review.googlesource.com/61440
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
* new `unnecessary_const` lint
* new `unnecessary_new` lint
* fixed errors in `use_to_and_as_if_applicable`
* new `file_names` lint
Change-Id: Ic461249050277ea81ade7a90b92506c6041ac480
Reviewed-on: https://dart-review.googlesource.com/61280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* updated `unnecessary_statements` to ignore getters (as they may be side-effecting).
Change-Id: I2019d1c2c49224525ac066a8f44c6da301dbfd91
Reviewed-on: https://dart-review.googlesource.com/60180
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
* fixed `void_checks` to handle arguments not resolved to a parameter
* fixed exceptions produced by `prefer_const_literals_to_create_immutables`
Change-Id: Ia25fe8e432ee7717cfe289bce4515481e801c4f8
Reviewed-on: https://dart-review.googlesource.com/59201
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Change-Id: If1705ac18715876fc5c1325dab4c3dda42b8d2b9
Reviewed-on: https://dart-review.googlesource.com/56580
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
* `unrelated_type_equality_checks` now allows comparison between `Int64` or `Int32` and `int`
* `unnecessary_parenthesis` improved to handle cascades _in_ cascades
Change-Id: I588893132e04a706e9fc93a7a16a07005465eb1f
Reviewed-on: https://dart-review.googlesource.com/55914
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Change-Id: I6843981cda8e0dc7936271bcc019ab9571b15d67
Reviewed-on: https://dart-review.googlesource.com/55321
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
This should be safe to do without rolling the prebuilt SDK since it
makes no changes to existing formatted code.
Change-Id: I3420698b5dac94ab04ee7908940ace70936a3e5b
Reviewed-on: https://dart-review.googlesource.com/55269
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
