_setPropertyUnchecked version that can be inlined.
No change in the generated JavaScript for dart2js.
Change-Id: Ie4a8e5a34826b6c9083d34656aaa27050635cb21
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200933
Reviewed-by: Srujan Gaddam <srujzs@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Riley Porter <rileyporter@google.com>
startup time
Change-Id: If0c792036ac377aa3d777f95816e9d1d548326b1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201167
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This is a reland of 5c9e37f03c
Following update of `DEPS` in `flutter/engine`:
https://github.com/flutter/engine/pull/26395
New commits include:
```
git log --format="%C(auto) %h %s" 00c00e8adf9706bebe8f94483b7663c5f36f59d2..def32ceb1d660552eaec24839d377199aea5a569
def32ceb Revert "Revert "Use the frontend server to compile pub executables (#2968)" (#3006)" (#3008)
0dc7e50c Make `.gitignore` and `.pubignore` case-insensitive on Windows / MacOS (#3009)
e89d4ab8 Generate GNU-style long file names in tar archives (#3005)
d2ad13d0 Revert "Use the frontend server to compile pub executables (#2968)" (#3006)
492b15ba New binstubs for global activate using `dart pub` (#3002)
e02f23bb fix grammer in .gitignore error message (#2995)
e01e3a41 Use the frontend server to compile pub executables (#2968)
647989c6 Use RetryClient from package:http/retry.dart (#2980)
```
Original change's description:
> Change-Id: I9a0b5fb2b5616a5a0eaa16f3a90205bb1bb1fc8f
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200878
> Auto-Submit: Jonas Jensen <jonasfj@google.com>
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>
Change-Id: I1a0570318c63ec97fd141d79b405f55105111077
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201260
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
I added one test for this case and several other tests for already
passing cases. I think that some of these cases were failing before the
switch away from using available suggestions for imported libraries and
was originally trying to write a test for a different reported problem,
but the test passed.
Change-Id: I989d8419506c59b883fe5b52168e15fd7d68787c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201300
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
This CL adds parser support for use of `<typeArguments>` as a
selector. This allows expressions like `List<int>` (type literal with
type arguments), `f<int>` (function tear-off with type arguments),
`C.m<int>` (static method tear-off with type arguments), `EXPR.m<int>`
(instance method tear-off with type arguments), and `EXPR<int>`
(tear-off of `.call` method with type arguments).
I will add parser support for `.new` as a constructor name in a
follow-up CL.
Change-Id: I157e732276421e8c3fd20c38c67ae9643993bd85
Bug: https://github.com/dart-lang/sdk/issues/46020, https://github.com/dart-lang/sdk/issues/46044.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197102
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
Only report an error here if the syntax _allows_ you to write type
arguments on metadata.
Also make nearby code more efficient by non-calculating some
variables if errorReporter == null.
Also add some tests with import prefixes.
Change-Id: I39fbe827b3062904f2eaf9b3fbc0119fa356126b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201225
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Avoid calling SetTypeTestingStub from PostLoad because it
uses write lock.
Saves ~10-15% on ReadProgramSnapshot on a large Flutter app.
Issue https://github.com/dart-lang/sdk/issues/46116
TEST=ci
Cq-Include-Trybots: luci.dart.try:vm-kernel-precomp-linux-release-x64-try,vm-kernel-precomp-linux-product-x64-try,vm-kernel-precomp-linux-debug-x64-try
Change-Id: If843828661e68f18df19824af204df326bf016a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201180
Auto-Submit: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Also update the comment since it used to be a negative test but is now
a positive test.
Change-Id: I8bc6fa9e112d2d84e61cd849f6f7cd37cebe9a47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201081
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Nearly-minimal changes to get to NNDB.
I'd like to remove Setlet, but we would need to assess the heap size
impact.
Change-Id: I9191579502e89f90673ad28a1363a208697d6219
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201120
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Currently external data is counted twice on the receiver size: once for
received transferable, second for newly created external typed data.
Ensure new space is collected when allocating external at the limit.
TEST=SendReceiveBytesTransferable with verbose-gc
Change-Id: I129d913f89e098b5d3066ce249ac0c4702e1394d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199842
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Many cases were already present in inconsistent_inheritence_test, but I added
more coverage. There were some test cases which were duplicate even just within
checked_test, and I deduplicated these as I copied into
inconsistent_inheritence_test.
Change-Id: I6d1059e714ab4606f7e17ccd3fd087ba638eb955
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201141
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Replaced uses with `const {}`.
Also removed unused function `modifiersToString`.
Change-Id: If59f88319e6a744d31814d8469be8faba9c3f2e4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201104
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
This should fix the navigation issue that was introduced after
switching to a more compact form of storing element models.
Change-Id: I1010be3595830713aab2ae5f35b5ce7bc8691734
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Each of these tests is covered in INVALID_ASSIGNMENT
or REDIRECT_GENERATIVE_TO_MISSING_CONSTRUCTOR tests.
Change-Id: Ia5ea128dad22b299e300fe94f9c082fd7cbf024d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201142
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
These test cases are mostly extracted from the bulk test cases in
check_tests, but I also added a new test case here and there.
Change-Id: I3c205903506d6194d258813a077ec3311c2f5189
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201105
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This saves ~5 minutes on Flutter Engine linux arm64 cross-builds.
Change-Id: I67d849422886101c217de7c2f21bc4eba4f6706a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201042
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
- Increase SDK requirements to allow Set literals
- Fix analyzer errors in test
TBR=fishythefish@google.com
Change-Id: I02fa18b6fc280cf74d6f7da7d2d24ff7dca806f6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/201082
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
