Brian Wilkerson
a6ad152315
Fix constant-related deprecation warnings in analyzer packages
...
Change-Id: I6e4186d2a877275db2f04881a6aa6d154d4f8693
Reviewed-on: https://dart-review.googlesource.com/55820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-05-17 21:24:38 +00:00
Danny Tuppeny
568e977a35
Update FoldingKinds enum, update specs and increase version number
...
Bug: https://github.com/dart-lang/sdk/issues/33033
Change-Id: Ieccfd90ead67a9803744c54db4eec8eea0b0403c
Reviewed-on: https://dart-review.googlesource.com/54920
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-05-14 16:48:48 +00:00
Konstantin Shcheglov
e3966fcfb9
Protocol for runtime completion.
...
This protocol will be used to support "Evaluate Expression" and "Watch"
window features in IDEs.
Change-Id: Ibde1e88507a66d8c487836a227dfeb13ffd77d9d
Reviewed-on: https://dart-review.googlesource.com/54629
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Jacob Richman <jacobr@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-05-11 22:23:42 +00:00
Konstantin Shcheglov
3d688deba7
Bump analysis server version to 1.20.2
...
Bug: https://github.com/dart-lang/sdk/issues/33034
Change-Id: I1dc4bfb97d2fae7a4c57baa056749fa520f7ea88
Reviewed-on: https://dart-review.googlesource.com/53684
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-05-03 20:02:53 +00:00
Danny Tuppeny
1855c6ef27
Increase analysis server version to 1.20.1
...
So clients can detect when the workaround for #29414 is not required.
Closes #32902
https://github.com/dart-lang/sdk/pull/32902
GitOrigin-RevId: e6476b24b905fa718f94516d8ca28dafdc5aa38b
Change-Id: I3aafb29ad5ad92962dfd79373842159deb5994b6
Reviewed-on: https://dart-review.googlesource.com/51400
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
2018-04-17 08:11:31 +00:00
Konstantin Shcheglov
6e25b9b2d3
Add flutter.getChangeAddForDesignTimeConstructor to API.
...
R=brianwilkerson@google.com
Change-Id: I91e40c447d32e603026de337ec2d36983174a8cd
Reviewed-on: https://dart-review.googlesource.com/49826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-06 02:40:00 +00:00
Konstantin Shcheglov
44dbba2b80
Use offset/length of the import prefix, or empty. Same for constructor names.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/32685
Change-Id: I40b7f9c679b04725db19dad661e3a88a4a982f1c
Reviewed-on: https://dart-review.googlesource.com/48682
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-28 18:19:09 +00:00
Brian Wilkerson
d3295ded48
Remove the SORT_MEMBERS refactoring from the spec
...
Change-Id: Ic8b8135f22d8c3c07d4ded661ac43d2d5105dc3f
Reviewed-on: https://dart-review.googlesource.com/48464
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-27 16:37:44 +00:00
Konstantin Shcheglov
0f7622d945
Remove 'stateful' option from the 'Extract Widget' refactoring.
...
There is already a Quick Assist to convert StatelessWidget to StatefulWidget,
and duplicating implementation is not very nice.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Iacbe58c9d05359ec96a86affc774c83532f7456f
Reviewed-on: https://dart-review.googlesource.com/48451
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-26 22:18:42 +00:00
Konstantin Shcheglov
633b2ccb38
Add 'isWidgetClass' and 'stateClassName' to FlutterOutline.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Idf7a986a67321b3ed33bb5d3bd4c139fac995474
Reviewed-on: https://dart-review.googlesource.com/48260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-25 20:22:26 +00:00
Konstantin Shcheglov
6bd38cc912
Analysis Server API for 'Extract Widget' refactoring.
...
R=brianwilkerson@google.com
Change-Id: Ie6b7c349d304785ab6829770ebd3504c0affe8df
Reviewed-on: https://dart-review.googlesource.com/47943
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-22 20:25:29 +00:00
Konstantin Shcheglov
64e092d4a3
Add fields codeOffset/codeLength to FlutterOutline.
...
R=brianwilkerson@google.com
Change-Id: I917a780704882fcd7537a9334febc21098aabd4f
Reviewed-on: https://dart-review.googlesource.com/46579
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-15 21:01:14 +00:00
Konstantin Shcheglov
e1909cb52a
Update Outline protocol - change offset/length, add codeOffset/codeLength.
...
R=brianwilkerson@google.com
Change-Id: I4b5c03a21254f7c497adc4c043641b18599c5c39
Reviewed-on: https://dart-review.googlesource.com/45764
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-09 01:52:57 +00:00
Brian Wilkerson
602a8c2a7b
Clean up usage of deprecated constants
...
Change-Id: I9005ba6e94529e15d8f7b21322591f4a9dabec47
Reviewed-on: https://dart-review.googlesource.com/45763
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-03-09 01:02:49 +00:00
Konstantin Shcheglov
eea08cfabe
Add optional 'file' for getElementDeclarations.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/32461
Change-Id: I0fa5ab2165e24f5b17ecc20ad8f97471389c8b8f
Reviewed-on: https://dart-review.googlesource.com/45761
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-08 19:10:47 +00:00
Konstantin Shcheglov
6189b9a360
Change Flutter Outline API to provide full instrumented code instead of edits.
...
This solves potential consistency problem between Analysis Server and IDE.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I1403af1c90d7fec2ff18ffdb862f2209b19e548e
Reviewed-on: https://dart-review.googlesource.com/45124
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-05 22:46:19 +00:00
Konstantin Shcheglov
3a5be046bb
Update FlutterOutline API to provide widgets instrumentation.
...
So, this is alternative approach - the plan is to instrument in Analysis
Server, then generate the entry point and instrumented code in Flutter
plugin, and run flutter_tester also from the plugin.
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I6b2bb0fea6494df6b9f6b3e69e7548d03af7e94b
Reviewed-on: https://dart-review.googlesource.com/44382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-28 23:02:53 +00:00
Konstantin Shcheglov
75858ec680
Add optional 'parameters' field to ElementDeclaration.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6b8e4417e7a7bc32537fdcbaa8fd04caf18da052
Reviewed-on: https://dart-review.googlesource.com/43885
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-27 01:27:37 +00:00
Konstantin Shcheglov
586c183904
Add code range to ElementDeclaration.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: I6e7afe3b8ea8191d737c717b753d55d2a7945a81
Reviewed-on: https://dart-review.googlesource.com/43840
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-26 20:37:44 +00:00
Konstantin Shcheglov
c3330ba080
Add 'pattern' and 'maxResults' to getElementDeclarations() request.
...
R=brianwilkerson@google.com
Change-Id: I2094fa106cbdd7bc4eff9015d94b34517b3d50a5
Reviewed-on: https://dart-review.googlesource.com/42180
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-26 18:46:27 +00:00
Konstantin Shcheglov
9b71ba7f17
Copy 'className' field into the API structure.
...
R=brianwilkerson@google.com , devoncarew@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie95f4b59dfa15fc085694317883b0c2fd81c1fbb
Reviewed-on: https://dart-review.googlesource.com/43160
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-22 18:40:37 +00:00
Konstantin Shcheglov
8fa5567edb
API for search.getElementDeclarations.
...
The goal is to provide clients (specifically VS Code) with API that
is fast, and can search top-level and class member declarations.
I'm not sure whether we want ElementKind, it has kinds that we will
not use, e.g. I don't think we will return local variables or
parameters.
It would be probably still a lot of information, maybe we should use
single string table in response?
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/29510
Change-Id: Ie31bb398a08d462c1cb08c7d82c4443c0c09932a
Reviewed-on: https://dart-review.googlesource.com/42105
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-17 04:27:52 +00:00
pq
ad11e5d615
Re-generate Server APIs.
...
Previous change only updated the plugin; this catches up server.
Follow-up from: bea00e5bb3
Change-Id: Iae2ec340ffe528d76c53198322d691320f507852
Reviewed-on: https://dart-review.googlesource.com/40501
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-02-11 18:28:27 +00:00
Konstantin Shcheglov
ffd67154f7
Add a new optional field - 'id' to SourceChange.
...
R=brianwilkerson@google.com
Change-Id: Ibe85415be35982327593ffd1187ec74b1d037463
Reviewed-on: https://dart-review.googlesource.com/40102
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-02-08 20:13:11 +00:00
Danny Tuppeny
fd6b8f772b
Increase analysis server version to 1.18.5.
...
The version hasn't been increased since the server started accepting overlays for HTML files (for angular plugin) so this is to allow editors to know for sure that the server supports them.
Closes #32034
https://github.com/dart-lang/sdk/pull/32034
GitOrigin-RevId: 82bef7be897a2fe30e1a01724c5284d6615d9a4a
Change-Id: Id5e8a12cd9a895cd1122ddf764d93fd6f7459aed
Reviewed-on: https://dart-review.googlesource.com/38260
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-02-02 16:56:15 +00:00
Konstantin Shcheglov
8fbcf977e5
Replace license in generated files.
...
R=devoncarew@google.com
Change-Id: I7511c8da329eba760698a48abc0f8db16038b9ea
Reviewed-on: https://dart-review.googlesource.com/37127
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-01-27 03:18:18 +00:00
Konstantin Shcheglov
402af4db46
Add a new experimental 'flutter' domain and move FLUTTER_OUTLINE there.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I8f829f10a630e38c5a3f1638d077e37832a08daa
Reviewed-on: https://dart-review.googlesource.com/36320
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-01-23 00:57:55 +00:00
Konstantin Shcheglov
a971aa8472
Add basic Flutter outline subscription/notification to the protocol.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: I50d7e4507c58854b4f2afc6048285c68ee873b8b
Reviewed-on: https://dart-review.googlesource.com/36024
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-01-19 23:22:17 +00:00
Devon Carew
47a861ca85
Add two new element types to the protocol.
...
Bug:
Change-Id: I5a60081d7c8500590bbabb9ee6dce74fa611b0a3
Reviewed-on: https://dart-review.googlesource.com/14883
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-18 19:02:47 +00:00
Devon Carew
a5c2256455
Send test element kinds for test outline items.
...
Bug:
Change-Id: Iebea8d4b9705c726e297722ef1678e1a2cd1ea96
Reviewed-on: https://dart-review.googlesource.com/12841
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-10-11 17:00:41 +00:00
Konstantin Shcheglov
455984bbf9
Fix fuzzy arrow warnings in analyzer and analysis_server.
...
There is one warning which I'd like to fix in a separate CL.
The rest is because of package:test predicate().
I think Leaf fixed it in 3625f13698
R=brianwilkerson@google.com
Bug:
Change-Id: I060f7ced55dbcc460185916251c47ebbd5c838d3
Reviewed-on: https://dart-review.googlesource.com/3404
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2017-09-06 00:26:18 +00:00
Brian Wilkerson
37042bb59b
Add an integration test for kythe support with bug fixes
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3006693002 .
2017-08-28 10:07:04 -07:00
Konstantin Shcheglov
f78d43c3d3
Convert GeneratedContent to async and use AnalysisDriver for tasks graph.
...
R=brianwilkerson@google.com , paulberry@google.com
BUG=
Review-Url: https://codereview.chromium.org/3002293003 .
2017-08-26 07:51:34 -07:00
Brian Wilkerson
44b5341de8
Update edit.importElements response data to support part files
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3001723002 .
2017-08-15 08:51:51 -07:00
Devon Carew
70cea428f4
Support experimental annotations for the analysis server spec.
...
BUG=
R=brianwilkerson@google.com , brustkelli77@gmail.com
Review-Url: https://codereview.chromium.org/3002543002 .
2017-08-13 12:37:46 -07:00
Brian Wilkerson
e42abf621e
Update the version of the server API spec for analysis.closingLabels
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/3002513002 .
2017-08-12 14:44:41 -07:00
Brian Wilkerson
8c8969db4c
Forward Kythe requests to plugins and merge in the results
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/3000823002 .
2017-08-12 08:16:34 -07:00
Brian Wilkerson
579a032564
Add kythe support to plugins and format the spec files
...
R=jwren@google.com
Review-Url: https://codereview.chromium.org/2994103002 .
2017-08-10 11:24:40 -07:00
Jaime Wren
8a426f3d67
Initial experimental Kythe Dart Analysis Server protocol
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2995683002 .
2017-08-09 12:44:59 -07:00
Danny Tuppeny
c4420a8943
Add "closing labels" to API spec. ( #30332 )
...
* Add "closing labels" to API spec.
See #30285
* Re-generate spec after adding "closing labels".
See 30285
2017-08-08 11:54:37 -07:00
Brian Wilkerson
c618032a69
Remove the uri from the ImportedElements object in the experimental spec API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2991893002 .
2017-07-27 12:52:38 -07:00
Brian Wilkerson
a040de8c08
Update the version of the server API
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2985003002 .
2017-07-25 12:45:16 -07:00
Brian Wilkerson
fe445e079e
Add a generated file that was missed
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966223004 .
2017-07-06 09:55:29 -07:00
Brian Wilkerson
d9754a58e9
Initial implementation of copy/paste support
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972833002 .
2017-07-05 14:02:07 -07:00
Brian Wilkerson
a3406c38e2
Update server version after adding experimental API
...
R=devoncarew@google.com
Review-Url: https://codereview.chromium.org/2972673002 .
2017-07-04 16:14:57 -07:00
Brian Wilkerson
0ee29eadf1
Run the generator after updates to spec
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2972473002 .
2017-07-02 07:49:05 -07:00
Brian Wilkerson
d31ed8690e
Capture imports on copy; update imports on paste
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2939593002 .
2017-07-01 12:02:30 -07:00
Brian Wilkerson
6248df44a6
Add the tests of the spec generator to the unit tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2966623003 .
2017-06-30 10:08:51 -07:00
Brian Wilkerson
9ddb832e10
Generate constants in server as we do in plugin
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2960073002 .
2017-06-28 08:21:33 -07:00
Steve Messick
c26c2774ca
This defines some postfix completion templates for use in the IntelliJ editor.
...
R=brianwilkerson@google.com
To use it, you'll need a version of the Dart plugin with this PR patched in:
https://github.com/JetBrains/intellij-plugins/pull/534
Review-Url: https://codereview.chromium.org/2917943002 .
2017-06-26 09:53:02 -07:00