Commit graph

32260 commits

Author SHA1 Message Date
William Hesse 57765a8929 Ensure correct line endings for method_mirror_source tests.
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1218813002.
2015-06-29 13:43:57 +02:00
Johnni Winther 74d04a6a48 Compute constant constructors in resolution.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1218793002.
2015-06-29 12:56:06 +02:00
Stephan Herhut 3b34c17909 Avoid multiline string literal in svgelement test.
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1219673002.
2015-06-29 12:39:05 +02:00
Konstantin Shcheglov 9f00e05918 Remove REFERENCED_NAMES result for ResolveUnitReferencesTask.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1212113004.
2015-06-27 11:26:20 -07:00
Paul Berry 967d4b3820 Tighten up dependencies in the task model.
- ResolveLibraryTypeNamesTask doesn't need to depend on RESOLVED_UNIT3
  for all sources in the transitive closure of imports; it only needs
  RESOLVED_UNIT3 for the units constituting the current library.

- ResolveVariableReferencesTask doesn't need to depend on
  LIBRARY_ELEMENT6 for all libraries in the transitive closure of
  imports, because it only resolves references to locals and
  parameters, and they can only resolve to elements in the same
  compilation unit; the transitive closure is not needed until
  ResolveUnitReferencesTask.

- ResolveVariableReferencesTask doesn't need LIBRARY_ELEMENT6 of the
  current library, since it only needs the LibraryElement to
  initialize the scope chain; LIBRARY_ELEMENT1 is sufficient.

- ResolveVariableReferencesTask doesn't need RESOLVED_UNIT3 of the
  current library, since it only needs to ensure that the elements for
  locals and parameters have been built; RESOLVED_UNIT1 is sufficient.

This should help reduce the amount of analysis which has to be
performed before code completions can be produced.

R=scheglov@google.com

Review URL: https://codereview.chromium.org//1212503004.
2015-06-26 21:56:20 -07:00
Sigmund Cherem 76cb9faa27 Update some files from CRLF to LF
R=sra@google.com

Review URL: https://codereview.chromium.org//1214853002.
2015-06-26 16:55:46 -07:00
Regis Crelier 6a69915cf5 Remove workaround in gcd for even operands and provide permanent fix.
Relax minimum length calculation in _lShift and _lShiftDigits.

See details in https://codereview.chromium.org/1205363003/

R=srdjan@google.com

Review URL: https://codereview.chromium.org//1207403003.
2015-06-26 15:31:32 -07:00
Brian Wilkerson fd0a53b27c Remove last failing test and minor clean-up
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1215723004.
2015-06-26 15:03:57 -07:00
Ryan Macnak f84461ed48 Observatory improvements for exploring compiled code.
- Views for ObjectPool, Instructions, ICData.
 - Allow querying retained size of non-Instances.
 - References to non-Dart functions as links.
 - Find ic data array from a Function.
 - Fix NPE when current token position in a script inset cannot be mapped.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1212933003.
2015-06-26 14:29:49 -07:00
John McCutchan 29dcc3394f Fix expected function names in Profiler_ToggleRecordAllocation test
BUG=

Review URL: https://codereview.chromium.org//1220483002.
2015-06-26 13:15:50 -07:00
Brian Wilkerson f95fb0d0e4 Fix another new task model test
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1212973003.
2015-06-26 13:05:35 -07:00
Paul Berry db6c95502a Work around naming conflict in analyzer's Resource class.
Commit f8ce36df55 introduced an SDK
class called "Resource", causing warnings to appear in any files that
reference the analyzer class with the same name.  (Fortunately there
was no regression in functionality since the spec requires the name
conflict to be resolved in favor of the definition that is outside the
SDK).

As a short term workaround to avoid the warnings, we are explicitly
importing 'dart:core' and hiding the new Resource class.  In a future
CL, we plan to rework analyzer's Resource class in order to make some
changes necessary for ".packages" file support; when that happens we
will probably rename the class to avoid the name conflict.

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1215753003.
2015-06-26 13:00:44 -07:00
John McCutchan 48dfce84b1 Fix allocation stub switching
- When disabling the allocation stub for a class, patch the stub so that the next caller will regenerate the stub.
- Use allocation profiling to test that stub switching and regeneration works.

R=koda@google.com

Review URL: https://codereview.chromium.org//1215773002.
2015-06-26 12:35:54 -07:00
John McCutchan bb934552ea Extend allocation profile testing
- Add ProfileTrieWalker to help with testing.
- Extend allocation profile test to check for expected stack trace.
- Don't inline allocation of class when allocation tracing is enabled.

Dependency: https://codereview.chromium.org/1210333002/

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1210283003.
2015-06-26 12:22:08 -07:00
Brian Wilkerson 3b48abedfd AST changes necessary for generic method support
R=leafp@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org//1212683002.
2015-06-26 12:07:39 -07:00
Brian Wilkerson 86d0309c65 Remove incrementalAnalysisCache and fix more tests
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1219503003.
2015-06-26 10:54:44 -07:00
John McCutchan ac2a1ccc62 Make CPU profile models public and refactor model building code
- Most of the refactoring is just organization.
- The core data structures and algorithms are not changed in this CL.
- I tried to use the same code wherever I could (renaming aside).

R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1210333002.
2015-06-26 10:49:34 -07:00
Jacob Richman 7e9e4d89d3 Revert "Enhance dart:js interop in a backwards compatible manner."
This reverts commit ac32e37ab1300cb1ce1cd081f050ff1d04e54cbe.

BUG=

Review URL: https://codereview.chromium.org//1209093005.
2015-06-26 10:29:25 -07:00
Jacob Richman 3fdeb669ee Enhance dart:js interop in a backwards compatible manner. List objects can now be passed back and forth to Dartium without requiring jsify
BUG=
R=terry@google.com, vsm@google.com

Review URL: https://codereview.chromium.org//1194643002.
2015-06-26 10:06:45 -07:00
Ryan Macnak 0d70fd8d9f Don't normalize the LF test either (for Windows).
Review URL: https://codereview.chromium.org//1212933002.
2015-06-26 09:53:21 -07:00
Konstantin Shcheglov b2ef3f1934 Don't remove ResultData(s) for incrementally updated results.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1218503003.
2015-06-26 09:39:15 -07:00
Konstantin Shcheglov 4eda1a5240 Test for final top-level variables.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1204423002.
2015-06-26 09:35:35 -07:00
Stephen Adams 7d6051f21e Mark static function getters as used in codegen.
Move marking from SSA builder to codegen.  If the only a reference to (a closure over a) static or top level function is optimized away, it is no longer retained in the generated code.

R=ahe@google.com, sigmund@google.com

Committed: 4d784a7d01

Reverted.

Review URL: https://codereview.chromium.org//1211223002.
2015-06-26 08:36:15 -07:00
Brian Wilkerson c9069537d8 Get more tests passing using the new task model
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1211993003.
2015-06-26 07:43:27 -07:00
Johnni Winther 4dced50c38 Use a FunctionSignature in CallStructure.signatureApplies
BUG=
R=ajohnsen@google.com

Review URL: https://codereview.chromium.org//1213833002.
2015-06-26 14:53:02 +02:00
Stephan Herhut 225be75498 Fix some tests and exclude others from CRLF rewriting.
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1212823002.
2015-06-26 14:40:01 +02:00
Asger Feldthaus e7e3706c59 dart2js cps: Better fallthrough analysis and eliminate "return null".
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1203423003.
2015-06-26 14:14:12 +02:00
Stephan Herhut dc02e2064a Don't normalize the CR test either.
BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//1208183002.
2015-06-26 13:13:02 +02:00
Stephan Herhut b3730bc4eb dart2js: Fix encoding of field names in csp mode.
R=floitsch@google.com
BUG=

Review URL: https://codereview.chromium.org//1215613002.
2015-06-26 13:00:53 +02:00
Johnni Winther 02d52374d4 Implement SsaBuilder without the ResolvedVisitor.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1212433002.
2015-06-26 12:48:26 +02:00
Lasse R.H. Nielsen f8ce36df55 Add Resource class. Currently unimplemented.
R=herhut@google.com, iposva@google.com

Committed: 2890a7a2a9

Review URL: https://codereview.chromium.org//1181663002.
2015-06-26 11:42:02 +02:00
Lasse R.H. Nielsen 3a0edfba72 Add tests for gcd, modInverse and modPow that also run on dart2js.
R=regis@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//1205363003.
2015-06-26 11:05:11 +02:00
Stephen Adams c1df2abeb0 Revert "Mark static function getters as used in codegen."
BUG=

Review URL: https://codereview.chromium.org//1215513003.
2015-06-25 21:20:52 -07:00
Stephen Adams 4d784a7d01 Mark static function getters as used in codegen.
Move marking from SSA builder to codegen.  If the only a reference to (a closure over a) static or top level function is optimized away, it is no longer retained in the generated code.

R=sigmund@google.com

Review URL: https://codereview.chromium.org//1211223002.
2015-06-25 20:29:38 -07:00
John Messerly 646eeb7af1 fix NodeReplacer for AwaitExpression
similar fix to fa5b8ce456

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1216463002.
2015-06-25 15:00:17 -07:00
Ryan Macnak 69938db31a Include pattern and functions for RegExps over the service protocol.
Remove some quadratic behavior from processing/display of Code in Observatory, so we can actually look at 300k regexp instructions.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1208153002.
2015-06-25 12:56:59 -07:00
Srdjan Mitrovic 6e8f867fc1 Allow 'guess_other_cid' for noopt as we do not have any type feedback at all (still investigating range analysis crash when running with type feedback)
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org//1210213002.
2015-06-25 12:40:08 -07:00
Konstantin Shcheglov d0dcb514a4 Initial version of limiting invalidation.
Work in progress.
It's nor the most optimal, nor always correct.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1204373002.
2015-06-25 11:20:17 -07:00
Matthias Hausner 323a7bf7f6 Fix dart2js test expectations.
TBR=sra

BUG=

Review URL: https://codereview.chromium.org//1207303002.
2015-06-25 11:02:25 -07:00
John Messerly fa5b8ce456 fix NodeReplacer for YieldStatement
it was missing a return, so it always fell through to the visitNode error case

R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1213503002.
2015-06-25 10:59:20 -07:00
Matthias Hausner e5f339b861 Yield in non-generator function is compile-time error
BUG=23710
R=srdjan@google.com

Review URL: https://codereview.chromium.org//1204103002.
2015-06-25 10:40:25 -07:00
pq 09842b1508 Test cleanup.
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1212533002.
2015-06-25 10:06:42 -07:00
Kevin Moore 9b56fe8e39 CHANGELOG: 1.11 - add note on checked flag to Isolate.spawn
TBR

Review URL: https://codereview.chromium.org//1211923002.
2015-06-25 09:29:47 -07:00
Kevin Moore d436d579a6 CHANGELOG: add date to 1.11.0 release 2015-06-25 09:04:34 -07:00
Asger Feldthaus cf920ec66c dart2js cps: Fix codegen for foreign statements.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1203353003.
2015-06-25 16:07:56 +02:00
Dan Rubel a87e9386eb performance measurement: generate report
* track/correlate responses
* separate req/resp from notifications
* track/report completion notifications
* add min/max/unexpected to report

BUG=
R=scheglov@google.com

Review URL: https://codereview.chromium.org//1202843010.
2015-06-25 10:03:24 -04:00
Asger Feldthaus fceb7f00dc dart2js cps: Handle checks against mutable and extendable lists.
BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1206873003.
2015-06-25 15:03:00 +02:00
Stephan Herhut 6655883f88 dart2js: Exclude string interpolation tests from CRLF rewriting.
BUG=
TBR=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1206953003.
2015-06-25 14:27:10 +02:00
Stephan Herhut b1c1606e17 Enforce LF line endings in the git database.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1168393003.
2015-06-25 13:41:53 +02:00
Stephan Herhut fbbc4c08ed dart2js: Also use new abstract names in csp mode.
BUG=
R=sigurdm@google.com

Review URL: https://codereview.chromium.org//1207823005.
2015-06-25 12:54:38 +02:00