Terry Lucas
9f09ef0af3
- Fixed callback signatures with indexed_db open method to expose VersionChangeEvent and
...
Event type parameters instead of dynamic.
- Fixed missing interceptor in dart2js for MutationEvent (even though its deprecated
and should not be used). The MutationEvent is created when a node is deleted. Enabled
Dart MutationEvent class generation.
- Fixed/re-enabled all indexed_db tests to run and pass successfully.
Stephen please take a look - target in VersionChangeEvent is a final field, per your suggestion,
instead of a getter. The MutationEvent is returned in the browser and without the MutationEvent
Dart class the error:
Uncaught TypeError: t1.get$target is not a function
R=vsm@google.com ,gabrielchow@google.com,sra@google.com
Change-Id: Ic36aea8c33b4263a32ff9d047ba3e6b979e03b10
Reviewed-on: https://dart-review.googlesource.com/41569
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-02-23 14:29:45 +00:00
Terry Lucas
d7a8aa155f
Fixed a number of File API methods in DDC.
...
R=vsm@google.com
Change-Id: I77881201f1e89f731476655476eb865e10d581a1
Reviewed-on: https://dart-review.googlesource.com/38164
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2018-02-05 22:29:00 +00:00
Terry Lucas
0af98266ab
Revert "Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test."
...
This reverts commit 0c8294e4a0
.
Bug:
Change-Id: Idb35c64fd5365f2669e8aff45765fed74e0f0766
Reviewed-on: https://dart-review.googlesource.com/31440
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
2017-12-23 01:59:38 +00:00
Terry Lucas
0c8294e4a0
Updated PYTHON code to correctly generate web_sql and re-wrote/re-enabled async web_sql test.
...
R=alanknight@google.com ,vsm@google.com
Change-Id: I80e82f5aaa3c9748740031d8da139f79e2c0ab70
Reviewed-on: https://dart-review.googlesource.com/31080
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Alan Knight <alanknight@google.com>
2017-12-22 22:57:34 +00:00
Terry Lucas
b3a90540f1
Fix sound not playing in Dartium checked mode.
...
Checked mode failure with optional args and Promise missing convertNativePromiseToDartFuture calls.
Easiest solution is to emit proper code instead of re-plumbing the Dartium emitter for operations
with optional arguments that are Promises.
https://github.com/dart-lang/sdk/issues/29810
TBR=alanknight@google.com ,kevmoo@google.com
Review-Url: https://codereview.chromium.org/2940543002 .
2017-06-12 22:50:12 -07:00
Terry Lucas
20dc749844
Suppress Scale interface - unused.
...
TBR=alanknight@google.com
Review-Url: https://codereview.chromium.org/2901213006 .
2017-05-25 12:54:38 -07:00
Alan Knight
6f71f9c80b
Revert "[Experiment] Stop suppressing DragEvent"
...
This reverts commit fbbb974670
.
Also updates the cached_patches.dart file.
BUG=
R=terry@google.com
Review-Url: https://codereview.chromium.org/2907563003 .
2017-05-25 11:16:10 -07:00
Alan Knight
b4b02daade
Include DDC fixes to dart:html in the main version
...
BUG=
R=jacobr@google.com , vsm@google.com
Review-Url: https://codereview.chromium.org/2899173002 .
2017-05-24 12:49:13 -07:00
Alan Knight
fbbb974670
[Experiment] Stop suppressing DragEvent
...
BUG=
R=jacobr@google.com
Review-Url: https://codereview.chromium.org/2898673003 .
2017-05-22 14:10:05 -07:00
Terry Lucas
f27144d7b5
Roll 50: Updated for push to origin/master.
...
TBR=jacobr@google.com
Review-Url: https://codereview.chromium.org/2875773003 .
2017-05-10 18:16:51 -07:00
Jacob Richman
864b64fd5e
Strong html
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1894713002 .
2016-04-19 15:08:45 -07:00
Terry Lucas
74ddf84ffd
Remove MutationEvent bad entries in both removed list and renamed list
...
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1890983002 .
2016-04-14 13:49:42 -07:00
Alan Knight
1f9395fb30
Add back CssCharsetRule for Safari support
...
BUG=
Review URL: https://codereview.chromium.org/1777683002 .
2016-03-08 14:40:57 -08:00
Terry Lucas
d094857c12
Fixed createImageData and added RequestAnimationFrameCallback for compat
...
TBR=jacobr@google.com
Committed: b524161f8f
Review URL: https://codereview.chromium.org/1753813005 .
2016-03-02 13:23:22 -08:00
Terry Lucas
8cb5ef741f
Fix more things with webgl so it works
...
- dart.idl emitted currently supported operations in Chrome 45 so there were 9 duplicates.
- Support mapping a bunch of webgl types to Dart types.
TBR=jacobr@google.com ,alanknight@google.com
Committed: 3a6e6cafea
Review URL: https://codereview.chromium.org/1748383002 .
2016-03-01 03:34:19 -08:00
Terry Lucas
e4b800845b
Fixed more sdk/lib issues
...
- SpeechRecognition calling blink constructor needs name prefixed with WebKit
- Enumerator types as arguments must be String (all enums in IDL are string values).
- Removed methods in IDBStorage that caused overloaded operations.
TBR=alanknight@google.com , jacobr@google.com
Review URL: https://codereview.chromium.org/1744613003 .
2016-02-27 10:44:45 -08:00
alanknight@google.com
5d2f7f8ae8
Fix notification
...
BUG=
R=terry@google.com
Review URL: https://codereview.chromium.org//1002953005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44471 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-13 17:21:31 +00:00
terry@google.com
68c6b252e4
Fixed tests for DOMPoint support for dart2js.
...
TBR=asiva@google.com ,vsm@google.com
Review URL: https://codereview.chromium.org//968613002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44115 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-01 18:01:53 +00:00
rmacnak@google.com
de9ba250c5
Reapply "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."
...
Fix static warning in storage_quota_test.
Fix status of fontface_loaded_test.
R=leafp@google.com
Review URL: https://codereview.chromium.org//658903005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41210 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-20 18:27:03 +00:00
rmacnak@google.com
f310862906
Revert "Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises."
...
TBR=vsm@google.com
Review URL: https://codereview.chromium.org//661603003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41138 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 02:54:14 +00:00
rmacnak@google.com
5178314123
Stop suppressing generation of bindings with Promise. Add some tests for DOM APIs that answer promises.
...
R=vsm@google.com
Review URL: https://codereview.chromium.org//605853003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@41136 260f80e4-7a28-3924-810f-c04153c831b5
2014-10-16 01:17:45 +00:00
vsm@google.com
94095d64a2
Merge 38 changes to bleeding edge
...
TBR=terry@google.com ,leafp@google.com
BUG=
Review URL: https://codereview.chromium.org//605083004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40774 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-29 15:56:25 +00:00
vsm@google.com
1c4bb5f363
Revert "Chrome 38 script changes from integration branch"
...
This reverts commit r40567.
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//589253002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40570 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 21:11:34 +00:00
vsm@google.com
9e25106514
Chrome 38 script changes from integration branch
...
TBR=leafp@google.com
Review URL: https://codereview.chromium.org//593853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40567 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-22 20:45:57 +00:00
vsm@google.com
e379d380bc
Migrate to Chrome 37 IDL
...
This enables terry's new scripts with fixes from vsm and leafp (tested in the dartium_integration branch).
R=leafp@google.com
Review URL: https://codereview.chromium.org//569783002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40219 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-12 21:18:06 +00:00
terry@google.com
ddf659197c
Reviewers=vsm,leafp
...
Fixed emitting problems with default/optional.
R=leafp@google.com , vsm@google.com
Review URL: https://codereview.chromium.org//551713003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40054 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 20:59:03 +00:00
terry@google.com
ecceb75d35
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Committed: https://code.google.com/p/dart/source/detail?r=39948
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40026 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 13:18:24 +00:00
terry@google.com
ac72bce2f1
"Reverting 39948"
...
BUG=
Review URL: https://codereview.chromium.org//554853002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39999 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 20:58:19 +00:00
terry@google.com
cf0c6a3565
Begin hookup of Blink IDL parser for dart:* libraries.
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//444743002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39948 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-08 02:33:50 +00:00
efortuna@google.com
b8ab793a1b
Reapply 38999. Third time's the charm! The issue was supportsTransitions was a
...
static method,and with my change I was calling an instance method. I've tested
all of the other html tests (before I was just testing on Dartium).
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//445733003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39003 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 18:36:23 +00:00
efortuna@google.com
c8d48f89a9
t cl dcommi# Enter a description of the change.
...
"Reverting 38998"
TBR
BUG=
Review URL: https://codereview.chromium.org//449033004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38999 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:50:26 +00:00
efortuna@google.com
c7dd285314
Reapplication of revision 38996 (dart side edits to make CSS Properties
...
accessible with and without prefixes), with the addition of CSSPropertyNames.in
which will be deleted once https://codereview.chromium.org/444453006/
is committed.
BUG=
Review URL: https://codereview.chromium.org//452493004
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38998 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:21:06 +00:00
efortuna@google.com
ceea5ab278
"Reverting 38996"
...
TBR because we need CSSPropertyNames.in from DEPS
BUG=
Review URL: https://codereview.chromium.org//451563005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38997 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:12:12 +00:00
efortuna@google.com
19c379afd9
This is the dart side edits to make this happen.
...
Fix for https://code.google.com/p/dart/issues/detail?id=19932
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//442523003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38996 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-07 17:09:40 +00:00
vsm@google.com
3aff966aa6
Fix broken FileReader API in _blink_dartium
...
TBR=leafp@google.com ,terry@google.com
Review URL: https://codereview.chromium.org//444973002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38926 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-06 11:27:47 +00:00
asiva@google.com
3d7bf833c0
Change in preparation of fixing issue 19500.
...
The bindings code will be returning ByteBuffer in dartium so we account
for that in the FileReader return values.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//395913002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38342 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-17 19:40:21 +00:00
jacobr@google.com
dd3514bc67
Add back invalid natives that couldn't be removed due to analyzer warnings.
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//325923003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37146 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-09 23:19:41 +00:00
jacobr@google.com
c4e40bb34d
Native method name mismatch cleanups for Dartium 36 roll.
...
BUG=
R=efortuna@google.com , leafp@google.com
Review URL: https://codereview.chromium.org//321043003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37142 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-09 22:31:05 +00:00
jacobr@google.com
3a10438002
Support Dart debugger API directly
...
BUG=
R=leafp@google.com , rmacnak@google.com
Review URL: https://codereview.chromium.org//258503008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36965 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-04 01:14:01 +00:00
terry@google.com
999c9a32e5
Supress webkitBackingStorePixelRatio and expose custom backingStorePixelRatio getter that always returns 1.0
...
Review=jacobr@google.com
BUG=
R=jacobr@google.com
Review URL: https://codereview.chromium.org//302753005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36720 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-27 23:38:04 +00:00
vsm@google.com
593f3fddf5
Revert "Revert 2 CLs to get one last Dartium 34."
...
This reapplies Jacob's CLs for Dartium 35 / 1916.
For landing after:
https://codereview.chromium.org/298823004/
R=ricow@google.com
Review URL: https://codereview.chromium.org//294043009
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36419 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 11:13:35 +00:00
vsm@google.com
8c33955982
Revert 2 CLs to get one last Dartium 34.
...
I will re-apply these after the next trunk push.
Revert "patch from issue 294853002"
This reverts commit r36395.
Revert "Fix Path"
This reverts commit r36401.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org//295913006
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36409 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-21 07:20:42 +00:00
jacobr@google.com
19c563446e
patch from issue 294853002
...
BUG=
R=leafp@google.com
Review URL: https://codereview.chromium.org//294993002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36395 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 22:21:01 +00:00
leafp@google.com
80b15f468f
SDK rebuild
...
Eliminate unneeded custom from dart.idl
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//292963002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@36367 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-20 17:33:09 +00:00
leafp@google.com
d1f0594840
Initial overloading implementation in _blink
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//260893007
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@35662 260f80e4-7a28-3924-810f-c04153c831b5
2014-05-01 22:03:06 +00:00
vsm@google.com
1a9d688491
Re-enable a couple events
...
This is need to get https://chromiumcodereview.appspot.com/221233005/ to link.
R=jacobr@google.com
Review URL: https://codereview.chromium.org//213743010
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34609 260f80e4-7a28-3924-810f-c04153c831b5
2014-04-01 18:50:27 +00:00
jacobr@google.com
1ea29a21d7
Fixes for Chrome 34 merge
...
BUG=
R=vsm@google.com
Review URL: https://codereview.chromium.org//204033002
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@34069 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-18 22:08:44 +00:00
leafp@google.com
6370348c37
Script changes for ChangeXXX -> Change=XXX
...
Move CustomSetter to Custom=Setter in dart.idl
BUG=17248
R=vsm@google.com
Review URL: https://codereview.chromium.org//187693008
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33359 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-06 00:17:12 +00:00
vsm@google.com
ad353d440b
Fixes for 1750 roll
...
TBR=jacobr@google.com
Review URL: https://codereview.chromium.org//150783005
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32477 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-10 01:38:01 +00:00
vsm@google.com
eebdf4ccf9
Revert "Revert "Revert "Fix dart2js type warnings"""
...
Hitting layout test failures in Dartium now....
TBR=blois@google.com
BUG=
Review URL: https://codereview.chromium.org//134623003
git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31702 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-10 19:27:09 +00:00