Florian Loitsch
f8b7d8d752
Fix typo in stream.dart.
...
BUG= #25223
Review URL: https://codereview.chromium.org/1517843002 .
2015-12-10 23:10:03 +01:00
Sigmund Cherem
db4195c752
Fix #19137 : handle when regexp doesn't match in constructorNameFallback
...
R=sra@google.com
Review URL: https://codereview.chromium.org/1510763006 .
2015-12-10 12:28:12 -08:00
Lasse R.H. Nielsen
e038407e27
Simplify future-propagation for whenComplete.
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1510053004 .
2015-12-10 09:15:38 +01:00
Florian Loitsch
a57abe83e2
Fix typo in streams.
...
Fixes issue 25195
Review URL: https://codereview.chromium.org/1502183009 .
2015-12-10 04:24:42 +01:00
Florian Loitsch
1a3853b128
Improve comment in UnmodifiableListView.
...
The class already states that the source must have efficient-length, but
the constructor didn't reiterate this requirement.
R=lrn@google.com
Review URL: https://codereview.chromium.org/1510043002 .
2015-12-09 21:25:55 +01:00
Florian Loitsch
6c84c42e67
Add microsecond support to DateTime.
...
R=iposva@google.com , lrn@google.com
Review URL: https://codereview.chromium.org/1493033003 .
2015-12-09 00:46:46 +01:00
Stephen Adams
cfbf367eba
Break up JS expression for smaller code and deferred loads.
...
TBR=asgerf@google.com
Review URL: https://codereview.chromium.org/1508083003 .
2015-12-08 15:42:09 -08:00
Lasse R.H. Nielsen
6327b26652
Add warning on DateTime.difference that DST + local-time is dangerous.
...
Fixes issue #16527
BUG= http://dartbug.com/16527
R=eernst@google.com
Review URL: https://codereview.chromium.org/1508053002 .
2015-12-08 11:44:22 +01:00
Lasse R.H. Nielsen
674a2f6d90
Update List.sort documentation to state that it isn't stable.
...
Fixes issue #23976 .
BUG= http://dartbug.com/23976
R=eernst@google.com
Review URL: https://codereview.chromium.org/1512503002 .
2015-12-08 10:23:49 +01:00
Stephen Adams
052b12c014
Fix comment on int.toUnsigned()
...
TBR=floitsch@google.com
Review URL: https://codereview.chromium.org/1510573002 .
2015-12-07 10:02:10 -08:00
Sigurd Meldgaard
fc868df004
Move the Match
class from core/regex.dart to core/pattern.dart
...
Match is defined without depending Rexeg, but the String class depends
on it.
As these are both included as parts in core.dart this should have
no external visible impact.
BUG=
R=lrn@google.com
Review URL: https://codereview.chromium.org/1498963004 .
2015-12-04 13:19:52 +01:00
Florian Loitsch
88d064fe01
Simplify scheduleMicrotask.
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/1487313002 .
2015-12-04 09:48:54 +01:00
Alan Knight
160355de42
Add the right type conversions for various postMessage methods
...
BUG=
Review URL: https://codereview.chromium.org/1490763005 .
2015-12-01 10:48:19 -08:00
Florian Loitsch
74d2846cb5
Don't use ".catch" in dart2js generated code.
...
"catch" as a property name is legal in most VMs nowadays, but a few implementations still don't like it.
R=sra@google.com
Review URL: https://codereview.chromium.org/1490463003 .
2015-12-01 01:54:37 +01:00
Florian Loitsch
e9ce747dac
Run x64 dart2js version by default.
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1484803003 .
2015-12-01 00:50:53 +01:00
Stephen Adams
ceaa0bdcc4
Use proper type in _createElement_2
...
Without the annotation it is possible for a (small) program to tree-shake Element.
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1486803002 .
2015-11-30 15:10:54 -08:00
Stephen Adams
0b9cdccf1c
Tweak Document.createElement for better inlining
...
Single return statement lets the current optimizer inline the function.
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1488793002 .
2015-11-30 13:36:19 -08:00
Zachary Anderson
5ee95b085f
Move tar archive parsing to C++
...
This gives a 30+ms speedup to startup.
Also uses HashMap instead of Map for assets.
BUG=
R=iposva@google.com
Review URL: https://codereview.chromium.org/1474603003 .
2015-11-25 14:39:19 -08:00
John Messerly
49c24b83da
add generic method comments to a few SDK methods
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/1462743002 .
2015-11-24 09:20:49 -08:00
Lasse R.H. Nielsen
003d905bf5
Fix bad line endings after sorting show names.
...
Review URL: https://codereview.chromium.org/1475573002 .
2015-11-24 09:15:49 +01:00
Lasse R.H. Nielsen
027b8dca39
Add StackTrace.current getter.
...
R=floitsch@google.com , iposva@google.com , sra@google.com
Review URL: https://codereview.chromium.org/1448003002 .
2015-11-24 08:26:03 +01:00
Alan Knight
d2b1388ed1
Switch IDB Database.transaction to use a template to do the right type conversions
...
BUG=
Review URL: https://codereview.chromium.org/1473443003 .
2015-11-23 14:29:44 -08:00
Karl Klose
b0b841d976
corelib: Do not print value in ArgumentError.notNull
...
R=lrn@google.com
Review URL: https://codereview.chromium.org/1460903003 .
2015-11-23 12:25:58 +01:00
pq
9ae1265ff5
analyzer_cli
move to SDK.
...
Tracking bug: https://github.com/dart-lang/sdk/issues/24731
Note, dartium build changes are in a separate CL: https://codereview.chromium.org/1453413006/
Some tests had to be disabled for want of mockito in the SDK; tracking their reimplementation is here: https://github.com/dart-lang/sdk/issues/24994
BUG=24731
R=whesse@google.com
Review URL: https://codereview.chromium.org/1459683003 .
2015-11-19 14:52:54 -08:00
Lasse R.H. Nielsen
5363e5c945
Make dart2js code retain the original stack trace for uncaught async errors.
...
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1383213002 .
2015-11-17 15:17:04 +01:00
Stephen Adams
38f623164a
fix Utf8Decoder hook.
...
dart2js can infer a non-null String result type with this fix.
TBR=floitsch@google.com
Review URL: https://codereview.chromium.org/1449273002 .
2015-11-16 18:29:44 -08:00
Sam Rawlins
931ceef9b2
Fixing dart:html links _not_ found in docs.json
...
BUG= https://github.com/dart-lang/sdk/issues/23601
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1448963002 .
2015-11-16 10:18:23 -08:00
Sam Rawlins
974b461235
Update 145 DOM doc links to use proper Markdown; fix 56 broken links
...
BUG= https://github.com/dart-lang/sdk/issues/23601
Tested with dartdoc package at HEAD with new markdown package 0.9. Looks great.
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1440183003 .
2015-11-13 14:43:49 -05:00
Ryan Macnak
f3759dedd3
Report iOS as iOS rather than OS X.
...
R=iposva@google.com
Review URL: https://codereview.chromium.org/1417013011 .
2015-11-13 11:15:04 -08:00
Harry Terkelsen
56249f5b53
fix typo in Iterable.expand docs
...
BUG=
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1441823002 .
2015-11-13 10:56:46 -08:00
Alan Knight
d3abcbaae0
Make GlobalEventHandlers not inherit from EventTarget
...
BUG=
Committed: 4d2191990e
Review URL: https://codereview.chromium.org/1437033002 .
2015-11-13 10:19:23 -08:00
John McCutchan
5725b0a0a0
Fast path Dart Timeline events with no arguments to avoid calling JSON.encode
...
BUG=
R=zra@google.com
Review URL: https://codereview.chromium.org/1441683005 .
2015-11-13 07:47:22 -08:00
Lasse R.H. Nielsen
50aa43569d
Add "growable" parameter to List.filled constructor.
...
Fixes issue #24884
BUG= http://dartbug.com/24884
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1440663003 .
2015-11-13 09:30:46 +01:00
Stephen Adams
77483ae5d3
dart2js: Forbid # placeholders in JS function bodies.
...
This enforces one of the guidelines that is described in the documentation for 'JS' in js_runtime/lib/foreign_helper.dart
The JS code should be rewritten to explicitly capture the values in JS.
// Dart 'a' might change after it is closed over.
JS('', 'function(){return #;}', a);
-->
// Immediately bind Dart 'a' to JS 'a' and then close over JS 'a':
//
JS('', '(function(a){return function(){return a;};})(#)', a);
R=sigmund@google.com
Review URL: https://codereview.chromium.org/1436263002 .
2015-11-12 15:38:12 -08:00
Alan Knight
65dfa74dd4
Revert "Make GlobalEventHandlers not inherit from EventTarget"
...
This reverts commit 4d2191990e
.
BUG=
Review URL: https://codereview.chromium.org/1442463005 .
2015-11-12 15:29:46 -08:00
Alan Knight
4d2191990e
Make GlobalEventHandlers not inherit from EventTarget
...
BUG=
Review URL: https://codereview.chromium.org/1437033002 .
2015-11-12 13:35:30 -08:00
Sam Rawlins
0b2e8b4bb1
Fixing many link syntaxes in doc comments
...
BUG= https://github.com/dart-lang/sdk/issues/23601
R=kevmoo@google.com
Review URL: https://codereview.chromium.org/1401063004 .
2015-11-12 15:34:41 -05:00
Søren Gjesse
bcd7466b56
Ensure proper response to chrome client_max_window_bits request.
...
I undid the patch John McCutchan did to disable compression and compiled and verify that Chrome does not experience any issues with websocket compression negotiation and that compression is enabled.
Also tested with observatory on Firefox and Edge (IE) and both work with current configuration.
BUG=#24864
subject: Ensure proper response to chrome client_max_window_bits
R=sgjesse@google.com
Review URL: https://codereview.chromium.org/1437623002 .
2015-11-12 17:04:07 +01:00
Lasse R.H. Nielsen
ed0b187d58
Add data-URI support class to dart:core (next to Uri).
...
R=floitsch@google.com , fschneider@google.com
Committed: bbc66c2c41
Review URL: https://codereview.chromium.org/1381033002 .
2015-11-12 13:02:20 +01:00
Jacob Richman
761a8151ce
Should we really be calling the serialized script value logic when getting elements out of Lists returned by dartium? I sure hope not as that is blowing up some multiple dom isolate cases. If there are cases in the dom that require the serialized script value conversions for array elements we can add it in we just need to fix the code so we stop returning null when we shouldn't be.
...
BUG=
R=alanknight@google.com
Review URL: https://codereview.chromium.org/1421023005 .
2015-11-11 15:19:10 -08:00
John McCutchan
291befa1cd
Redo TimelineTask API
...
A TimelineTask represents an asynchronous track of operations on the timeline.
The old API allowed multiple isolates to emit events simultaneously on the same task or to start / finish events in any order. This isn't supported by our UI and probably many other tools that consume trace-event.
With this change, operations within a TimelineTask must complete in the reverse order of their start calls (aka a stack). You can pass a TimelineTask from one isolate to another but you must first complete all open operations before passing it.
Example:
var task = new TimelineTask();
task.start('Some phase');
await someFuture;
task.finish();
Also: Add support for instant events.
R=rmacnak@google.com
Review URL: https://codereview.chromium.org/1412183008 .
2015-11-11 10:59:38 -08:00
William Hesse
df5ef1b136
Revert "Add data-URI support class to dart:core (next to Uri)."
...
This reverts commit bbc66c2c41
.
BUG=
R=ricow@google.com
Review URL: https://codereview.chromium.org/1432203002 .
2015-11-11 11:42:04 +01:00
Lasse R.H. Nielsen
bbc66c2c41
Add data-URI support class to dart:core (next to Uri).
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1381033002 .
2015-11-11 10:27:08 +01:00
Søren Gjesse
95bb2159d9
Web Socket compression - take two
...
Resolve issues with typed data tests and compression.
Uses HeaderValues to parse permessage_deflate option.
Includes changes from https://codereview.chromium.org/1208473005/
BUG=https://github.com/dart-lang/sdk/issues/14441
R=sgjesse@google.com
Committed: 59bb84127b
Reverted: d1e01e205a
Additional fixes for failing tests.
Review URL: https://codereview.chromium.org/1390353005 .
2015-11-06 08:59:02 +01:00
Stephen Adams
b3a4cc337c
dart2js Uri patch: avoid unnecessary code-unit to String conversions
...
results in:
H.Primitives_stringFromCharCode(C.JSString_methods.codeUnitAt$1("0123456789ABCDEF", $byte & 15)
-->
"0123456789ABCDEF"[$byte & 15]
dart2js does not know how to do this yet.
R=lrn@google.com
Review URL: https://codereview.chromium.org/1420303011 .
2015-11-05 17:55:41 -08:00
Alan Knight
42b9d7b702
Serialize the data argument to History's state-related APIs.
...
BUG=
Review URL: https://codereview.chromium.org/1414903007 .
2015-11-05 16:23:44 -08:00
Terry Lucas
1492a5dedd
Return the real error during custom element created failure
...
TBR=alanknight@google.com
Review URL: https://codereview.chromium.org/1405963015 .
2015-11-05 13:49:47 -08:00
Kevin Moore
77d4faa6b9
update docs on noSuchMethod
...
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1412243011 .
2015-11-05 12:10:19 -08:00
Stephen Adams
7b48eb2b7f
dart2js cps_ir: propagate constant field values
...
The effect is to remove endianness logic in SHA1.
Mark some single-call methods as @NoInline()
R=asgerf@google.com
Review URL: https://codereview.chromium.org/1408193009 .
2015-11-05 10:40:12 -08:00
Stephen Adams
f7a39a6241
Side effect characterization of String.fromCharCode
...
This allows dart2js to determine 'Primitive_stringFromCharCode' is effect free.
BUG=
R=floitsch@google.com
Review URL: https://codereview.chromium.org/1420273011 .
2015-11-05 10:36:06 -08:00