Devon Carew
a0b335ac6c
Try no implicit casts in pkg/analyzer_cli.
...
Change-Id: Ied093d1d988e944b497121e654956e93e61ee52d
Reviewed-on: https://dart-review.googlesource.com/69002
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-08-08 22:14:12 +00:00
Konstantin Shcheglov
80e08e0913
Use 'useCFE' flag to turn on CFE in AnalysisDriver.
...
R=brianwilkerson@google.com
Change-Id: If0aa7d10bc46f1dd408d0be8128fc25538758359
Reviewed-on: https://dart-review.googlesource.com/68720
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-08-07 16:12:47 +00:00
Zach Anderson
2be2cf2061
Bump analyzer_cli protobuf dep
...
This is needed to convince pub to let Fuchisa have
a Dart 2 compliant version of protobuf.
Change-Id: Ie9f8460d231579c07735355262f16fb1dad9fef9
Reviewed-on: https://dart-review.googlesource.com/68100
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-08-02 15:53:05 +00:00
Devon Carew
89cfa2edd7
Update package:test_reflective_loader.
...
Change-Id: If23bb61ef03efe62282ba2e163d3a830d6e0bfad
Reviewed-on: https://dart-review.googlesource.com/67700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-01 00:20:45 +00:00
Devon Carew
6e322f794c
No longer run pub list-package-dirs from the analysis server.
...
Change-Id: Id02bdfc25cb8827873ff607f7c4d4a3401c9a199
Reviewed-on: https://dart-review.googlesource.com/67205
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-27 23:05:41 +00:00
Brian Wilkerson
34fea8710c
More cleanup related to strong mode, mostly in the SDK support
...
Change-Id: I1aa0f5169774d53d8ba0902df7880a6462a600bd
Reviewed-on: https://dart-review.googlesource.com/66941
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-07-26 16:33:11 +00:00
Konstantin Shcheglov
a456edcb8f
Remove analyzer Dart files from AnalysisDriver.
...
This caused language_2/malformed2_test being flaky.
R=brianwilkerson@google.com
Change-Id: I8bf813e3244e9a76ea2ff72cd9c10b9516596a79
Reviewed-on: https://dart-review.googlesource.com/65980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-07-20 18:47:25 +00:00
Jenny Messerly
3320d8f677
fix #31237 , missing return hint was missing for inferred returns
...
Change-Id: I3c8c59f31196b220aaa0421f8357a950ff16ba20
Reviewed-on: https://dart-review.googlesource.com/62727
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Jenny Messerly <jmesserly@google.com>
2018-07-19 00:19:24 +00:00
Paul Berry
863c79a5fa
Fix analyzer/FE integration of unresolved method invocations with no targets.
...
Change-Id: I0429801429082a39601f588308774aed1c26a240
Reviewed-on: https://dart-review.googlesource.com/65572
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-07-18 22:04:40 +00:00
Peter von der Ahé
64a1f8f69c
Prepare for upcoming void usage semantics
...
Change-Id: I30d92ffb88338036aebed4e6891ce8e5737bf81f
Reviewed-on: https://dart-review.googlesource.com/65322
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Peter von der Ahé <ahe@google.com>
2018-07-17 15:36:38 +00:00
Brian Wilkerson
ab1c1582b1
Remove deprecation hints in analyzer packages
...
Change-Id: I001e57239a87f2806be74052a5e7686245fea812
Reviewed-on: https://dart-review.googlesource.com/65000
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2018-07-17 15:22:07 +00:00
Brian Wilkerson
d5c7f5af88
Convert more Unspecified errors to concrete errors
...
Change-Id: Ia72c33e3258472aa8d17ff24c58c8cf63483b823
Reviewed-on: https://dart-review.googlesource.com/64803
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-07-13 22:55:22 +00:00
Kevin Moore
902b6db749
Mark analyzer_cli, analysis_server pubspecs as not-to-publish
...
Closes https://github.com/dart-lang/sdk/pull/33828
Change-Id: I3693f4b0315c4cb8f8d757dc53a9b49c0a38b0e0
Reviewed-on: https://dart-review.googlesource.com/64721
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-07-12 17:04:43 +00:00
Devon Carew
188ef5e3d5
Analyze all the pkg/ code on the bots.
...
Bug: https://github.com/dart-lang/sdk/issues/29318
Change-Id: Iccb16ddbccbb43fa7a12eb818c2dde3a75700b97
Reviewed-on: https://dart-review.googlesource.com/64663
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-07-12 16:35:03 +00:00
Devon Carew
3ad109038e
Fix a runtime type issue in the dartanalyzer cli.
...
Change-Id: I5457ac82bb836fe36b3e8765e9fde690e2b324a2
Reviewed-on: https://dart-review.googlesource.com/64648
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-11 22:57:03 +00:00
Devon Carew
96b840dcd2
Fix an npe in the analyzer cli when used with --no-hints.
...
Bug: https://github.com/dart-lang/sdk/issues/33821
Change-Id: I4fd08134a86ed3d6eb599bd17e5e4bfa19cc900d
Reviewed-on: https://dart-review.googlesource.com/64642
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-11 19:52:53 +00:00
Devon Carew
fbd9c4e7a6
Fix a build mode test breakage from a recent DEPS update.
...
Bug: https://github.com/dart-lang/sdk/issues/33814
Change-Id: Ibff9db2c71eb8aeb32c6da0f6b63f4ce44f5f12e
Reviewed-on: https://dart-review.googlesource.com/64600
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-11 18:12:44 +00:00
Devon Carew
2dd33c2a6c
Have the package:analyzer strong mode option hard coded to on. Delete several spec mode only tests.
...
Change-Id: I5dffec68d9845fe75936d55100c03306b6eda363
Reviewed-on: https://dart-review.googlesource.com/64060
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-07-10 05:30:10 +00:00
Devon Carew
d6cf9b471e
Deprecate and remove the implementation of an older flag.
...
Change-Id: I650f5c7cc14c53b1109b8555a7e68544266ad65a
Reviewed-on: https://dart-review.googlesource.com/63860
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-05 18:30:18 +00:00
Devon Carew
e8ff3d596f
Deprecate and ignore the --strong flag on dartanalyzer.
...
Change-Id: Icb5adae9a628b96394a4249d6326c24acc40a8fc
Reviewed-on: https://dart-review.googlesource.com/63700
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-07-05 06:20:48 +00:00
Devon Carew
11e001595a
Update analysis options files.
...
Change-Id: I06b659b5ee7105d3f11343259f787194f1d2bd79
Reviewed-on: https://dart-review.googlesource.com/63501
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-03 00:20:06 +00:00
Devon Carew
710530c640
Update deprecated uses of package:test's isInstanceOf.
...
Change-Id: I0789ad89f2a247a17c472d74ca16885c5b8b6d5c
Reviewed-on: https://dart-review.googlesource.com/63320
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-06-30 00:08:44 +00:00
Konstantin Shcheglov
cf4313c14e
Throw exception if CompilationMessage cannot be translated to a Analyzer ErrorCode.
...
Fixes some of the new failures in unit tests.
R=brianwilkerson@google.com , paulberry@google.com
Change-Id: I39d132fa6c71dd8e5a492ed8dbcbea4cb6c0dac6
Reviewed-on: https://dart-review.googlesource.com/62960
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-06-29 00:13:08 +00:00
Devon Carew
c19233dcce
Plumb in more of the analytics impl into the analysis server; allow clients to enble analytics.
...
Change-Id: Id546ce60e3ec49d37d6c5545f98a46bff009e6c1
Reviewed-on: https://dart-review.googlesource.com/62701
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-06-28 16:28:25 +00:00
Devon Carew
17b53a2835
Test out no_implicit_casts on the analyzer source base.
...
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-06-28 02:20:43 +00:00
Devon Carew
e132240c91
Re-enable some failing analyzer_cli --use-cfe tests.
...
Change-Id: I1085c0dd5d8e4fa818bf82b258a3639a1d196266
Reviewed-on: https://dart-review.googlesource.com/61903
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2018-06-23 01:17:05 +00:00
Paul Berry
591cf85c76
Re-enable the old analyzer/FE integration logic.
...
This gets the tests running again. I'll follow this up with CLs that
reshape the ResolutionStorer API to match the Factory API we're
building, and then after that we can transition the code over to
calling the Factory API directly.
Fixes #33504
Fixes #32258
Change-Id: I105841ed5b2ed1198ec5e3e7387f694c61d36ca7
Reviewed-on: https://dart-review.googlesource.com/61101
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Kevin Millikin <kmillikin@google.com>
2018-06-20 14:35:31 +00:00
Devon Carew
de5f9ea95f
Add --use-fasta-parser flags to dartanalyzer and the analysis server.
...
Change-Id: Id7272c0d86806f2cbdfc982ee90923b018e08866
Reviewed-on: https://dart-review.googlesource.com/60453
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Dan Rubel <danrubel@google.com>
2018-06-16 13:21:24 +00:00
Brian Wilkerson
f6d2c2378a
Add awaits in async methods to restore previous semantics
...
Change-Id: I7711cd878a31df0fb0c92572e2256c0a26923640
Reviewed-on: https://dart-review.googlesource.com/59480
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2018-06-08 19:58:07 +00:00
Konstantin Shcheglov
8e59876cca
Issue 33381. Make input paths in analyzer_cli absolute and normalized.
...
R=brianwilkerson@google.com
Bug: https://github.com/dart-lang/sdk/issues/33381
Change-Id: I27e710859fdf2ab8e9380b232739def5acdf561d
Reviewed-on: https://dart-review.googlesource.com/59101
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-06-07 18:48:18 +00:00
Konstantin Shcheglov
36e73371fb
Switch analyzer_cli to using AnalysisDriver only.
...
R=brianwilkerson@google.com , devoncarew@google.com
Change-Id: Ibb97bf4843636655e646ee994532ec7e74c43b62
Reviewed-on: https://dart-review.googlesource.com/58622
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-06-06 15:47:03 +00:00
Brian Wilkerson
a6ad152315
Fix constant-related deprecation warnings in analyzer packages
...
Change-Id: I6e4186d2a877275db2f04881a6aa6d154d4f8693
Reviewed-on: https://dart-review.googlesource.com/55820
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-05-17 21:24:38 +00:00
Janice Collins
1afe71c08a
Enable preview-dart-2 as default for analyzer.
...
Based on https://dart-review.googlesource.com/c/sdk/+/52340 , but adds
the necessary plumbing through the test system to pass through
negations to strong and preview-dart-2. Also adds support for those
negations to the analyzer.
Change-Id: I9793ff28bb593d25bbb0a2ed8736b5b53e0a62d8
Reviewed-on: https://dart-review.googlesource.com/52461
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-26 17:01:12 +00:00
Brian Wilkerson
7054d92a02
Remove some classes from the analyzer public API
...
Change-Id: Ic53a8426818b06f44c2876abd16c789589bf78b5
Reviewed-on: https://dart-review.googlesource.com/52421
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-04-24 15:28:15 +00:00
Brian Wilkerson
b936ffb329
Move several libraries out of the public API
...
Change-Id: I8259de00134310f25b1c6168940aea5190488999
Reviewed-on: https://dart-review.googlesource.com/51443
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-04-17 17:35:27 +00:00
Devon Carew
9968728df1
Remove package:cli_util deps from package:analyzer.
...
Change-Id: I6bda63e31b9a8eb3e7ede406bd7e3e5748130ff6
Reviewed-on: https://dart-review.googlesource.com/51362
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-04-16 20:26:08 +00:00
Brian Wilkerson
dd897d35a2
Move the task API out of the public API
...
Change-Id: I0fbafb4965ced89fb9a063edb773c3f1cb3a39fa
Reviewed-on: https://dart-review.googlesource.com/51242
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-04-16 18:18:08 +00:00
Brian Wilkerson
c214c43758
Make LineInfo a public class
...
Change-Id: I1bc7f5302797374609752ea5293b96c30719b41f
Reviewed-on: https://dart-review.googlesource.com/51101
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-04-13 16:23:47 +00:00
Brian Wilkerson
98671b2659
Make DeclaredVariables immutable
...
Change-Id: I3d0233cfb4002140af7cf0166cd98466d73d630c
Reviewed-on: https://dart-review.googlesource.com/50580
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-04-11 01:58:51 +00:00
Devon Carew
07a05906c5
Remove an unused flag from dartanalyzer.
...
Change-Id: I4250f4accd98fe83a81d9845f09653bf860024a7
Reviewed-on: https://dart-review.googlesource.com/49980
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2018-04-07 02:51:14 +00:00
Konstantin Shcheglov
d53291d156
Fix MockErrorCode after adding isUnresolvedIdentifier.
...
R=brianwilkerson@google.com
Change-Id: Ic8bb1bbc9ade3e895f59ece50f29c012a4d7284f
Reviewed-on: https://dart-review.googlesource.com/48801
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-29 21:58:09 +00:00
Brian Wilkerson
7470f410dd
Clean up documentation of command-line analyzer options
...
Change-Id: If37cfbd7f1187229ab90205e59a7eb60d3b884cf
Reviewed-on: https://dart-review.googlesource.com/48701
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-28 21:15:58 +00:00
Brian Wilkerson
71c782a104
One more change to get the analyzer_cli tests to all pass under preview-dart-2
...
Change-Id: I5913e5db484d6c285d4efd503200728c1166b787
Reviewed-on: https://dart-review.googlesource.com/48083
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 16:13:31 +00:00
Brian Wilkerson
bd6f28f4c7
Make analyzer_cli closer to Dart 2 clean
...
Change-Id: I2f9b9e5bf87b65e871699c16633b1bfcf7605de5
Reviewed-on: https://dart-review.googlesource.com/48061
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-23 13:14:07 +00:00
Brian Wilkerson
26c06cdd82
Clean up Dart 2 type issues related to YAML support
...
Change-Id: Ic29054afca9773286aa899eecede287f7ecbca9a
Reviewed-on: https://dart-review.googlesource.com/47680
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-22 17:06:40 +00:00
Konstantin Shcheglov
1d184ace7b
Fixes for packages:args deprecated uses.
...
Mostly addOption() -> addMultiOption().
Change-Id: Iab40059aab45a371e0def89fbdfcd08bd1487d47
Reviewed-on: https://dart-review.googlesource.com/47121
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2018-03-19 20:15:37 +00:00
Brian Wilkerson
7a607ab239
Convert analyzer_cli tests to pass under preview-dart-2
...
Change-Id: I763ddcb880db9d7afb633d145c3de70dfb96f7b9
Reviewed-on: https://dart-review.googlesource.com/46567
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-15 16:46:54 +00:00
Devon Carew
5bc6d66bd9
fix a few --preview-dart-2 issues
...
Change-Id: Ib4bd63b826d8957cdd2db97e1d5311f52bcdf921
Reviewed-on: https://dart-review.googlesource.com/46304
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-03-13 17:46:09 +00:00
Brian Wilkerson
ea94e65b43
Make preview-dart-2 imply strong-mode
...
Change-Id: Ifa230f9e64a538e222557ea471dc728ad3dd01d7
Reviewed-on: https://dart-review.googlesource.com/46300
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2018-03-13 17:15:39 +00:00
Devon Carew
80a571d546
Take the --preview-dart-2 defaults from the context and options classes, not the cli tool defaults.
...
Also, allow --no-preview-dart-2 from dartanalyzer.
Change-Id: Ic304a29e640bbddb50892c28712a131a2b306930
Reviewed-on: https://dart-review.googlesource.com/45881
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-03-09 22:30:24 +00:00