Visual Studio is at 2017 Update 9 now.
Change-Id: Id577de7bf08e8ebedffbeec4c467f78b0f76adcd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/108906
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Changes to the canonical are the addition of a comment header and path-setting lines:
```
chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
SRC_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, os.path.join(chrome_src, 'tools'))
```
TBR=aam@google.com
Change-Id: Ia79f6ba6cab1504c2e09370fccc03909862923ea
Reviewed-on: https://dart-review.googlesource.com/c/84630
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Changes to the canonical are only addition of a comment header and path-setting lines:
```
chrome_src = os.path.abspath(os.path.join(script_dir, os.pardir))
SRC_DIR = os.path.dirname(os.path.dirname(os.path.abspath(__file__)))
sys.path.insert(0, os.path.join(chrome_src, 'tools'))
```
Change-Id: I403c1d7dd56cc45fcddd93142e8929e8cd5ae75f
Reviewed-on: https://dart-review.googlesource.com/76705
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reland of https://dart-review.googlesource.com/#/c/sdk/+/8168/ following
fixes to bots.
This is mainly to support upcomping changes in BoringSSL, and to keep
our version of MSVC up-to-date with Chromium.
Change-Id: Ibe5dbd97e6750072ff648b3967ac8396ab81bf64
Reviewed-on: https://dart-review.googlesource.com/9001
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This reverts commit 51ee5ce40e.
Reason for revert: The windows vm-product builder is crashing on all tests after this commit. The MSVC 2017 compiler apparently builds a crashing executable for product mode. Failing build is at https://luci-milo.appspot.com/buildbot/client.dart/vm-win-product-x64-be/8697
Original change's description:
> Reland: [Windows] Update toolchain to MSVC 2017
>
> Reland of https://dart-review.googlesource.com/#/c/sdk/+/8168/ following
> fixes to bots.
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: I861ee4ab10513b93ea3fb1c357766e0f942afd10
> Reviewed-on: https://dart-review.googlesource.com/8730
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I465ad7586a76b27f6a9aa9431efbe0eb3d934b4e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8800
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This reverts commit 42d93ff083.
Reason for revert: The windows bots don't have the correct authorization file to download our internal copy of MSVC 2017.
Original change's description:
> [Windows] Update toolchain to MSVC 2017
>
> This is mainly to support upcomping changes in BoringSSL, and to keep
> our version of MSVC up-to-date with Chromium.
>
> Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
> Reviewed-on: https://dart-review.googlesource.com/8168
> Reviewed-by: William Hesse <whesse@google.com>
TBR=whesse@google.com,vegorov@google.com,zra@google.com,asiva@google.com
Change-Id: I89dd1c8250d997a01bbc8de1a13cd86d5342c316
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/8660
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
This is mainly to support upcomping changes in BoringSSL, and to keep
our version of MSVC up-to-date with Chromium.
Change-Id: Id6148b74a7e986147faf721b2923599f148b8b3a
Reviewed-on: https://dart-review.googlesource.com/8168
Reviewed-by: William Hesse <whesse@google.com>