Change-Id: I7bd4356556023ff4a56d876684ea63bad1917b07
Reviewed-on: https://dart-review.googlesource.com/8341
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Passing the type argument vector <int> in the 'none' configuration is not
correct, but this is not what this test is supposed to check.
Change-Id: I2afd2987e572a6b4340a7d70ee92878abc67055e
Reviewed-on: https://dart-review.googlesource.com/8729
Reviewed-by: Ben Konyi <bkonyi@google.com>
Restoring non_const_super_negative_test (which was outside the migrated block) to strong tests.
Bug:
Change-Id: I012d1fc6ce3b0aa3dc070894699bb9a3ed8ab8ac
Reviewed-on: https://dart-review.googlesource.com/8724
Reviewed-by: Phil Quitslund <pquitslund@google.com>
(Migration moved helper when it should have been copied.)
Bug:
Change-Id: I5bdb97ea2411b3882f4689e5b34316287eb5277c
Reviewed-on: https://dart-review.googlesource.com/8722
Reviewed-by: Ben Konyi <bkonyi@google.com>
This reverts commit 1ca12788c6.
Patchset 1 is the reverted CL, patchset 2 shows the changes.
Bug:
Change-Id: I4ffcb9ec20f2ac3c59d09adc3a6693f52c71601d
Reviewed-on: https://dart-review.googlesource.com/6360
Reviewed-by: Peter von der Ahé <ahe@google.com>
No major changes.
Bug:
Change-Id: I7092880088d0fd334d6d2b1f6d4f1dbc2cb03ed2
Reviewed-on: https://dart-review.googlesource.com/7487
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
To recover properly from the error, change lookup priority in the Diet Listener from setter, field/getter/method, constructor to setter, constructor, field/method/getter.
Closes https://github.com/dart-lang/sdk/issues/29944
Change-Id: I3648501880e4e2059c386aa0032d37d0470aab96
Reviewed-on: https://dart-review.googlesource.com/7712
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
When replacing 64bit signed operations with unsigned 32bit ones
IntegerInstructionSelector::Replace would simply copy 64bit operation's
range onto uint32 op. This however is only correct for positive range,
non-positive ranges must become [0, kMaxUint32].
Fixes https://github.com/dart-lang/sdk/issues/30853
Bug:
Change-Id: I896b7828c29fe8f04a844cfb984295cb47ddaaf2
Reviewed-on: https://dart-review.googlesource.com/8020
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Did not migrate null_bottom / null_is_bottom type tests. Modified
null_test to not run some mirrors related checks on platforms that don't
support mirrors.
Bug:
Change-Id: I7fce784f537cc298e2945a32073700083d9275f8
Reviewed-on: https://dart-review.googlesource.com/7848
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Quite a few changes were made to method_override* tests.
Bug:
Change-Id: I554c83ae766010b55f17a86caee9418d0c34cbe7
Reviewed-on: https://dart-review.googlesource.com/7683
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
This reverts commit ba09eb787c, which was
a revert of ca6bec3414.
New status lines have been added to tests/languge_2/language_2_dart.js.status.
Bug:
Change-Id: I9e5b344d67df1fb00d5a51078a3d2b6113223a3e
Reviewed-on: https://dart-review.googlesource.com/7800
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Change-Id: I903d3e5e59b9d836c7dbe23c5610286437731cb2
Reviewed-on: https://dart-review.googlesource.com/7500
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
- Put all $dart2js_with_kernel results in two sections.
- Moved these sections to the end so our scripts don't malfunction.
TBR=rnystrom@google.com
Change-Id: I0bedc1ce334a4ce30e3c976a3e880bd2022de865
Reviewed-on: https://dart-review.googlesource.com/7680
Reviewed-by: Stephen Adams <sra@google.com>
Bug:
Change-Id: I2544efc246ce285222aa569990f23106dcee4d09
Reviewed-on: https://dart-review.googlesource.com/7557
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
This moves Http code into dart:_http. dart:io then imports and
re-exports dart:_http. This is the first stage of moving
dart:_http into its own pub package.
This CL was reverted due to a failure in the Flutter engine build
which happened due to an incomplete change in gen_snapshot.cc, and to
update sdk/lib/libraries.yaml and sdk/lib/libraries.json
Change-Id: Ie90c77ef631aea7a163774b58e8ccbaf71a24d3c
Reviewed-on: https://dart-review.googlesource.com/7588
Reviewed-by: Zach Anderson <zra@google.com>
It seems to round differently than expected.
Change-Id: Ibec5842063bf5de02bd6b4b34da4f66d824e9b62
Reviewed-on: https://dart-review.googlesource.com/7620
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Minor changes to a couple of tests to make them strong-mode clean.
Bug:
Change-Id: Id0cac7a120dbdf940d101c3e5de8c206a0ad6342
Reviewed-on: https://dart-review.googlesource.com/4613
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
