We need this API to create a mock SDK in a way that makes
ProcessedOptions.validateOptions() to accept it - the SDK root
must exist.
Alternatively (or in addition to) we could make writeXYZ create parent
directories implicitly. So, to "create" a directory, you would need
to create a file in this directory.
R=ahe@google.com, paulberry@google.com, sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2994643002 .
This mainly splits along compiler lines, but uses runtime for a couple
of things -- VM and Flutter mainly.
I did most of the work automatically by hacking up the migration script
to re-migrate the existing file, but I also went through and manually
cleaned the result up as best I could.
R=bkonyi@google.com, jcollins@google.com
Review-Url: https://codereview.chromium.org/2993043002 .
This reverts commit bb6203dade and
adds changes FlushTLS.
Now, FlushTLS will fill the mutator thread's TLAB instead of
changing top_ in the Scavenger. This should prevent the assertion
(thread->end() == 0) || (thread->end() == top_)
in TryAllocateInTLAB in runtime/vm/scavenger.h due to a race on top_.
R=asiva@google.com, rmacnak@google.com, zra@google.com
Review-Url: https://codereview.chromium.org/2991343003 .
This is only moving status lines around to ensure we only have 2 sections for
$dart2js_with_kernel per file: minified and host-checked. Some entries are now
duplicated because we no longer have the $dart2js_with_kernel (non-checked)
section.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2993083002 .
For the migration script, I need a (less hacky) way of programmatically
modifying a status file. As a step along that path, I need the ability
to write a status file to disc given a StatusFile object.
With that, it was a small step to write a little "formatter" that turns
a status file into its canonical representation.
It removes unneeded parentheses in expressions, normalizes expectation
case, and normalizes whitespace. Seems useful.
R=whesse@google.com
Review-Url: https://codereview.chromium.org/2988383002 .
list_unmodifiable_test required some modifications so callbacks matched
the correct types. list_unmodifiable_test and list_test also needed to
be disabled on dartdevc due to some issue with List<int> not mapping to
JSArray.
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2992833002 .
duration2_test.dart converted to a static-only test and skipped where appropriate for non-strong. error_stack_trace_test converted to a multitest and error_stack_trace1_test modified to use more modern catch convention for stack traces.
R=bkonyi@google.com, rnystrom@google.com
Review-Url: https://codereview.chromium.org/2987793002 .
This was a hairy test block, please review carefully. Special circumstances:
file_resource_test.dart: deleted, depends on Resource class which was moved outside the SDK
from_environment_const_type_undefined_test.dart, from_environment_const_type_test: change to expect compile-time errors for all error cases.
Hacked up status files to enable non-strong/checked/non-checked modes to work in all cases.
format_exception_test.dart: corelib is newer, has updated tests
growable_list_test.dart: corelib is newer, with updated comments. Stripped runtime checking of checked mode. Also, this doesn't work, but should, with dartdevc, so added to exclusion list
hash_map2_test.dart: corelib_strong version seems to be newer, has VM option comments
BUG=
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2989643002 .
Summary:
Previously, the VM would crash when it encountered a ClosureCreation node
because it was not aware of the new type arguments field.
Now, it skips the type arguemnts field, which allows many tests to pass again,
even though it doesn't correct forward the type arguments at runtime.
Test Plan:
Removed expected failure lines for all the tests added in my prior
CL (introducing the new field).
BUG=
R=dmitryas@google.com, jensj@google.com
Reviewers: dmitryas@google.com
Review-Url: https://codereview.chromium.org/2987143002 .
