languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-05 18:22:09 +00:00
Code Issues Projects Releases Packages Wiki Activity
67137 commits 11 branches 6011 tags 1.4 GiB
Commit graph

67137 commits

This branch
This branch
All branches
Author SHA1 Message Date
Mike Fairhurst
328addd2cf Skip timing out mac+linux tests. 
This uses, temporarily, a hack to skip the tests. The `skip_` prefix is
not formally recognized, however, it causes it to not be registered as a
test.

After landing this, I will add a @skippedTest annotation to
test_reflective_loader and switch to that.

This doesn't fix the windows dartfix tests, which are structured differently.

Change-Id: Id1bc1dd801c3182381d2c769af52b26f1ea6fa12
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119203
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
Auto-Submit: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
 2019-09-30 15:58:53 +00:00
Konstantin Shcheglov
f135761537 Set the context type for inference after rewriting AST. 
Otherwise we create a new node during rewriting, and lose the context
type that was set for the old node.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: Ife792900696b44c92577d88e06fd40fa9cf97fe8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119260
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-30 15:44:36 +00:00
Danny Tuppeny
34bdcec877 Don't statically register for LSP document changes when dynamic registration is supported 
Change-Id: I672a3207ab0a0f869721f6cce81b2b81c97db4ea
Bug: https://github.com/dart-lang/sdk/issues/38490
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119333
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-09-30 14:51:36 +00:00
Konstantin Shcheglov
93902399dd Remove isAstBasedSummary, keep only 'true' branches in tests. 
R=brianwilkerson@google.com

Change-Id: Ie27d5569e526193feb07480d923ad355fcf72291
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119280
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-30 14:37:02 +00:00
Konstantin Shcheglov
963c338104 Don't use ResolverTestCase for two tests. 
R=brianwilkerson@google.com

Change-Id: I375dfe9d9227d9a0cca50ed9ed5938620f9cfc50
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-30 14:35:37 +00:00
Konstantin Shcheglov
3f65652ad0 Enable avoid_init_to_null. 
R=brianwilkerson@google.com

Change-Id: I983fdff71c47dbf2b271508955095a73cfbeee59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119380
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-30 14:26:06 +00:00
Konstantin Shcheglov
a006914279 Enable prefer_contains and no_duplicate_case_values. 
R=brianwilkerson@google.com

Change-Id: I2ad2754b587c00d40811f6e5710b30d9111b828a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119361
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-30 14:25:36 +00:00
Konstantin Shcheglov
d3e7adf548 Issue 38641. Fix linking metadata with unqualified references to static methods. 
This CL includes changes to ResolvedAstPrinter done in a previous CL.
But it also includes new changes, I'm sorry about this.
https://dart-review.googlesource.com/c/sdk/+/119260

R=brianwilkerson@google.com, paulberry@google.com

Bug: https://github.com/dart-lang/sdk/issues/38641
Change-Id: I05e9b0cf94a11aa8f18829bbecb25f0c930d00df
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119360
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-30 14:16:07 +00:00
Danny Tuppeny
82b25f9e47 Use server snapshot for LSP tests 
This matches the non-LSP tests and has a significant performance improvement.

Bug: https://github.com/dart-lang/sdk/issues/38548

Change-Id: I62772c8e8c1bbbec97406b7993844dd5b16c4350
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119330
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Danny Tuppeny <dantup@google.com>
 2019-09-30 13:49:59 +00:00
Aske Simon Christensen
0a5f736c68 [cfe] Fix missing comma between type parameters in function types 
Change-Id: I90f7d1665a93414ed89799b3f564fdb7d2114e20
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119324
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Auto-Submit: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 13:44:59 +00:00
Brian Wilkerson
343723cdff Support navigation targets in migration tooling 
Change-Id: I13ee9ae0d87272248b83c45ee775dd359d830850
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-30 13:38:09 +00:00
Johnni Winther
f1d6282fa3 [cfe] Report error on extension members that conflict with Object members 
Closes #38561

Change-Id: I9c26879662502e1f56203f87d1cd7a21036dcb2f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119325
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-30 13:21:49 +00:00
Dmitry Stefantsov
b682235c4c [cfe] Preserve the nullability of LHS of intersection types 
Change-Id: I2e91338d4172c1288ceb58c566d9d3e3e465a0b9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118985
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 12:53:19 +00:00
Dmitry Stefantsov
902a36e36f [cfe] Thread nullability of typedef types from source into Kernel 
Closes #38214, #38215.

Bug: http://dartbug.com/38214
Bug: http://dartbug.com/38215
Change-Id: I6f96668f3dc7b315b0848a8d8953783ceb5f1c47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119326
Commit-Queue: Dmitry Stefantsov <dmitryas@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 12:52:29 +00:00
Dmitry Stefantsov
b361639a74 [cfe] Account for nullability in type substitution on TypeBuilders 
Closes #37689.

Bug: http://dartbug.com/37689
Change-Id: Ifac30bede3dbec9008e31e5fc81014cc69069afc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119145
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 12:52:29 +00:00
Dmitry Stefantsov
7d75eb1fd9 [cfe] Account for nullability in type substitution on DartTypes 
Bug: http://dartbug.com/37689
Change-Id: I5c37f0e13da956285300288cffc58263e67ac302
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119140
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 12:52:29 +00:00
Alexander Thomas
e39a15b6d6 [release] Add 2.5.1 to CHANGELOG.md 
TBR=whesse@google.com

Change-Id: Id50b298857133c6b3b89626c8b84f1412c1940be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119329
Reviewed-by: Alexander Thomas <athom@google.com>
 2019-09-30 11:32:25 +00:00
Johnni Winther
d8c5daf17a Enable extension methods by default 
Change-Id: Ib70ac3a1dd4885ef95a9b5b001978ffbb46f6ad0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119327
Reviewed-by: Daco Harkes <dacoharkes@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-30 11:28:46 +00:00
Johnni Winther
e52542b421 [cfe] Handle generic return types 
Returns types on generic methods in generic extension that contained
type variables declared on the generic method were not substituted,
leaving these as unindexed type parameters during serialization.

Change-Id: I4f53005318ba2be014bfe6e92f4f6c93288f2a4f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118995
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
 2019-09-30 10:58:05 +00:00
Johnni Winther
dd028547ce [cfe] Support patching of extension methods 
Change-Id: I453e17e63f97a0ca2477371541c6a9602bee2404
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119322
Reviewed-by: Jens Johansen <jensj@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-30 09:51:31 +00:00
Clement Skau
bb600e99e2 [SDK] Make dart2native default output .exe, not .dart.exe. 
Bug: https://github.com/dart-lang/sdk/issues/38530
Change-Id: I485bfe52e82932f5e886e6b3aaee6f8b079ed91e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119146
Reviewed-by: Michael Thomsen <mit@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
 2019-09-30 09:13:22 +00:00
Aske Simon Christensen
8f24bd2901 [cfe] Remove or reformulate some bad tips and messages. 
Change-Id: I5f37da30370fb48a4417e2b0c990d9fc1c9713a7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118990
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 09:02:41 +00:00
Aske Simon Christensen
4b9557e5e3 [cfe] Check valid return type of local async functions. 
Fixes https://github.com/dart-lang/sdk/issues/37681

Change-Id: I24e53f92ab9c812591a1317673082c4a40c2d00b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119142
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
 2019-09-30 08:48:08 +00:00
Konstantin Shcheglov
942af5bd62 Resolve initializers of final class fields in classes with const constructors. 
ResolvedAstPrinter is used to print otherwise invisible properties of
AST nodes, such as elements and types. In this case - the static type
of the constant ListLiteral, that must get the static type, and this
type must be inherited from the context.

This solves (a surprisingly rare) breakage in google3 when I ran a
presubmit to enable stronger runtimeType constant checks using
TypeSystem.

R=brianwilkerson@google.com, paulberry@google.com

Change-Id: I9f50fb7edef344677e3b3b1ac27b136326cb2c40
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119240
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-29 16:08:04 +00:00
Paul Berry
200e5b668d Migration: extract decoratedClassHierarchy from EdgeBuilder. 
This will allow it to be re-used when we traverse input files for a
third time to generate modifications.

Change-Id: I0984484a90eb2ecb87f848ee70c03280ec69cecf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119124
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-29 12:36:47 +00:00
Konstantin Shcheglov
595022bdea Remove summary1, part 1. 
Change-Id: I557785ac13fa411280ce032324b0305bf25a0a6d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119170
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-28 14:30:05 +00:00
Konstantin Shcheglov
da75135c7d Revert "Revert "Issue 37608. Use instantiated FunctionType for tear-off(s)."" 
This reverts commit b31e71e990.

https://github.com/dart-lang/sdk/issues/38546 was fixed.
https://github.com/dart-lang/source_gen/pull/430 fixed source_gen.
source_gen rolled into google3.
So, I think it is safe to re-apply this change.

Change-Id: Ia40830b733fce2ba4473a847df1af3c30cf139a0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119182
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-28 14:24:45 +00:00
Paul Berry
caaa577b0c Migration: add support for user-definable operators on generic classes 
Change-Id: I2153c5ac3000c0617dfbe5654d57c3c21c74431d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119122
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-28 14:21:56 +00:00
Paul Berry
21ee71c3e5 Migration: favor explicit /*?*/ comments over hard edges. 
Change-Id: I9bc6dcb7a21af24e1a6ce6918f098c9686ab40c9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119121
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-28 12:51:15 +00:00
Paul Berry
e4d8ad5866 Flow analysis: remove add method. 
It is no longer necessary to explicitly "add" variables that are
subject to flow analysis.  Unrecognized variables are now treated
simply as uninitialized.  This simplifies analyzer error recovery by
ensuring that an attempt to use a variable before its declaration
doesn't lead to a crash.

Change-Id: I11e8afc3ffb93c864db4638a224ff782d11f5a6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119200
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-28 01:55:45 +00:00
Nicholas Shahan
b47c8f0d24 [dartdevc] Actually apply SDK patch files from fork in DDC modular test 
The previous fix didn't work correctly because the nnbd experiment flag can be
applied per test, not per run of the entire modular suite.

Change-Id: Iffeadb57afee51ceb35f9441751eaea17f8d8d91
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119185
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
 2019-09-28 00:23:41 +00:00
Liam Appelbe
6da8c39c5a [vm] Small WasmImports API change, and more WASM error tests 
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I3044d588398ccb19e3ebcebe6cd506b047a37857
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118601
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-09-27 23:36:11 +00:00
Mayank Patke
fca257f8ba [dart2js] New RTI: Don't assert that RTI objects have old structure. 
Change-Id: I580242dcc6d05e5e202b32c01350e605461c5568
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119177
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
 2019-09-27 23:15:21 +00:00
Kaushik Iska
b7019a0340 [fuchsia] Currently Flutter/Dart -> Fuchsia rolls are broken 
https://dart-review.googlesource.com/c/sdk/+/117620 missed updating
a few dependencies.

tqr/147436 is the failure situation.

Change-Id: I01f33b0fa6519e7d10a67b2af28a78ac534477a1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119178
Reviewed-by: Zach Anderson <zra@google.com>
Reviewed-by: Chinmay Garde <chinmaygarde@google.com>
Auto-Submit: Kaushik Iska <kaushikiska@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
 2019-09-27 23:14:51 +00:00
Sam Rawlins
56082c230e Add highlight.pack.js and highlight.js's androidstudio.css to nnbd i13n output 
Change-Id: Ica7975af64ca3ab8a8457eb19630032cb48d6a80
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119172
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-27 22:57:11 +00:00
Sam Rawlins
a1a9d02cfd Fix CSS regarding tooltip positions and sizing 
Change-Id: Iac99aa61d722f2132619be7aad23309833c93133
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119175
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-27 22:53:11 +00:00
Paul Berry
34899a8a56 Flow analysis: remove TypeOperations.isLocalVariable. 
The last use of it was removed in c73df64c94.

Change-Id: Iececde3309246bfb6f6106e6e6d62ac2b08f9376
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119163
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
 2019-09-27 22:09:01 +00:00
Liam Appelbe
d2a0900a50 Reland "[vm] Wasm function imports" 
This reverts commit a7cb8ee88b.

Reason for revert: Fixed the crash

Original change's description:
> Revert "[vm] Wasm function imports"
> 
> This reverts commit 7a24aec8f4.
> 
> Reason for revert: debug-mode gen_snapshot crashes on all programs
> 
> Original change's description:
> > [vm] Wasm function imports
> > 
> > Bug: https://github.com/dart-lang/sdk/issues/37882
> > Change-Id: Ia8aa9a87803d5e8b899ddab5479b8cd93e03fd71
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118204
> > Commit-Queue: Liam Appelbe <liama@google.com>
> > Reviewed-by: Ryan Macnak <rmacnak@google.com>
> > Reviewed-by: Alexander Markov <alexmarkov@google.com>
> 
> TBR=rmacnak@google.com,alexmarkov@google.com,liama@google.com
> 
> Change-Id: Ib5d348e25854af010b1d8a64a87406da443981df
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/37882
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119143
> Reviewed-by: Samir Jindel <sjindel@google.com>
> Commit-Queue: Samir Jindel <sjindel@google.com>

TBR=rmacnak@google.com,alexmarkov@google.com,sjindel@google.com,liama@google.com

Change-Id: I4fd073a087eae7bb95c75079446d9111e7bc8c40
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/37882
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119168
Reviewed-by: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
 2019-09-27 21:29:12 +00:00
Alexander Aprelev
34087a61ba [build] Remove dart_host_toolchain. 
Consensus seems to be that there should be different mechanism to support host-targeting-host vs host-targeting-target configuration: comparing toolchains names won't work for that.
Also, dart_host_toolchain was set up to be used by Fuchsia, but it is no longer being used.

Change-Id: Ic2e63d8cef00b18bf6866122199027459eaf32c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118910
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
 2019-09-27 21:14:11 +00:00
Liam Appelbe
4aa10d0aeb Skip all dart:wasm tests 
Bug: https://github.com/dart-lang/sdk/issues/37882
Change-Id: I8f6c3f9b8d69a43ef6382a3d07579ea14d335c35
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119173
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
 2019-09-27 21:12:32 +00:00
Paul Berry
ec2823d052 Make an interface type to represent promotable variables. 
And updade flow analysis clients to use this interface, so that we
have no risk of accidentally trying to promote things that shouldn't
be promotable.  (Previously we used VariableElement, which would have
allowed fields).

Fixes https://github.com/dart-lang/sdk/issues/38572.

Change-Id: I225d3adabea503ca7eb9042516cf95d5a257fec6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119162
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
 2019-09-27 20:54:00 +00:00
Brian Wilkerson
2c94bb9849 Fix some recently introduced bugs found by running over logging 
Change-Id: I1df5217bad7abd30dcb393fbda2aa63a31824993
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119171
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-27 20:39:41 +00:00
Chingjun Lau
e5661b469d Parse all startup arguments from a file param. 
Change-Id: I9aca910b170ceacf37844f6c962420675c366345
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119183
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
 2019-09-27 19:57:10 +00:00
Felicitas Hetzelt
d2897ff85f [vm/fuzzer] Catch oom error on last block 
Rationale:
VM might run out of memory when printing global vaiables at the last
step.
Change-Id: I4450e05d71218582003e8e3eb56be0e68cb39002
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119167
Reviewed-by: Aart Bik <ajcbik@google.com>
Commit-Queue: Felicitas Hetzelt <felih@google.com>
 2019-09-27 19:54:20 +00:00
Konstantin Shcheglov
9bf38afe9c Check that ClassElement is Object using the corresponding getter. 
Bug: https://github.com/dart-lang/sdk/issues/38589
Change-Id: I76c510bd212c48dbb3efc6b2ca2156d187937fa1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119181
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
 2019-09-27 18:31:25 +00:00
Johnni Winther
05fb7d80dc [cfe] Update test expectations in static_extension_internal_name_conflict_error_test 
Change-Id: Iab47b7aa3a493f5aeeed9c58c6b7067ebcdcf068
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119141
Reviewed-by: Aske Simon Christensen <askesc@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
 2019-09-27 18:30:24 +00:00
Sam Rawlins
7bf76c5925 Change i13n output files to live in a directory structure; fixes #38503 
Bug: https://github.com/dart-lang/sdk/issues/38503
Change-Id: I6838a9b07c6a4acdf49839a3992254ec3c9a1ffd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119120
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
 2019-09-27 18:26:56 +00:00
Konstantin Shcheglov
18f941d9e0 Fix for the ordering and caching issue for default types. 
TypeParameterElement caches its default type, as it gets it from the
resolved TypeParameter node. So, while DefaultTypesBuilder will get
to the node from which we got this default type, and will finish its
building from TypeBuilder to a normal DartType, it is too late. We
should make sure that we only cache already built types.

R=brianwilkerson@google.com

Bug: https://github.com/dart-lang/sdk/issues/38498
Change-Id: Ie3e3645efdf44a9e599655bec5a5e410c75c1a58
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119166
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
 2019-09-27 18:20:00 +00:00
Ben Konyi
394f57ed7f [ VM / Service ] Add --object-id-ring-size to unblock UX studies for memory profiling 
Rationale:
This flag is temporary and will be removed once UX studies are
completed in the next month or so. These studies are currently blocked
as DevTools has not yet migrated to use the new HeapSnapshot format and
will be unable to for at least a few weeks, and the current memory profiling
page is running into a significant number of sentinel IDs during long
sessions.

Removal is tracked here and is set for the first half of November: https://github.com/dart-lang/sdk/issues/38535

Change-Id: Ia8c1f9c65efd6690443ba9d4f41254e79091a16a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118471
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
 2019-09-27 18:18:51 +00:00
Samir Jindel
132bee48d0 Revert "Reland "[vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions."" 
This reverts commit 44da8af04f.

Reason for revert: SIMARM_X64 assembly generation is still broken.

You can see the new bot "vm-kernel-precomp-linux-debug-simarm_x64" for failing tests. Also https://github.com/dart-lang/sdk/issues/38617 and https://github.com/flutter/flutter/issues/41484.

Original change's description:
> Reland "[vm, compiler] Reduce alignment of Instructions and remove some debugging trap instructions."
> 
> Fix generating assembly from simarm_x64.
> 
> Bug: https://github.com/dart-lang/sdk/issues/37103
> Bug: https://github.com/dart-lang/sdk/issues/38452
> Change-Id: Ic3402beb0278dc483ba82874cb573ce26b8669b2
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118702
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Aart Bik <ajcbik@google.com>
> Reviewed-by: Liam Appelbe <liama@google.com>

TBR=aam@google.com,rmacnak@google.com,alexmarkov@google.com,ajcbik@google.com,liama@google.com

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/37103, https://github.com/dart-lang/sdk/issues/38452
Change-Id: If9fe95a04371d2960200ffc1f5e5c008298b9890
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119149
Reviewed-by: Samir Jindel <sjindel@google.com>
Commit-Queue: Samir Jindel <sjindel@google.com>
 2019-09-27 18:01:00 +00:00