Commit graph

18 commits

Author SHA1 Message Date
Johnni Winther 969c0de335 Avoid crash on EOF error in file with Windows line encoding
+ start using spans from CFE (now that they're available)

Change-Id: I4fe82070d32948a64fb0fab527bd4cc857eebeb4
Reviewed-on: https://dart-review.googlesource.com/49841
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-04-09 12:16:20 +00:00
Bob Nystrom ba84855c0a Migrate the lingering language_strong tests over to language_2.
Change-Id: I4d60b650a2146c1d9be0fd0c5f98eac85f9e2eb1
Reviewed-on: https://dart-review.googlesource.com/16333
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2017-10-27 23:44:08 +00:00
Jakob Roland Andersen 0a3ed33abd Reland "Migrate test batch 226 to Dart 2.0"
This is a reland of 77a7ca98a2
Original change's description:
> Migrate test batch 226 to Dart 2.0
> 
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
> 
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

Change-Id: I083c07c08333909aaf5bce763601445ff9f0413f
Reviewed-on: https://dart-review.googlesource.com/3920
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-08 09:28:18 +00:00
Jakob Roland Andersen b4835cce26 Revert "Migrate test batch 226 to Dart 2.0"
This reverts commit 77a7ca98a2.

Reason for revert: Migrated a test file that's still being used by the unmigrated tests.

Original change's description:
> Migrate test batch 226 to Dart 2.0
> 
> Specifically skipped formatting these files, since there are tests that depend
> on non-standard source formatting.
> 
> Bug:
> Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
> Reviewed-on: https://dart-review.googlesource.com/3440
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>

TBR=jakobr@google.com,lrn@google.com

Change-Id: If4d0b44f81cfadf290bf72b23765fa85a6580937
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/3900
Reviewed-by: Jakob Roland Andersen <jakobr@google.com>
2017-09-07 09:34:28 +00:00
Jakob Roland Andersen 77a7ca98a2 Migrate test batch 226 to Dart 2.0
Specifically skipped formatting these files, since there are tests that depend
on non-standard source formatting.

Bug:
Change-Id: I3058984458a9c63b239ed8714828ec42d33316c5
Reviewed-on: https://dart-review.googlesource.com/3440
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2017-09-07 09:15:44 +00:00
Florian Loitsch 051f0f1267 Added new entries to the .gitattributes file.
Also updated the tests so that we don't forget in the future.

Change-Id: I0a998af306a0b6fa54b3c86cf164fdfe1f76340d
Reviewed-on: https://dart-review.googlesource.com/3624
Reviewed-by: William Hesse <whesse@google.com>
2017-09-06 18:05:57 +00:00
Bob Nystrom d5acd26b1d Restore line endings of files that should be CRLF. 2016-12-09 11:09:55 -08:00
Zach Anderson eba3743adb Adjust line endings setting in .gitattributes
When checking out code on Windows, we have git set up to automagically
convert LF line-endings to CRLF line-endings. This confuses the canned
formatting presubmit check, which fails because the line endings are not
what it wants.

This CL turns off the automagic line-ending conversion for C/C++ source
files, so that clang-format doesn't get confused by them on Windows.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2490993002 .
2016-11-09 09:23:21 -08:00
John Messerly c1cde9600b use pkg/dev_compiler in the build 2016-08-31 18:05:17 -07:00
Ivan Posva 3a8c3ecf9e - Fix git files.
BUG=
R=asiva@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org//1340133006 .
2015-09-14 16:27:51 -07:00
Johnni Winther f49f00608f Add tests for problem with newline encoding in multiline strings.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//1252443002.
2015-07-22 13:10:13 +02:00
Stephen Adams 4f06486925 js_ast test is now line-ending agnostic
TBR=herhut@google.com

Review URL: https://codereview.chromium.org//1208993006.
2015-07-01 08:26:36 -07:00
William Hesse 57765a8929 Ensure correct line endings for method_mirror_source tests.
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1218813002.
2015-06-29 13:43:57 +02:00
Ryan Macnak 0d70fd8d9f Don't normalize the LF test either (for Windows).
Review URL: https://codereview.chromium.org//1212933002.
2015-06-26 09:53:21 -07:00
Stephan Herhut 225be75498 Fix some tests and exclude others from CRLF rewriting.
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1212823002.
2015-06-26 14:40:01 +02:00
Stephan Herhut dc02e2064a Don't normalize the CR test either.
BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//1208183002.
2015-06-26 13:13:02 +02:00
Stephan Herhut 6655883f88 dart2js: Exclude string interpolation tests from CRLF rewriting.
BUG=
TBR=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1206953003.
2015-06-25 14:27:10 +02:00
Stephan Herhut b1c1606e17 Enforce LF line endings in the git database.
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1168393003.
2015-06-25 13:41:53 +02:00