This version includes a fix for building with the iOS simulators.
Bug: https://github.com/dart-lang/sdk/issues/39611
Change-Id: I99532e891e57733fd04785c9c2b6e56285a2bb95
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138570
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Chinmay Garde <chinmaygarde@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2020-03-05 sgrekhov@unipro.ru Added tests for covariant late final variables
2020-03-05 irina.arkhipets@gmail.com Fixed Issue 535: assertions updated.
2020-03-05 sgrekhov@unipro.ru Fixes 536. Use correct Requirements value
2020-03-04 sgrekhov@unipro.ru Minor static errors tests changes
2020-03-04 sgrekhov@unipro.ru More static errors tests added
2020-03-03 irina.arkhipets@gmail.com Fixed Issue 534: new tests added.
2020-02-27 irina.arkhipets@gmail.com Fixed Issue 533: toF common function updated according to the Issue 40368 comments.
2020-02-26 irina.arkhipets@gmail.com Fixed Issue 531: type normalization is taken into account.
2020-02-26 sgrekhov@unipro.ru More static errors tests added
2020-02-25 sgrekhov@unipro.ru Fixes 521. Update Process tests to be able to work with NNBD and on all platforms
2020-02-25 sgrekhov@unipro.ru Static errors tests renamed and reordered according to the spec text
2020-02-25 sgrekhov@unipro.ru Fixes 532. FileSystemEvent.isDirectory is always false for delete events
2020-02-24 irina.arkhipets@gmail.com Fixed Issue 530: update overridings tests for generics - assigning to non-nullable variable corrected, nonfunction-type-aliases flag added.
2020-02-21 sgrekhov@unipro.ru More static errors tests added (classes and mixins with no generative constructor)
2020-02-20 sgrekhov@unipro.ru Static errors tests renamed and reordered according to the spec text
2020-02-20 irina.arkhipets@gmail.com Fixed Issue 530: update overridings tests for generics - assigning to non-nullable variable corrected, nonfunction-type-aliases flag added.
2020-02-19 sgrekhov@unipro.ru Negative static errors tests around late keyword fixed. Fixed expected error position and abstract classes added
2020-02-19 irina.arkhipets@gmail.com Fixed Issue 529: test call arguments changed.
2020-02-18 sgrekhov@unipro.ru Update static errors tests around late keyword according changed NNBD specification
2020-02-17 sgrekhov@unipro.ru Fixes 528. Process Never in a special way
2020-02-13 irina.arkhipets@gmail.com Fixed Issue 465: re-factoring: overriding tests mover to separate directory.
2020-02-12 sgrekhov@unipro.ru Fixes 527. Less specific type error detection
2020-02-12 sgrekhov@unipro.ru Fixes 522. Test rewritten
2020-02-12 sgrekhov@unipro.ru Fixes 523. Move tests that use mirrors to API tests.
2020-02-12 sgrekhov@unipro.ru Fixes 523. Move tests that use mirrors to API tests. Add metadata tests without mirrors
2020-02-11 irina.arkhipets@gmail.com Fixed Issue 519: it's possible to call generic function with default type parameter if it's Never.
2020-02-11 irina.arkhipets@gmail.com Fixed Issue 465: overriding tests updated according to the Issue 40454 evaluation.
2020-02-11 sgrekhov@unipro.ru Fixes 527. Make type error detection less specific
2020-02-11 sgrekhov@unipro.ru Fixes 525. Expect error not on 'switch' but on 'case'
2020-02-11 sgrekhov@unipro.ru Fixes 526. Remove tests for the statement deleted from spec
2020-02-11 sgrekhov@unipro.ru Issue numbers added to the tests
2020-02-10 irina.arkhipets@gmail.com Fixed Issue 465: test case table added.
2020-02-10 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-10 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-10 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-10 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-09 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-09 irina.arkhipets@gmail.com Fixed Issue 465: new tests added.
2020-02-07 irina.arkhipets@gmail.com Fixed Issue 465: check for status warning added.
2020-02-07 irina.arkhipets@gmail.com Fixed Issue 465: test corrected, @Issue tag for the SDK bug 40514 added.
2020-02-07 irina.arkhipets@gmail.com Fixed Issue 465: type corrected.
New failures will be triaged on:
https://github.com/dart-lang/co19/issues/537
Change-Id: Iaf03662b8595927c0bb8589804d0a0e30cd600cb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138289
Reviewed-by: Karl Klose <karlklose@google.com>
This reverts commit b2b7337ad4.
Reason for revert: flutter build broke!!
Original change's description:
> [dart:io] Stop forcing lower case on HttpHeaders
>
> This is a breaking change. Request: https://github.com/dart-lang/sdk/issues/33501
>
> HttpHeaders use lowercase by default for all headers, since it is supposed to be case insensitive. Some servers incorrectly treat case as significant, however, and expect headers with capitalization or in uppercase. The current implementation forces headers to be lower cases when adding values. Users cannot even manually modify the headers.
>
> This change removes this restriction here so that users can modify the headers to whatever form they want. The new behavior is backwards compatible except if class was implemented. All headers inside http.dart are written as lower cases, adding values to HttpHeaders is still receiving lower cases input.
>
> The other cl (https://dart-review.googlesource.com/c/http_multi_server/+/121411) migrates multi_headers.dart to be compatible with this change.
>
> Bug: https://github.com/dart-lang/sdk/issues/33501
> Change-Id: I6f7f2ef907b229773c283140c07f2de4cd500981
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119100
> Commit-Queue: Zichang Guo <zichangguo@google.com>
> Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
TBR=whesse@google.com,sortie@google.com,lrn@google.com,zichangguo@google.com
Change-Id: I4d4299393ad6549b250053df8823e726855e2baf
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: https://github.com/dart-lang/sdk/issues/33501
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134102
Reviewed-by: Zichang Guo <zichangguo@google.com>
Commit-Queue: Zichang Guo <zichangguo@google.com>
This is a breaking change. Request: https://github.com/dart-lang/sdk/issues/33501
HttpHeaders use lowercase by default for all headers, since it is supposed to be case insensitive. Some servers incorrectly treat case as significant, however, and expect headers with capitalization or in uppercase. The current implementation forces headers to be lower cases when adding values. Users cannot even manually modify the headers.
This change removes this restriction here so that users can modify the headers to whatever form they want. The new behavior is backwards compatible except if class was implemented. All headers inside http.dart are written as lower cases, adding values to HttpHeaders is still receiving lower cases input.
The other cl (https://dart-review.googlesource.com/c/http_multi_server/+/121411) migrates multi_headers.dart to be compatible with this change.
Bug: https://github.com/dart-lang/sdk/issues/33501
Change-Id: I6f7f2ef907b229773c283140c07f2de4cd500981
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/119100
Commit-Queue: Zichang Guo <zichangguo@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
New commits included in this revision:
```
$ git log --pretty=oneline 4d8ecbd409d773fec47da33b7e6c8db0b51487fd..429a06039d185149f387a65e3503b0693ce6d24e
429a06039d185149f387a65e3503b0693ce6d24e (HEAD -> master, origin/master, origin/HEAD) Parallel fetching of available versions (#2280)
6705b085b9bf4754a4c8002a070f436f115dc4d1 Retry on all SocketExceptions (#2254)
a1820273b9f3c7bb5a13d26cd14d30d5bab187ae Use a unqiue file name for the snapshot during testing. (#2303)
72686563e767f8a359e48a267a2c323953a6a0ef Include osx and windows testing on Travis (#2299)
a7a66821d13920b9b22cc394dfa55c679e971e40 Fail travis for lints and warnings (#2301)
25aa24c023453f064dad8f3cce1bbd55269d0efa Omit languageVersion when there is no SDK constraint (#2300)
82e60a3dcb3afe753563e7d304827fb650bc4833 Use LOCALAPPDATA for system cache on windows (#2297)
ceaa86f2c7eb35f044b4c202268a17361de68d13 Enforce and fix lints from package:pedantic (#2291)
6ce1606564352c305bd0f6d97704f0f7f6ebbca0 Use more collection literals for args (#2293)
be245e6baeebb71aaf3b3a260fcfbbb011a9a7e0 Rename some test utilities from Mock to Fake (#2294)
f7638ce85298df7d9e73d717dd4d81f499681720 Refactor Set.add following !Set.contains (#2295)
390022b24bc076cb934385936ac7904f045a75ba Filter out `null` from `getCachedPackages`. (#2292)
0eea0c4421ed0b83c8597b62dacf68b93de172b9 Fix existing hints and lints (#2290)
7cf2fe860a40517ccb65f5efdda9e4dc350142c3 promote strict deps failures to errors from warnings (#2289)
```
Change-Id: I62782b29e16092114940df00811bfdd20c8045fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/131839
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
UPDATE (1/3): blocked on a new analyzer roll (details: https://github.com/dart-lang/linter/issues/1927)
UPDATE (1/8): updated to 0.1.108
Change-Id: I4fc825c5019fee05b4d9e1ec38bd50f9044f42dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/130081
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: David Morgan <davidmorgan@google.com>
2019-12-18 sgrekhov@unipro.ru Fixes 508. Relative import in multitests fixed
2019-12-13 sgrekhov@unipro.ru Increasing List length tests added
2019-12-13 sgrekhov@unipro.ru 491. Generic function type null-check operator tests fixed
2019-12-12 sgrekhov@unipro.ru Analyzer error in Expect library fixed
2019-12-12 sgrekhov@unipro.ru 491. Null-check operator tests improved and new ones added
2019-12-11 sgrekhov@unipro.ru 491. Null-check operator tests improved and new ones added
2019-12-11 sgrekhov@unipro.ru Tests for calling of 'call()' method via 'this()' and 'super()' added
2019-12-09 sgrekhov@unipro.ru 491. Static errors tests extended according to the updated specification
2019-12-09 irina.arkhipets@gmail.com Fixed Issue 465: tests for overriding with NNBD re-named and corrected. New tests added.
2019-12-08 irina.arkhipets@gmail.com Fixed Issue 465: tests for overriding with NNBD re-named and corrected. New tests added.
2019-12-06 irina.arkhipets@gmail.com Fixed Issue 465: tests for overriding with NNBD re-named and corrected.
2019-12-06 irina.arkhipets@gmail.com Fixed Issue 507: needless compile-error expectation removed.
2019-12-06 irina.arkhipets@gmail.com Fixed Issue 506: test expected result corrected.
2019-12-06 irina.arkhipets@gmail.com Fixed Issue 505: --enable-experiment=nonfunction-type-aliases option added.
2019-12-06 irina.arkhipets@gmail.com Fixed Issue 465: tests for NNBD (Overriding Section) corrected, new tests added.
2019-12-05 sgrekhov@unipro.ru 491. Static errors tests extended according to the updated specification
2019-12-04 sgrekhov@unipro.ru 491. Static errors tests extended to check all possible nullable/non-nullable types
2019-12-03 sgrekhov@unipro.ru Fixes 504. Fix typos in the tests
2019-12-02 irina.arkhipets@gmail.com Get rid of useless references to the issue 34950 which is fixed now.
2019-12-02 irina.arkhipets@gmail.com Fixed Issue 498: compile error diagnostic improved.
2019-12-02 irina.arkhipets@gmail.com Fixed Issue 498: get rid of self-references in non-function type aliases tests.
2019-11-28 sgrekhov@unipro.ru 491. Static errors tests extended to check all possible nullable types
2019-11-27 sgrekhov@unipro.ru Required keyword tests improved
2019-11-26 sgrekhov@unipro.ru Fixes 503. Allow multiple return statements of different kind
2019-11-26 sgrekhov@unipro.ru 491. Static errors tests extended to check all possible nullable types
Change-Id: Icbf4057fa6ee8def864069200dd199712cb22bce
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128729
Reviewed-by: Jonas Termansen <sortie@google.com>
This includes the single commit:
```
4d8ecbd409d773fec47da33b7e6c8db0b51487fd Don't precompile on pub get/upgrade by default (#2277)
```
Change-Id: I1e72498487858cfc61f3af03e2eeb3397499d246
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/128070
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Also change the script to use gsutil.py, which is usually in the path
because it's in depot tools.
Closes#39672
Change-Id: If434b4ebc4c0cb6054f6eb6d15f85a221a9ab1e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127894
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
This reverts commit 63333deed6.
Reason for revert: Causes failures on Flutter HHH CI in the "flutter test hostonly_devicelab_tests" step due to kernel binary format version mismatch.
Original change's description:
> [vm/cfe] Elaborate for-in statements during async transform
>
> This allows us TFA to analyze the iterator calls and we generate much tighter
> code in AOT.
>
> However, due to the increased inlining opportunities, we end up emitting 0.5%
> more code. Inlining of the _GrowableList iterator specifically also includes the
> concurrent modification check and error handling.
>
> Calls to get:iterator, moveNext and get:current account for 7.12% of all InstanceCall
> instructions in Flutter Gallery.
>
> Fixes https://github.com/dart-lang/sdk/issues/39516
> Issue https://github.com/dart-lang/sdk/issues/39566
> Issue https://github.com/dart-lang/sdk/issues/39565
>
> Change-Id: I8dcc08b7571137e869a16ceea8cc73539eb02a5a
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126381
> Commit-Queue: Samir Jindel <sjindel@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
TBR=kustermann@google.com,sjindel@google.com,johnniwinther@google.com
# Not skipping CQ checks because original CL landed > 1 day ago.
Change-Id: I89b88c3d9f7c743fc340ee73a45c3f57059bcf30
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126734
Reviewed-by: Clement Skau <cskau@google.com>
Reviewed-by: Teagan Strickland <sstrickl@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
This includes only commit
ff5ad1eab1649a8eee6cc593302d3624d9853049
'Warn in Flutter plugin validator with implicit flutter
sdk dependency'.
Bug: https://github.com/dart-lang/pub/issues/2264
Change-Id: I8d7c9e95d0c1121917a55e4d85c665c09dda8524
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127000
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
This allows us TFA to analyze the iterator calls and we generate much tighter
code in AOT.
However, due to the increased inlining opportunities, we end up emitting 0.5%
more code. Inlining of the _GrowableList iterator specifically also includes the
concurrent modification check and error handling.
Calls to get:iterator, moveNext and get:current account for 7.12% of all InstanceCall
instructions in Flutter Gallery.
Fixes https://github.com/dart-lang/sdk/issues/39516
Issue https://github.com/dart-lang/sdk/issues/39566
Issue https://github.com/dart-lang/sdk/issues/39565
Change-Id: I8dcc08b7571137e869a16ceea8cc73539eb02a5a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126381
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
