Commit graph

574 commits

Author SHA1 Message Date
pq 5dfe3c8f94 bump to linter 0.1.69
* improved message display for `await_only_futures`
* performance improvements for `null_closures`
* new lint: `avoid_returning_null_for_void`

Change-Id: Ib00f88cc93e1b81fd6d87880edfc1440233c1538
Reviewed-on: https://dart-review.googlesource.com/c/80507
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-10-17 22:26:47 +00:00
pq 4506e1d179 add linter changes (#34817)
fixes: #34817

Change-Id: I3c174cdd1fb438f6885704b022809356ccf22b49
Reviewed-on: https://dart-review.googlesource.com/c/80500
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-17 17:41:26 +00:00
Sam Rawlins 56306b90ee Fix html changes markdown syntax:
Bug: https://github.com/dart-lang/sdk/issues/34815
Change-Id: I73aa8ee54bcc48ca76f8744316c9d2e38b108239
Reviewed-on: https://dart-review.googlesource.com/c/80268
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Terry Lucas <terry@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-10-16 17:48:22 +00:00
Terry Lucas 490421d166 Fixed Service Workers and any Promise/Future API with a Dictionary parameter.
APIs in dart:html (that take a Dictionary) will receive a Dart Map parameter.  The Map parameter
must be converted to a Dictionary before passing to the browser's API.  Before this change,
any Promise/Future API with a Map/Dictionary parameter never called the Promise and didn't
return a Dart Future - now it does.

This caused a number of breaks especially in Service Workers (register, etc.).  Here is a
complete list of the fixed APIs:

BackgroundFetchManager
    Future<BackgroundFetchRegistration> fetch(String id, Object requests, [Map options])

CacheStorage
    Future match(/*RequestInfo*/ request, [Map options])

CanMakePayment
    Future<List<Client>> matchAll([Map options])

CookieStore
    Future getAll([Map options])
    Future set(String name, String value, [Map options])

CredentialsContainer
    Future get([Map options])
    Future create([Map options])

DirectoryEntry
    Future<Entry> _getDirectory(String path, {Map options})
    Future<Entry> _getFile(String path, {Map options})

ImageCapture
    Future setOptions(Map photoSettings)

MediaCapabilities
    Future<MediaCapabilitiesInfo> decodingInfo(Map configuration)
    Future<MediaCapabilitiesInfo> encodingInfo(Map configuration)

MediaStreamTrack
    Future applyConstraints([Map constraints])

Navigator
    Future requestKeyboardLock([List<String> keyCodes])
    Future requestMidiAccess([Map options])
    Future share([Map data])

OffscreenCanvas
    Future<Blob> convertToBlob([Map options])

PaymentInstruments
    Future set(String instrumentKey, Map details)

Permissions
    Future<PermissionStatus> query(Map permission)
    Future<PermissionStatus> request(Map permissions)
    Future<PermissionStatus> revoke(Map permission)

PushManager
    Future permissionState([Map options])
    Future<PushSubscription> subscribe([Map options])

RtcPeerConnection
    REMOVED:  Future createAnswer([options_OR_successCallback,
                                   RtcPeerConnectionErrorCallback failureCallback,
                                   Map mediaConstraints])
    REMOVED:  Future createOffer([options_OR_successCallback,
                                  RtcPeerConnectionErrorCallback failureCallback,
                                  Map rtcOfferOptions])
    REMOVED:  Future setLocalDescription(Map description, VoidCallback successCallback,
                                         [RtcPeerConnectionErrorCallback failureCallback])
    REMOVED:  Future setLocalDescription(Map description, VoidCallback successCallback,
                                         [RtcPeerConnectionErrorCallback failureCallback])
    Future<RtcSessionDescription> createAnswer([Map options])
    Future<RtcSessionDescription> createOffer([Map options])
    Future setLocalDescription(Map description)
    Future setRemoteDescription(Map description)

ServiceWorkerContainer
    Future<ServiceWorkerRegistration> register(String url, [Map options])

ServiceWorkerRegistration
    Future<List<Notification>> getNotifications([Map filter])
    Future showNotification(String title, [Map options])

VRDevice
    Future requestSession([Map options])
    Future supportsSession([Map options])

VRSession
    Future requestFrameOfReference(String type, [Map options])

Window
    Future fetch(/*RequestInfo*/ input, [Map init])

WorkerGlobalScope
    Future fetch(/*RequestInfo*/ input, [Map init])


In addition, exposed Service Worker "self" as a static getter named "instance".  The
instance is exposed on four different Service Worker classes and can throw a InstanceTypeError
if the instance isn't of the class expected (WorkerGlobalScope.instance will always work
and not throw):

*   SharedWorkerGlobalScope.instance
*   DedicatedWorkerGlobalScope.instance
*   ServiceWorkerGlobalScope.instance
*   WorkerGlobalScope.instance

R=vsm@google.com

Bug: #34202
Change-Id: I641ccbff7cc771465dd32c73db20eba5d6667939
Reviewed-on: https://dart-review.googlesource.com/c/74482
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-10-14 22:48:33 +00:00
Sigmund Cherem 0cdd5b9ff3 Raise warning to error: duplicate key in a const map is now an error in Dart.
Eventually the plan is to handle this in the CFE when it performs
constant-evaluation, but for now we can check this in dart2js
(see https://github.com/dart-lang/sdk/issues/32983)

Change-Id: Ic2e5cfd96961094e634da201c55f82398c060aca
Reviewed-on: https://dart-review.googlesource.com/c/79421
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-10-12 00:18:34 +00:00
Lasse R.H. Nielsen 5658d406b7 Add changelog entry for integer literals in double contexts.
Bug: http://dartbug.com/34355
Change-Id: I862ec975d3c0c2d916b9a03af95bf92e1a4625a7
Reviewed-on: https://dart-review.googlesource.com/c/79213
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2018-10-11 20:15:23 +00:00
Alexander Thomas 34f6aea008 [release] Prepare changelog for 2.1.0-dev.7.0
TBR=whesse@google.com

Change-Id: I08a4b0b504dbaae589b07c48db3d81a7d579e69b
Reviewed-on: https://dart-review.googlesource.com/c/79100
Reviewed-by: Alexander Thomas <athom@google.com>
2018-10-10 18:36:42 +00:00
Aske Simon Christensen 10b1b35418 Update changelog for override check fixes
Change-Id: Ic2419c1d8d4dabfc96f96f44900d8bcd9c7bab1d
Reviewed-on: https://dart-review.googlesource.com/c/77741
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-10-03 14:56:43 +00:00
Alexander Thomas aaf3b709e6 [release] Prepare changelog for 2.1.0-dev.6.0
Change-Id: Id2c8d86db9e9d07cd9b6f5c8cf7982ffffd8636b
Reviewed-on: https://dart-review.googlesource.com/76861
Auto-Submit: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Jonas Termansen <sortie@google.com>
2018-09-27 08:31:44 +00:00
Lasse R.H. Nielsen 429bca8e65 Make Uri.parse accept [ and ] in path, query and fragment.
Also accept `#` in fragment.
Fix bug in parsing URI where first character of path needs escaping.
The characters are escaped, but parsing doesn't fail, like it previously
did on misplaced general delimiters in those places

Fixes #34451.

Bug: https://dartbug.com/34451
Change-Id: I99aa39bd2909661802ad9d1bb5dada94d579141b
Reviewed-on: https://dart-review.googlesource.com/74780
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-09-26 14:09:37 +00:00
Nate Bosch d9fcaa33b1 Implement StreamTransformer.fromBind
Closes #32021

Change-Id: I9b8c680ace8b3d7a7bb479ffe19fa0e01fc2cf2f
Reviewed-on: https://dart-review.googlesource.com/71923
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-09-18 21:11:10 +00:00
Lasse R.H. Nielsen cc08d0e1da Add operators &, | and ^ to bool.
Change-Id: Idd6472f239445914c1ff1ab68fc7b38fa6b320ae
Reviewed-on: https://dart-review.googlesource.com/25240
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2018-09-17 12:33:12 +00:00
Nate Bosch 3c4a86c709 Forward drain argument through after .take(0)
Fixes #30305

Change-Id: I7a30cee3e9a406e99f5d714a201b031c428a12e8
Reviewed-on: https://dart-review.googlesource.com/74015
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-09-11 11:07:01 +00:00
Lasse Reichstein Holst Nielsen f0172a4c41 Export Future and Stream from dart:core.
This allows `async` and `async*` functions to be typed without importing `dart:async`.
All other async types still need to be imported, including `FutureOr` and `Zone`,
but pure `async`/`await` based code can be written with no imports.

Fixes #26162.

Bug: http://dartbug.com/26162
Change-Id: Iaf36631ef5b3251a688e495a9d238b2f8787f14c
Reviewed-on: https://dart-review.googlesource.com/71480
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-09-07 06:14:32 +00:00
Alexander Thomas 95c5706979 [release] Prepare changelog for 2.1.0-dev.3.0
TBR=whesse@google.com

Change-Id: I06aa3780de058a72cb4bd5d416f2597f31a341e9
Reviewed-on: https://dart-review.googlesource.com/71761
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-28 08:05:52 +00:00
Lasse Reichstein Holst Nielsen edd6b75a05 Add missing method to UnmodifiableMapMixin.
Fixes 34256
BUG= http://dartbug.com/34256

Change-Id: I780368176b0111130bee1b5aae1f5228eabfa16f
Reviewed-on: https://dart-review.googlesource.com/71460
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-08-28 05:11:12 +00:00
Lasse Reichstein Holst Nielsen 72e6353c32 Make Stream.fromIterable handle errors in current and send a done.
The code didn't handle `iterator.current` throwing, and it didn't send a done
event after `iterator.moveNext()` throws.

Fixes #33431.

Bug: http://dartbug.com/33431
Change-Id: Ic8f7b5d52793ea3db30480e7aa69d01a86e93772
Reviewed-on: https://dart-review.googlesource.com/63841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-08-27 08:06:54 +00:00
Alexander Thomas e1039fc89e [release] Prepare changelog for 2.1.0-dev.2.0
TBR=whesse@google.com

Change-Id: Ibd63236316991346689de2452be679f3b8f88d53
Reviewed-on: https://dart-review.googlesource.com/71169
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-22 17:57:44 +00:00
Devon Carew 2e33d597e7 Roll to the latest dart_style.
Change-Id: I207f1c06d8ca85ade382d6141ac2e0cbba27bbbe
Reviewed-on: https://dart-review.googlesource.com/70940
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-22 17:35:41 +00:00
Lasse R.H. Nielsen 42f295ece5 Deprecate provisional and Provisional and make them unusable.
Will be removed in Dart 3.

Change-Id: I0bf8b01f23bab5a7871f0562562b7ad98887394f
Reviewed-on: https://dart-review.googlesource.com/69462
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-08-17 07:55:12 +00:00
Alexander Thomas 05f2448371 [release] Prepare changelog for 2.1.0-dev.1.0
TBR=whesse@google.com

Change-Id: I2837e27a6dbabe61a4958c0dc0e0d22757edbf3a
Reviewed-on: https://dart-review.googlesource.com/70261
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-08-16 09:29:11 +00:00
Nate Bosch 90440ad2df Update to latest pub with --enable-asserts
Change-Id: I73efbb00b49a7a580a958d287ba0bfab76d10505
Reviewed-on: https://dart-review.googlesource.com/70162
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-08-15 23:30:24 +00:00
William Hesse 54a5aeba4a Change date format in CHANGELOG.md to yyyy-mm-dd uniformly.
There were previously both dd-mm-yyyy and yyyy-mm-dd.

Change-Id: I3eb49c61bc032ff4986283bcc78e4410c0d007ac
Reviewed-on: https://dart-review.googlesource.com/69309
Reviewed-by: William Hesse <whesse@google.com>
2018-08-10 13:42:43 +00:00
Sigmund Cherem 099f1504fa Mention -O flag in CHANGELOG
Fixes https://github.com/dart-lang/sdk/issues/34104

Change-Id: I9d74c931bcb35f280c85b87e1e7847bfe98b72a7
Reviewed-on: https://dart-review.googlesource.com/69181
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-08-09 18:14:15 +00:00
William Hesse f7ff739448 Insert date of 2.0.0 release in Changelog
Change-Id: I3eb567531d117541532b8f60126de1180b1e8507
Reviewed-on: https://dart-review.googlesource.com/69120
Reviewed-by: Michael Thomsen <mit@google.com>
2018-08-09 14:02:33 +00:00
Alexander Thomas f3a2c0e28f [release] Prepare changelog for 2.1.0-dev.0.0
TBR=whesse@google.com

Change-Id: I3909ce29bba429a6fad9238faa11efecd73f6fb9
Reviewed-on: https://dart-review.googlesource.com/69100
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-09 07:32:09 +00:00
Nate Bosch 3d25d3761b Update pub - leave packages directories alone
Change-Id: I56f269568972e16cd5e7ce57d2dc64bd6a6541d8
Reviewed-on: https://dart-review.googlesource.com/68801
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-08-08 22:05:00 +00:00
Bob Nystrom a19a4687f5 Revise CHANGELOG.
Change-Id: I79f20a03ea7f52d436c353fd2de878f6797d1e28
Reviewed-on: https://dart-review.googlesource.com/68203
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-08-02 22:01:19 +00:00
Patrice Chalin 91c6130b5e CHANGELOG copyedits
Originally from https://github.com/dart-lang/sdk/pull/34064

Change-Id: Ic0052055b63ba9939723428d65b8f2c4218ef504
Reviewed-on: https://dart-review.googlesource.com/68201
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-08-02 21:04:13 +00:00
Sigmund Cherem 5f4c617117 Fix typo in CHANGELOG.md
TBR=rnystrom@google.com

Change-Id: I58a16f448be53fe0f9a7a4a9ab3ec5179bd67879
Reviewed-on: https://dart-review.googlesource.com/68220
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-08-02 20:41:04 +00:00
Sigmund Cherem bbfc465bd0 Cleaned up a few entries in the CHANGELOG
Mostly addressing my comments on https://dart-review.googlesource.com/c/sdk/+/67860 for the dart2js section

Change-Id: I421489088ba79be693fa07662a7c008f1f950944
Reviewed-on: https://dart-review.googlesource.com/68160
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-08-02 19:03:21 +00:00
Bob Nystrom cb5513fbc9 Make a single clear CHANGELOG entry for all 2.0.0 changes.
Change-Id: Ib37a0a22aa75c7abdd0bb95381bdbafdc96bfe0f
Reviewed-on: https://dart-review.googlesource.com/67860
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-08-02 01:07:22 +00:00
Lasse R.H. Nielsen f2402b3c08 Remove deprecated SDK constant declarations.
Change-Id: I0e4208b6fa957765403608103128c28562280657
Reviewed-on: https://dart-review.googlesource.com/51841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-07-18 13:05:00 +00:00
Lasse R.H. Nielsen 91ce347309 Reapply "Create _nullFuture and _falseFuture in the root zone."
Originally landed by https://dart-review.googlesource.com/c/sdk/+/49509
Reverted because an internal test is fragile and changes behavior when the bug is fixed.

Change-Id: I8516082e5741547c46aa521a91826846dc101303
Reviewed-on: https://dart-review.googlesource.com/63743
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2018-07-16 16:19:15 +00:00
Lasse Reichstein Holst Nielsen e26d3d5f9f Reenable the Iterable.whereType method.
Fixes #32463.

Bug: http://dartbug.com/32463
Change-Id: Ie58ff1acbc0a834956741c7ec0ab8d890793baf9
Reviewed-on: https://dart-review.googlesource.com/63940
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-07-10 18:05:15 +00:00
William Hesse b5e97a6537 Roll dart_style to version 1.1.2
This stops the splitting of long strings inside their interpolations.

BUG=https://github.com/dart-lang/sdk/issues/33773

Change-Id: Ie3a7a576de036c9055b02e6770f5f28d8bb49e35
Reviewed-on: https://dart-review.googlesource.com/64040
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-07-09 22:51:54 +00:00
Devon Carew d52555c26e Update the changelog for analyzer changes.
Change-Id: I3a6907d6e73aad224d3395635a787c8ebcaae544
Reviewed-on: https://dart-review.googlesource.com/63800
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-05 19:14:10 +00:00
Sigmund Cherem 90e9fec5ae Add changelog entry for language change on int literals
Bug: https://github.com/dart-lang/sdk/issues/33282
Change-Id: I50d1a8855e83996777b8b8e051cd4171d5a8a9aa
Reviewed-on: https://dart-review.googlesource.com/63664
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-03 19:12:35 +00:00
Zach Anderson 0ccdc3ec38 Reland: [dart:io] Adds Socket.startConnect
This is a reland of https://dart-review.googlesource.com/c/sdk/+/62484
with the following changes:
- _NativeSocket.connect now drops references to pending sockets on
  an error or successful connection.
- eventhandlers are updated to ignore unset Dart ports on a close
  command.
- Test updated to account for new SocketException.

This is the second part of https://dart-review.googlesource.com/c/sdk/+/62484

This CL adds a startConnect method to Socket types that returns
a ConnectionTask object that can be cancelled. Cancelling
a ConnectionTask closes any sockets that were opened for the
connection attempt that are not yet connected to the host.

This allows a closing HttpClient to close sockets for pending
requests whose sockets weren't fully connected yet.

related https://github.com/flutter/flutter/issues/18617

Change-Id: I47fe3564e41197d622079aad4bb644bbdfe0bfe8
Reviewed-on: https://dart-review.googlesource.com/63040
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-07-03 14:47:41 +00:00
William Hesse fb762be46a Update dart_style to version 1.1.1 in DEPS
Bug: https://github.com/dart-lang/sdk/issues/33663
Change-Id: Ic4dc36489b70164c723433487a6ac82082b2a165
Reviewed-on: https://dart-review.googlesource.com/63585
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-07-03 13:44:38 +00:00
Aske Simon Christensen 73386f75d6 Update changelog to mention new member conflict rules.
Closes https://github.com/dart-lang/sdk/issues/33237

Change-Id: Ic2b477013534190ccf725b119b85f167c5cd2727
Reviewed-on: https://dart-review.googlesource.com/62802
Commit-Queue: Aske Simon Christensen <askesc@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
2018-06-29 11:25:28 +00:00
Zach Anderson 4e04ad50b7 Revert "[dart:io] Adds Socket.startConnect"
This reverts commit eb3becea2c.

Reason for revert: test failures on the bots.

Original change's description:
> [dart:io] Adds Socket.startConnect
> 
> This is the second part of https://dart-review.googlesource.com/c/sdk/+/62484
> 
> This CL adds a startConnect method to Socket types that returns
> a ConnectionTask object that can be cancelled. Cancelling
> a ConnectionTask closes any sockets that were opened for the
> connection attempt that are not yet connected to the host.
> 
> This allows a closing HttpClient to close sockets for pending
> requests whose sockets weren't fully connected yet.
> 
> related https://github.com/flutter/flutter/issues/18617
> 
> Change-Id: I59c761b06e070d555fc514614079930b69c129dd
> Reviewed-on: https://dart-review.googlesource.com/62780
> Commit-Queue: Zach Anderson <zra@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com

Change-Id: I890d0de7fcde65fec55bfa9bad077c1a3dd13a74
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/62980
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-06-28 22:42:38 +00:00
Zach Anderson eb3becea2c [dart:io] Adds Socket.startConnect
This is the second part of https://dart-review.googlesource.com/c/sdk/+/62484

This CL adds a startConnect method to Socket types that returns
a ConnectionTask object that can be cancelled. Cancelling
a ConnectionTask closes any sockets that were opened for the
connection attempt that are not yet connected to the host.

This allows a closing HttpClient to close sockets for pending
requests whose sockets weren't fully connected yet.

related https://github.com/flutter/flutter/issues/18617

Change-Id: I59c761b06e070d555fc514614079930b69c129dd
Reviewed-on: https://dart-review.googlesource.com/62780
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-06-28 21:58:08 +00:00
Zach Anderson b4a426fa72 [dart:io] Adds HttpClient.connectionTimeout
This is the first part of a two part change for fixing a file
descriptor leak when using HttpClient with a flaky network connection.
There are two ways to use HttpClient. The first way is to allocate
and close an HttpClient for each request. The second way is to allocate
an HttpClient and use it to make several requests. This change
addresses leaks that can happen when using it the second way. A
subsequent change will address leaks that can happen when using it
the first way.

This change adds a field connectionTimeout to HttpClient. Users of
HttpClient can set this field to indicate the `timeout` parameter
that should be passed to calls to {SecureSocket,Socket}.connect() for
new http connections. If the field is not set, the OS default is
used.

related https://github.com/flutter/flutter/issues/18617

Change-Id: I26ae2fce7d28273923d1af697c93d987e3e4a38a
Reviewed-on: https://dart-review.googlesource.com/62484
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-06-27 20:27:08 +00:00
William Hesse 12971f37a9 Update dart_style package to 1.1.0 in DEPS
Update Changelog to add this info, and to prepare for releasing -dev.65.0

Change-Id: Iaa6c0d917acb1132227352b422ef3939cda2a9f4
Reviewed-on: https://dart-review.googlesource.com/61926
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-06-26 11:33:24 +00:00
Alexander Thomas 9aa0c4ae3f [release] Prepare changelog for 2.0.0-dev.65.0
Change-Id: Ie463e9b88a68d86e6e09d0c9e9d53f89ab1d77ed
Reviewed-on: https://dart-review.googlesource.com/62149
Reviewed-by: William Hesse <whesse@google.com>
2018-06-26 10:36:46 +00:00
Nate Bosch f598e6933c Drop support for Dart 1 in pub
Closes #33187

Brings in the latest version of pub. There is still an issue with
invaliding old snapshots, but this version works better than the current
synced version.

Change-Id: I5c98b0277ea769baa83c3fee7ebfff2034ba9920
Reviewed-on: https://dart-review.googlesource.com/61983
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-06-23 01:00:05 +00:00
asiva 68ecf31fc5 Update CHANGELOG.md with text for the default switching to Dart 2.0.
Change-Id: Ib47cc23ff1bcaefc708f1049a7964798a91b4157
Reviewed-on: https://dart-review.googlesource.com/61304
Reviewed-by: Dan Grove <dgrove@google.com>
2018-06-20 19:36:02 +00:00
Sigmund Cherem c96f23243b Enable Dart2 in dart2js by default
Change-Id: Id197fc734bcb45f0805e49e89c0d03419384bb0b
Reviewed-on: https://dart-review.googlesource.com/60448
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-06-19 19:20:36 +00:00
Lasse R.H. Nielsen dfeaf79cef Fix VM accepting too many overlarge hex numbers in int.parse.
Fixes #32858

BUG= http://dartbug.com/32858

Change-Id: I362e51ef0fb8b55a0ca1a7ed75a77a13c9d94893
Reviewed-on: https://dart-review.googlesource.com/60243
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-06-18 10:04:07 +00:00
Leaf Petersen 8e9e8e1da0 Fix various bugs and regularize behavior of returns statements in
various kinds of functions.

Closes-bug: #31887
Closes-bug: #30638
Closes-bug: #32233
Closes-bug: #32881
Closes-bug: #31278
Change-Id: I4ebd7e71096d611e189b571ba5de2998dd11c98b
Reviewed-on: https://dart-review.googlesource.com/60300
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Leaf Petersen <leafp@google.com>
2018-06-15 16:07:44 +00:00
William Hesse 84f077842b Update CHANGELOG.md for 2.0.0-dev.63 release
Change-Id: I8ee73624eddf5a5698a6a89db691b530de694102
Reviewed-on: https://dart-review.googlesource.com/60420
Reviewed-by: Nate Bosch <nbosch@google.com>
2018-06-14 22:38:50 +00:00
Nate Bosch 34ee27a52d Update to the latest pub
Brings in fix for https://github.com/dart-lang/pub/issues/1919

Change-Id: Ied08a3c4b9a61879bed33c0bf15c800690bf341d
Reviewed-on: https://dart-review.googlesource.com/60148
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-06-13 22:03:14 +00:00
Alexander Thomas baef792361 [release] Prepare changelog for 2.0.0-dev.62.0
TBR=whesse@google.com

Change-Id: I7b1a2012cc432cafa5f817fc50d8118f4e9e8683
Reviewed-on: https://dart-review.googlesource.com/60141
Reviewed-by: Alexander Thomas <athom@google.com>
2018-06-13 14:39:56 +00:00
Patrice Chalin 6cc4038db5 Markdown formatting fix
Closes #33435
https://github.com/dart-lang/sdk/pull/33435

GitOrigin-RevId: 957da9d3615cdec785ae12891db6bde01173ada3
Change-Id: Ic9964c5669410b473bd2ecaaa9d9fb7ecb91a6f6
Reviewed-on: https://dart-review.googlesource.com/60080
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-06-13 14:29:54 +00:00
Nate Bosch 00bfb03cf3 Update pub to the latest
Change-Id: Ie203de0c410fbbd73ff615aec3d9cdd586a0b0e6
Reviewed-on: https://dart-review.googlesource.com/59940
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-06-12 19:53:49 +00:00
Mike Fairhurst 7911fb2683 First pass at disabling packages/ dir, packageRoot
Change-Id: Ib2d7738c84cd1258dcad46e8e2c8da8105efea60
Reviewed-on: https://dart-review.googlesource.com/59100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Mike Fairhurst <mfairhurst@google.com>
2018-06-12 19:38:40 +00:00
Lasse R.H. Nielsen 0b91676362 Remove the retype method.
See #33075.

Bug: http://dartbug.com/33075
Change-Id: I1ee2f587afbc672dd08ac61ac003bbdc85bb95e2
Reviewed-on: https://dart-review.googlesource.com/59091
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-06-12 14:36:09 +00:00
Leaf Petersen ebc30fd0da Move void to top of type hierarchy
Fixes #33341

Change-Id: Ib2b7b5542b702a04b38dee5261fc80664a7fcc18
Reviewed-on: https://dart-review.googlesource.com/59822
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-06-11 22:40:44 +00:00
Alexander Thomas 5aa65c0037 [release] Prepare changelog for 2.0.0-dev.61.0
TBR=whesse@google.com

Change-Id: I41274ea551feea4166fd349fb6a943fdd994695d
Reviewed-on: https://dart-review.googlesource.com/59720
Reviewed-by: Alexander Thomas <athom@google.com>
2018-06-11 12:39:35 +00:00
Zach Anderson 87b5112d5b [dart:_http] Adds Dart-styled constants
Change-Id: I42e0c02b3aac7f952c5346bbcddd50293bf2b5b8
Reviewed-on: https://dart-review.googlesource.com/58620
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-06-07 16:18:33 +00:00
Nate Bosch 2f79dc3f00 Bring in the latest pub
Fixes https://github.com/dart-lang/pub/issues/1914

Includes fixes for snappshotting and running executables in Dart 2 mode.

Change-Id: If35c22859b3985fee769e15d2606f484746f2926
Reviewed-on: https://dart-review.googlesource.com/58804
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-06-06 19:06:04 +00:00
Florian Loitsch 398ba13e4a Reapply "Make --sync-async the default for the VM."
Change-Id: I6e4da0da6c3f635d84380b384ae17fbb55587895
Reviewed-on: https://dart-review.googlesource.com/58721
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Florian Loitsch <floitsch@google.com>
2018-06-06 14:32:13 +00:00
Sam Rawlins c95617b19c Add a release note about the VM going sync-async
Bug: none
Change-Id: Idf1499bddb3f40034512d8ee349b3bee5f4c552b
Reviewed-on: https://dart-review.googlesource.com/57641
Reviewed-by: Florian Loitsch <floitsch@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-06-06 13:24:42 +00:00
Ryan Macnak 53f7bb175e Revert "Make --sync-async the default for the VM."
This reverts commit 1ddf553eb6.

Reason for revert: Failing service tests

Original change's description:
> Make --sync-async the default for the VM.
> 
> Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
> Reviewed-on: https://dart-review.googlesource.com/57580
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>

TBR=vegorov@google.com,kustermann@google.com,floitsch@google.com

Change-Id: I062cb40badf0d1cf1808bee152fdd4074b00179d
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/58380
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-06-04 21:04:20 +00:00
Alexander Thomas 839c03e092 [release] Prepare changelog for 2.0.0-dev.60.0
TBR=whesse@google.com

Change-Id: Ie14d3fab5f5fdc8e3e25660496cd677fcee1f645
Reviewed-on: https://dart-review.googlesource.com/58340
Reviewed-by: Alexander Thomas <athom@google.com>
2018-06-04 20:01:22 +00:00
Florian Loitsch 1ddf553eb6 Make --sync-async the default for the VM.
Change-Id: Ic6d7bbc27835ea7b197cccf05724adb99e95dd51
Reviewed-on: https://dart-review.googlesource.com/57580
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2018-06-04 18:05:20 +00:00
Sam Rawlins f66769c92f Add duplicate shown/hidden name analyzer note to changelog
Bug: none
Change-Id: I92f57407b4eb657a0e03cde1e9e6abb2bcc8ac07
Reviewed-on: https://dart-review.googlesource.com/57640
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-05-31 16:28:17 +00:00
Lasse R.H. Nielsen 66c590d3ad Add json/utf8 BOM support in changelog.
Change-Id: I91185015ea8cc05b332dda6d6ac9f3582a29cb4c
Reviewed-on: https://dart-review.googlesource.com/57240
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-05-30 09:19:28 +00:00
Ryan Macnak c30af41b96 Reapply "[mirrors] Add IsolateMirror.loadUri."
- Forward only kImportTag requests to DFE. This restores the current handling of a kScriptTag request when loading the kernel isolate in the simulators.
 - Mark dynamic_load_test as failing in the reload stress tests (reload fails to preserve library identity).

Change-Id: Ibe6f0a3505b99736a38d566abf3b2151505d7a7e
Reviewed-on: https://dart-review.googlesource.com/56706
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-05-29 22:01:01 +00:00
Alexander Thomas ff815d05a5 [release] Prepare changelog for 2.0.0-dev.59.0
TBR=whesse@google.com

Change-Id: Ia7266b2b27f6c623d0383450977b00fbc986c36d
Reviewed-on: https://dart-review.googlesource.com/56982
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-29 20:01:09 +00:00
Leaf Petersen 2d8bf7751e CHANGELOG for invariant generic bounds
Change-Id: If7dcc07b9fb68e149814e8de42bbf6d9d0425a62
Reviewed-on: https://dart-review.googlesource.com/56621
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2018-05-24 20:23:42 +00:00
Ryan Macnak de545b4079 Revert "[mirrors] Add IsolateMirror.loadUri."
This reverts commit ad4cfa0260.

Reason for revert: Assertion failures on DBC

Original change's description:
> [mirrors] Add IsolateMirror.loadUri.
> 
> This allows a programmer to dynamically load code into an isolate. The closest existing API is Isolate.spawnUri, but communication with the dynamically loaded code in that case is limited to asynchronous message passing of JSON-like objects.
> 
> Change-Id: Icb23e9dacfb0035622c119f11d4e0f892ba2ccd1
> Reviewed-on: https://dart-review.googlesource.com/45363
> Reviewed-by: Zach Anderson <zra@google.com>

TBR=rmacnak@google.com,zra@google.com,asiva@google.com,kmillikin@google.com

Change-Id: I80669188b9f40b3b527e8e268ade0d0d514a8753
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/56640
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-05-24 20:03:40 +00:00
Ryan Macnak ad4cfa0260 [mirrors] Add IsolateMirror.loadUri.
This allows a programmer to dynamically load code into an isolate. The closest existing API is Isolate.spawnUri, but communication with the dynamically loaded code in that case is limited to asynchronous message passing of JSON-like objects.

Change-Id: Icb23e9dacfb0035622c119f11d4e0f892ba2ccd1
Reviewed-on: https://dart-review.googlesource.com/45363
Reviewed-by: Zach Anderson <zra@google.com>
2018-05-24 17:07:15 +00:00
Ben Konyi 3ab7cf0590 Revert "[dart:io] Revert recent non-utf8 path handling"
This reverts commit 42bcdcd332.

Change-Id: I11fb7db2aac3b7dc15cb35a22fea38b31069cbc0
Reviewed-on: https://dart-review.googlesource.com/55502
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2018-05-23 21:01:44 +00:00
Alexander Thomas 88d847ea3e [release] Prepare CHANGELOG.md for 2.0.0-dev.58.0
TBR=whesse@google.com

Change-Id: Ia8868eba66f22cc3f6475ec3cad0c1c244128de0
Reviewed-on: https://dart-review.googlesource.com/56347
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-23 18:37:52 +00:00
Alexander Thomas cbe76eeea0 [release] Prepare changelog for 2.0.0-dev.57.0
Change-Id: I3f3ea74ee550d6110ebb2cdcf96a1b9f07293d99
Reviewed-on: https://dart-review.googlesource.com/56323
Reviewed-by: William Hesse <whesse@google.com>
2018-05-23 15:37:08 +00:00
Terry Lucas cf87b84f7d Support Promise to Future for both DDC and dart2js.
APIs in the newer Chrome IDLs support more JS style promises. The Dart web libraries now hookup those promises and return a Dart Future.
Additionally, a new type maplike is exposed in the IDL this is exposed too.

Change-Id: I44175877eb95f4d910586d42c0139fb182483f82
Reviewed-on: https://dart-review.googlesource.com/49800
Commit-Queue: Terry Lucas <terry@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-23 04:08:14 +00:00
Alexander Thomas 85ddeb990a [release] Prepare changelog for 2.0.0-dev.56.0
TBR=whesse@google.com

Change-Id: Iadbd442d65dd02d76794e59b0f2d8700f3fbe22a
Reviewed-on: https://dart-review.googlesource.com/56110
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-22 14:35:50 +00:00
Leaf Petersen a5d4195b0b CHANGELOG entry for noSuchMethod change
Change-Id: Idf8ea6252aba97b4a29a3d0acaa530e8c0cb59eb
Reviewed-on: https://dart-review.googlesource.com/55843
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-05-18 00:16:46 +00:00
Zach Anderson e7495e427c [dart:io] Adds X509Certificate.der and X509Certificate.pem
fixes #33115

Change-Id: I7ccf5998b23e936040fe65792824f09d3f494cf7
Reviewed-on: https://dart-review.googlesource.com/55505
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2018-05-17 16:20:06 +00:00
Lasse R.H. Nielsen cdc520f459 Mark MirrorsUsed as deprecated.
Change-Id: I8e28f80581fdb22de5fd63d9a604252c95df14ee
Reviewed-on: https://dart-review.googlesource.com/55360
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Anders Sandholm <sandholm@google.com>
2018-05-16 09:51:18 +00:00
Lasse R.H. Nielsen bf77f064c1 Mark NoSuchMethodError constructor as deprecated.
Move implementation details into patch files, it does not belong in the interface.
Actually implement NoSuchMethod.withInvocation in dart2js.

Change-Id: I37049c258067b962d18eff42196e37aa127f0dea
Reviewed-on: https://dart-review.googlesource.com/55166
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-05-16 09:09:08 +00:00
Bob Nystrom 07f642384e Roll dart_style 1.0.14 into the SDK.
This should be safe to do without rolling the prebuilt SDK since it
makes no changes to existing formatted code.

Change-Id: I3420698b5dac94ab04ee7908940ace70936a3e5b
Reviewed-on: https://dart-review.googlesource.com/55269
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-05-15 21:13:27 +00:00
Alexander Thomas b651b0ebcd [release] Prepare changelog for 2.0.0-dev.55.0
TBR=whesse@google.com

Change-Id: I91d7691c6e3d983c804c6a09b7fb136a78d247dd
Reviewed-on: https://dart-review.googlesource.com/54820
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-14 06:55:54 +00:00
Nate Bosch 57dee60d4d Update to latest pub
Change-Id: I34de418baa3e3a202edb129e3d88f751473e0d3d
Reviewed-on: https://dart-review.googlesource.com/54636
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-05-11 00:03:35 +00:00
Sigmund Cherem c25a9fd46b Remove support for dart:isolate in dart2js.
Change-Id: I1216a0ac91d8a1d13b441809596e1a8b5e51bb34
Reviewed-on: https://dart-review.googlesource.com/54526
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2018-05-10 01:20:17 +00:00
Leaf Petersen 2d95c54392 CHANGELOG for cast/retype changes
Change-Id: I8d23c6829937de3c1d6c42d7e33b106473f82d1d
Reviewed-on: https://dart-review.googlesource.com/54522
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-05-09 18:36:32 +00:00
Zach Anderson a49fd95d59 [CHANGELOG] Update for dart:io constant rename
Change-Id: I18c965ebed9fb700b07f879f64d602b5fc985a83
Reviewed-on: https://dart-review.googlesource.com/54440
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-05-09 16:57:53 +00:00
Alexander Thomas a0d3bef5fb [release] Prepare changelog for 2.0.0-dev.54.0
TBR=sortie@google.com

Change-Id: I42a914ba39a6744b1940639ce4833f8869ca9a6f
Reviewed-on: https://dart-review.googlesource.com/54381
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-09 07:39:05 +00:00
Nate Bosch 6c301a4e32 Bring in the latest pub
Closes https://github.com/dart-lang/sdk/issues/33030
Change-Id: Ib71de5c979e9bdeca5dace501ff5436852e32a82
Reviewed-on: https://dart-review.googlesource.com/54060
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-05-07 21:44:05 +00:00
Alexander Thomas 16f6ce2fee [release] Prepare changelog for 2.0.0-dev.53.0
TBR=whesse@google.com

Change-Id: I780fc63f1efcb433c2b397716e5a72e496ee0d07
Reviewed-on: https://dart-review.googlesource.com/53601
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-03 10:32:35 +00:00
Alexander Thomas 5087ffa481 [release] Move DDC sync-async flip to correct section in the release notes
TBR=sortie@google.com

Change-Id: I0e3293ca1a7e13d79b2b59fb8500393ef4f0f5e5
Reviewed-on: https://dart-review.googlesource.com/53214
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-01 16:32:31 +00:00
Alexander Thomas fe7056ebaa [release] Update changelog for 2.0.0-dev.52.0
TBR=sortie@google.com

Change-Id: I2c23a76ab95368a598c1156b5bf6c6ef36f245c8
Reviewed-on: https://dart-review.googlesource.com/53213
Reviewed-by: Alexander Thomas <athom@google.com>
2018-05-01 16:10:27 +00:00
Alexander Thomas 03ca45c0a8 [release] Merge changelog corrections from dev branch
Change-Id: I11bf3b4dde2b62d1f52bcb512311832ef97a54fb
Reviewed-on: https://dart-review.googlesource.com/53005
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-05-01 08:38:33 +00:00
Bob Nystrom 9d34963947 Stop ignoring explicit ("as") cast failures on all but function types.
Change-Id: Ia421cce7bab4fe9c74775b5bf2474901475cfa89
Reviewed-on: https://dart-review.googlesource.com/53160
Reviewed-by: Vijay Menon <vsm@google.com>
2018-04-30 23:05:24 +00:00
Vijay Menon 001af89c8e Flip DDC to default to sync-async
See #32868

Change-Id: I757321632c9f383edea398741c67fc7c3e3815e5
Reviewed-on: https://dart-review.googlesource.com/52900
Commit-Queue: Vijay Menon <vsm@google.com>
Reviewed-by: Jenny Messerly <jmesserly@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-04-30 15:04:51 +00:00
Alexander Thomas c164f92397 [release] Prepare CHANGELOG.md for 2.0.0-dev.51.0
TBR=sortie@google.com

Change-Id: I63f807c3e12ddd4f704400f7f7e2052c56415055
Reviewed-on: https://dart-review.googlesource.com/53003
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-30 07:40:01 +00:00
Sigmund Cherem 239b2fd090 move changelong entry
TBR=vsm@google.com

Change-Id: I0c50ae409124be8ea27e8533a17d5841dc135d68
Reviewed-on: https://dart-review.googlesource.com/52960
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-04-27 20:07:55 +00:00
Sigmund Cherem 3c9d0858b0 dart2js: turn on sync-async by default
Closes https://github.com/dart-lang/sdk/issues/32869

Change-Id: I79b2d02d13adccdfbbd3a78158805244aceff7de
Reviewed-on: https://dart-review.googlesource.com/52061
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2018-04-27 19:48:46 +00:00
Alexander Thomas f95df2a26b [dartfmt] Bump dart:style to 1.0.11
* Fix a runtime error when dart_style is itself run in Dart 2.
* Force splitting an empty block as the then body of an if with an else.
* Use the new lowercase Dart 2 constant names.

https://github.com/dart-lang/sdk/issues/32961

Change-Id: I283f28a5e75016528093358a899b7f983ae1445e
Reviewed-on: https://dart-review.googlesource.com/52760
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-04-26 18:26:32 +00:00
Nate Bosch 94f45c8876 Bring in the latest pub
Bug: 32593
Change-Id: I4a8ce82591249968cfb00e9c57ddf75afb760d14
Reviewed-on: https://dart-review.googlesource.com/52700
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-04-26 00:01:35 +00:00
Alexander 9d4514bb9e [release] Merge changelog from dev branch into master
TBR=whesse@google.com

Change-Id: Ib30ca03e2068ebe05a7f00902afcfe62c7ebbc4f
Reviewed-on: https://dart-review.googlesource.com/51663
Reviewed-by: Alexander Thomas <athom@google.com>
2018-04-18 18:50:35 +00:00
Natalie Weizenbaum 54531ad4e7 Bring in the latest pub_semver
Change-Id: Icb7419e0922c9bf8a794a324c4da15f1da0e3074
Reviewed-on: https://dart-review.googlesource.com/51200
Reviewed-by: Gary Roumanis <grouma@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-04-16 21:14:59 +00:00
Lasse R.H. Nielsen 7cc4d76a30 Add tryParse alternatives to parseFunctions.
Deprecate `onError` arguments to parse methods.

Change-Id: Iac1d87416abc8a73ce1853edffab49df8a8cb5fe
Reviewed-on: https://dart-review.googlesource.com/50723
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-12 13:16:49 +00:00
Natalie Weizenbaum 7689dc9e06 Bring in the latest pub_semver
Change-Id: Ibd772c70d596fdc32c6654a058bf44ef0ab787a0
Reviewed-on: https://dart-review.googlesource.com/49827
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-04-10 01:41:09 +00:00
Devon Carew 6ce79da9a1 Fix windows issues w/ the packages dir handling removal.
Change-Id: I78cf4b8787da7449f8a7a2840b9dd91e2342d5ec
Reviewed-on: https://dart-review.googlesource.com/49830
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-04-06 16:24:52 +00:00
Devon Carew 7cbd0f55b5 Remove the special casing of 'packages' files from the analyzer and analysis server.
Change-Id: I11fa2f73f7cdba8c53478c9002cefe82e58c09d6
Reviewed-on: https://dart-review.googlesource.com/49822
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-04-06 14:57:42 +00:00
Lasse Reichstein Holst Nielsen 8ada18e9a1 Mention removal of defaultValue parameter on stream methods in changelog.
Also remove mentions in documentation.

Change-Id: I51ad3137fff505168acde7f2e21bebc42a49da3b
Reviewed-on: https://dart-review.googlesource.com/49721
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-04-06 10:35:52 +00:00
Natalie Weizenbaum a0a06e172c Bring in the latest pub_semver
Change-Id: I8ba26694c1b52d47ac335117c863de26b432d084
Reviewed-on: https://dart-review.googlesource.com/49320
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-04-03 23:38:11 +00:00
Terry Lucas 49558b9c4c Fixed MessageChannel receiveing messages on ports.
Removed pkg browser from tests.

Fixes https://github.com/dart-lang/sdk/issues/26351
Fixes https://github.com/dart-lang/sdk/issues/32631

R=kevmoo@google.com

Change-Id: Ib0ef5f933d38b2f748cca1f82de8bcf01702df4d
Reviewed-on: https://dart-review.googlesource.com/48742
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Terry Lucas <terry@google.com>
2018-03-30 17:16:15 +00:00
Zach Anderson 865f52737a [dart:io] Adds IOOverrides.socketConnect
fixes #32535

Change-Id: I335e3698ec3505114d480ae6179254fa0ade3f7a
Reviewed-on: https://dart-review.googlesource.com/48702
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Todd Volkert <tvolkert@google.com>
2018-03-28 23:07:49 +00:00
Natalie Weizenbaum d46915d239 Bring in the latest pub
Change-Id: If138dd10ebae40bf031c05d9702f166abfb511e5
Reviewed-on: https://dart-review.googlesource.com/48525
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-03-28 21:50:28 +00:00
Sam Rawlins 301b5a1f16 Remove Maps; move _fillMapWith* methods to MapBase
Fixes #31843

Bug: https://github.com/dart-lang/sdk/issues/31843
Change-Id: I02c544c921951f4a50421205dc1f25997cbecd6e
Reviewed-on: https://dart-review.googlesource.com/39880
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-03-26 21:23:21 +00:00
Sigmund Cherem 05207c5c87 Remerge changelog: it seems I merged the log with 2.0.0-dev.41, not with the tip
of the dev channel.

TBR

Change-Id: Iab49de4007a6fe677417d1b83cd48114a8d73310
Reviewed-on: https://dart-review.googlesource.com/48090
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2018-03-23 20:14:10 +00:00
Sigmund Cherem 2ef5bbf853 Add entries to changelog
Change-Id: I7f5994fbaf3ca91beb4bae7892cc79075c9cc61e
Reviewed-on: https://dart-review.googlesource.com/48089
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-23 19:22:16 +00:00
Kevin Moore 4905a2da7c Fix pub issues links from bde48c67ec
Change-Id: Id28c8d57c9cede6780e3f83ad4a05e32dfcb3e33
Reviewed-on: https://dart-review.googlesource.com/47722
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-03-22 01:12:12 +00:00
Kevin Moore bde48c67ec Update pub dependency
Closes https://github.com/dart-lang/sdk/issues/32622

Change-Id: I5677acf9f069d4786544dfa6b3cd2a05af77e7b2
Reviewed-on: https://dart-review.googlesource.com/47682
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-03-22 00:54:36 +00:00
Kevin Moore 95089a2eeb cleanup CHANGELOG for -dev.39 and -dev.40
Change-Id: Id9c52edb419fdbf3dfdbfdc34e5df1759c4a84a6
Reviewed-on: https://dart-review.googlesource.com/47681
Reviewed-by: William Hesse <whesse@google.com>
2018-03-22 00:12:10 +00:00
Terry Lucas 3d34f4d4fe Updated CHANGELOG with Chrome 63 roll changes and fixed status file test now passes.
TBR=whesse@google.com

Change-Id: Ie48a6023cc3c0abecb8347b1a2f3ce774d42681a
Reviewed-on: https://dart-review.googlesource.com/47243
Reviewed-by: Terry Lucas <terry@google.com>
2018-03-20 15:14:38 +00:00
Alexey Knyazev 4f1f5f8167 Reland "Do not return this on RandomAccessFile.close"
This is a reland of 44aa9a17fd

Original change's description:
> Do not return this on RandomAccessFile.close
> 
> Bug: 32015
> Change-Id: I98508bdad569201afeed91f1287f061b5bb39a31
> Reviewed-on: https://dart-review.googlesource.com/44060
> Reviewed-by: Sigmund Cherem <sigmund@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Commit-Queue: Vyacheslav Egorov <vegorov@google.com>

Bug: 32015
Change-Id: I96d870e083d7862cf0f6ad664364cf7ddef0f598
Reviewed-on: https://dart-review.googlesource.com/46780
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-03-19 13:45:25 +00:00
Alexandre Ardhuin d0f4d7e229 update CHANGELOG for new hints
Fixes #32518

Closes #32524
https://github.com/dart-lang/sdk/pull/32524

GitOrigin-RevId: 7779b37697bf522b9d7d1dd3b6cbb9e67191b70c
Change-Id: I15f7cb3cb69e6c3fb6db57943f73f9187b499d1e
Reviewed-on: https://dart-review.googlesource.com/46423
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2018-03-16 15:43:37 +00:00
Sigmund Cherem b24a9d8ee6 Roll pub once again: this allows reenables suing the CFE from pub-build
Change-Id: Ia1dba48f3b7f74891d30a0e4065ab4ed53187d96
Reviewed-on: https://dart-review.googlesource.com/46821
Reviewed-by: Emily Fortuna <efortuna@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-15 22:24:34 +00:00
William Hesse ca0776ba3c CHANGELOG: Add section for current dev release changes
Change-Id: Iba39c924b6914f569acfec0d197e5a419397a513
Reviewed-on: https://dart-review.googlesource.com/46581
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-15 16:29:46 +00:00
Sigmund Cherem c438f8b3f4 Dart2js defaults to the new common front-end
Change-Id: Id0f69d258b010a746b56e259335185bcca7dafec
Reviewed-on: https://dart-review.googlesource.com/45143
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-03-13 19:25:59 +00:00
Sigmund Cherem e5f490fb00 Roll a new version of pub
There was only 1 change since the last roll.

Change-Id: I44a8ef56bc16d4bc4616480025125f1ca64beff8
Reviewed-on: https://dart-review.googlesource.com/46221
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-03-13 15:37:09 +00:00
Lasse R.H. Nielsen 00dae36b47 Add of constructors to collections.
Change-Id: Ic9a180cbb758cf8fe51369d904fa4b51fd1b8e27
Reviewed-on: https://dart-review.googlesource.com/44480
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-13 12:57:49 +00:00
Lasse Reichstein Holst Nielsen 0b5d718489 Change return type of decodeBase64 to Uint8List.
Matches base64.decode.

Change-Id: Ida4e2a450940217959089d5bc48b6462b52df755
Reviewed-on: https://dart-review.googlesource.com/46140
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-13 08:12:52 +00:00
Lasse Reichstein Holst Nielsen 414a3318ea Add jsonDecode, jsonEncode, base64Decode, base64Encode, base64UrlEncode functions.
Change-Id: Ic65ada3b107cc8e6c3459459c4bea389feef2168
Reviewed-on: https://dart-review.googlesource.com/23664
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-12 09:16:27 +00:00
Leaf Petersen 4c881188b2 Disable the .whereType method until generic methods are turned on.
The whereType method silently does the wrong thing without methods,
so make it throw until we turn them on everywhere.

Change-Id: Id934c8bdb4f682dbc3560d78fbca580e37297e2d
Reviewed-on: https://dart-review.googlesource.com/45744
Reviewed-by: Nate Bosch <nbosch@google.com>
2018-03-08 23:14:22 +00:00
Lasse Reichstein Holst Nielsen b3c12d4e3a Dart 2 Libraries Wave 3
Add `typeArguments` to Invocation.
Add constructors to Invocation, making it less necessary for users to create their own implementations.
Add tests.
Add Symbol.unaryMinus and Symbol.empty constants.

Change-Id: I70cb3265f9413617cf57fce1297e393a29eeb26a
Reviewed-on: https://dart-review.googlesource.com/40741
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-03-08 16:36:07 +00:00
Vyacheslav Egorov 675048d0b6 Add pragma class to dart:core.
This class can be used to annotate declarations with
tool specific hints.

For example @pragma('vm:extern') can tell that a method is invoked from
outside (e.g. via VM C API), which informs Kernel based tools not to
tree-shake this method.

Design doc (internal) https://docs.google.com/document/d/1yqje8uctBqITcwKxhebb0EHunY1bt0Qd4yZExrTHIW8/edit

Change-Id: Icf2106accfb1167124582466a3a55486d432793d
Reviewed-on: https://dart-review.googlesource.com/43062
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-03-07 11:01:57 +00:00
Natalie Weizenbaum 699f7bc1b1 Bring in the latest pub
Closes #32030

Bug: 32030
Change-Id: I349bfff94ebd2700f9950ed151da08c0becc9500
Reviewed-on: https://dart-review.googlesource.com/44022
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-02-27 23:49:46 +00:00
Lasse R.H. Nielsen 8d38d94ddb Add static list methods.
Change-Id: I40574d695826a3ed038c7c756ce980fae001325d
Reviewed-on: https://dart-review.googlesource.com/43040
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Peter von der Ahé <ahe@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-02-26 11:34:43 +00:00
Kevin Moore 696a8fcfa9 Changelog updates for SDK APIs through -dev.28
Excluding web-specific APIs – for now

Change-Id: I7a1c9b5550e1104d89dc1b338bc485e5324b5cc6
Reviewed-on: https://dart-review.googlesource.com/42889
Reviewed-by: Zach Anderson <zra@google.com>
2018-02-22 04:12:44 +00:00
Kevin Moore f5a8ac6c95 Update changelog entries for Dart 2 library changes
Includes async, cli, collection, convert, and core through -dev.28

Change-Id: I8b8769196e14a7d3952575edf1c79d54d8007523
Reviewed-on: https://dart-review.googlesource.com/42522
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-21 01:36:15 +00:00
Mike Fairhurst 4c402f06da Add void semantic changes to the changelog, as they are now.
Deliberately a bit vague so that it is compliant with various subtle
changes that could still occur. Also, some suggestions to help people
migrate mockito, broadened into more general advice.

Bug: 32117
Change-Id: I93ee5575e85a6fb5f7fc7d2c5806b237a19c0ce4
Reviewed-on: https://dart-review.googlesource.com/40505
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2018-02-12 02:15:58 +00:00
Lasse R.H. Nielsen f72e327df7 Add new Iterable/List/Set/Map changes to CHANGELOG.md.
Change-Id: I3486631d64f37fe66ee38c3f87dfd4e053bc7a30
Reviewed-on: https://dart-review.googlesource.com/39660
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-02-07 14:58:11 +00:00
Florian Loitsch 3b8e4d41a7 Reapply "Run async functions immediately."
Which was reverted in commit 032be73dbe.
Originally commited in commit 67bac0bce6.
Original review URL: https://dart-review.googlesource.com/5263

Change-Id: Ic7333c29e502a3924dc6aade8ffa46fc8aa5b04a
Reviewed-on: https://dart-review.googlesource.com/38120
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-02 15:50:16 +00:00
Florian Loitsch 032be73dbe Revert "Run async functions immediately."
This reverts commit 67bac0bce6.

Reason for revert: broke the bot.

Original change's description:
> Run async functions immediately.
> 
> Migrated from https://codereview.chromium.org/2478703003/
> 
> Change-Id: I1d678c01ba5876490b12c676c500171328361d31
> Reviewed-on: https://dart-review.googlesource.com/5263
> Commit-Queue: Florian Loitsch <floitsch@google.com>
> Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
> Reviewed-by: Vijay Menon <vsm@google.com>
> Reviewed-by: William Hesse <whesse@google.com>
> Reviewed-by: Martin Kustermann <kustermann@google.com>
> Reviewed-by: Régis Crelier <regis@google.com>

TBR=whesse@google.com,rnystrom@google.com,vegorov@google.com,kustermann@google.com,zra@google.com,floitsch@google.com,jmesserly@google.com,vsm@google.com,regis@google.com,sigmund@google.com

Change-Id: I20c948057423c3fa5aa8c72843f8f2a17e086ad5
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/37981
Reviewed-by: Florian Loitsch <floitsch@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-02-01 15:01:21 +00:00
Florian Loitsch 67bac0bce6 Run async functions immediately.
Migrated from https://codereview.chromium.org/2478703003/

Change-Id: I1d678c01ba5876490b12c676c500171328361d31
Reviewed-on: https://dart-review.googlesource.com/5263
Commit-Queue: Florian Loitsch <floitsch@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
2018-02-01 14:08:57 +00:00
Lasse Reichstein Holst Nielsen 0c18b643c6 Add RegExp.escape methods.
Fixes 4706

Bug: http://dartbug.com/4706
Change-Id: If635cb0eb7c20405ab0127a443fe51176191b5ad
Reviewed-on: https://dart-review.googlesource.com/35641
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-02-01 09:56:47 +00:00
Leaf Petersen 991753313f Remove deep future flattening from analyzer and DDC
Change-Id: Ic48f29adec3a46744b259ba5b2b8ad7d97caa6c2
Reviewed-on: https://dart-review.googlesource.com/37424
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-01-30 18:11:11 +00:00
Zachary Anderson c8f1af91a1 [dart:io] Update changelog for ProcessStartMode.INHERIT_STDIO
Change-Id: I917152a42c3054021047724d49624dcee77481dc
Reviewed-on: https://dart-review.googlesource.com/36565
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-01-24 16:39:57 +00:00
Alexander Markov 3c3c50e352 Add CHANGELOG entry for fixed-size integers in VM
Change-Id: I47fd1aef8765e927899cda164ed5a3764eaaf51c
Reviewed-on: https://dart-review.googlesource.com/36080
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2018-01-19 21:55:40 +00:00
Natalie Weizenbaum 1065b68388 Update the CHANGELOG to include the latest pub changes
Change-Id: Iacdf8023b6d4c429e1e709ef97c874da3a6c78ca
Reviewed-on: https://dart-review.googlesource.com/35814
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-01-19 01:01:24 +00:00
Zachary Anderson 9c40a7e662 Reland: [dart:cli] Adds waitFor(Future)
This is a reland of https://dart-review.googlesource.com/#/c/sdk/+/28920/
with the following changes:
- It creates a new library dart:cli
- waitFor(Future) goes in dart:cli instead of dart:io
- Removes a flaky test, and adds a missing precompiler entrypoint
- Adds waitFor(Future)
- Improves doc comments

fixes #31102

Change-Id: I04d2c46fd0afac049dd4fd1353905dc20da18f90
Reviewed-on: https://dart-review.googlesource.com/29449
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2018-01-18 16:38:54 +00:00
Natalie Weizenbaum ed431d5a61 Bring in the latest pub
Change-Id: I8d2d11394a07cd116147e2ae86f3326c85cfe0f7
Reviewed-on: https://dart-review.googlesource.com/33661
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Natalie Weizenbaum <nweiz@google.com>
2018-01-12 22:47:50 +00:00
Lasse R.H. Nielsen 4dd367c652 Fix return type of Base64Codec.decode to say Uint8List.
Update some documentation.

Change-Id: I4e05d89e84bd35068ca57917e752af235c62b647
Reviewed-on: https://dart-review.googlesource.com/32762
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-01-08 13:27:02 +00:00
Sam Rawlins a8de95a55a Update changelog with analyzer features
Change-Id: Ibf8f08d43bd84faad5fad10bf73996273175428b
Reviewed-on: https://dart-review.googlesource.com/32144
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2018-01-03 20:51:04 +00:00