Regis Crelier
8ca244ba27
Make finalization of recursive function types more robust, especially since
...
the Kernel frontend may omit the information that a function type is a typedef.
Re-enable several previously failing tests for dartk.
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2806893002 .
2017-04-10 11:06:14 -07:00
Dmitry Stefantsov
078847f2cc
Mark lib/async/stream_type_test with Pass
...
The fix 170bf10904
made the test pass.
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2808743003 .
2017-04-10 14:18:10 +02:00
Dmitry Stefantsov
4cac62b47c
Fix multitest lines in status files for strong-mode async libs
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2807103002 .
2017-04-10 11:30:58 +02:00
Dmitry Stefantsov
3ad84ed150
Mark tests in "tests/lib_strong" as not strong-mode ready
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2811593003 .
2017-04-10 10:36:02 +02:00
Jennifer Messerly
8ada796a86
fix #29233 , final fields can be settable in a mock
...
also fix #29273 , user mixins can override native methods
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2803673007 .
2017-04-07 14:12:49 -07:00
Vijay Menon
1975c8431a
Migrate async tests to strong
...
No modifications to the actual tests
R=rnystrom@google.com
Review-Url: https://codereview.chromium.org/2802973005 .
2017-04-07 12:46:12 -07:00
Peter von der Ahé
1e70fef1a2
Small steps towards deferred loading.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2803833003 .
2017-04-07 12:23:35 +02:00
Johnni Winther
97b19651a5
Extract ResolutionWorldBuilderBase from ElementResolutionWorldBuilder
...
This is a step towards reusing parts of ElementResolutionWorldBuilder
for kernel-based elements.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2804993002 .
2017-04-07 09:59:49 +02:00
Johnni Winther
12615de38f
Support dartk on Windows.
...
This adds tools/dartk_wrappers/dartk.bat. The --package argument is
deliberately relative because of issue 29284.
R=asgerf@google.com
Review-Url: https://codereview.chromium.org/2803973002 .
2017-04-07 09:31:10 +02:00
Johnni Winther
76737bb8ea
Register deferred load impact through ResolutionEnqueuerListener
...
This is a part of the work to decouple the backend from the used element model.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2800643002 .
2017-04-07 09:26:25 +02:00
Regis Crelier
b87f7ece72
Mark 2 tests as crashing in dartk debug mode.
...
Review-Url: https://codereview.chromium.org/2800043002 .
2017-04-06 18:04:12 -07:00
Stephen Adams
427ccea1b2
Test can pass if minification accidentally picks same name
...
Ideally, we should make all tests that use x.runtimeType.toString() use classes with longer names.
BUG=
Review-Url: https://codereview.chromium.org/2798263004 .
2017-04-06 17:33:32 -07:00
Vijay Menon
5c3bcff375
DDC fix for foreign futures
...
Fixes #29287
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2804113002 .
2017-04-06 14:52:59 -07:00
Konstantin Shcheglov
7cd782db6e
Issue 29186. Make several top-level variables explicitly 'dynamic'.
...
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/29186
Review-Url: https://codereview.chromium.org/2806543002 .
2017-04-06 10:57:39 -07:00
Stephen Adams
fe7baee848
Fix for type analysis bug in constructor with early return
...
TEST_28 is isomorphic to the original report.
BUG=
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2799763003 .
2017-04-06 09:11:34 -07:00
Johnni Winther
dff229736b
Skip most dart2js serialization tests.
...
These are very slow and are no longer a priority.
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2801853004 .
2017-04-06 15:15:45 +02:00
Peter von der Ahé
32e2d2af84
Handle const list and map literals.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2802693004 .
2017-04-06 14:51:35 +02:00
Peter von der Ahé
588857cae3
Restore status line for non-dart2js compilers.
...
Review-Url: https://codereview.chromium.org/2802003002 .
2017-04-06 14:46:17 +02:00
Peter von der Ahé
4e65f5d759
Update status file with dart2js crash.
...
Review-Url: https://codereview.chromium.org/2798313002 .
2017-04-06 13:44:53 +02:00
Peter von der Ahé
d515791312
Handle bad packages files and #void without crashing.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2804843003 .
2017-04-06 12:05:54 +02:00
Peter von der Ahé
0df001cebf
Implement various getters on DillMember.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2799783004 .
2017-04-06 10:54:48 +02:00
Peter von der Ahé
af30042973
Remove Pass expectations from Kernel status.
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2799733002 .
2017-04-06 10:06:03 +02:00
Stephen Adams
f36aaa72a8
dart2js: make dominator tree traversals nonrecursive
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2799603003 .
2017-04-05 13:13:31 -07:00
Jennifer Messerly
247fc68d21
fix #29228 , let* precedence should match generated expression
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2804833002 .
2017-04-05 12:40:42 -07:00
Vijay Menon
aa3fba7d8d
Preserve async markers when parsing js_ast
...
Fixes #29252
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2797873002 .
2017-04-05 12:13:22 -07:00
Emily Fortuna
b7b3714086
Reapply "Add "load from .dill" file capability and run a white-box test.""
...
This reverts commit 8febfff784
.
BUG=
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2797443008 .
2017-04-05 11:40:52 -07:00
Peter von der Ahé
b06e4d5754
Create separate scopes for constructors, setters, and other members.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2788153002 .
2017-04-05 16:07:32 +02:00
Peter von der Ahé
a8d08eaf4b
Make lines and columns one-based in SourceLocation.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2804613003 .
2017-04-05 15:19:05 +02:00
Florian Loitsch
167c7243c2
many_method_calls_test sometimes passes.
...
Review-Url: https://codereview.chromium.org/2796373002 .
2017-04-05 15:03:02 +02:00
Peter von der Ahé
ddda182957
Add Source.getTextLine and use it to display source snippets in error messages.
...
R=asgerf@google.com , johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2788373002 .
2017-04-05 15:02:49 +02:00
Johnni Winther
5553b600e0
Split MirrorsData methods and MirrorsDataImpl data by element kind.
...
This is a step towards making MirrorsData(Impl) reusable for kernel
based elements.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2791263005 .
2017-04-05 09:06:05 +02:00
Stephen Adams
6ce24eeb23
Update dart2js status
...
Some tests no longer crash after removing recursion.
TBR=efortuna@google.com
BUG=
Review-Url: https://codereview.chromium.org/2800593002 .
2017-04-04 20:10:06 -07:00
Emily Fortuna
8febfff784
Revert "Add "load from .dill" file capability and run a white-box test."
...
This reverts commit 310532ab50
.
TBR=sra@google.com
BUG=
Review-Url: https://codereview.chromium.org/2795763005 .
2017-04-04 17:40:10 -07:00
Emily Fortuna
310532ab50
Add "load from .dill" file capability and run a white-box test.
...
The dill_loader_test is rather intrusive and I look forward to rewriting it once we have the Entity model spread throughout the compiler rather than Elements.
BUG=
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2798443002 .
2017-04-04 16:22:14 -07:00
Zachary Anderson
8c9c54d833
[dart:io] Don't close stdin with a socket finalizer
...
If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.
Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.
See also: https://github.com/dart-lang/test/issues/583
fixes #29229
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2791423002 .
2017-04-04 13:57:42 -07:00
Peter von der Ahé
bfc4039d54
Special scope for labelled statements.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2790923002 .
2017-04-04 14:29:25 +02:00
Peter von der Ahé
7f9ec1b639
standalone/verbose_gc_to_bmu_test no longer fails on Kernel.
...
Review-Url: https://codereview.chromium.org/2797623004 .
2017-04-04 13:08:31 +02:00
Peter von der Ahé
a0b58622d7
Handle unresolved identifiers with an accessor.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2790743004 .
2017-04-04 12:43:21 +02:00
Peter von der Ahé
4827ac4f38
Remove references to renamed test.
...
R=jmesserly@google.com
Review-Url: https://codereview.chromium.org/2790893002 .
2017-04-04 09:51:29 +02:00
Peter von der Ahé
a2e79d87cd
Fix typo in bug number.
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2784133003 .
2017-04-04 09:50:15 +02:00
Peter von der Ahé
2155fb6f6c
Update status for Dartium.
...
Review-Url: https://codereview.chromium.org/2795973002 .
2017-04-04 09:31:51 +02:00
Peter von der Ahé
2b27805f07
Change test to match issue 19725.
...
R=johnniwinther@google.com , regis@google.com , vegorov@google.com
Review-Url: https://codereview.chromium.org/2781273003 .
2017-04-04 08:20:17 +02:00
Siva Annamalai
c53e020e6c
Adjust status files to account for running the Dart test cases through flutter engine on linux.
...
Accounted for language, co19, lib, corelib, isolate and standalone tests.
Filed issues to track all failing tests
https://github.com/flutter/flutter/issues/9109
https://github.com/flutter/flutter/issues/9110
https://github.com/flutter/flutter/issues/9111
https://github.com/flutter/flutter/issues/9113
https://github.com/flutter/flutter/issues/9114
https://github.com/flutter/flutter/issues/9115
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2784293003 .
2017-04-03 16:35:09 -07:00
Martin Kustermann
d8e291cb89
[kernel] vm: Fix a few issues in the kernel flow graph builder, update status file for checked-mode
...
R=vegorov@google.com
Review-Url: https://codereview.chromium.org/2792033002 .
2017-04-03 19:47:01 +02:00
Vyacheslav Egorov
41b5d7c6de
VM: Fix incorrect canonicalization rule for UnboxedIntConverterInstr
.
...
The rule assumed that `UnboxedIntConverter(U->V, UnboxedIntConverter(V->U, v))` is
equal to `v` which is incorrect if the first convertion is truncating and
V is a larger representation (Mint) than U (Int32 or Uint32).
Now canonicalization rule takes into account if the first convertion is
truncating and does not try to short-circuit such convertions.
Fixes https://github.com/dart-lang/sdk/issues/29137
R=kustermann@google.com
BUG=http://dartbug.com/29137
Review-Url: https://codereview.chromium.org/2793003002 .
2017-04-03 18:51:04 +02:00
Jacob Richman
509bcd58e1
Fix type checks and display for JS interop types.
...
Re-enable formatter test that had been disabled when someone changed type
name display for Foo<dynamic> types.
Fix bug in how type names were displayed for JS interop types.
BUG=
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2789663005 .
2017-04-03 08:34:20 -07:00
Peter von der Ahé
38f398281d
Mark tests as slow.
...
Review-Url: https://codereview.chromium.org/2791283002 .
2017-04-03 16:54:20 +02:00
Peter von der Ahé
5bdc1199ca
Fix dart2js warnings and add test to ensure it stays clean.
...
Filed https://github.com/dart-lang/sdk/issues/29224 to track all the problems that require ignore.
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2791993002 .
2017-04-03 15:08:40 +02:00
Johnni Winther
9fd5ae5b81
Use entities in NativeResolutionEnqueuer and make it reusable for kernel
...
This is step towards computing closed world directly from kernel.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2786593004 .
2017-04-03 10:33:21 +02:00
Johnni Winther
23999a0f1e
Use entities in NoSuchMethodRegistry
...
This prepares for a kernel based implementation of NoSuchMethodResolver.
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2777093010 .
2017-04-03 10:26:53 +02:00