Commit graph

44 commits

Author SHA1 Message Date
Stephen Adams
f1e6092dd8 [dart2js] More shared_messages.dart cleanup
- Remove references to deleted file.
- Remove message that is unreachable in kernel.

Change-Id: I5fe772a3a6fbd00b31d085f10c47d63778a64217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214071
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2021-09-22 19:20:54 +00:00
Konstantin Shcheglov
78d9ce7820 Add myself to watch for tools/experimental_features.yaml changes.
Change-Id: I72ab91bde46b9b6181801c4ab0bfd591aabeddbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192047
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-03-19 18:09:38 +00:00
Keerti Parthasarathy
98d6994a35 Remove keertip@ from watchlists for build changes
Change-Id: I07fe96c5b65615b5c193d78df8ac551d547e9bc5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/190780
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Keerti Parthasarathy <keertip@google.com>
2021-03-11 21:45:41 +00:00
Sigmund Cherem
912005267d [web] rename suite dart2js -> web.
Change-Id: I46be49b2effec3e38a3dc44cd45cfe736f77fa78
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182680
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Joshua Litt <joshualitt@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2021-02-04 23:11:32 +00:00
Joshua Litt
66c1b51c07 [dart2js] 20 dart2js tests ported to nnbd #1.
Change-Id: I8cb1bb03655762669ac88775b5aee763e79c4b11
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152594
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Joshua Litt <joshualitt@google.com>
2020-06-26 15:21:42 +00:00
Joshua Litt
d14ab0779a [dartdevc] Migrate tests/compiler/dartdevc_native to tests/dartdevc_2.
Change-Id: I9c486f29f3bcf8a6ecf481eb25ea61d0468049b2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150667
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
2020-06-17 18:14:00 +00:00
Leaf Petersen
d44457f79d [Core Libraries] Eliminate the fork in the core libraries.
Move the nnbd core libraries from sdk_nnbd to sdk, and updates
references in build files and elsewhere accordingly.

Change-Id: I09760fe1e006657aacdfe80f3b22fdf6f7e30a9f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151121
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2020-06-16 23:37:36 +00:00
Sigmund Cherem
70f228db5e [web] change watchlists to cc team emails instead of individuals
Change-Id: Ibba6756340c8f9f665e0c44536a2d851ff785e08
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145443
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2020-05-14 04:40:47 +00:00
Alexander Markov
e520daf81a Update pkg/vm patterns so pkg/vm_service doesn't match them
Change-Id: Ic5298fcedab2214e82c9ef548ba7e7f61b38a2bd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/142202
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-04-02 18:46:15 +00:00
Johnni Winther
e911747e33 [WATCHLISTS] Remove johnniwinther@ from dart2js watchlist
Change-Id: I91d35f8cd2bbf915a6262d1af8f80d597422829c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140280
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2020-03-20 15:25:59 +00:00
Mayank Patke
94c031c56f [WATCHLISTS] Add joshualitt@ to dart2js watchlist.
Change-Id: I40b880c3a2e3d6f4bf280daeceafc62c38ac934d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/137463
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-02-28 18:41:45 +00:00
Mayank Patke
6a2a20207a Auto-CC dart2js on changes to the js_runtime sdk.
Change-Id: I7662aa60eb8326e19bc38fa7f6094581d4aa74c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/116893
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-09-12 18:17:38 +00:00
Karl Klose
974bee0934 Remove karlklose@ from kernel watchlist
Change-Id: Id21970c447355fa84918c24fa6ede1c22837b003
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/112394
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2019-08-13 12:14:23 +00:00
Jens Johansen
a408e8ee97 Remove Kevin from kernel watchlist
Change-Id: I6154eb51ab4264646b8d9ec322e914e1842161ae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111724
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2019-08-02 09:31:26 +00:00
Mayank Patke
68ba8f9198 [WATCHLISTS] Don't CC dart2js on tests/compiler/dartdevc_native.
Change-Id: Ibd4c56df154a718717605b322e06d9545d57df01
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/109982
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2019-07-22 23:52:18 +00:00
Mayank Patke
bd179a2660 Add fishythefish@ to dart2js watchlist.
Change-Id: I13b070a9f606551da979bdb5ee6a189e0dd291a5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/106432
Auto-Submit: Mayank Patke <fishythefish@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2019-06-18 02:36:48 +00:00
Zach Anderson
2d5e82bb7a [watchlists] Remove zra from watchlists
https://media.giphy.com/media/11F0d3IVhQbreE/giphy.gif

Change-Id: I7da5ed7bd17083473817f341a8f4768465441efb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/101627
Commit-Queue: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Auto-Submit: Zach Anderson <zra@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2019-05-07 21:01:50 +00:00
Ryan Macnak
b3e5be7a0a Remove from WATCHLISTS.
Change-Id: I7d2d91e7bc47e78a15e6094cf6ab036bffac3b46
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/99209
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2019-04-11 23:37:04 +00:00
Ben Konyi
15b11b0183 [ VM / Service / Observatory ] The VM service now requires an authentication code by default.
Previously, a valid web socket connection would use the following URI:

`ws://127.0.0.1/ws`

Now, by default, the VM service requires a connection to be made with a
URI similar to the following:

`ws://127.0.0.1:8181/Ug_U0QVsqFs=/ws`

where `Ug_U0QVsqFs` is an authentication code generated and shared by the
service.

This behavior can be disabled with the `--disable-service-auth-codes`
flag.

Change-Id: I288aac58e3ba9d35dca8071f3f7e7a073896c271
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/98433
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2019-04-09 22:57:29 +00:00
Vyacheslav Egorov
1cc8f36da2 [vm/compiler] Add VM Compiler Team WATCHLIST
Change-Id: I5e6273bf6ab3d18276e46587296ba31a9768089c
Reviewed-on: https://dart-review.googlesource.com/c/85164
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-11-23 10:24:02 +00:00
Vyacheslav Egorov
064a7d89ce [vm/compiler] Add VM Compiler Team WATCHLIST
Change-Id: I14d1c65d436e158903c439c952b20104d0393302
Reviewed-on: https://dart-review.googlesource.com/c/84900
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
2018-11-20 15:06:59 +00:00
Sigmund Cherem
3f2251986d CC sra also in changes to compiler files and tests
Change-Id: Ia1bae3f67c73a92fd06327836016becc16ba8bf9
Reviewed-on: https://dart-review.googlesource.com/67660
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-31 18:27:19 +00:00
Sigmund Cherem
76c920559b Add watcher to be cc'd on changes in pkg/compiler or tests/compiler
Change-Id: Ib8a1f7e21c29aadaf5e9e1927c93e3a319aca3dc
Reviewed-on: https://dart-review.googlesource.com/65781
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2018-07-20 22:04:55 +00:00
Alexander Markov
53963bc630 Update WATCHLISTS to get notifications about changes in kernel and pkg/vm
Change-Id: I1f8d0a739ade56810d29a3cf58dc619f5938b77b
Reviewed-on: https://dart-review.googlesource.com/59360
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2018-06-11 18:29:29 +00:00
Zachary Anderson
b19716a648 Creates a watchlist for sdk/lib/_http and adds me to it
Starting to move these files over to package:http_io and
package:web_socket.
Change-Id: I04ee0fc2950f5aca96494b990a334dac16de9deb
Reviewed-on: https://dart-review.googlesource.com/31744
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-01-02 18:39:53 +00:00
Zachary Anderson
f09c86d0d5 Remove turnidge@ from WATCHLISTS =(
Change-Id: I958446e963e03a1145be108c44be4d82a23ac1f5
Reviewed-on: https://dart-review.googlesource.com/18242
Reviewed-by: Siva Annamalai <asiva@google.com>
2017-11-02 16:53:10 +00:00
keertip
e1ec23aaea Adding myself to watchlist for build files
Bug:
Change-Id: I8b7a9584d9d34500b75a1ddadc9e9e4ec4265531
Reviewed-on: https://dart-review.googlesource.com/15720
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-23 14:59:03 +00:00
Karl Klose
b34a107371 Add WATCHLISTS entry for pkg/kernel
R=dmitryas@google.com

Change-Id: Iafa7071a74ed40aae48887c460b5b5efcf1c8c5d
Reviewed-on: https://dart-review.googlesource.com/13721
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
2017-10-13 11:15:13 +00:00
Ryan Macnak
8ab98bd6aa [infra] Add mirrors WATCHLIST.
R=zra@google.com

Review-Url: https://codereview.chromium.org/2995633002 .
2017-08-08 12:30:01 -07:00
Ryan Macnak
e9eeb1a070 [infra] Fix Observatory watchlist.
TBR=zra@google.com

Review-Url: https://codereview.chromium.org/2935873004 .
2017-06-13 16:21:35 -07:00
Zachary Anderson
4b87a09c6f [infra] Add watchlist for build files. Clean up WATCHLISTS a bit
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2932323004 .
2017-06-13 13:45:15 -07:00
John McCutchan
ed821439ba Remove johnmccutchan from observatory watchlist 2017-05-19 07:56:54 -07:00
Peter von der Ahé
0c9c069066 Add more diagnostics to UX watch list.
R=karlklose@google.com, lukechurch@google.com

Review-Url: https://codereview.chromium.org/2801253002 .
2017-04-18 14:51:00 +02:00
Peter von der Ahé
c7093700c4 Create watch list for messages.yaml.
R=lukechurch@google.com

Review-Url: https://codereview.chromium.org/2790643002 .
2017-04-04 08:06:29 +02:00
Peter von der Ahé
6684a7845c Configure watch list for pkg/front_end.
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2723453002 .
2017-02-27 12:59:50 +01:00
Rico Wind
8b06d881d6 Remove tools directory from WATCHLISTS
R=whesse@google.com
BUG=

Review URL: https://codereview.chromium.org/1700963002 .
2016-02-16 14:30:06 +01:00
Florian Schneider
d8450eb63a Fix to WATCHLISTS.
Avoid flooding vm-dev@ with unrelated emails.

BUG=
R=whesse@google.com

Review URL: https://codereview.chromium.org//1367923003 .
2015-09-24 12:47:20 +02:00
John McCutchan
6c2fed747d Add more Observatory related paths to WATCHLISTS and add rmacnak@
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//1229463002.
2015-07-06 15:33:58 -07:00
johnmccutchan@google.com
261200c587 Build Observatory as part of runtime
Relanding https://codereview.chromium.org/810623005/

Review URL: https://codereview.chromium.org//837723004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42645 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 21:59:42 +00:00
whesse@google.com
aa5a986d5d Revert "Build Observatory with runtime"
This reverts commit 76df7b3c1bf83c08d3994d61df4c9c530fadb4e5.
This commit breaks dartium compilation.

BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//839543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42619 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-06 10:07:58 +00:00
johnmccutchan@google.com
9d6ac72b46 1) Remove prebuilt Observatory sources
2) Move observatory from runtime/bin/vmservice/observatory to runtime/observatory

3) Add two tools scripts:
- tools/run_pub.py (runs pub before SDK is built)
- tools/obs_tool.py (helper for get, build, and deploy stages)

4) Build Observatory with runtime:
- pub get --offline
- pub build
- deploy

5) Build artifacts are now in standard output directory, for example, out/DebugIA32/observatory.

6) Add a new 'dart_boostrap' host target (no snapshot, no observatory) that can be used as the Dart executable to run pub when building Observatory. This is behind a build.py flag --use-bootstrap-for-observatory because:

- It is only necessary on older Linux distributions that are incompatible with the prebuilt Dart testing executable.
- running pub build with the boostrap Debug build is significantly slower.

7) Detect if the prebuilt executable doesn't work and automatically switch to the 'dart_bootstrap' executable. Also, warn the user and provide a Wiki link with more information.

R=turnidge@google.com

Review URL: https://codereview.chromium.org//810623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42614 260f80e4-7a28-3924-810f-c04153c831b5
2015-01-05 21:26:52 +00:00
johnmccutchan@google.com
fe9a381dbe Update WATCHLISTS for Observatory
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org//196373002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33623 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-12 23:09:53 +00:00
ricow@google.com
648f9e011c Add ricow@ to the watchlist of tools/
R=whesse@google.com

Review URL: https://codereview.chromium.org//176883014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@33204 260f80e4-7a28-3924-810f-c04153c831b5
2014-03-03 10:38:42 +00:00
fschneider@google.com
993e6b6417 Add WATCHLISTS file.
This CL adds a watcher for the runtime/ directory. Whenever
a file in runtime/ is affected, the CC list of the CL will
have vm-dev@ added.

R=ricow@google.com

Review URL: https://codereview.chromium.org//22999006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@26177 260f80e4-7a28-3924-810f-c04153c831b5
2013-08-15 09:25:23 +00:00