Commit graph

1466 commits

Author SHA1 Message Date
Ben Konyi ef0e4ea107 [ VM / DDS / CLI ] Add DevTools support to the standalone VM
Example output on stdout when DevTools is enabled:

Observatory listening on http://127.0.0.1:8181/CzkZzZaONW4=/
The Dart DevTools debugger and profiler is available at: http://127.0.0.1:8181/devtools/#/?uri=ws%3A%2F%2F127.0.0.1%3A8181%2FCzkZzZaONW4%3D%2Fws
hello world!

vm-service: isolate(1674461414267555)  'main' has no debugger attached and is paused at exit.  Connect to Observatory at http://127.0.0.1:8181/CzkZzZaONW4=/ to debug.

TEST=pkg/dartdev/test/commands/run_test.dart

Change-Id: Icd1afda87ad4a46f228125d53094d10adf8056ec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/188361
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2021-05-03 18:24:09 +00:00
Alexander Thomas fa7d56e7fb [sdk] Update checked-in SDKs to 2.13.0-211.14.beta
The previous attempt to upgrade to `2.13.0-211.13.beta` was reverted:
https://github.com/flutter/flutter/issues/81335

Change-Id: Ia358fc2ec4fed3a9b8e3f85cd70a74801298ebc9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197721
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-05-03 12:14:58 +00:00
Nate Bosch f006b75ed0 Update to the latest package:http
Change-Id: I24598f4cce30d3e1dfa775e05fbed0fb8f32bb76
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197584
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2021-05-01 00:00:16 +00:00
Nate Bosch 0d64a90d2b Update to the latest http_multi_server
Change-Id: I829bf74944d8340e439b5c45554714647b82e539
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197581
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-30 20:23:16 +00:00
Nate Bosch a3629633eb Update to the latest web_socket_channel
Change-Id: I2a59513f34fac4137c9dc669d156c045ed91216e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197563
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-30 18:36:16 +00:00
Nate Bosch 4f5b72cf76 Update to the latest package:async
Change-Id: I368aea9d01541212fe359a6d91daa945ad9a370e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197446
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Gary Roumanis <grouma@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-04-30 16:42:16 +00:00
Nate Bosch 8488b37aae Update to the latest package:test
Change-Id: I0877954a967df22c76ef0d232f9985da07862118
TEST=No added tests for package roll
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197440
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-30 00:19:05 +00:00
Alexander Aprelev 5af7f465b5 Revert "[sdk] Update checked-in SDKs to 2.13.0-211.13.beta"
This reverts commit 0c9078756a as it
breaks analyzer exclude file paths handline.

Issue https://github.com/flutter/flutter/issues/81335

Change-Id: I23baa202f902def4eda7638eb105f9a5e8a1227c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197113
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2021-04-28 14:43:48 +00:00
Nate Bosch 1dedeffc4c Update to the latest package:http
Change-Id: I99368077f04208dac0e9b64feb78eccd2a03ddaa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197112
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Gary Roumanis <grouma@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-04-28 01:42:32 +00:00
Nate Bosch 4be6c04ae5 Update to the latest package:async
Change-Id: Id8603f7be61c0ae394f2c3881658819bec1428e0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197105
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-28 00:05:52 +00:00
pq 513c1a1c7e Reland "linter 1.4.0"
This is a reland of 17644eea39

Additional supporting changes in flutter (and plugins):

https://github.com/flutter/flutter/pull/81017
https://github.com/flutter/plugins/pull/3823
https://github.com/flutter/flutter/pull/80817
https://github.com/flutter/flutter/pull/80901
https://github.com/flutter/flutter/pull/81210

Additional context in meta linter issue: https://github.com/dart-lang/linter/issues/2609





Original change's description:
> linter 1.4.0
>
> Mitigating PRs:
>
> https://dart-review.googlesource.com/c/sdk/+/196223
> https://dart-review.googlesource.com/c/sdk/+/196180
>
> https://github.com/flutter/flutter/pull/80817
> https://github.com/flutter/flutter/pull/80901
>
>
>
>
>
> Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

Change-Id: Ie6b9682a2f54ef039dd7ac9c6a46cb925615acef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196581
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2021-04-27 23:53:52 +00:00
Alexander Thomas 0c9078756a [sdk] Update checked-in SDKs to 2.13.0-211.13.beta
Change-Id: I543cee3c7a70816526a0fa9ed1bcc7e7d127804c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197041
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-27 07:34:08 +00:00
Alexander Thomas 17a1c13fdf [co19] Roll co19 to 13f010c4047c4c7d52afe67ecc57ebc415ea4ea8
2021-04-22 sgrekhov@unipro.ru 993. Wrong annotation tests added
2021-04-22 sgrekhov@unipro.ru 993. Packed tests added
2021-04-21 irina.arkhipets@gmail.com Issue 1081: Missing Issue tags added to the tests.
2021-04-21 sgrekhov@unipro.ru Fixes 1004. Add tests that confirms that tight-looped isolate is not killed with Isolate.beforeNextEvent priority
2021-04-20 sgrekhov@unipro.ru Fixes 1078. Expect an error in case of cyclic initialization

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,analyzer-nnbd-mac-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I04d6af2bcf7fd436082f460d9b91c22f7a1f1255
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/197040
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-27 07:29:00 +00:00
Nate Bosch 90c309e9e4 Upgrade to null safe migrated json_rpc_2
Change-Id: I05c7dc4c266c7351f044f1e423922c01d05e96e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196563
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-04-24 01:11:42 +00:00
Martin Kustermann b3c0b58e93 Revert "linter 1.4.0"
This reverts commit 17644eea39.

Reason for revert: This caused various failures in HHH configuration
which is an early warning that dart-lang/sdk -> flutter/{engine,flutter}
rolls will not work smoothly.

See more information in go/dartvm-gardening-log for various failures
this causes.

Original change's description:
> linter 1.4.0
>
> Mitigating PRs:
>
> https://dart-review.googlesource.com/c/sdk/+/196223
> https://dart-review.googlesource.com/c/sdk/+/196180
>
> https://github.com/flutter/flutter/pull/80817
> https://github.com/flutter/flutter/pull/80901
>
>
>
>
>
> Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026
> Commit-Queue: Phil Quitslund <pquitslund@google.com>
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>

TBR=brianwilkerson@google.com,pquitslund@google.com,davidmorgan@google.com

Change-Id: I15af9de53d98de7b65902a015bef7ac2d368abeb
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196499
Reviewed-by: Martin Kustermann <kustermann@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2021-04-23 12:08:02 +00:00
Nate Bosch d261ccfbb0 Update to the latest package:shelf
Change-Id: Ic24e358bd755c8c760e223354132a50a128204f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196620
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Jonah Williams <jonahwilliams@google.com>
Reviewed-by: Jonah Williams <jonahwilliams@google.com>
2021-04-23 05:54:41 +00:00
pq 17644eea39 linter 1.4.0
Mitigating PRs:

https://dart-review.googlesource.com/c/sdk/+/196223
https://dart-review.googlesource.com/c/sdk/+/196180

https://github.com/flutter/flutter/pull/80817
https://github.com/flutter/flutter/pull/80901





Change-Id: Ib916d541076e24b9e8db1d6120dbc043d9e40b87
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196026
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2021-04-22 20:41:26 +00:00
Alexander Thomas 9ddfcd745f [infra] Upgrade jsshell to 88.0
* Use cipd for jsshell.
* Add script to update jsshell.
* Add new CIPD namespace, with access rights for some web team members.
* Add a copy of the new package to the old location (b/186078239).

Change-Id: I0169d077af6b0d5119fe8545272ca1df1596558f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196324
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-22 08:37:56 +00:00
Alexander Thomas 0a87379622 [co19] Roll co19 to 8c5fea8a51cf8c35724ddf136248350bb307d344
2021-04-20 irina.arkhipets@gmail.com Fixes 996: new tests for i-2-b and least-and-greatest-closures added.
2021-04-20 sgrekhov@unipro.ru Status files checker. Error processing improved
2021-04-19 sgrekhov@unipro.ru Status files checker. Small updates. Working version
2021-04-16 sgrekhov@unipro.ru Status files checker. Initial commit
2021-04-16 irina.arkhipets@gmail.com Addition for the Issue 534: checked constant variables are moved into main function.
2021-04-16 irina.arkhipets@gmail.com Fixes 1080: comments and more test cases added.
2021-04-15 irina.arkhipets@gmail.com Issue 1080: error in parameter name fixed.
2021-04-15 sgrekhov@unipro.ru Fixed typo which broke the test
2021-04-13 irina.arkhipets@gmail.com Fixes 1077: test corrected
2021-04-13 irina.arkhipets@gmail.com Fixes 1076: test expectation corrected.
2021-04-13 irina.arkhipets@gmail.com Fixes 1075: test expectation corrected.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Icff306da85e8c41cd9cd6406ed10d586fea0ddde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195985
Reviewed-by: William Hesse <whesse@google.com>
2021-04-20 13:36:39 +00:00
Nate Bosch 37446a245a Update to the latest package:async
Adds `ChunkedStreamReader`.

Change-Id: Iad0a4b26ee9ce2ed9aeb5cec55c81bdb39e8c4e2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195663
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2021-04-16 21:47:17 +00:00
Alexander Thomas b5c63ce757 [infra] Migrate scripts to python3
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.

Fixes: https://github.com/dart-lang/sdk/issues/28793

TEST=Manually tested common user journeys.

Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2021-04-15 10:10:20 +00:00
William Hesse 2eef08eb95 [infra] Make download of jsshell conditional
The jsshell is used rarely for benchmarking and testing.
Make download of it conditional, at least until it is uploaded
and moved to CPID, to help migration to python3.

To download the shell in a checkout, add
"checkout_javascript_engines": True
to the "custom_vars" in a .gclient solution.

Change-Id: I693a4b402ffebca28d94c124624c4bd897315818
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195261
Reviewed-by: Alexander Thomas <athom@google.com>
2021-04-14 11:16:16 +00:00
Nate Bosch 17bac2f180 Update to the latest http_throttle
Change-Id: I3631b294de8aee0ae1430eb0d1c5c90641fcd363
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195171
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-04-14 00:43:54 +00:00
pq fc03431d44 linter 1.3.0
Change-Id: Iac54e6cb25445d8e3d03f6575d2b821051442f48
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195052
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2021-04-13 23:10:38 +00:00
Nate Bosch 837d632617 Update to the latest package:http
Add a `retry` library to replace `http_retry`. We will be able to remove
`http_retry` from the SDK after `http` is published and the usage is
migrated in `pub`.

Change-Id: Id39674d08388ada6406c85d1263494c3d7cbe720
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195168
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-04-13 19:19:28 +00:00
Alexander Thomas e1eb9d1c7f [co19] Roll co19 to 65d887eaa99f45e0bd5320ae7ef247eb8d4a264f
2021-04-13 sgrekhov@unipro.ru Fixes 1073. Wait for isolate start before pausing it (1074)
2021-04-12 irina.arkhipets@gmail.com MMore fixes for 1057: test expectation corrected, Issue tags added.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try
Change-Id: I6ed26b930881df5bbac16b3aa6b4f41cddaf8452
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195070
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-04-13 11:49:17 +00:00
Nate Bosch 8b62d2dda7 Update to the latest http_multi_server
Adds a static bindSecure method.

Change-Id: Ibde1a077a3ab1aff6db81646ca055050af353d54
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195054
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Gary Roumanis <grouma@google.com>
2021-04-13 04:11:11 +00:00
Gary Roumanis 62fb824ea2 Rev http_multi_server version
sync


Update http_multi_server version

Change-Id: I486dd49dbbfa9c45476094e6512d84bd3f896cf8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/195051
Auto-Submit: Gary Roumanis <grouma@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2021-04-12 23:08:46 +00:00
Alexander Thomas 0b816ed13f [co19] Roll co19 to 42fe3fd9d6eb66702604dc38f4deca66245ee974
2021-04-12 irina.arkhipets@gmail.com Fixes #1071: test expectation corrected.
2021-04-09 sgrekhov@unipro.ru Fixes #1072. Remove excessive @compile-error
2021-04-08 sgrekhov@unipro.ru Allow both 254 and 255 result codes on Windows
2021-04-08 irina.arkhipets@gmail.com Fixes #1070: tests expectations corrected.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: Iccec27cb0050da7979b471d6a1bd63cbc4656220
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194785
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2021-04-12 08:14:42 +00:00
Robert Nystrom c8b3fb1e71 Roll dart_style to the new 2.0.1.
The reverts the change to flatted nested conditional expressions since
audience reaction to that was pretty negative.

See: https://github.com/dart-lang/dart_style/pull/1019
Change-Id: Ie9e4460f75c5b7e99e5a6d60e9c38b50ba0bc44a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194883
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2021-04-10 00:37:53 +00:00
Alexander Thomas 37700c4314 [co19] Roll co19_2 to f7f583366396cb1457e58c9bfb6d6e53dc21d741
2021-03-29 sgrekhov@unipro.ru Fixes 1052. Typos in tests fixed
2021-03-29 sgrekhov@unipro.ru Fixes 1051. Fix invalid use of null in different expressions

Change-Id: Ibdf603c1ff556a328bdeb7e0af2a323bbcb6bf07
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194720
Reviewed-by: William Hesse <whesse@google.com>
2021-04-09 11:49:32 +00:00
Alexander Thomas 4a6a92e8e5 [co19] Roll co19 to 812ab751c41fe8d706fd1e4aae62d2dea2887ac2
2021-04-07 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added.
2021-04-07 sgrekhov@unipro.ru Fixes #1068. Remove excessive - in a SharedOptions
2021-04-05 irina.arkhipets@gmail.com Fixes #535: more nnbd tests for constant evaluation added.
2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added.
2021-04-05 irina.arkhipets@gmail.com Fixes #996: more tests added.
2021-04-05 irina.arkhipets@gmail.com Fixes #1067: added checks for old and new dart versions.
2021-04-05 irina.arkhipets@gmail.com Fixes #1066: added @dart=2.12 to the initial version of the test, new test which checks recent dart behavior added.
2021-04-05 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-02 sgrekhov@unipro.ru Fixes #1062. Remove unnecessary assignment
2021-04-01 irina.arkhipets@gmail.com Fixes #1057: Expected result doe the tests with mailformed types updated.
2021-04-01 sgrekhov@unipro.ru Expected error code is fixed for Windows
2021-04-01 sgrekhov@unipro.ru Fixes #1060. Expected error message position updated
2021-04-01 sgrekhov@unipro.ru Fixes #1059. Expected error message updated
2021-04-01 sgrekhov@unipro.ru Fixes #1024. Adjust expected results for web platforms
2021-04-01 sgrekhov@unipro.ru #993. More Array tests added
2021-03-31 58489007+franklinyow@users.noreply.github.com Update LICENSE
2021-03-31 sgrekhov@unipro.ru #993. Array tests added
2021-03-31 irina.arkhipets@gmail.com Issue #1053: Missing Issue tag added, test expectation updated.
2021-03-30 irina.arkhipets@gmail.com Fixes #1054: Updated expectations for mailformed raw type variables.
2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Updated expectations for mailformed raw type variables.
2021-03-30 irina.arkhipets@gmail.com Fixes #1050: Got rid of mailformed row type variable usage in i-2-b- tests.
2021-03-29 sgrekhov@unipro.ru Fixes #1043. Remove static warning as an expected result
2021-03-29 irina.arkhipets@gmail.com Fixes #1049: Correct expectation adjusted
2021-03-29 sgrekhov@unipro.ru Fixes #1048. Move tests to correct folder and change the description
2021-03-29 irina.arkhipets@gmail.com Fixes #1046: Test adjusted to work with the generic metadata feature enabled.
2021-03-29 sgrekhov@unipro.ru Fixes #1047. Change expected result to not to fail on JavaScript configurations
2021-03-29 sgrekhov@unipro.ru Fixes #1044. Change expected result to not to fail on JavaScript configurations
2021-03-26 irina.arkhipets@gmail.com Fixes #1029: Missing Issue tag added to the test.
2021-03-26 sgrekhov@unipro.ru Fixes #1042. Add check that produces different results for triple and double shifts
2021-03-26 sgrekhov@unipro.ru Fixes #1042. Fix built-in_types_t11.dart to expect correct results
2021-03-25 sgrekhov@unipro.ru Fixes #1019. Don't use type aliases in legacy libraries
2021-03-25 irina.arkhipets@gmail.com Fixes #1039: Old-style aliases corrected.
2021-03-25 sgrekhov@unipro.ru Fixes #988. Expect static type warning in a right way
2021-03-24 irina.arkhipets@gmail.com Issues #1029: Static expectation corrected.
2021-03-24 irina.arkhipets@gmail.com Issues #1035: Issue tag for the bug 45443 added.
2021-03-24 irina.arkhipets@gmail.com Merge branch 'master' of https://github.com/dart-lang/co19
2021-03-24 sgrekhov@unipro.ru #1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior
2021-03-23 sgrekhov@unipro.ru #1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 sgrekhov@unipro.ru Fixes #1034. Missed experimental flag added
2021-03-23 sgrekhov@unipro.ru #1033. Perform runtime check on big values for non-JavaScript configurations only
2021-03-23 irina.arkhipets@gmail.com Issues #1029: co19/Language/Generics/Superbounded_types/typedef3_A01_t06/02 corrected and does not expect a compile error now.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I5fae01c7b48aba502da04638430f4f6de79ac745
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194241
Reviewed-by: William Hesse <whesse@google.com>
2021-04-07 10:51:56 +00:00
Johnni Winther f0ccceab4d Roll dart_style 2.0.1 into the SDK.
This pins to https://github.com/dart-lang/dart_style/pull/1016.

Change-Id: Ia7b297a03eff00c68bf76bbfd206cf88d800a92c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193961
Reviewed-by: Jens Johansen <jensj@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
2021-04-06 14:32:37 +00:00
Alexander Thomas b7b8863859 [co19] Roll co19_2 to 3642f24e2e6273c6fb65a8f60cd0edc95153942e
2021-03-25 sgrekhov@unipro.ru 1037. A couple of tests that still use nonfunction-type-aliases removed from co19_2 repository
2021-03-24 sgrekhov@unipro.ru 1023. Change SplayTreeMap and SplayTreeSet tests according to the new behavior

Change-Id: Ia8ea48c30b05765bc03cd5a9ee8bb8ad9336e6ba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193300
Reviewed-by: Erik Ernst <eernst@google.com>
2021-04-06 07:16:03 +00:00
Janice Collins 6cacbb2bf0 Update dartdoc to 0.42.0.
Also removes the mustache dependency from the SDK.

Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v0.42.0

Change-Id: I2c97e1be180199db3a520f3fa020973761781dbf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194011
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2021-04-05 17:17:46 +00:00
Janice Collins ed7dd1eda6 Update dartdoc to 0.41.0
Release notes:  https://github.com/dart-lang/dartdoc/releases/tag/v0.41.0

Change-Id: I45bfdcb745f22bff9c8e1cbc0ffd6c61cd11bb47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193448
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2021-03-30 06:30:08 +00:00
Devon Carew f6ce7a829f In-line the package:stagehand templates into 'dart create'.
Change-Id: I717f0970314700b123b750fcfe7ed066ba88d2e5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192944
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
2021-03-25 18:05:09 +00:00
Nicholas Shahan 38e5e9bc19 [ddc] Update pedantic version to 1.11.0
Apply new lints, cleanup violations, and ignore in `lib/src/js_ast` to
avoid adding additional diffs with the version it was forked from.

Change-Id: I1def25865bf195120c594223ebdc0f59139e75b7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192241
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2021-03-24 17:35:32 +00:00
Nate Bosch a6fe47cfe4 Update to the latest package:args
Change-Id: I39fa66d4e28204685e14c13fada20867a9dbb6d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192729
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2021-03-24 15:53:12 +00:00
Alexander Thomas 424c554b73 Revert "Bump pub"
This reverts commit 633d4ace6b.

Reason for revert: breaks dependency resolution in some cases.

Original change's description:
> Bump pub
>
> New commits included:
> ```
> > git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7
>  255a3091 Vendor package:tar and package:chunked_stream (#2932)
>  86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
>  3716a681 Let `pub add` fail if extra arguments are passed (#2927)
>  a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
>  e87b7b66 Added null check for name in UserInfo class (#2918)
>  056a8c9a pub deps --json (#2896)
>  53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
>  d6308efc pub upgrade command shows count of discontinued packages (#2908)
>  51744805 Upgrade to the null safe versions of all dependencies (#2913)
>  e0d538c7 Introduce .pubignore (#2787)
>  79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
>  22463872 `cache clean` (#2904)
>  11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
>  b6977d50 Remove untrue assert (#2884)
>  35841f8d Merge branch 'cherry_picks_for_2_12'
>  0db3255b Don't fail on failed status listing (#2877)
>  53e8ecca Don't allow outdated taking arguments (#2872)
>  e83a1dc1 Enable asserts when testing pub (#2754)
>  178f2edb Add --directory option (#2876)
>  5aadb70e Don't fail on failed status listing (#2877)
>  4bf8a927 Remove unused field (#2878)
>  73ad5426 Don't allow outdated taking arguments (#2872)
>  9a70949e Use Dart library to read and write tar files (#2817)
>  2f74230c Do not recommend decativating packages (#2871)
>  b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
>  16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
>  6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
>  58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
>  b1bf9a33 Handle poor package-listing responses robustly. (#2847)
>  d941bd24 Fix request metadata when overriding dependencyType (#2848)
>  ```
>
> Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304
> Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
> Reviewed-by: Jonas Jensen <jonasfj@google.com>

TBR=sigurdm@google.com,jonasfj@google.com

Change-Id: I364a26468a36438bbbc887e613241030decef4d3
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192748
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2021-03-24 09:03:36 +00:00
Alexander Thomas 5be4e20b16 [co19] Roll co19_2 to 6b71fed8c0f6cf396c085ba2d405d5a9af1daf45
2021-03-24 sgrekhov@unipro.ru extension-methods experimental flag removed from co19_2 tests
2021-03-24 sgrekhov@unipro.ru 1028. Tests that use nonfunction-type-aliases removed from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1021. Remove expecting errors on web configurations for some negative numbers
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift operator from co19_2 repository
2021-03-23 sgrekhov@unipro.ru 1028. Remove triple shift tests from co19_2 repository
2021-03-22 irina.arkhipets@gmail.com Fixes 1015: removed test because triple-shift feature is not supported in this branch.
2021-03-18 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js as [web]
2021-03-17 sgrekhov@unipro.ru Fixes 1014. Expect compile error on dart2js for big numbers
2021-03-17 sgrekhov@unipro.ru Fixes 1017. Use => for setter returning value tests
2021-03-16 sgrekhov@unipro.ru Fixes 1013. Fix cast failures in Type_Cast/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1012. Fix Additive_Expressions/syntax_t01 test
2021-03-16 sgrekhov@unipro.ru Fixes 1010. Description updated for method_definition tests
2021-03-16 sgrekhov@unipro.ru Fixes 1011. Expect an error if non-function type is called as a function
2021-03-16 sgrekhov@unipro.ru Fixes 1009. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1008. Calling constructor without new keyword is not an error
2021-03-16 sgrekhov@unipro.ru Fixes 1007. Missed experimental flag added
2021-03-16 sgrekhov@unipro.ru Fixes 1006. Import library first before export it

Cq-Include-Trybots: dart/try:analyzer-linux-release,analyzer-mac-release,analyzer-win-release,dart2js-strong-hostasserts-linux-ia32-d8,dart2js-strong-linux-x64-chrome,dart2js-strong-linux-x64-firefox,dart2js-strong-mac-x64-chrome,dart2js-strong-mac-x64-safari,dart2js-strong-win-x64-chrome,dart2js-strong-win-x64-edge,dart2js-strong-win-x64-firefox,dart2js-strong-win-x64-ie11,ddc-linux-release-chrome,ddc-win-release-chrome,ddk-linux-release-firefox,front-end-linux-release-x64,front-end-mac-release-x64,front-end-win-release-x64,vm-kernel-linux-debug-ia32,vm-kernel-linux-debug-x64,vm-kernel-linux-debug-x64c,vm-kernel-linux-product-x64,vm-kernel-linux-product-x64c,vm-kernel-linux-release-x64,vm-kernel-linux-release-x64c,vm-kernel-mac-debug-x64,vm-kernel-mac-debug-x64c,vm-kernel-mac-product-x64,vm-kernel-mac-product-x64c,vm-kernel-mac-release-x64,vm-kernel-mac-release-x64c,vm-kernel-precomp-linux-release-x64,vm-kernel-win-release-x64,vm-kernel-win-release-x64c

Change-Id: I7dda06f20991d47c5a6e83321c0a18005e645a72
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192745
Reviewed-by: William Hesse <whesse@google.com>
2021-03-24 08:52:17 +00:00
David Morgan 0155436ba0 Bump bazel_worker.
Change-Id: I33f23f9f56d8b4a624c912981c04aa260078e25b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192300
Commit-Queue: David Morgan <davidmorgan@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
2021-03-24 08:36:33 +00:00
Nate Bosch 614e1a547d Update to the latest package_config
Change-Id: I3941b4513c6db04f782227dc55f6fc92d28e499e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192562
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Auto-Submit: Nate Bosch <nbosch@google.com>
2021-03-24 03:03:35 +00:00
Sigurd Meldgaard 2178411b06 Bump package:usage version
New commits:

```
> git log --format="%C(auto) %h %s" 6c64d9e7b6b3758d06d030efcb5afe20bfc04dde..HEAD
 5b7317b Force close the http-client on IOAnalytics.close() (#155)
 21e6d3c publishing a null safe stable release (#153)
```

Bug: https://github.com/dart-lang/sdk/issues/45235
Change-Id: I47d6119cdeb8210db2207a9247a5f38e0c1841dd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192686
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2021-03-23 16:06:26 +00:00
pq 706758a142 linter 1.2.1
Change-Id: I4d2ccc0bcc4128d60d76ea5119594d946fec35c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192483
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2021-03-23 15:01:16 +00:00
Sigurd Meldgaard ccb8643e0c Remove tar_rev from DEPS
Accidentally added in 633d4ace6b

Change-Id: I949da425c08415ce51a02e60a1d625a3f44a0f2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192684
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
2021-03-23 14:24:26 +00:00
Sigurd Meldgaard 633d4ace6b Bump pub
New commits included:
```
> git log --format="%C(auto) %h %s" 0e657414a472e74ca5dd76ae0db50cc060251dec..255a3091fc278b04be74d246a3bec8743ef4d0b7
 255a3091 Vendor package:tar and package:chunked_stream (#2932)
 86bf8b20 Handle relative git-url-paths correctly when --directory (#2919)
 3716a681 Let `pub add` fail if extra arguments are passed (#2927)
 a03ac729 Minor cleanup to reduce risk of using path.current (#2924)
 e87b7b66 Added null check for name in UserInfo class (#2918)
 056a8c9a pub deps --json (#2896)
 53a69e27 Fix .packages entries of relative path deps when using --directory (#2916)
 d6308efc pub upgrade command shows count of discontinued packages (#2908)
 51744805 Upgrade to the null safe versions of all dependencies (#2913)
 e0d538c7 Introduce .pubignore (#2787)
 79f3a8b9 pub outdated: added clear message when no outdated packages. (#2898)
 22463872 `cache clean` (#2904)
 11e7b2ce `publish --dry-run` informs that the server might do more checks (#2883)
 b6977d50 Remove untrue assert (#2884)
 35841f8d Merge branch 'cherry_picks_for_2_12'
 0db3255b Don't fail on failed status listing (#2877)
 53e8ecca Don't allow outdated taking arguments (#2872)
 e83a1dc1 Enable asserts when testing pub (#2754)
 178f2edb Add --directory option (#2876)
 5aadb70e Don't fail on failed status listing (#2877)
 4bf8a927 Remove unused field (#2878)
 73ad5426 Don't allow outdated taking arguments (#2872)
 9a70949e Use Dart library to read and write tar files (#2817)
 2f74230c Do not recommend decativating packages (#2871)
 b1697a27 Use full error message string in CommandResolutionFailedException (#2870)
 16a6210d Upgrade `downgrade --help`: `downgrade` actually updates `pubspec.lock` (#2859)
 6e240ea9 Use cached version listings as heuristic when prefetching (#2851)
 58152f7c Allow trailing slash in PUB_HOSTED_URL (#2856)
 b1bf9a33 Handle poor package-listing responses robustly. (#2847)
 d941bd24 Fix request metadata when overriding dependencyType (#2848)
 ```

Change-Id: Id6ed5698330fc0cdb507e024eabc34f925ca9208
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192304
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
2021-03-23 12:55:06 +00:00
Alexander Thomas 96918aab8c [co19] Roll co19 to fddb1dce948cec277bf3dc23b45ee95e761b89fe
2021-03-23 irina.arkhipets@gmail.com Fixes Issues #1021, #1030: tests corrected according to the roll results, missing Issue tags added.

Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Change-Id: I2d447eb68e2bf3d0a3c8fb071ecf469a800ea6ad
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192680
Reviewed-by: William Hesse <whesse@google.com>
2021-03-23 08:58:14 +00:00
Mark Zhou 5eceb354e2 [dartdevc] Porting expression compiler tests.
This is part of a series of changes to add support for SDK expression eval tests.

Change-Id: Ia96931fdf81324fa131014b49ec2067507c451f2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/191022
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Anna Gringauze <annagrin@google.com>
Commit-Queue: Mark Zhou <markzipan@google.com>
2021-03-22 23:17:55 +00:00
Alexander Thomas d9aaa9b792 Reland "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
This reverts commit 88ee333408.

Reason for revert: Hook added by mistake removed.

Original change's description:
> Revert "[co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12"
>
> This reverts commit 03e8ddd13c.
>
> Reason for revert: Change to hooks does not work with Windows.
>
> Original change's description:
> > [co19] Roll co19 to ae818220b12ec9c2470519db2c7167cbe4745e12
> >
> > 2021-03-22 sgrekhov@unipro.ru Fixes #1032. Change place where analyzer expects COMPILE_TIME_ERROR.UNCHECKED_USE_OF_NULLABLE_VALUE
> > 2021-03-22 sgrekhov@unipro.ru Fixes #1027. Typo fixed
> > 2021-03-22 sgrekhov@unipro.ru Fixes #1026. Missed experimental flag added
> > 2021-03-22 sgrekhov@unipro.ru Fixes SDK issue #45381. Use 32-bit int boundaries for 32-bit systems
> > 2021-03-19 sgrekhov@unipro.ru #1024. Tests that plays with the integers not representable in JS moved to separate files. These files will be skipped on JS
> >
> > Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
> > Change-Id: Idc63625a841f1f90b0cce5db9ca6add13e4d1192
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192303
> > Reviewed-by: William Hesse <whesse@google.com>
> > Commit-Queue: Alexander Thomas <athom@google.com>
>
> TBR=whesse@google.com,athom@google.com
>
> Change-Id: I5f66db541034377f5d68424073282080d13fd34b
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try
> Cq-Include-Trybots: dart2js-nnbd-linux-x64-chrome-try
> Cq-Include-Trybots: ddc-nnbd-linux-release-chrome-try
> Cq-Include-Trybots: front-end-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-nnbd-linux-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-mac-release-x64-try
> Cq-Include-Trybots: vm-kernel-nnbd-win-release-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-debug-x64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-simarm64-try
> Cq-Include-Trybots: vm-kernel-precomp-nnbd-linux-release-x64-try
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192380
> Reviewed-by: William Hesse <whesse@google.com>

# Not skipping CQ checks because this is a reland.

Change-Id: Ie54fde2d92d1b2cdb3b70835f1f8c17e3c5ac477
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-x64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-debug-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192384
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-03-22 18:39:20 +00:00