Commit graph

10359 commits

Author SHA1 Message Date
Zachary Anderson a83edeee95 Add missing files to sources list
Review URL: https://codereview.chromium.org/2220683002 .
2016-08-05 14:19:04 -07:00
Zachary Anderson 2e3d56a9d6 Remove duplicate entry from source list
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2218173003 .
2016-08-05 14:11:29 -07:00
Carlo Bernaschina 3c786269cb Converted Observatory class-tree element
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2212253002 .
2016-08-05 12:48:07 -07:00
Carlo Bernaschina 1d0ec7b74c Always send typeClass field, if it is resolved
R=johnmccutchan@google.com, regis@google.com, rmacnak@google.com

Review URL: https://codereview.chromium.org/2223543002 .
2016-08-05 12:44:55 -07:00
Terry Lucas c811e3c26e Currently breaks Dartium. Will investigate with John.
Revert "Clear isolate callback data before running shutdowncallback"

This reverts commit aed6dd844d.

TBR=jacobr@google.com,johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2224543002 .
2016-08-05 11:01:51 -07:00
Ryan Macnak 7a12b0cb60 Fix IA32 build.
Review URL: https://codereview.chromium.org/2214313002 .
2016-08-04 17:52:52 -07:00
Ryan Macnak 19716b351a Reset most ICs by returning to the canonical empty data arrays.
We can't do this for the binary operators because they must be writable and not shared for the fast Smi op stubs to record invocation counts.

Suspected to help avoid races, see Issue #26946.

Also remove some dead code and avoid TLS.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2217733002 .
2016-08-04 17:41:03 -07:00
Carlo Bernaschina ba0f803fbe Centralized event streams
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2211603002 .
2016-08-04 17:11:16 -07:00
Todd Turnidge f8ff7bd5c4 Delete NativeMessageHandler once a native port closes.
Closes #27002

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2217693002 .
2016-08-04 15:34:24 -07:00
Regis Crelier fbbedf4f18 Introduce getter p on double in the VM to control fractional precision.
Add test.

R=asiva@google.com, fschneider@google.com

Review URL: https://codereview.chromium.org/2208473006 .
2016-08-04 15:18:00 -07:00
Siva Annamalai 99baa3de32 Fix for issue 27019 (Safepoint assertion failure in Flutter)
BUG=27019
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2215523002 .
2016-08-04 13:56:04 -07:00
John McCutchan aed6dd844d Clear isolate callback data before running shutdowncallback
BUG=
R=turnidge@google.com

Review URL: https://codereview.chromium.org/2212083002 .
2016-08-04 13:09:24 -07:00
Matthias Hausner 643fdb9dc8 Implement the language change that makes initializing formal parameters visible in the initializer list, but not in the constructor's body.
The feature is enabled with the flag --initializing-formal-access.

BUG=26655, 26656
R=regis@google.com

Review URL: https://codereview.chromium.org/2051213005 .
2016-08-04 11:24:25 -07:00
Zachary Anderson 8808f853e3 Fix memory leaks in BoringSSL secure socket implementation
After running our tests with ASAN and inspecting the
BoringSSL code, it appears that the calls indicated
in the CL increment the reference count of the
objects passed in being added to the security context.
Therefore, to avoid a leak, we have to free() the
objects to decrement the reference count so that the
memory is freed when the context is destroyed.

R=asiva@google.com

Review URL: https://codereview.chromium.org/2206233003 .
2016-08-04 10:49:51 -07:00
Ryan Macnak 5f4a685cd7 Reload: Have dangling extracted properties raise NoSuchMethod.
Closes #26995

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2204593011 .
2016-08-04 09:54:40 -07:00
John McCutchan 9f2a883739 Fix reload service protocol reporting
BUG=
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2213753002 .
2016-08-04 09:34:04 -07:00
Florian Loitsch b8c12bc9ff Make Mac-port non-blocking.
Fixes issue #26790.

BUG= http://dartbug.com/26790
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2211523002 .
2016-08-04 15:58:20 +02:00
Florian Loitsch ef4933df25 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Reverted: a1005bad7e

Committed: 8c4954492f

Reverted: 5ebcd3cda0

Committed: eaeb260244

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: 90a194be3c
2016-08-04 14:45:01 +02:00
Carlo Bernaschina 5948909120 Fixed typos in observatory_sources and folder name
TBR=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2210103002 .
2016-08-03 20:09:17 -07:00
Carlo Bernaschina 60afd8bddd Converted observatory flag-list element
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2213613002 .
2016-08-03 19:53:05 -07:00
Carlo Bernaschina c9b1215870 Converted general-error tag
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2199403002 .
2016-08-03 18:16:19 -07:00
Carlo Bernaschina 17bde049e0 Removed warnings from test
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2212643002 .
2016-08-03 17:55:26 -07:00
Carlo Bernaschina 937d281f7f Converted Observatory class-ref & library-ref elements
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2204973003 .
2016-08-03 17:48:42 -07:00
Carlo Bernaschina f151384596 Dynamic host and port in vm-connect element
Fixes https://github.com/dart-lang/sdk/issues/24014

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2204943005 .
2016-08-03 17:20:18 -07:00
Ryan Macnak 978abe4e32 Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function.
Don't AddTypesOf(function) before the work queue is empty, or we may miss types in exception handlers that are not computed until the function is compiled.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2209893003 .
2016-08-03 16:57:55 -07:00
Todd Turnidge 27db90e56f Disable a test on windows which uses an illegal window filename character.
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2207233002 .
2016-08-03 16:37:23 -07:00
Todd Turnidge 74ad64038a Allow weird characters (like ?) to appear in devfs filenames.
Closes #27011

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2208223002 .
2016-08-03 15:43:37 -07:00
Todd Turnidge 4bcc85e37e From Regis: Remove regexp pattern from function name to avoid crash in debug mode. Fix service object to properly support regexp. Add regression test. (Review by Todd)
From Todd: Fix a problem in caching that Regis's change discovered in
the Observatory.  (Review by Regis)

From Ryan: Added teest.

BUG=
R=regis@google.com

Review URL: https://codereview.chromium.org/2207883004 .
2016-08-03 15:24:22 -07:00
Siva Annamalai 39ae4337dd Fix issue 27006 (safepoint assertion failure).
BUG=27006
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2206423002 .
2016-08-03 14:28:41 -07:00
Florian Loitsch 90a194be3c Enter a description of the change.
Merge branch 'master' into revert

Revert "Better error-message when bind fails."

This reverts commit eaeb260244.

Review URL: https://codereview.chromium.org/2213533002 .
2016-08-03 23:18:39 +02:00
Florian Schneider 9a68bad6fd During generation of the version.cc file, read the current Git hash.
R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2206953004 .
2016-08-03 14:16:39 -07:00
Florian Loitsch eaeb260244 Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Reverted: a1005bad7e

Committed: 8c4954492f

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: 5ebcd3cda0
2016-08-03 22:44:28 +02:00
Ryan Macnak ecbf3f7b31 Disable canonical verifier for precompiled.
Issue #27003

TBR=asiva@google.com

Review URL: https://codereview.chromium.org/2201163004 .
2016-08-03 13:43:06 -07:00
Zachary Anderson 0e6f087942 Clear the error bit after reading the default trusted certs
fixes #26954

R=whesse@google.com

Review URL: https://codereview.chromium.org/2211453002 .
2016-08-03 12:24:35 -07:00
John McCutchan 133c087cdb Become the old E.values into the new E.values
Fixes https://github.com/dart-lang/sdk/issues/26988

R=rmacnak@google.com

Review URL: https://codereview.chromium.org/2199173002 .
2016-08-03 10:46:40 -07:00
Ryan Macnak 5ebcd3cda0 Revert "Better error-message when bind fails."
This reverts commit 8c4954492f.

This change broke the Android build.

Review URL: https://codereview.chromium.org/2201183004 .
2016-08-03 09:54:57 -07:00
Ryan Macnak 8c87121afe Revert "Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function."
This reverts commit 908309fe6d.

Review URL: https://codereview.chromium.org/2199263004 .
2016-08-03 09:34:10 -07:00
Florian Loitsch 8c4954492f Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Committed: 34aed6a08b

Review URL: https://codereview.chromium.org/2205913003 .

Reverted: a1005bad7e
2016-08-03 16:27:48 +02:00
Florian Loitsch a1005bad7e Revert "Better error-message when bind fails."
This reverts commit 34aed6a08b.

Review URL: https://codereview.chromium.org/2210523002 .
2016-08-03 15:47:15 +02:00
Florian Loitsch 873c6e4688 Don't close stdio/stderr when shutting down.
Fixes #26872.

BUG= http://dartbug.com/26872
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2204953002 .
2016-08-03 15:30:30 +02:00
Florian Loitsch 34aed6a08b Better error-message when bind fails.
See #26790.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org/2205913003 .
2016-08-03 15:29:41 +02:00
John McCutchan a547fd531c Propagate UnhandledExceptionErrors returned by the tag handler in Reload
TBR=rmacnak

Review URL: https://codereview.chromium.org/2205573005 .
2016-08-02 19:08:45 -07:00
John McCutchan 35146c688e Fix reload handling of unwind / stackoverflow errors
BUG=

Review URL: https://codereview.chromium.org/2201283002 .
2016-08-02 18:27:35 -07:00
John McCutchan b8500cdd2d More reload status and bug fixes
TBR=rmacnak

Review URL: https://codereview.chromium.org/2209513003 .
2016-08-02 17:26:13 -07:00
Ryan Macnak 908309fe6d Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function.
Allows dropping const constructors never used as non-const constructors nor roots.

R=fschneider@google.com

Review URL: https://codereview.chromium.org/2203843003 .
2016-08-02 16:30:57 -07:00
John McCutchan 24b6264c13 Silence service isolate startup error unless --trace-service is enabled
Fixes https://github.com/flutter/flutter/issues/5186

Review URL: https://codereview.chromium.org/2205953003 .
2016-08-02 16:19:24 -07:00
John McCutchan a6114c23cd Simplify reload error reporting
- [x] Rationalize the load failure code path.
- [x] Remove support for reload to be aborted via a callback.
- [x] If a reload fails due to an unwind error, ignore it as the isolate is dead anyway.
- [x] Move more allocations into the zone.

Review URL: https://codereview.chromium.org/2208553002 .
2016-08-02 16:11:30 -07:00
Ryan Macnak cdae2f2783 Revert "Also attempt to symbolize dart frames in Profiler::DumpStackTrace."
This reverts commit d215693513.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2201953003 .
2016-08-02 15:14:43 -07:00
Matthias Hausner 478e0db389 Eliminate remaining case of ambiguous context level info
When generating the scopes in an await-for loop, make sure the scope
of the loop block is a proper sub-range of the block surrounding
the loop.

This eliminates the last case where the compiler generated context
info of the same range, but with contradicting context level info.

BUG=26941
R=regis@google.com

Review URL: https://codereview.chromium.org/2201203002 .
2016-08-02 14:44:29 -07:00
Carlo Bernaschina bd79732101 Converted Observatory error-ref element
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org/2202943002 .
2016-08-02 13:51:22 -07:00