Commit graph

682 commits

Author SHA1 Message Date
Janice Collins
08e485c43f Update dartdoc to 0.23.1.
https://github.com/dart-lang/dartdoc/releases/tag/v0.23.1

Change-Id: I943b8c4417411345852d099cbb558c5659e022a7
Reviewed-on: https://dart-review.googlesource.com/c/78866
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-10-10 16:56:46 +00:00
Alexander Thomas
7072d3b17e [infra] Upgrade d8 to 6.9.427.23 (#34698)
* Use 64bit d8 on Windows & Mac.
* Default to 64bit d8 on Linux.

Change-Id: Ia03275e48ed0e30bcb2a7b390e7007e34e92cfc5
Reviewed-on: https://dart-review.googlesource.com/c/78640
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-10-10 12:36:55 +00:00
Janice Collins
09f95bfaa7 Update dartdoc to version 0.23.0
Change-Id: Id1e1028edc2548bf2830291a40854650f00fda0f
Reviewed-on: https://dart-review.googlesource.com/c/78341
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-10-05 21:39:18 +00:00
Sergey G. Grekhov
e8e9677fad [co19] co19_2 roll.
* co19_2 tests enabled for vm-kernel CQ builders.

Change-Id: I5ccc27d1110c22960e550b060a7e140bc1ac68b1
Reviewed-on: https://dart-review.googlesource.com/c/76820
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-10-05 06:35:43 +00:00
pq
03e6a51478 bump to linter 0.1.68
* updated analyzer compatibility to `^0.33.0` (reduces mixin lint false negatives)

Change-Id: Ie3a928ab003a697e4f61fca853f39e617005c335
Reviewed-on: https://dart-review.googlesource.com/c/78184
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-05 02:53:59 +00:00
pq
cf48bad128 bump linter to 0.1.67
* miscellaneous mixin support fixes
* update to `sort_constructors_first` to apply to all members
* update `unnecessary_this` to work on field initializers

Change-Id: If0578fb3dd67d8f746044e8bbc21e166cd43e4ef
Reviewed-on: https://dart-review.googlesource.com/c/77984
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-03 22:19:37 +00:00
Janice Collins
248a15f994 Upgrade dartdoc and dependencies for 0.22.0.
Bug: https://github.com/dart-lang/sdk/issues/34651
Change-Id: I384f2516d359b7e233058b3a3c501d9575955e0a
Reviewed-on: https://dart-review.googlesource.com/c/77900
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-10-03 21:05:17 +00:00
Alexander Thomas
ff51edf6e2 [infra] Update checked in SDKs to 2.1.0-dev.6.0
Change-Id: I91fe0da8595ddf07c5b0a345ac9417730b6f964f
Reviewed-on: https://dart-review.googlesource.com/77542
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2018-10-02 14:32:40 +00:00
pq
76bfa425bb bump to linter 0.1.66
* broadened SDK version constraint

Change-Id: I2e9fed5e0521725edfad8d91bb380c18317d0bbc
Reviewed-on: https://dart-review.googlesource.com/77464
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-10-01 18:59:54 +00:00
pq
8a919426f0 bump to linter 0.1.65
* fix cast exceptions related to mixin support

Change-Id: I26361e41f9dee940c462558b6d8251a93f351ecb
Reviewed-on: https://dart-review.googlesource.com/77227
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-09-28 21:31:32 +00:00
Zach Anderson
defd68e431 [infra] Don't run generate_buildfiles.py during gclient hooks
There is a race with downloading the prebuilt Dart SDK from CIPD
introduced by:

647e1e79eb

If the prebuilt Dart SDK isn't there, then generate_buildfiles.py will
fail. Instead check whether generate_buildfiles.py should be run
right before we try to build.

Change-Id: I1e25e5280075f9d1c7d96877602617ddfb40291e
Reviewed-on: https://dart-review.googlesource.com/77160
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-09-28 18:11:07 +00:00
pq
b3b947d9a6 bump to linter 0.1.64
* fixes to better support mixins

Change-Id: Ibc67ec7b98d8bc478b0343335e40974b385da152
Reviewed-on: https://dart-review.googlesource.com/76565
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-09-25 22:52:52 +00:00
Janice Collins
491db89917 Upgrade dartdoc to v0.21.1
Changes:

https://github.com/dart-lang/dartdoc/releases/tag/v0.21.1
https://github.com/dart-lang/dartdoc/releases/tag/v0.21.0

Change-Id: Ib6a113b919b8d9718d312d4dc6b7a611593550c2
Reviewed-on: https://dart-review.googlesource.com/75984
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-09-21 19:45:28 +00:00
pq
c92406f57c bump to linter 0.1.63
* updated `unawaited_futures` to ignore assignments within cascades
* new lint: `sort_dependencies`

Change-Id: Iec39fce58d4c6230613f947ed6fc99fec516c722
Reviewed-on: https://dart-review.googlesource.com/75942
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-09-21 17:10:14 +00:00
Bob Nystrom
878017481f Roll dart_style to 1.2.0.
This is safe to do without also rebuilding the checked in SDK because
it doesn't affect any existing formatted code.

Change-Id: I615c1145c2343da54b7a532ff3f5d077e63cb7ed
Reviewed-on: https://dart-review.googlesource.com/75563
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-09-19 20:23:58 +00:00
David Morgan
2cd277a085 Update bazel_worker package to v0.1.14.
Change-Id: I2b66bd7ac8c2bc4089e5a6d1a6fd49ec76187f68
Reviewed-on: https://dart-review.googlesource.com/75180
Reviewed-by: Nate Bosch <nbosch@google.com>
2018-09-18 14:15:13 +00:00
pq
cd26b889e1 linter 0.1.62
* new lint: `prefer_mixin`
* new lint: `avoid_implementing_value_types`

Change-Id: Iaba2d1dd50511db935cf050ba49e7d10746be8cb
Reviewed-on: https://dart-review.googlesource.com/74880
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-09-13 18:55:35 +00:00
pq
858d65eb80 Integrate linter 0.1.61
* new lint: `flutter_style_todos`
* improved handling of constant expressions with generic type params
* NPE fix for `invariant_booleans`
* Google lints example moved to `package:pedantic`
* improved docs for `unawaited_futures`

Change-Id: Ie0eb779f8cb98aaa67674ecfd17baf12445a5934
Reviewed-on: https://dart-review.googlesource.com/74340
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-09-11 13:59:36 +00:00
Alexander Thomas
aa003d4f8e [infra] Update checked in SDKs to 2.1.0-dev.4.0
Change-Id: Ib37f2f5fd6aec3b86677b5f1c51f6ec6147069a7
Reviewed-on: https://dart-review.googlesource.com/74280
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-09-10 21:25:22 +00:00
Alexander Thomas
c0697ad738 [co19] Roll co19_2 and enable for dart2js
Change-Id: I72b493a65ef5c854b122d76d80549d30141157fd
Reviewed-on: https://dart-review.googlesource.com/71243
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-09-06 09:09:29 +00:00
William Hesse
3603bfaebd Remove remaining traces of content_shell and DumpRenderTree
Change-Id: Iae15260fa588b101929095c865807efecfb678a2
Reviewed-on: https://dart-review.googlesource.com/71960
Reviewed-by: Jonas Termansen <sortie@google.com>
2018-08-30 08:15:30 +00:00
Janice Collins
3e0631761c Update dartdoc to 0.20.4.
Includes a bump to quiver's version.

Release notes: https://github.com/dart-lang/dartdoc/releases/tag/v0.20.4

Change-Id: I50a34473470a9f04b19fede200d20da7c2a00257
Reviewed-on: https://dart-review.googlesource.com/71882
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
2018-08-28 20:56:44 +00:00
pq
b72da4194c linter 0.1.60
* new lint: `avoid_void_async`
* `unawaited_futures` updated to check cascades

Change-Id: I9378df6ab618c9a0e71f8a3c5b16d2543445b014
Reviewed-on: https://dart-review.googlesource.com/71386
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-08-23 22:46:21 +00:00
Alexander Thomas
718a6672da [infra] Update checked in SDKs to 2.1.0-dev.2.0
TBR=whesse@google.com

Change-Id: I447a59ceea00887dd1feee85a881304dd2a7f55b
Reviewed-on: https://dart-review.googlesource.com/71242
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-08-22 20:53:30 +00:00
Devon Carew
2e33d597e7 Roll to the latest dart_style.
Change-Id: I207f1c06d8ca85ade382d6141ac2e0cbba27bbbe
Reviewed-on: https://dart-review.googlesource.com/70940
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-22 17:35:41 +00:00
Nate Bosch
90440ad2df Update to latest pub with --enable-asserts
Change-Id: I73efbb00b49a7a580a958d287ba0bfab76d10505
Reviewed-on: https://dart-review.googlesource.com/70162
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-08-15 23:30:24 +00:00
Sergey G. Grekhov
1e72c90521 [co19] Next roll of .status and DEPS update
Change-Id: Iff7d207cda2a88c0f51135a56aec78eed0935d0a
Reviewed-on: https://dart-review.googlesource.com/69461
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-08-13 10:28:12 +00:00
pq
80a05845d8 linter 0.1.59
* relaxed `void_checks` (allowing `T Function()` to be assigned to `void Function()`)
* test and build improvements
* introduced Effective Dart rule set
* Google ruleset updates
* (internal cleanup): move cli main into `lib/`
* fixed false positives in `lines_longer_than_80_chars`
* new lint: `prefer_void_to_null`

Change-Id: I374197f09701041fd0b507062a3ad903f731656a
Reviewed-on: https://dart-review.googlesource.com/69382
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-08-10 20:41:14 +00:00
Paul Berry
508751c5b1 Revert "[co19] co19_2 tests roll (DEPS and .status files update)"
This reverts commit f99b9b80ff.

Reason for revert: Rolls in a version of co19_2 that contains two files whose name differs only by case and whose content is not the same.  This breaks "gclient sync" on machines with case-insensitive filesystems (e.g. macs).

Original change's description:
> [co19] co19_2 tests roll (DEPS and .status files update)
> 
> Closes #33894
> 
> Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
> Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
> Reviewed-on: https://dart-review.googlesource.com/68860
> Commit-Queue: Alexander Thomas <athom@google.com>
> Reviewed-by: Alexander Thomas <athom@google.com>

TBR=whesse@google.com,athom@google.com,eernst@google.com,sgrekhov@unipro.ru

Change-Id: Icd6d8d763c8baff2b82bd15c6b28c56591b7431e
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Reviewed-on: https://dart-review.googlesource.com/69340
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2018-08-10 17:22:54 +00:00
Sergey G. Grekhov
f99b9b80ff [co19] co19_2 tests roll (DEPS and .status files update)
Closes #33894

Cq-Include-Trybots: luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release
Change-Id: If1fd4c78cb1c7948602d9a26276cce75cf3133d4
Reviewed-on: https://dart-review.googlesource.com/68860
Commit-Queue: Alexander Thomas <athom@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2018-08-10 08:28:38 +00:00
Nate Bosch
3d25d3761b Update pub - leave packages directories alone
Change-Id: I56f269568972e16cd5e7ce57d2dc64bd6a6541d8
Reviewed-on: https://dart-review.googlesource.com/68801
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
2018-08-08 22:05:00 +00:00
Alexander Thomas
9bb39ccabc [infra] Update checked in SDKs to 2.0.0-dev.69.5
Closes #33878

Change-Id: Id4687f59c31adb1338643f86909bc5b6b7afb88a
Reviewed-on: https://dart-review.googlesource.com/68040
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2018-08-02 10:36:29 +00:00
Devon Carew
89cfa2edd7 Update package:test_reflective_loader.
Change-Id: If23bb61ef03efe62282ba2e163d3a830d6e0bfad
Reviewed-on: https://dart-review.googlesource.com/67700
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-08-01 00:20:45 +00:00
Janice Collins
74d480b27f Update dartdoc to 0.20.2 and update dependencies.
This may impact other parts of the SDK who share dartdoc's dependencies.

Change-Id: I5ec19aabcca78c373386dff3c194108b6586841f
Reviewed-on: https://dart-review.googlesource.com/66702
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
2018-07-25 20:11:30 +00:00
Sigmund Cherem
2d366c3ae9 Switch to use swarm instead of sunflower for dart2js unittests.
These where the last two uses of sunflower in the repo. Sunflower sources have
been deleted from the public github repo. We can alternatively copy them here,
but for these tests it doesn't really matter what code we use.

A benefit of using swarm: this will test compiling swarm, so we detect breakages
early (and not when they hit the perf bots). A drawback of using swarm: it is
bigger and these tests will take longer.  For dump-info that might be a good
thing, though.

TBR

Change-Id: Ie976cf4250f5f7ce17147ba8b166e7a6bd429425
Reviewed-on: https://dart-review.googlesource.com/65784
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2018-07-19 20:57:18 +00:00
pq
83a615cf4b Linter 0.1.58
* roll-back to explicit uses of `new` and `const` to be compatible w/ VMs running `--no-preview-dart-2`

# 0.1.57

* fix to `lines_longer_than_80_chars` to handle CRLF endings
* doc improvements
* set max SDK version to <3.0.0
* fix to `non_constant_identifier_names` to better handle invalid code
* new lint: `curly_braces_in_flow_control_structures`


Change-Id: I1fd3c9b3892f377c634057451ea0938347ef4e9a
Reviewed-on: https://dart-review.googlesource.com/65573
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-07-18 20:23:05 +00:00
William Hesse
fa270d5c10 Update checked-in SDK version to 2.0.0-dev.69.0
Change-Id: Ia0b1d87c4be79cbcd5e5b6b785b41fcfb3b45820
Reviewed-on: https://dart-review.googlesource.com/65546
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-07-18 20:09:30 +00:00
Lasse R.H. Nielsen
f2402b3c08 Remove deprecated SDK constant declarations.
Change-Id: I0e4208b6fa957765403608103128c28562280657
Reviewed-on: https://dart-review.googlesource.com/51841
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
2018-07-18 13:05:00 +00:00
Ryan Macnak
296319d2f0 [observatory] Switch to static mode.
Bug: https://github.com/dart-lang/sdk/issues/32503
Change-Id: I9ff65d1598031473fa8ca97a27e340e722f038fa
Reviewed-on: https://dart-review.googlesource.com/65382
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2018-07-17 18:04:10 +00:00
William Hesse
dcd58ff563 Update unittest to 0.11.x. Check out unittest from chromium.googlesource.
Change-Id: I35fbf7d18cf596c23fcdc9c702cc1a6d498a4691
Reviewed-on: https://dart-review.googlesource.com/65320
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-07-17 12:18:48 +00:00
Bob Nystrom
42bbdec54e Update dartfmt to 1.1.3.
We also need to update the prebuilt SDK to keep it in sync with this
change so the presubmit doesn't get wonky. But, in this case, it should
be fine. The change affects a rare case that I don't think occurs in
the SDK: a multi-line string inside a string interpolation, inside
another string. If that does occur, it's easy to just change that code.

Change-Id: Icdfdfb0b2e1359005d88d983e9a3cf05b0e91e48
Reviewed-on: https://dart-review.googlesource.com/65280
Reviewed-by: Jenny Messerly <jmesserly@google.com>
2018-07-17 11:04:29 +00:00
Leaf Petersen
bcad45f350 Update DEPS to post CONSTANT versions of packages
Change-Id: I0f09586610e4096ed6b1031541c90934ed8a2a59
Reviewed-on: https://dart-review.googlesource.com/65161
Commit-Queue: Leaf Petersen <leafp@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-07-16 17:18:30 +00:00
William Hesse
58f1819023 Update the checked-in sdk to version 2.0.0-dev.68.0
Change-Id: Ifc39a60ca75d4b03830f14b8c99ad436966d6c4e
Reviewed-on: https://dart-review.googlesource.com/64541
Reviewed-by: Bob Nystrom <rnystrom@google.com>
2018-07-12 09:01:12 +00:00
Lasse R.H. Nielsen
2efe3447ee Update DEPS to remove dependencies on upper-case constants
Change-Id: I5839a92d9790abcf35011b7ab3cdd3e05dbfa45c
Reviewed-on: https://dart-review.googlesource.com/63950
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2018-07-11 09:45:33 +00:00
Leaf Petersen
6f822ace89 Update bazel_worker, shelf, oauth2, markdown DEPS to latest versions
to enable removing deprecated CONSTANTS.

Change-Id: Ib8d7fbf7cbb2826dd239f62186a5c4e315b60cff
Reviewed-on: https://dart-review.googlesource.com/64461
Reviewed-by: Nate Bosch <nbosch@google.com>
2018-07-10 23:35:08 +00:00
Sergey G. Grekhov
54f66eebf2 [co19] co19 roll: DEPS and test_matrix update
Cq-Include-Trybots:luci.dart.try:front-end-mac-release-x64;luci.dart.try:front-end-win-release-x6;luci.dart.try:analyzer-mac-release;luci.dart.try:analyzer-win-release

Change-Id: I37f3b78180133c31f6267b76c3eeb16f8c00325a
Reviewed-on: https://dart-review.googlesource.com/63623
Reviewed-by: Erik Ernst <eernst@google.com>
2018-07-10 11:07:36 +00:00
William Hesse
b5e97a6537 Roll dart_style to version 1.1.2
This stops the splitting of long strings inside their interpolations.

BUG=https://github.com/dart-lang/sdk/issues/33773

Change-Id: Ie3a7a576de036c9055b02e6770f5f28d8bb49e35
Reviewed-on: https://dart-review.googlesource.com/64040
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
2018-07-09 22:51:54 +00:00
Devon Carew
007dcd415d Upgrade package:http to 0.11.3+17.
Change-Id: Ic2eb67fac0c361be458d44201f4d573bcfac9221
Reviewed-on: https://dart-review.googlesource.com/64080
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-09 17:29:40 +00:00
William Hesse
fb762be46a Update dart_style to version 1.1.1 in DEPS
Bug: https://github.com/dart-lang/sdk/issues/33663
Change-Id: Ic4dc36489b70164c723433487a6ac82082b2a165
Reviewed-on: https://dart-review.googlesource.com/63585
Reviewed-by: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
2018-07-03 13:44:38 +00:00
pq
1ed94b8db8 linter 0.1.56
* fix to `avoid_positional_boolean_parameters` to ignore overridden methods
* fix to `prefer_is_empty` to not evaluate constants beyond int literals
* new lint: `null_closures`
* new lint: `lines_longer_than_80_chars`

Change-Id: Id11694d65091de6f26f521d62f3c5fb1921f58af
Reviewed-on: https://dart-review.googlesource.com/63271
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
2018-06-29 21:02:31 +00:00