languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-21 03:13:14 +00:00
Code Issues Packages Projects Releases Wiki Activity
46204 commits 11 branches 6011 tags 1.4 GiB
Commit graph

46204 commits

This branch
This branch
All branches
Author SHA1 Message Date
Emily Fortuna adce9b982a Revert "Gracefully handle if loaded dill program has no mainMethod set." 
This reverts commit b24e594ebd.

I got an email this broke Dart/Flutter integration???

BUG=

Review-Url: https://codereview.chromium.org/2799063002 .
 2017-04-05 13:03:00 -07:00
Ben Konyi ddc4f30d75 Re-land socket refactor with fixes for Windows. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2797993005 .
 2017-04-05 12:45:31 -07:00
Ryan Macnak 683077944b Conservatively disable use of integer division on Android ARM64 devices. 
R=jsimmons@google.com

Review-Url: https://codereview.chromium.org/2800883002 .
 2017-04-05 12:45:01 -07:00
Jennifer Messerly 247fc68d21 fix #29228, let* precedence should match generated expression 
R=vsm@google.com

Review-Url: https://codereview.chromium.org/2804833002 .
 2017-04-05 12:40:42 -07:00
Emily Fortuna b24e594ebd Gracefully handle if loaded dill program has no mainMethod set. 
BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2800463002 .
 2017-04-05 12:35:52 -07:00
Vijay Menon aa3fba7d8d Preserve async markers when parsing js_ast 
Fixes #29252

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2797873002 .
 2017-04-05 12:13:22 -07:00
Emily Fortuna b7b3714086 Reapply "Add "load from .dill" file capability and run a white-box test."" 
This reverts commit 8febfff784.

BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2797443008 .
 2017-04-05 11:40:52 -07:00
Vyacheslav Egorov 7e1d584218 VM: [Kernel] Implement CatchBlockEntryInstr::should_restore_closure_context on all platforms. 
This was the only Kernel specific backend change - to simplify the graph builder
we allowed it to capture exception and stack trace variables. This in turn
requires CatchBlockEntryInstr to respect that this variables can be captured
and correctly update them when exception is caught.

This was implemented on X64 and ARM before. This CL expands implementation to
all other implementations including DBC.

R=zra@google.com

Review-Url: https://codereview.chromium.org/2796283003 .
 2017-04-05 20:32:03 +02:00
Dan Rubel a370462274 move fasta.Keyword methods to analyzer.Keyword 
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2800583002 .
 2017-04-05 13:51:53 -04:00
Adam Barth c25cd4da33 Restrict @immutable checks to instance fields 
R=brianwilkerson@google.com, pquitslund@google.com

Review-Url: https://codereview.chromium.org/2805443002 .
 2017-04-05 10:50:41 -07:00
Peter von der Ahé 0fcc4ee024 Implement parsing of metadata on local variables. 
R=johnniwinther@google.com, scheglov@google.com

Review-Url: https://codereview.chromium.org/2798603003 .
 2017-04-05 19:12:42 +02:00
Paul Berry 191be2df39 Make the AstFactory API refer to kernel types rather than "shadow" types. 
This dramatically reduces the amount of type casting that has to
happen in the Fasta type inference prototype.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2802433003 .
 2017-04-05 09:04:53 -07:00
Peter von der Ahé b06e4d5754 Create separate scopes for constructors, setters, and other members. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2788153002 .
 2017-04-05 16:07:32 +02:00
Dmitry Stefantsov 95560cb02a Add Kernel AST nodes for Vector and Closure primitives in VM 
Five Kernel AST nodes added: VectorCreation, VectorGet, VectorSet,
VectorCopy, and ClosureCreation.

R=asgerf@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2792333002 .
 2017-04-05 15:59:25 +02:00
Brian Wilkerson c2f599473b Fix generic function types in variable declarations (issue 29237) 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2798663003 .
 2017-04-05 06:24:25 -07:00
Peter von der Ahé f07800446d Remove classMembers getter. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2792453003 .
 2017-04-05 15:23:55 +02:00
Peter von der Ahé da115a0bca Add debugString to scope. 
R=karlklose@google.com

Review-Url: https://codereview.chromium.org/2795433002 .
 2017-04-05 15:20:07 +02:00
Peter von der Ahé a8d08eaf4b Make lines and columns one-based in SourceLocation. 
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2804613003 .
 2017-04-05 15:19:05 +02:00
Florian Loitsch 167c7243c2 many_method_calls_test sometimes passes. 
Review-Url: https://codereview.chromium.org/2796373002 .
 2017-04-05 15:03:02 +02:00
Peter von der Ahé ddda182957 Add Source.getTextLine and use it to display source snippets in error messages. 
R=asgerf@google.com, johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2788373002 .
 2017-04-05 15:02:49 +02:00
Dmitry Olshansky ffc4c1df30 VM [KERNEL] Use simpleInstanceOf in kernel. 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2794373002 .
 2017-04-05 14:56:42 +02:00
Florian Loitsch cb426d5d21 Mark service/pause_on_unhandled_async_exceptions2_test as crashing. 
Review-Url: https://codereview.chromium.org/2804643002 .
 2017-04-05 14:23:29 +02:00
Lasse R.H. Nielsen 94b23d3b12 Fix text around least upper bound. 
R=eernst@google.com

Review-Url: https://codereview.chromium.org/2802633002 .
 2017-04-05 14:09:07 +02:00
Dmitry Olshansky 7c011eda26 VM [KERNEL] Fix a buffer overflow in COMPARE_NAME 
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2794113003 .
 2017-04-05 14:06:00 +02:00
Zhivka Gucevska c91fd31036 Implement flow control with breaks 
BUG=
R=dmitryas@google.com, kmillikin@google.com

Review-Url: https://codereview.chromium.org/2790063002 .
 2017-04-05 13:00:44 +02:00
Zhivka Gucevska f420d1bef5 Update documentation for InvocationExpression and implicit setters 
BUG=
R=kmillikin@google.com

Review-Url: https://codereview.chromium.org/2790063005 .
 2017-04-05 12:19:34 +02:00
Lasse R.H. Nielsen 7d08f9ddd2 Add type parameters to methods in typed-data patch. 
Fixes #29100.
BUG= http://dartbug.com/29100
R=ahe@google.com, asiva@google.com

Review-Url: https://codereview.chromium.org/2750163004 .
 2017-04-05 10:09:50 +02:00
Johnni Winther 5553b600e0 Split MirrorsData methods and MirrorsDataImpl data by element kind. 
This is a step towards making MirrorsData(Impl) reusable for kernel
based elements.

R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2791263005 .
 2017-04-05 09:06:05 +02:00
Stephen Adams 6ce24eeb23 Update dart2js status 
Some tests no longer crash after removing recursion.

TBR=efortuna@google.com

BUG=

Review-Url: https://codereview.chromium.org/2800593002 .
 2017-04-04 20:10:06 -07:00
Emily Fortuna 8febfff784 Revert "Add "load from .dill" file capability and run a white-box test." 
This reverts commit 310532ab50.

TBR=sra@google.com

BUG=

Review-Url: https://codereview.chromium.org/2795763005 .
 2017-04-04 17:40:10 -07:00
Emily Fortuna 310532ab50 Add "load from .dill" file capability and run a white-box test. 
The dill_loader_test is rather intrusive and I look forward to rewriting it once we have the Entity model spread throughout the compiler rather than Elements.

BUG=
R=johnniwinther@google.com

Review-Url: https://codereview.chromium.org/2798443002 .
 2017-04-04 16:22:14 -07:00
Jennifer Messerly e4e7dffadb fix #29182, generate top level const fields lazily 
This fixes an ordering issue, but also may help load time.

R=vsm@google.com

Review-Url: https://codereview.chromium.org/2797443007 .
 2017-04-04 16:18:46 -07:00
Jacob Richman 774f261165 Print the correct path to dartfmt in the presubmit error message. 
BUG=
R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2795653005 .
 2017-04-04 16:13:31 -07:00
Stephen Adams 887e733203 dart2js: Avoid recursion in visiting blocks of subgraph 
Replace recursive calls with a Queue.

BUG= https://github.com/dart-lang/sdk/issues/26864 https://github.com/dart-lang/sdk/issues/29232
R=efortuna@google.com

Review-Url: https://codereview.chromium.org/2790063008 .
 2017-04-04 15:20:24 -07:00
Konstantin Shcheglov 03a0ee0943 Include 'invokeMethodRef' reference as a linking dependency. 
It was crashing with StackOverflow internally. With changes since the
latest internal release it was not crashing, but still failing with
assertion. This makes it fail with a correct error, without throwing
an exception.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2802473002 .
 2017-04-04 14:35:52 -07:00
Dan Rubel 99aefce48c do not allow built-in keywords to specified when refactoring 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2802433002 .
 2017-04-04 17:13:42 -04:00
Zachary Anderson 8c9c54d833 [dart:io] Don't close stdin with a socket finalizer 
If an Isolate touches the 'stdio' getter, a _NativeSocket with
attached finalizer is created for it. Previously, when such an
Isolate exited, the finalizer would close the underlying
file descriptor. This CL changes the finalizer for stdin such
that the native objects will be cleaned up, but the underlying
file descriptor will not be closed. The underlying file
descriptor will now only be closed if the stdin stream
subscription is explicitly canceled.

Accessing the stdin getter after the stream is explicitly
canceled will result in a FileSystemException.

See also: https://github.com/dart-lang/test/issues/583

fixes #29229

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2791423002 .
 2017-04-04 13:57:42 -07:00
John McCutchan e33e09a23c Disable async debugger support until context mismatch issue is resolved. 
BUG=
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2795303002 .
 2017-04-04 13:36:42 -07:00
Konstantin Shcheglov 565408593b Remove _StdSink._isTranslatable field. 
The field is not used since 141b6351ba,
but it is final and not initialized, so this causes an error during
analyzer tests.

R=paulberry@google.com, zra@google.com
BUG=

Review-Url: https://codereview.chromium.org/2800453002 .
 2017-04-04 12:56:44 -07:00
Konstantin Shcheglov 16e9641583 Build elements for FieldFormalParameter(s) even for local functions. 
This is invalid code, we report an error, but we cannot leave it as
null, because this causes exceptions down the stream.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2800443002 .
 2017-04-04 12:45:11 -07:00
Konstantin Shcheglov a5d8f67ea5 Move tests for parseVariableDeclarationList(), fix for keywords. 
R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2796123002 .
 2017-04-04 12:41:41 -07:00
Konstantin Shcheglov 83f6ef67a8 Fix for resynthesis when a part URI is empty. 
This is about 20% of all internal exceptions.

R=paulberry@google.com, brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2789113005 .
 2017-04-04 12:31:49 -07:00
Jacob MacDonald 3e623d7df1 Add --build-summary-only-unlinked flag, which makes the output summary be an unlinked summary instead of a linked one. 
BUG=
R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2796953002 .
 2017-04-04 12:22:20 -07:00
Regis Crelier a08c95e003 Rename dart::Genericity::kClass to dart::Genericity::kCurrentClass to avoid 
collision with dart::kernel::Tag::kClass.

R=bkonyi@google.com

Review-Url: https://codereview.chromium.org/2796993002 .
 2017-04-04 12:08:57 -07:00
Paul Berry 80101ac407 Re-duplicate frontend_accessors.dart. 
This was de-duped in 02573b3caa, however
there's a problem: In order to share type inference and error
detection logic between Fasta's AstBuilder and BodyBuilder classes,
Fasta's use of the accessors needs to be rewritten to make use of the
shadow hierarchy (see
pkg/front_end/lib/src/fasta/builder/shadow_ast.dart), which kernel
shouldn't have to depend on.

R=ahe@google.com

Review-Url: https://codereview.chromium.org/2794013003 .
 2017-04-04 10:48:50 -07:00
Mike Fairhurst 1a8ef13fd1 We ended up needing just one more change to angular, versions ticked. 
BUG=
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2793693002 .
 2017-04-04 08:47:34 -07:00
Konstantin Shcheglov 21982e562c Use SubStringScanner to scan generic comments. 
R=ahe@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2794833003 .
 2017-04-04 08:45:41 -07:00
William Hesse c3d4674a8c Remove unused call to discoverPackagesInRepository from test scripts. 
Rewrite StandardTestSuite.forEachTest using async/await.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2793333002 .
 2017-04-04 17:31:42 +02:00
Peter von der Ahé 79b021be92 Change signature of resolveConstructors. 
Review-Url: https://codereview.chromium.org/2795723003 .
 2017-04-04 17:15:30 +02:00
Janice Collins 17b1e30d04 DEPS to pull pre-release dartdoc for generic function types 
BUG=
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2795653003 .
 2017-04-04 07:54:00 -07:00