Commit graph

38 commits

Author SHA1 Message Date
Devon Carew 3dbed884c2 [pkg] use package:lints when analying pkg/
Change-Id: Ib25573375ea1f54e07846af6fcd9cd74a8fefb7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/250784
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2022-07-07 14:29:22 +00:00
Devon Carew f7c46f145c [pkg] prefer 'any' deps for package dev dependencies
Tested: CI validation
Change-Id: If65cc156130a65ffe00c6f1660ac320e2921afae
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/246053
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2022-05-27 01:34:59 +00:00
Nate Bosch 6ebd2633cd Use any deps for all unpublished packages
It should not be necessary to ever run `pub get` for a package which is
not published. All packages used in the SDK are controlled by a single
package config, so it's not necessary to declare versions or paths for
any packages.

Remove all dependency overrides.

R=devoncarew@google.com

Change-Id: Icb328813b471f35ee4c99995f4e90aac4d8ed438
Tested: Covered by existing static analysis.
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/244767
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2022-05-17 01:22:25 +00:00
Alexander Thomas 30beab0f43 [infra] Add OWNERS to the Dart SDK
* Add team "groups" in tools/OWNERS_<group name>.
* Add top-level OWNERS as a fallback.
* Add OWNERS for all top-level directories.
* Add OWNERS to all packages.

For additional background information see go/dart-sdk-owners.

TEST=No op until code-owners is enabled.
Bug: b/200915407
Change-Id: I7fe6116cc599c749cd50ca16151d6d6a801d99d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/229147
Reviewed-by: Jonas Termansen <sortie@google.com>
2022-02-14 14:06:34 +00:00
Sam Rawlins f90b6e0b0c telemetry: Use the new strict-casts instead of deprecated no-implicit-casts
Bug: https://github.com/dart-lang/sdk/issues/47902
Change-Id: I99919a08d4f051bd3c294fd901a1f1833209d673
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/225045
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2021-12-20 22:33:43 +00:00
Kevin Moore 6459e73570 telemetry: allow the latest pkg:usage
Change-Id: I2c3d97b5b999e03682e60a6a62947257f597c182
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214308
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2021-09-23 21:49:28 +00:00
Kevin Moore cb7c932f7b analyzer: use Object.hash functions, deprecate JenkinsSmiHash
Also bump min SDK for pkg:analyzer

Towards https://github.com/dart-lang/sdk/issues/27698

Change-Id: Ic32c839c02f18afd99fdb98eb382540aae7da88a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/214126
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
2021-09-22 19:11:24 +00:00
pq 5f21e93f51 deprecated field pubspec diagnostic
Corresponding analysis in the pub client: https://github.com/dart-lang/pub/blob/master/lib/src/validator/deprecated_fields.dart

Downstream Flutter repo fixes: https://github.com/flutter/flutter/pull/84997


Change-Id: If453abcce3a24468e6fbcd2402e196000226fb4c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/204420
Commit-Queue: Phil Quitslund <pquitslund@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2021-06-22 17:26:09 +00:00
Devon Carew b8f4b252ef move pkg/telemetry to using package:lints
Change-Id: I75130cc8d5964ef0f95a672858da8bbce8ffd78c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/200520
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
2021-05-19 16:26:42 +00:00
Franklin Yow 03101c0c2b Update LICENSE
Changes to comply to internal review

Closes https://github.com/dart-lang/sdk/pull/45568
https://github.com/dart-lang/sdk/pull/45568

TEST=CL contains no code changes.

No-Try: true
GitOrigin-RevId: 65796784e5fdfddaa021b5c55ad435b1db419700
Change-Id: I085a948f16dc9a0de128ed0bd456ae69adf6c124
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/193888
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2021-04-07 10:28:38 +00:00
Konstantin Shcheglov 625bfe5cae Migrate package:telemetry
Change-Id: I1d06861b5838a12b807d47cfbb53b0537a68d52f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/194205
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2021-04-07 03:40:29 +00:00
Sam Rawlins 689b088e6d telemetry: Remove unnecessary imports
Bug: https://github.com/dart-lang/sdk/issues/44569
Change-Id: I75ca15c391e0c77840e65d27b26583f15b59eea4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/177340
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-12-30 22:38:50 +00:00
Devon Carew 8cba879f46 Add additional validations to the pkg/ package pubspecs.
TEST=these are additional validations that we run on the bots

Redux of https://dart-review.googlesource.com/c/sdk/+/161040

Change-Id: Ia32ced5d48fbfeafacfa9e51dc4774d2e9425091
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/174601
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-12-02 17:27:18 +00:00
Michael Thomsen f0c87e9f21 Clean up no-publish comments in pubspecs
Change-Id: I6cc1ab404de75cd02183b862842198c85b6d9256
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152005
Reviewed-by: Alexander Thomas <athom@google.com>
2020-06-23 10:34:09 +00:00
Jaime Wren 03483c1dab Update the isRunningOnBot() check in telemetry.dart for Travis, check for env.containsKey('BOT'), instead of env['BOT'] == true
This should fix bot failures such as https://travis-ci.org/github/flutter/devtools/builds/700932057

Change-Id: Ie65455d3f7de825f6691669174ec05f8bac6925e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152020
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
2020-06-22 20:49:46 +00:00
Jaime Wren 6293c3dfee Update telemetry.dart with the most recent environment variables from the flutter tooling. Also: a TODO has been added to check for Azure bot usage.
Change-Id: I2ead645694d599ee393a60db4880c7fa4eb8a3be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/147660
Commit-Queue: Jaime Wren <jwren@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-05-14 18:43:01 +00:00
Mike Fairhurst f1c1dfacb7 [analysis_server] Report to both prod & staging crash reporting
This CL enables us to have different crash reporters that report to
different backends, this will be useful if we report plugin errors to
staging and server errors to prod.

Currently doing this with server errors so that we can make the switch
over to prod incrementally. For the time being, the staging backend will
have our whole crash history, and continue to get new crashes. Reports
and dashboards can switch over to the prod backend as we get enough
history for those reports to be useful, and when we have switched
everything over we can stop reporting to staging entirely.

Change-Id: Ie29b4e05c89fd57faf1487a2c2eba3701fc319d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/145922
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-05-04 18:11:54 +00:00
Devon Carew 1e45051341 [analyzer] initial implementation of SDK, file based configuration of the analysis server
Change-Id: Iff3808fb073b062fa566993e7f05e2669a5fde7e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140003
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2020-03-24 14:07:59 +00:00
Konstantin Shcheglov 09f08bff8b Give 'filename' to attachment MultipartFile(s).
Apperently just field is not enough to show attachments are files.

Change-Id: I42089d25d7055aa81d79ea2dfd621ad1be742b69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140180
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
2020-03-19 22:14:59 +00:00
Konstantin Shcheglov baff77f7cb Allow adding attachments to CrashReportSender.sendReport()
R=devoncarew@google.com

Change-Id: I2925a88190a545e16d97cb7baf985cfbc4bddd0d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/138180
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
2020-03-04 20:09:16 +00:00
Devon Carew f6a76586de [analyzer] send additional data to crash reporting
Change-Id: I9f2da85e1c283ed4942ba076c98003aef80b7051
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/126203
Reviewed-by: Jaime Wren <jwren@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-11-27 00:16:50 +00:00
Devon Carew 18b7580944 [analyzer] for 'Failed to handle request' errors, send the exception to crash reporting as well
Change-Id: Id50543fe6cac0e60ec32bfc6860064b210514dca
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125988
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-11-25 20:20:46 +00:00
Devon Carew f1adb0b4d8 [analyzer] use the staging url for crash reports
Change-Id: I0e706fadac4709a723165beea3446f578c4abd63
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/125682
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-11-20 05:19:08 +00:00
Devon Carew d355778418 [analyzer] rate limit the crash reports we send
Change-Id: I9f6af7fbcec653a2a9396d1098bea678777d4b3b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124761
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-11-12 21:37:22 +00:00
Devon Carew be2866b9b1 [analyzer] update lib/crash_reporting.dart
Change-Id: Ie3b3ffc8a0e0351341f28ff26bbb3c82deb0b5dc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124640
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2019-11-08 23:29:58 +00:00
Devon Carew 983447f95a [analyzer] fix an exception when run on platforms w/o home dirs
Bug: https://github.com/dart-lang/sdk/issues/37308
Change-Id: I2e117a678bfc99dcc3f48d4a58ea5895d0079261
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/107580
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2019-06-28 18:31:49 +00:00
Kevin Moore 0236c5c051 pkg:analyzer_fe_comparison, diagnostics, telemetry remove version info
Until we plan to publish these, it helps tools track what are our public
packages

Change-Id: I5bb692fd6f3da5cfdc9b759d55375435c7885b83
Reviewed-on: https://dart-review.googlesource.com/c/87220
Reviewed-by: Devon Carew <devoncarew@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
2018-12-13 16:44:44 +00:00
Devon Carew 28a8fa50f6 Upgrade package:http to 0.12.0.
Change-Id: I621316d2eb1467ee2a403b52013ddbd7844ea02e
Reviewed-on: https://dart-review.googlesource.com/c/81328
Reviewed-by: Zach Anderson <zra@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-10-24 21:23:16 +00:00
Devon Carew c9a11d866a Upgrade pubspec constraints.
Change-Id: I3b93101adb19762374d2905809263f376ec51882
Reviewed-on: https://dart-review.googlesource.com/66180
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-07-23 16:44:39 +00:00
Devon Carew c19233dcce Plumb in more of the analytics impl into the analysis server; allow clients to enble analytics.
Change-Id: Id546ce60e3ec49d37d6c5545f98a46bff009e6c1
Reviewed-on: https://dart-review.googlesource.com/62701
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2018-06-28 16:28:25 +00:00
Devon Carew 17b53a2835 Test out no_implicit_casts on the analyzer source base.
Change-Id: I4eb2414d7d9bbe21883c9e5e8eca10f2eaafb465
Reviewed-on: https://dart-review.googlesource.com/62725
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2018-06-28 02:20:43 +00:00
Lasse R.H. Nielsen 973a1a0219 Remove uses of upper-case constants in remaining SDK code.
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.

Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
2018-04-16 16:11:57 +00:00
P.Y. Laligand ce79a77331 Remove Fuchsia-specific build files.
Also fix Fuchsia tools to account for new project location (//third_party/dart).

Change-Id: If89a934729c4fa44229eaca83219dbdf8bb700a8
Bug:
Reviewed-on: https://dart-review.googlesource.com/14800
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Zach Anderson <zra@google.com>
2017-10-19 17:52:37 +00:00
Devon Carew 13346cab3d Put the analytics UI behind a flag.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/3003783002 .
2017-08-24 11:17:37 -07:00
Paul Berry 7c94f00d24 Fix spelling errors in telemetry README.
R=devoncarew@google.com

Review-Url: https://codereview.chromium.org/2972203003 .
2017-07-07 10:57:58 -07:00
Devon Carew ca8d646ce1 Fix a telemetry test.
BUG=

Review-Url: https://codereview.chromium.org/2966373002 .
2017-07-06 00:02:59 -07:00
Devon Carew d4abd49df7 Add analytics to analyzer-cli and analysis server.
BUG=
R=brianwilkerson@google.com, scheglov@google.com, zra@google.com

Review-Url: https://codereview.chromium.org/2963323002 .
2017-07-05 23:29:46 -07:00
Devon Carew 8e45759a67 Add initial version of analytics and crash reporting package.
BUG=
R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2954733002 .
2017-06-29 16:46:54 -07:00