Commit graph

1474 commits

Author SHA1 Message Date
Alexander Markov 55f22572d7 [gardening] Mark pkg/vm/test/kernel_front_end_test as Slow
This test is timing out on pkg-linux-debug and
flaky timing out on pkg-win-release.

So it is marked as Slow on all bots and skipped on pkg-linux-debug.

Fixes https://github.com/dart-lang/sdk/issues/49469

Change-Id: I0429acc221605f12ea235ce203de71f76278cdcb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/251820
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2022-07-18 17:07:43 +00:00
Chloe Stefantsova 95d8a5d41a [cfe] Remove Kernel round-trip text serialization
Change-Id: Ifdf0df0b93773f95eb1646a313c15e0a578b5a8d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/249181
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Chloe Stefantsova <cstefantsova@google.com>
2022-06-21 10:28:24 +00:00
Nicholas Shahan 58c84272bc [web] Move libraries to a shared location
These libraries will be shared between the dart2js and DDC runtimes.

Also renames the `shared` directory to `synced` to avoid confusion.
Synced directories are copied to be in sync with the compilers and
runtimes.

Change-Id: Ic36076938741d7102792f09413666de0033da3a4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238300
Reviewed-by: Mayank Patke <fishythefish@google.com>
Reviewed-by: Ivan Inozemtsev <iinozemtsev@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
2022-05-18 19:59:33 +00:00
Ben Konyi 1771c55238 [ DDS ] Split DevTools server tests into smaller pieces
Should resolve timeout issues, particularly around server connection
tests

Change-Id: Ic06d1179b09a17497e38de9aa19549f66ff79d2c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/240180
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
2022-04-04 22:07:21 +00:00
Ben Konyi 2ebad4841f Mark devtools_server tests as slow on Windows
Change-Id: I211f3c3a029a9fd16a1ca485fd62b62c2f6b1d43
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239584
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
2022-04-01 15:11:37 +00:00
Ben Konyi d087f0334d [ DDS ] Fix devtools_server tests on Windows
Fixes https://github.com/dart-lang/sdk/issues/48528

Change-Id: Iaa08d6ee409354eadc37d3beb98ea79b75575758
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239464
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2022-03-30 20:45:20 +00:00
Kenzie Schmoll 3f623c65b0 Split DevTools server tests up into two libraries
Change-Id: Ic394faee18547f3338fb36419defa45c6734d90c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/236301
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2022-03-14 17:51:28 +00:00
Kenzie Schmoll 167970dea7 Reland "Add DevTools Server test and test driver to DDS"
This reverts commit d0dff0e9ba.

Reason for revert: fixed broken tests to reland.

Original change's description:
> Revert "Add DevTools Server test and test driver to DDS"
>
> This reverts commit 02bff5bde2.
>
> Reason for revert: broken tests. (e.g. https://ci.chromium.org/ui/p/dart/builders/ci.sandbox/pkg-mac-release/20638/overview)
>
> Original change's description:
> > Add DevTools Server test and test driver to DDS
> >
> > Bug: https://github.com/dart-lang/sdk/issues/48300
> > Change-Id: I3b72274d111489448a482d65eb7cc23a9f263edf
> > Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/233320
> > Reviewed-by: Ben Konyi <bkonyi@google.com>
> > Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
>
> TBR=bkonyi@google.com,kenzieschmoll@google.com
>
> Change-Id: Iaca6b34a4e55ddd7b984b49821f3cc95337d696a
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: https://github.com/dart-lang/sdk/issues/48300
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234114
> Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
> Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/dart-lang/sdk/issues/48300
Change-Id: I60ffd0e8a394353014408530d636c5918e517a59
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/234861
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Kenzie Davisson <kenzieschmoll@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Commit-Queue: Kenzie Davisson <kenzieschmoll@google.com>
2022-03-09 16:48:54 +00:00
Ryan Macnak b6ab7350be [test] Inform status files about the new simulated architectures.
TEST=ci
Bug: https://github.com/dart-lang/sdk/issues/37299
Bug: https://github.com/dart-lang/sdk/issues/38587
Change-Id: I6f1a749690b894b14f465d608f37acf62568cdef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/231521
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
2022-02-03 20:32:16 +00:00
Nicholas Shahan 1d20986629 [dart2js] Skip dump_info unit test that times out
Skipping pkg/compiler/test/end_to_end/dump_info_test

Change-Id: I61622a7be69d4e14ac338716c5db8d1689fb0b6a
Issue: https://github.com/dart-lang/sdk/issues/47401
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/215944
Reviewed-by: Joshua Litt <joshualitt@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2021-10-07 15:40:42 +00:00
Joshua Litt 7ac9c46977 [dart2js_info] Fix tests after migration.
Change-Id: Idafa7d2ea308cf480fcbdac21b7ae5d783c81a32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210060
Commit-Queue: Joshua Litt <joshualitt@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2021-08-13 18:47:41 +00:00
Ben Konyi 4c9e322dd4 [ VM / Service ] Allow for CpuSamples to be streamed when samples are about to be overwritten.
TEST=pkg/vm_service/test/cpu_samples_stream_test.dart

Change-Id: I1fcb49b6a79cde725a1f0622d1327b9a86165ae9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206920
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2021-07-16 20:50:58 +00:00
Brian Wilkerson 9f01e024f7 Enable the verify_diagnostics_test on the bots
The test was marked as flaky because it was timing out. This should give
the test longer to run, making it possible to enable it again.

Change-Id: I086b70e128185a7def9967d81b647834823c1e06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/203360
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Brian Wilkerson <brianwilkerson@google.com>
2021-06-11 15:44:56 +00:00
Danny Tuppeny 48a67a24f5 [dds] Improve error logging if DAP tests fail to connect
+ re-enable tests

Change-Id: I0262db03ee0df9714d2086dc40265bea2962ee5d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202760
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
2021-06-07 20:52:13 +00:00
Alexander Thomas af98f73849 [infra] Skip analyzer/tool/experiments/experiments_test
The test causes flaky purple builds on CI and CQ.

https://github.com/dart-lang/sdk/issues/46277

Change-Id: I60bd0447ff8f10cb2d7ecb680a3a849580c88938
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/202625
Auto-Submit: Alexander Thomas <athom@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
2021-06-07 13:45:42 +00:00
Liam Appelbe 96bb78a5ec [wasm] Prepare for release
- Update pubspec and readme.
- Copy the setup.dart output directory logic from package:webcrypto
- Work around NPE in IsFfiCompound (see https://dart-review.googlesource.com/c/sdk/+/199602)
- Move all the wasm tests into the pkg/wasm directory

Bug: https://github.com/dart-lang/sdk/issues/45967
Change-Id: I467eb5401c9dfc94c2c6771e79a3da24459c9691
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/199368
Commit-Queue: Liam Appelbe <liama@google.com>
Reviewed-by: Michael Thomsen <mit@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2021-05-20 20:40:15 +00:00
Ryan Macnak 5a385890b9 [test] Apply simarm64 status file entries to simarm64c.
Remove references to the removed simarmv6 architecture.

TEST=ci
Change-Id: I10e9fc8291c3e5b6b9a4bd71ca05de95e53f22c6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/187500
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2021-02-25 21:18:02 +00:00
Clement Skau 2236883ff2 [SDK] Removes non-exiting tests from .status
TEST=Tested all configurations.

Change-Id: Iec00d7e6ea56221ffebcf044de22647907f598f1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/182500
Reviewed-by: Tess Strickland <sstrickl@google.com>
Commit-Queue: Clement Skau <cskau@google.com>
2021-02-04 06:46:13 +00:00
Jens Johansen 30ae8e3d14 [CFE] Rename tests that require git; split unit_test_suites; filter tests better
This CL is a warm-up to a follow-up change that will make running the
CFE trybot faster.
This CL:
* Rename tests that require git (because when working with filesets
  and shards in the test system, the "checkout" is not a git checkout
  and git commands thus doesn't work properly.
* Filters the front-end unit test setup on the front-end bot the way
  it was probably intended, i.e. run tests in pkg/kernel, pkg/front_end
  and pkg/fasta (actually, the last one doesn't exist, but still)
  instead of just in folders inside the "suite" 'pkg' that somewhere in
  the path has something called 'kernel', 'front_end' or 'fasta'.
* Split unit_test_suites.dart into a "forwarding shell" and a impl.
  In a follow-up CL the impl will be converted to nnbd to allow for
  using 'required' on named parameters, but if the entry point was
  nnbd it would run in sound nnbd mode and nothing would compile
  because all imports are not nnbd.

Overall this CL should change very little, mostly just run a few less
tests, i.e. for instance skip tests that live inside a folder called
'fasta' somewhere inside the analyzer directory path.

Change-Id: I3226c7261cff8b68cc287cff07dc1715dfd85159
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/181381
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2021-01-28 07:46:10 +00:00
Sigmund Cherem 7c1b43d10a [dart2js] make js_runtime a proper package
Change-Id: Ib5583f79abc0ab00a96ce6473282f4322da5143c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/180720
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2021-01-25 22:39:23 +00:00
Sigurd Meldgaard 00b7040dc8 Remove obsolete dartfix build target and scripts
The package was deleted in 224a997a23

Bug: https://github.com/dart-lang/sdk/issues/43863
Change-Id: I599ea7b594365ef244550c90f50bab15d116c937
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170696
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
2020-11-13 09:18:36 +00:00
Jens Johansen 8fe78d5f31 [CFE] Give incremental_compiler_leak_test more time and reduce risk of hang
Change-Id: Iba96a9fb3f304b964d10838462b484ad33283185
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/162752
Commit-Queue: Jens Johansen <jensj@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
2020-09-16 13:07:38 +00:00
Johnni Winther e7d0947811 [kernel] Delete bin/transform.dart
Change-Id: I92b9f13d4e541c080fa29c9a79df0c925eebcc7a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159241
Commit-Queue: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Jens Johansen <jensj@google.com>
2020-08-19 13:07:41 +00:00
Jens Johansen f3ce2d6c33 [CFE] Mark two incremental tests slow (2nd try)
The tests incremental_dart2js_test and incremental_compiler_leak_test
- taking ~1 minute each locally - often times out at 4 minutes (after
almost being done) on the bots. This CL gives them a little more time
hopefully allowing them to finish.

Fixes https://github.com/dart-lang/sdk/issues/43000

Note that this is the 2nd try as the first try accidentially had the
extension (.dart) in the status file so they did not apply.

Change-Id: I6bad5e96f247a65ec795b238308cc570454d3090
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/159247
Reviewed-by: Jens Johansen <jensj@google.com>
2020-08-19 09:40:08 +00:00
Jens Johansen e92533dea3 [CFE] Mark two incremental tests slow
The tests incremental_dart2js_test and incremental_compiler_leak_test
- taking ~1 minute each locally - often times out at 4 minutes (after
almost being done) on the bots. This CL gives them a little more time
hopefully allowing them to finish.

Fixes https://github.com/dart-lang/sdk/issues/43000

Change-Id: Ic6309ebc1a0c77300f1b4f5262f8d48f4de3e0be
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/157982
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Jens Johansen <jensj@google.com>
2020-08-11 12:42:09 +00:00
Ben Konyi cb6ed67a73 [ VM ] Fix issue where dartdev's script_uri was being freed prematurely
This was causing flaky failures when initializing DDS as it was invoking
the getVM RPC which in turn sometimes accessed the script_uri after it
had been freed.

Change-Id: I4454b6fa2da3ad6767938ed12b1013223a667af7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/155740
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
2020-07-27 19:11:53 +00:00
Vyacheslav Egorov 69ec1a9965 [vm/aot] Add machine readable precompiler trace
This CL adds --trace-precompiler-to option which generates a machine readable
precompiler trace (list of all compiled functions and their dependencies).

It also expands package:vm_snapshot_analysis with tools for reading and
analysing this trace.

For example snapshot_analysis explain dynamic-calls command allows
to list all dynamic calls sorted by their impact on the size of the AOT
snapshot.

Issue https://github.com/dart-lang/sdk/issues/41249

Cq-Include-Trybots: luci.dart.try:pkg-linux-debug-try,pkg-linux-release-try,pkg-win-release-try,pkg-mac-release-try
Change-Id: Ie49143f4da375067991991e2ad20a41ec67bb1c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152851
Commit-Queue: Vyacheslav Egorov <vegorov@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2020-07-03 09:29:10 +00:00
Vyacheslav Egorov bfb59f42eb [gardening] Skip vm_snapshot_analysis tests on non-VM configurations
Closes https://github.com/dart-lang/sdk/issues/42452

TBR=sstrickl@google.com

Change-Id: I5f5f9890321c44cd14420ac1a80a0a76bcb187ed
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/152142
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2020-06-23 14:44:16 +00:00
Stephen Adams 88411f7cf7 Don't run analysis_server_client tests on dart2js
They use 'dart:io'.

Change-Id: Ia18dff5c4427e5592adbe426d2d1afb3b1af9b53
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151361
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2020-06-17 05:08:40 +00:00
Stephen Adams 60ec2b31e6 [dart2js] More sharding of rti_need and rti_emission tests
Both are now sharded 4-ways, which should reduce the individual shards
to about 2 minutes.

Change-Id: I5e8a718a0b5c58b0850015bee76f10df26aee84d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/151141
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2020-06-15 16:32:25 +00:00
Joshua Litt 20faaa5d94 [dart2js] Move dart2js unit tests to pkg/compiler/test.
Change-Id: Ib18f554c1076f27a3f7c0df5a36410da41a1f467
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148784
Reviewed-by: Paul Berry <paulberry@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
2020-05-28 18:51:11 +00:00
Paul Berry eeed19d6e4 Skip pkg/nnbd_migration/tool tests on dart2js.
These tests are only meant to run on the VM.  They won't work on
dart2js because they require doing I/O to check the status of
generated files.

Change-Id: I3611dd68353827828e9993fa9d042fb086863396
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144800
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-04-24 18:37:08 +00:00
Alexander Markov 9445b52b45 [vm/test] Remove timeouts for pkg/vm/test/kernel_front_end_test test cases
Test cases in this test could be slow, especially if other tests are
running simultaneously. They could run out of 30 second default
timeout enforced by package:test for each individual test case.

If test hangs, test.py would kill it anyway.

Fixes https://github.com/dart-lang/sdk/issues/41489

Change-Id: I16fef1f2a157392f3ff6a695a6ba72fa9ec4da14
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/144004
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-04-20 18:14:12 +00:00
Regis Crelier 50eaadbe70 [gardening] Skip timing out pkg/vm/test/kernel_front_end_test.
Filed http://dartbug.com/41489

Change-Id: Ia32a1100de2d6f81fa0c871d0c995ef14c0143d4
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143422
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Régis Crelier <regis@google.com>
2020-04-14 23:05:19 +00:00
Regis Crelier ece4ad5688 [gardening] Mark timing out tests in pkg as slow.
Change-Id: I3802b3cba0a7ac1cbf8d7e1f073261f8519c15aa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143385
Reviewed-by: Régis Crelier <regis@google.com>
2020-04-14 22:06:18 +00:00
Jaime Wren aa3d4ef958 Mark dartdev/test/* as Slow, Pass in pkg/pkg.status file
Change-Id: I290e6792b515a64cb275af5e3def3efa9bd01734
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/143285
Reviewed-by: Jaime Wren <jwren@google.com>
Commit-Queue: Jaime Wren <jwren@google.com>
Auto-Submit: Jaime Wren <jwren@google.com>
2020-04-14 19:09:35 +00:00
Ben Konyi a74e877104 [ package:dds ] Initial commit of the Dart Development Service, package:dds
- Defined initial interface
- Currently can spawn an HTTP server and forward websocket and HTTP
requests to the VM service
- Simple smoke tests
- Initial documentation in dds_protocol.md and other book keeping
- Enabled analysis on bots

Change-Id: Ia11e9e33fd10b0b4700b704a29e2977341441cec
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/139542
Commit-Queue: Ben Konyi <bkonyi@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-03-19 23:36:45 +00:00
Devon Carew c8ed304e97 [dartdev] add a dartdev 'create' command
Change-Id: I95625a9c422335ba5de92c887afce9eb564d6a04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133460
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Jaime Wren <jwren@google.com>
2020-02-02 02:23:13 +00:00
Mayank Patke ed441e48d0 Update all Slow tests to be Slow, Pass.
Change-Id: I610b272355b045eab80cf941210774fb12d775eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/134103
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Mayank Patke <fishythefish@google.com>
2020-02-01 00:17:42 +00:00
Stephen Adams 4078b3b352 Don't run pkg/dartdev/test/command_test on dart2js
TBR: jwren@google.com
Change-Id: Ib7693ebbd874ee35a0388416c669397ff3505ecc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/133282
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2020-01-24 20:07:43 +00:00
Johnni Winther e3a20bf361 [analyzer,cfe,dart2js] Support annotated code generation
Add support for generating annotations from actual data using
option -g

Change-Id: I88d9cdb62a38d579234b15097c9e9bb3d81ebe8c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/129708
Reviewed-by: Dmitry Stefantsov <dmitryas@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
2020-01-03 13:57:39 +00:00
Martin Kustermann 7a0d9455e4 [vm/aot] Ensure interface targets are re-resolved after deduping of mixin application classes
When the CFE compiles an application as a whole (reads in all source
code), the interface targets to members of mixin applications are the
original mixin classes.

When the CFE compiles an application modularly (dependencies are
supplied as kernel files), the interface targets to members of mixin
applications are the copied members in the mixin application classes.

This slight difference does not surface in any test failures. Yet if we
start running our AOT kernel pipeline, we will deduplicate the mixin
application classes. This leaves dangling references (with no target).

The C++ AOT compiler, `gen_snapshot`, will crash if it hits any of
those.

Issue https://github.com/dart-lang/sdk/issues/39375

Change-Id: I17a57370a87cfbdc174829c2e68ecdb7c4a9757e
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/124993
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Reviewed-by: Samir Jindel <sjindel@google.com>
2019-11-13 20:03:04 +00:00
Mayank Patke 0722c39ffa [dart2js] Mark pkg/js_ast/test/printer_callback_test as slow.
Change-Id: Ia552af22a1f79a3cadf9f0caaff9612b553e6a92
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123544
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-10-30 20:49:13 +00:00
Stephen Adams 18acdf11ef status file update for js_ast
Change-Id: I3f691cb1f58ef24e9256730faf3ae02a5a287c06
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/123325
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
2019-10-28 23:49:20 +00:00
Samir Jindel c885bdde1d [vm] DBC is obsolete. Remove dead code.
Change-Id: Ica33af158cca53c8e951e4b2582de83660e8a60d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/121851
Commit-Queue: Samir Jindel <sjindel@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
2019-10-27 18:18:29 +00:00
Martin Kustermann e82fedc345 [vm] Remove deprecated (and untested) ARMv5 support from the VM
Since we have no CQ/CI test coverage of ARMv5 and none of our customers
uses it, a breaking change request was made (see issue further down).

The breaking change has been approved and a corresponding email has been
sent out:

https://groups.google.com/a/dartlang.org/forum/?nomobile=true#!topic/announce/vRQja7di3FQ

This CL removes any armv5 related code from our codebase.

Closes https://github.com/dart-lang/sdk/issues/36666

Change-Id: I9abf32f1980ca19a9cf882b43c9966b2127f89e3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/122540
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Martin Kustermann <kustermann@google.com>
2019-10-23 14:44:33 +00:00
Alexander Aprelev 6364302f5d [gardening] Skip pkg/frontend_server on all but vm
This is follow-up to
https://dart-review.googlesource.com/c/sdk/+/120321.

Bug: dartbug.com/38757
Change-Id: I799ab99b61af1fdd05d676308daaf43937267c04
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/120682
Reviewed-by: Alexander Aprelev <aam@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
2019-10-08 15:41:11 +00:00
Mayank Patke 1707aff921 [dart2js] Mark pkg/modular_test/test/validate_{pipeline,suite}_test as slow.
Change-Id: If3cc979a51182bfefca4fb06aa77048c99e02868
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118905
Auto-Submit: Mayank Patke <fishythefish@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
Reviewed-by: Stephen Adams <sra@google.com>
2019-09-26 20:01:48 +00:00
Stephen Adams 73eb0ee4ae Mark pkg/modular_test/test/memory_pipeline_test slow (to compile) on dart2js
Change-Id: Ie2a2c91ba77368d7199f3d4d3dfbe094525ef132
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/118368
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Stephen Adams <sra@google.com>
2019-09-20 23:27:59 +00:00
Karl Klose f2789f74fc [infra] Remove non-essential test expectations with comments from pkg status file
Change-Id: I8e5d565cf92491c486d1210455837adeb317c6b5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/114856
Commit-Queue: Karl Klose <karlklose@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-09-04 07:18:51 +00:00