Commit graph

2 commits

Author SHA1 Message Date
Nicholas Shahan 10656e3dcd [dart2js] Enforce recommended lints in pkg/js_ast
Enforcing these lints helps reduce the diffs with the forked version
in pkg/dev_compiler/lib/src/js_ast.

Enforce extra lints:
- always_declare_return_types
- depend_on_referenced_packages
- directives_ordering
- prefer_single_quotes
- prefer_relative_imports

Add ignores for:
- avoid_function_literals_in_foreach_calls
- avoid_renaming_method_parameters
- constant_identifier_names
- non_constant_identifier_names
- prefer_void_to_null

Change-Id: I6b96eca51fdb698927569df538d1db1bf07498cd
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/239325
Reviewed-by: Stephen Adams <sra@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2022-04-01 18:26:01 +00:00
Stephen Adams 0e2f274a51 [js_ast] Add analysis_options.yaml, add @overrides
Change-Id: Ice4a9cf104d9e454c9a473051ed7c94d06b5090f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/238385
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
2022-03-23 23:38:21 +00:00