We also stop reporting
`HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE` and
`HintCode.DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE_WITH_MESSAGE`
as these are now replaced by the new lint rule.
The biggest change here is in the DEPRECATED_MEMBER_USE tests,
as most of these tests have
`DEPRECATED_MEMBER_USE_FROM_SAME_PACKAGE` reported (since it's
easier to write tests with files in one package). We move all
of those tests to `DEPRECATED_MEMBER_USE` tests, without losing
coverage.
Bug: https://github.com/dart-lang/sdk/issues/50796
Change-Id: I7cada44265cd0e1e47ab77d4354de9a5571db614
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289444
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Upcoming changes to the analyzer will result in compilation errors
in dartdoc without this change.
Change-Id: Ie80724fcfa6bc2b6fdfff3d851806669f9c20329
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290401
Auto-Submit: Janice Collins <jcollins@google.com>
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Janice Collins <jcollins@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
This has two changes:
- Hide "--fix" in the help. The command is still fully supported, we
just don't show it because we want to gradually migrate users to
"dart fix".
- Remove support for the "interface", "final", and "sealed" modifiers
on mixin declarations, since the proposal no longer supports those
(and we need to remove them from the analyzer AST API).
There are no meaningful style changes, so there's no need to update the
pre-build SDK for this change.
Change-Id: I2357970e298a9be8f6f26efb5b922d40ee4fbb7d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/290020
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Kallen Tu <kallentu@google.com>
http (805a147..74f9d3d):
74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889)
ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868)
2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888)
Change-Id: I56faf5cf41ad16f6a365db66265b02e66adbc59f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289502
Commit-Queue: Devon Carew <devoncarew@google.com>
Reviewed-by: Devon Carew <devoncarew@google.com>
Auto-Submit: Ivan Inozemtsev <iinozemtsev@google.com>
Change-Id: I00752198daceccf41d688f5aeb3bb8595e91d78b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289040
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
args (9305d5a..7a5e3b0):
7a5e3b0 2023-03-14 Devon Carew update readme; add contributing doc (#237)
benchmark_harness (a6a0891..725534a):
725534a 2023-03-14 Kevin Moore Spelling fixes, latest lints, move to minilibs (drop parts) (#85)
csslib (b671738..d32bdd4):
d32bdd4 2023-03-14 Devon Carew refactor the package example (#170)
dartdoc (98fa859..7fde7a4):
7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)
http (805a147..74f9d3d):
74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889)
ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868)
2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888)
shelf (e3cfe79..9a792b4):
9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340)
c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339)
webdev (cfe9753..a15fde0):
a15fde0 2023-03-15 Anna Gringauze fix matching record types (#2032)
05031da 2023-03-14 Anna Gringauze Update build_daemon constraint and log errors (#2029)
49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024)
442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021)
yaml_edit (6abc42a..fbc5cb3):
fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints
c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42)
Change-Id: Ia79a056cfaf7e51e73fdc6fd353e5f1938e6881a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/289023
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
dartdoc (98fa859..7fde7a4):
7fde7a4d 2023-03-13 dependabot[bot] Bump github/codeql-action from 2.2.5 to 2.2.6 (#3363)
http (805a147..74f9d3d):
74f9d3d 2023-03-09 Brian Quinlan Add conformances test that verify that the Client works in Isolates (#889)
ee03604 2023-03-09 Brian Quinlan Add a flag to allow the default Client to be tree shaken away. (#868)
2039fb3 2023-03-09 Brian Quinlan Fix a reference count race with forwarded delegates. (#888)
matcher (c1a0704..985e4ef):
985e4ef 2023-03-10 Sigurd Meldgaard Improve mismatch description of `contains` (#206)
5bc765d 2023-03-09 Nate Bosch Copy expect and async matchers from test package (#210)
shelf (e3cfe79..9a792b4):
9a792b4 2023-03-13 Kevin Moore Update format for latest v3 SDK (#340)
c8094b7 2023-03-13 Kevin Moore Update no-response.yml - once a day (#339)
test (3ba78f1..0e5c028):
0e5c028d 2023-03-10 Nate Bosch Only use environment variable for chrome (#1970)
0b08d704 2023-03-08 Nate Bosch Add a hooks_testing library (#1952)
aacee2c7 2023-03-08 Nate Bosch Retry filesystem deletes (#1965)
webdev (cfe9753..49013b8):
49013b8 2023-03-09 Elliott Brooks (she/her) [MV3 Debug Extension] Fix authentication issue for the Dart Debug Extension (#2026)
c8d4439 2023-03-09 Elliott Brooks (she/her) Support `Set` inspection in DWDS (#2024)
442639d 2023-03-08 Elliott Brooks (she/her) Handle unexpected extension debugger disconnection events without crashing app (#2021)
yaml_edit (6abc42a..fbc5cb3):
fbc5cb3 2023-03-09 Kevin Moore Require Dart 2.19, update to latest lints
c9e82f0 2023-03-09 Mohamed Ishad Fix YamlEditor.update method leaving trailing spaces at eol (#42)
Change-Id: Idc785347448e6a56e26d9d46b3666440d59c22de
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/288801
Auto-Submit: Devon Carew <devoncarew@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Our "all" build targets were actually broken by protobuf-gn at revision
5f87ef9990fc4f4ffd76b3f5b0138562178db8bc, and got fixed again at
revision 390a1c9bd6fe63f0ca474ac1bc1bc23033e1ecf8. This updates our dep
to a revision newer than 390a1c9bd6fe63f0ca474ac1bc1bc23033e1ecf8.
Change-Id: Ibc60e7067e01702a3ae120bbbbb7a603fcad6f47
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287621
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Derek Xu <derekx@google.com>
Includes just one more commit - "Enable support for inline class syntax"
Change-Id: Ie230fc72b7170d3610bdd7ed7ab8c193338f8a93
Bug: b/271244238
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/287020
Commit-Queue: Oleh Prypin <oprypin@google.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
This reverts commit c67fac9cb4.
Reason for revert: Regresses `dart:io` performance and causes
failures.
https://github.com/dart-lang/sdk/issues/51639
Original change's description:
> [vm] Remove tcmalloc and malloc profiler.
>
> The standalone VM originally began statically linking tcmalloc to work around bugs in the system malloc for Fiber. Later it used tcmalloc's hooks to implement a profiler, but this is rarely used since it is only available in debug mode, misses early allocations, and often misses late allocations from an exhausted sample buffer. Removing it altogether avoids build complexity around which combinations of compiler/architecture/sysroot support tcmalloc, and reduces binary size.
>
> TEST=ci
> Change-Id: I4b259e18b82b2d12a2a60962aabf83bd8d997d19
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286120
> Reviewed-by: Ben Konyi <bkonyi@google.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
Change-Id: I4395edd6f5bd7e26b4e38f4d931ad2ea67afba18
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286925
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Daco Harkes <dacoharkes@google.com>
The standalone VM originally began statically linking tcmalloc to work around bugs in the system malloc for Fiber. Later it used tcmalloc's hooks to implement a profiler, but this is rarely used since it is only available in debug mode, misses early allocations, and often misses late allocations from an exhausted sample buffer. Removing it altogether avoids build complexity around which combinations of compiler/architecture/sysroot support tcmalloc, and reduces binary size.
TEST=ci
Change-Id: I4b259e18b82b2d12a2a60962aabf83bd8d997d19
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286120
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
This contains support for all of the 3.0 language features. It also
contains a couple of very minor style changes. Unlike the previous
reverted roll (https://dart-review.googlesource.com/c/sdk/+/285460),
this does *not* contain the style change to support compact switch
statements. This should eliminate most of the style churn.
Change-Id: I95dd73a3a921b4a0cd278a7abb86daf8eea21397
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286701
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
This reverts commit 69b9559caf.
Reason for revert: Windows error: overflow in expression
Original change's description:
> Roll Clang from 20d06c833d83 to 28ee6040710f
>
> If this roll has caused a breakage, revert this CL and stop the roller
> using the controls here:
> https://autoroll.skia.org/r/clang-dart-sdk
> Please CC dart-engprod@google.com,dart-vm-gardener@grotations.appspotmail.com,dart-vm-team@google.com on the revert to ensure that a human
> is aware of the problem.
>
> To file a bug in Clang: https://bugs.fuchsia.dev/p/fuchsia/issues/list?q=component%3AToolchain
> To file a bug in Dart SDK: https://github.com/dart-lang/sdk/issues
>
> To report a problem with the AutoRoller itself, please file a bug:
> https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug
>
> Documentation for the AutoRoller is here:
> https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
>
> Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
> Change-Id: I433a87e0b7a2f8407ea3b8e23a1894957cfa23ac
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286580
> Commit-Queue: DEPS Autoroller <dart-autoroll@skia-public.iam.gserviceaccount.com>
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Ryan Macnak <rmacnak@google.com>
Change-Id: I09a090a33fb663327eb74e5a192714673bcd661f
Cq-Include-Trybots: luci.dart.try:dart-sdk-linux-try;luci.dart.try:dart-sdk-mac-try;luci.dart.try:dart-sdk-mac-arm64-try;luci.dart.try:dart-sdk-win-try
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286608
Auto-Submit: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
This reverts commit bbba3c9788.
Reason for revert: latest dart_style has a few bugs and overall the changes should be discussed more
Original change's description:
> Roll the latest dart_style into the SDK.
>
> This includes support for records, patterns, sealed classes, and class
> modifiers. It also includes a fairly small number of style changes. The
> one that will be most noticeable is more compact switch statements.
>
> Change-Id: I9e89ba82d52bfa451fc54f9dd59048d72db48377
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285460
> Reviewed-by: Alexander Thomas <athom@google.com>
> Reviewed-by: Johnni Winther <johnniwinther@google.com>
> Commit-Queue: Bob Nystrom <rnystrom@google.com>
> Auto-Submit: Bob Nystrom <rnystrom@google.com>
Change-Id: I12fad53bdc75dda349b9362aeb84e798983bfa25
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/286420
Reviewed-by: Alexander Thomas <athom@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Oleh Prypin <oprypin@google.com>
Commit-Queue: Oleh Prypin <oprypin@google.com>
This includes support for records, patterns, sealed classes, and class
modifiers. It also includes a fairly small number of style changes. The
one that will be most noticeable is more compact switch statements.
Change-Id: I9e89ba82d52bfa451fc54f9dd59048d72db48377
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285460
Reviewed-by: Alexander Thomas <athom@google.com>
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
cli_util (fd38b5f..3851652):
3851652 2023-02-24 Kevin Moore Move to dart_flutter_team_lints, require Dart 2.19 (#77)
705bb29 2023-02-24 Kevin Moore blast_repo fixes (#76)
crypto (03eb2c9..9efb888):
9efb888 2023-02-23 Kevin Moore move to pkg:dart_flutter_team_lints, require Dart 2.19 (#141)
test (2cc4144..1307cc5):
1307cc59 2023-02-23 Nate Bosch Add ComparableChecks extension (#1960)
66f2985c 2023-02-24 Pascal Welsch Fix isNotEmpty rejection (#1959)
cf10dc5b 2023-02-23 Nate Bosch Condition must have dynamic generic in deepEquals (#1958)
6fc48d03 2023-02-23 Nate Bosch Fix timeouts when a predicate throws instead (#1957)
vector_math (920e9b6..1e4d000):
1e4d000 2023-02-23 Kevin Moore Move to latest team lints, require Dart 2.19 (#281)
webdev (1e7f9b7..deb801b):
deb801b 2023-02-24 Devon Carew contribute issue templates and pull request labeling (#1979)
74a6520 2023-02-24 Elliott Brooks (she/her) [MV3 Debug Extension] Use new Dart Debug Extension bug template (#1992)
c1f325c 2023-02-24 Elliott Brooks (she/her) [MV3 Debug Extension] Bolt debugging: can reload the page and continue to debug (#1991)
057f598 2023-02-23 Elliott Brooks (she/her) [MV3 Debug Extension] Small fixes for building the extension (#1990)
28a090e 2023-02-23 Anna Gringauze Run dwds tests in a copy of the sdk directory (#1989)
b58d3eb 2023-02-23 Anna Gringauze Run webdev tests in a copy of the sdk directory (#1987)
Change-Id: Iaad67eec68cf3cfeba832abbeb42728043e15b22
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/285760
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Revisions updated by `dart tools/rev_sdk_deps.dart`.
dartdoc (dba6f94..e4cdbd6):
e4cdbd6f 2023-02-21 Janice Collins Record rendering simplification (#3344)
http (c13a3f8..1500a71):
1500a71 2023-02-23 Devon Carew contribute a pull request labeler workflow (#875)
e2c4e6f 2023-02-21 Brian Quinlan Add a link to cronet_http_embedded from cronet_http. (#874)
markdown (4befe66..ecbffa9):
ecbffa9 2023-02-22 Kevin Moore Use latest lints, require Dart 2.19 or later (#524)
shelf (707c8b2..e3cfe79):
e3cfe79 2023-02-22 Devon Carew contribute issue templates and a pull request labeler (#332)
test (e56c643..2cc4144):
2cc4144e 2023-02-22 Nate Bosch Avoid exceptions for iterable getters (#1954)
f7fe4f06 2023-02-22 Nate Bosch Include stack trace for exception in has (#1953)
ba8e43af 2023-02-22 Nate Bosch Only grab the first failure in softCheck (#1949)
34df652b 2023-02-22 Nate Bosch Flush stdin before test (#1950)
ae015ef6 2023-02-22 Nidal Bakir Add Concurrency Testing section to README (#1944)
4e23d036 2023-02-21 Nate Bosch Mention .having and .has in migration guide (#1948)
438c2274 2023-02-21 Nate Bosch Annotate `has` with `@useResult` (#1947)
3ddecafd 2023-02-21 Nate Bosch Add async examples to README (#1946)
tools (a53933c..c7518f7):
c7518f7 2023-02-22 Elias Yishak Update to regex to look for underscore delimited labels (#12)
webdev (ae7eb80..1e7f9b7):
1e7f9b7 2023-02-22 Anna Gringauze Create copying sdk configuration provider (#1984)
26910ba 2023-02-22 Anna Gringauze Pass SdkLayout to the frontend server (#1986)
784e28b 2023-02-22 Anna Gringauze Remove unnecessary awaits (#1982)
3cbaf37 2023-02-22 Elliott Brooks (she/her) [MV3 Debug Extension] Support Bolt workflow (#1983)
0f893e6 2023-02-22 Anna Gringauze Move project definitions into a separate class (#1975)
a942b5f 2023-02-22 Anna Gringauze Add unnecessary_lambdas lint (#1978)
3774cf8 2023-02-21 Anna Gringauze Add 'avoid_void_async' lint (#1977)
705e0ac 2023-02-21 Elliott Brooks (she/her) [MV3 Debug Extension] Show a warning if multiple Dart apps are in a single page (#1976)
Change-Id: Iea264a18a154e71cd0990e1363951648bec5ceba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/284940
Reviewed-by: Konstantin Shcheglov <scheglov@google.com>
Auto-Submit: Devon Carew <devoncarew@google.com>
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
