Commit graph

12 commits

Author SHA1 Message Date
Sam Rawlins 8d998a89a2 Update migration tool README
Change-Id: I16349a7399d735a6edf8615570f4c783a98e8276
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/263461
Reviewed-by: Paul Berry <paulberry@google.com>
Auto-Submit: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2022-10-13 19:00:25 +00:00
Paul Berry d6292f99c2 Add a notice to the nnbd_migration package README.
I plan to publish this on pub, and then mark the package as
discontinued.  Customers should invoke NNBD migration using the `dart
migrate` command.

Change-Id: Ia871e71258e3951ac7fd866e46ae97043a6fa93c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/167364
Reviewed-by: Samuel Rawlins <srawlins@google.com>
Commit-Queue: Paul Berry <paulberry@google.com>
2020-10-13 16:29:08 +00:00
Sam Rawlins 6ac9749546 Update nnbd_migration README with more details.
* Use title case on all headings.
* Link to https://dart.dev/null-safety and
  https://dart.dev/tools/pub/cmd/pub-outdated
* Remove any text which suggests to publish. Official docs warn
  strongly against using in production.
* Mention `pub outdated --mode=null-safety`.
* Mention migrating a clean code repository.
* Add more text about committing along the way.
* Make clear that the tool provides no revert capability.

Change-Id: I7914dc904a93046ce2508c51cae158ac39e889af
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150822
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
2020-06-11 03:33:25 +00:00
Michael Thomsen ab2020725c Clarify migration guidance
Closes https://github.com/dart-lang/sdk/pull/42172
https://github.com/dart-lang/sdk/pull/42172

GitOrigin-RevId: af666ade7a03affc5210ddd644ac1f9ede682df1
Change-Id: I2cf627aab3d79c32025a2fd345d30dc97ef0cc02
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149802
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2020-06-03 16:06:53 +00:00
creativecreatorormaybenot 1b886a806d [nnbd_migration] Fix typos/mistakes
The text says "We can fix this all by adding a single `/*!*/` hint.", but the code uses `/*?*/`. I am pretty sure that this is wrong.

Closes https://github.com/dart-lang/sdk/pull/42153
https://github.com/dart-lang/sdk/pull/42153

GitOrigin-RevId: f8b974b475bdaaa5c9c82204e2313d539a8247d7
Change-Id: I03a991b93bced2e24562f57128ef4bfb21eabf82
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149685
Reviewed-by: Samuel Rawlins <srawlins@google.com>
2020-06-03 16:06:01 +00:00
Sam Rawlins 93d39a5ef5 Migrator: Edit the package_config.json file
Bug: https://github.com/dart-lang/sdk/issues/41765
Change-Id: I019a97427b6faa4d4f5335b64424fab4bc3c5cde
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149611
Commit-Queue: Samuel Rawlins <srawlins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2020-06-02 15:51:11 +00:00
Sam Rawlins 258b6cb525 Migrator: tweaks to README
* Change the "Migrating a package" to be an ordered list of steps.
* Spell 'url' as 'URL'.
* Be consistent about capitalization and hyphenating "null-safe" and not
  hyphenating "null safety".
* Add text that the tool will edit pubspec.yaml.

Change-Id: Ief5eac682af2813d267568695f920445b0b79615
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/149484
Reviewed-by: Mike Fairhurst <mfairhurst@google.com>
Commit-Queue: Samuel Rawlins <srawlins@google.com>
2020-05-30 23:40:42 +00:00
Mike Fairhurst 9bcdbfa34e [nnbd_migration] Update README
Change-Id: Idc81bbebadbe3d6111a6e7e31ee0c68a30d8ff26
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148795
Reviewed-by: Devon Carew <devoncarew@google.com>
Reviewed-by: Janice Collins <jcollins@google.com>
2020-05-21 19:50:23 +00:00
Janice Collins 8acc0a8deb Update the README based on meeting notes
Change-Id: Icfc21a79e0f4224568bf10e508fa8867a1b251eb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140365
Commit-Queue: Janice Collins <jcollins@google.com>
Reviewed-by: Paul Berry <paulberry@google.com>
2020-03-20 23:08:36 +00:00
Devon Carew 52cb5917cc [nnbd migration] initial mogration workflow docs
Change-Id: Iac99a852f15a9d7cdb25f6233dec6a52b64a55c7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140320
Reviewed-by: Paul Berry <paulberry@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-03-20 18:13:28 +00:00
Devon Carew 3f8366363b [nnbd migration] move the docs for the NNBD migration tool
Change-Id: I932da23be10839b5bde6034f120763c54f63889f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/140102
Reviewed-by: Janice Collins <jcollins@google.com>
Commit-Queue: Devon Carew <devoncarew@google.com>
2020-03-19 23:12:24 +00:00
Paul Berry 51046368c5 Move NNBD migration tool to a fresh package.
This gives us more flexibility for how we want to publish and deploy
the tool.  We now have the option, for example, of making a command
line app that invokes the tool and does not depend on analysis_server.

Note that some testing infrastructure had to be duplicated.  I plan to
consolidate this infrastructure in follow-up CLs.

Change-Id: I046506bc2bb5c3e467e15885f198ee0632351ee9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105463
Commit-Queue: Paul Berry <paulberry@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
2019-06-09 17:45:35 +00:00