languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-07-20 18:05:01 +00:00
Code Issues Actions 1 Packages Projects Releases Wiki Activity
43994 commits 16 branches 5848 tags 1.4 GiB
Commit graph

43994 commits

This branch
This branch
All branches
Author SHA1 Message Date
Ben Konyi 1e0bf05aaf Added tracking of memory usage within ApiNativeScopes. Usage to be displayed within Observatory. 
BUG=
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2650583014 .
 2017-01-26 15:24:03 -08:00
Matthias Hausner cc8139350d Add debug step check before break and continue 
This allows debuggers to set a breakpoint in a line that contains
a break or continue statement.

When running dart2js on a small program, this adds around 900 DebugStepCheck
runtime calls. I’m not sure the price is worth paying.

BUG=#28473
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2651263002 .
 2017-01-26 13:49:37 -08:00
Florian Schneider 9ea0dbcab1 VM: Remove unused optimization of merging of sin/cos. 
It was only implemented on ia32/x64, and has been disabled
for a long time (broken on Windows).

Fixes #22504.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2658733002 .
 2017-01-26 12:42:54 -08:00
Konstantin Shcheglov 2d318065b0 Fix for getFilesForPath() for a generated file. 
This causes exceptions for internal users.
Not fatal, other files analysis is fine.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2655373002 .
 2017-01-26 12:12:58 -08:00
Brian Wilkerson 9761ff14d4 Backout part of previous commit to fix bots 
Review-Url: https://codereview.chromium.org/2645283009 .
 2017-01-26 11:56:06 -08:00
Brian Wilkerson 59a9861743 Fix some bugs related to the covariant keyword 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2662433002 .
 2017-01-26 11:27:42 -08:00
Konstantin Shcheglov a3cc5fe7f7 Implement using AnalysisDriver in analyzer_cli. Disabled. 
It's not ready to be enabled yet.

There are 11 failing tests in tests/language, and 174 in tests/co19.

It also works about 5 times slower.

But I'd like to land it to make parallel changes to AnalysisDriver and
analyzer_cli to make it pass more tests and be faster.

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657903006 .
 2017-01-26 10:16:52 -08:00
Ryan Macnak 3392aa94dc Fix refactoring mistake in Mac ~VirtualMemory. 
TBR=asiva@google.com

Review-Url: https://codereview.chromium.org/2656123002 .
 2017-01-26 10:14:56 -08:00
Ryan Macnak 8b217ec519 Rename references to "external pages" as "image pages" to avoid confusion with the kind of external memory associated with finalizers. 
R=asiva@google.com

Review-Url: https://codereview.chromium.org/2654183002 .
 2017-01-26 09:53:06 -08:00
Konstantin Shcheglov 15cf5cb017 Run analyzer_cli asynchronously. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2658863002 .
 2017-01-26 09:42:51 -08:00
Konstantin Shcheglov d142d80af7 Make analyzer_cli batch mode asynchronous. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2659463003 .
 2017-01-26 07:25:23 -08:00
Konstantin Shcheglov 12191284aa Add NullByteStore, that does not store any data. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653203005 .
 2017-01-26 07:21:54 -08:00
Dan Rubel 2cc2e63f63 IncrementalKernalGenerator watch source callback 
Update the IncrementalKernalGenerator.computeDelta() method
with an optional "watch this source" callback.
This new callback notifies the caller when a source should be watched
for modifications, and when a source is no longer part of the program
and thus no longer needs to be watched.

R=paulberry@google.com

Review-Url: https://codereview.chromium.org/2653143003 .
 2017-01-26 08:25:28 -05:00
Johnni Winther 8c86a3c5db Fix query to isFunctionApplyMethod 
Review-Url: https://codereview.chromium.org/2656073002 .
 2017-01-26 13:16:47 +01:00
Johnni Winther 6c919f02b4 Add no-info mappings at start of out.js and after mapped functions 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2654023003 .
 2017-01-26 11:46:06 +01:00
Johnni Winther b699aba744 Reenable parts of kernel/impact_test 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2653673011 .
 2017-01-26 10:38:10 +01:00
Johnni Winther a3d0329735 Use entities in CommonElements interface. 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2653203002 .
 2017-01-26 10:29:13 +01:00
Johnni Winther d2645e2ffd Further decouple KernelImpactBuilder from elements 
R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2655843003 .
 2017-01-26 10:23:56 +01:00
Dan Rubel 236497901e Revert "add warning for deprecated .analysis_options file name" 
This reverts commit b431498760.

Review-Url: https://codereview.chromium.org/2654223002 .
 2017-01-25 23:03:03 -05:00
Dan Rubel b431498760 add warning for deprecated .analysis_options file name 
This warns users about using the deprecated analysis options file name
and recommend that they rename it.
See https://github.com/dart-lang/sdk/issues/28385

R=brianwilkerson@google.com

Review-Url: https://codereview.chromium.org/2654043003 .
 2017-01-25 22:00:36 -05:00
Vijay Menon fd94337b42 Fix for Animation and other polyfills 
The polyfill code needs to run before dart_sdk is loaded.  Otherwise, the registerExtension step on these types does not work.

Also fixes #27605

R=jacobr@google.com

Review-Url: https://codereview.chromium.org/2649613003 .
 2017-01-25 16:18:49 -08:00
Vijay Menon a91cc9cc9e Use microtasks in dart.async 
Not quite sure about this, but it makes ordering match for the example in  #28509

R=jmesserly@google.com

Review-Url: https://codereview.chromium.org/2653253002 .
 2017-01-25 16:14:01 -08:00
Siva Annamalai 9a4d616c35 Fix status files to correctly account for asan failure in x64 target only. 
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2657953002 .
 2017-01-25 16:12:52 -08:00
Jennifer Messerly 0e00b3e5c8 fix #28008, fix #28009 implement FutureOr<T> 
This implements FutureOr<T> in strong mode, otherwise it's ignored (treated as `dynamic`.

Also fixes strong mode's inference subtype function incorrectly treating `void` as a malformed type. This had the consequence of allowing `void` to be inferred as a type argument.

R=leafp@google.com, paulberry@google.com

Review-Url: https://codereview.chromium.org/2647833002 .
 2017-01-25 15:32:57 -08:00
Konstantin Shcheglov 4cd790abe3 Record isFinal for parameters into summaries. 
Found this out while running shared tests with the new analysis driver.

R=paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657583007 .
 2017-01-25 15:08:37 -08:00
Ben Konyi de72bf4991 Moved isolate high watermark calculations into the Observatory client. 
BUG=
R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2656723002 .
 2017-01-25 15:03:42 -08:00
Brian Wilkerson f6f2ecfe69 Improve performance of visiting large invalid compilation units 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2653343002 .
 2017-01-25 14:55:32 -08:00
Ben Konyi 0d9a7970f5 Removed usage of std::map and std::vector from kernel code. Issue #28064. 
BUG=
R=zra@google.com

Review-Url: https://codereview.chromium.org/2658693002 .
 2017-01-25 14:53:33 -08:00
Matthias Hausner 197f141100 Allow debugger to stop when reading a static field 
Add a DebugStepCheck when the right-hand side of an expression is an access
to a static field or top-level variable.

BUG=#28453
R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2650823007 .
 2017-01-25 14:39:24 -08:00
Ben Konyi 6c2e67e764 Revert "Switched from GrowableArray to MallocGrowableArray to fix crash caused" 
This reverts commit ac2b995a9296a100b0385fe7f262ebefa1da30d8.

BUG=

Review-Url: https://codereview.chromium.org/2656693006 .
 2017-01-25 13:59:46 -08:00
Ben Konyi 9956256223 Switched from GrowableArray to MallocGrowableArray to fix crash caused by no isolate/thread existing when called. Also created MallocMap for the same reason. 
BUG=
R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2655463005 .
 2017-01-25 13:55:45 -08:00
Zachary Anderson 0c3d73967d VM eventhandler: Update epoll/kqueue even if the only event is an error 
Otherwise, we may try to add an fd to epoll/kqueue when it is already
there.

Also avoid sending multiple notifications on an error.

related #24417

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2655893002 .
 2017-01-25 13:50:00 -08:00
Siva Annamalai e07cc86697 Skip third_party/pkg/linter (Issue 27937) 
Review-Url: https://codereview.chromium.org/2649313007 .
 2017-01-25 13:37:47 -08:00
John McCutchan a47af8ea9e Fix memory leaks in cc/Log_* tests 
Fixes #28347

BUG=
R=vegorov@google.com

Review-Url: https://codereview.chromium.org/2651013002 .
 2017-01-25 13:32:28 -08:00
Brian Wilkerson a27c9e4a0b Skip linter tests on the pkg bots 
R=whesse@google.com

Review-Url: https://codereview.chromium.org/2655963002 .
 2017-01-25 13:26:07 -08:00
P.Y. Laligand d0a9768377 Fix analyzer tests. 
This was failing on Windows.

BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2654183003 .
 2017-01-25 13:25:07 -08:00
Konstantin Shcheglov f1f5d490d7 Fix MockSdk.fromFileUri() implementations. 
This should fix the test failure on Windows bot.

TBR

R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2653753006 .
 2017-01-25 12:08:25 -08:00
Zachary Anderson 63c4b6b1cb Revert "Remove package:unittest from some tests" 
This reverts commit dde47b2aad.

Revert "Update Dartium status for passing test"

This reverts commit d71c70d56d.

Tests failing on dart2js and async_star_pause_test is
passing on Dartium. Need to think about how to update the
status files.

Review-Url: https://codereview.chromium.org/2656503004 .
 2017-01-25 11:06:58 -08:00
Zachary Anderson d71c70d56d Update Dartium status for passing test 
Review-Url: https://codereview.chromium.org/2655913002 .
 2017-01-25 10:38:33 -08:00
Ryan Macnak ed00447138 Make the VM resilient to a confusion between a NULL instructions snapshot and instructions snapshot that is an empty array in the Flutter embedder. 
Related to issue #28504

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2648383006 .
 2017-01-25 09:58:14 -08:00
Kevin Moore 1e8558a3a6 fix spelling in core libraries 
Fixes https://github.com/dart-lang/sdk/issues/28490

R=dgrove@google.com, rnystrom@google.com

Review-Url: https://codereview.chromium.org/2655883002 .
 2017-01-25 09:36:55 -08:00
P.Y. Laligand 66cda63fea Added support for GN workspaces. 
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org/2651613003 .
 2017-01-25 09:26:45 -08:00
Paul Berry 7d314c99bb Always pass "allocate: true" when converting URIs to paths. 
There's no need to special case the handling of "dart:" URIs.
Eventually we will need the "allocate:" behavior for all URIs anyhow,
because we won't have a pre-traversal of the import graph to populate
the FileRepository.

R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2651193002 .
 2017-01-25 09:21:59 -08:00
Brian Wilkerson ed40bd3eca Add failing test for sort issue 
R=scheglov@google.com

Review-Url: https://codereview.chromium.org/2655803004 .
 2017-01-25 09:06:49 -08:00
Zachary Anderson dde47b2aad Remove package:unittest from some tests 
package:unittest is deprecated in favor of package:test.

R=fschneider@google.com

Review-Url: https://codereview.chromium.org/2656743002 .
 2017-01-25 08:50:02 -08:00
Konstantin Shcheglov ebe04d131b Issue 28387. Test for search of classes defined in SDK. 
R=brianwilkerson@google.com
BUG= https://github.com/dart-lang/sdk/issues/28387

Review-Url: https://codereview.chromium.org/2651103004 .
 2017-01-25 08:39:42 -08:00
Konstantin Shcheglov 9264c1191a Implement LibraryElement.hasExtUri for resynthesized. 
R=brianwilkerson@google.com, paulberry@google.com
BUG=

Review-Url: https://codereview.chromium.org/2657743002 .
 2017-01-25 07:03:59 -08:00
Konstantin Shcheglov b8ab9b7e17 Fix tests to run with the new analysis driver. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656783002 .
 2017-01-25 06:58:24 -08:00
Konstantin Shcheglov 608cb122e3 Fix for dart:html query() type inference. 
R=brianwilkerson@google.com
BUG=

Review-Url: https://codereview.chromium.org/2656673003 .
 2017-01-25 06:56:28 -08:00
Johnni Winther c885d809b6 Add inference test functionality based on code point id. 
The code point id is meant to be basis for AST/Kernel-IR equivalence and the test framework should thereby be portable to a Kernel based inference.

R=sigmund@google.com

Review-Url: https://codereview.chromium.org/2656583003 .
 2017-01-25 14:44:28 +01:00