Change-Id: I459caf39d812d7c9e799617cf59f38c138b14d32
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210062
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Also shorten description
Change-Id: Ida9c7ba0f8c6beb10f218ba53803352b469c7a83
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196044
Reviewed-by: Nate Bosch <nbosch@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Change-Id: Ife3c77834df9f781d447a7d3cbc842fb7e44be49
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170140
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Auto-Submit: Kevin Moore <kevmoo@google.com>
This also highlighted a couple of mistakes in the patch files for
dart:_internal and the test.
Change-Id: I60b4e7d5673d64f85a95108c9e03f9328249b9d0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153021
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
This is simply to get around the new restriction on publishing
packages that depend on a dev version of the sdk.
Change-Id: I523d6732ee2c0bc7b45a73050bff6b327372e5d6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/156564
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Auto-Submit: Nicholas Shahan <nshahan@google.com>
Change-Id: I55e9b1224f69268ccfb8ba345d3a9d62d3d93838
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/127449
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Change-Id: I0e992e40150a7eb0af7f6a039597eca89f5d9a9c
Reviewed-on: https://dart-review.googlesource.com/c/94355
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
(This is mainly needed to allow using it with bleeding edge SDKs.)
Change-Id: Ie90d4dd51c03b1f48b42066041e9f5b743d791cb
Reviewed-on: https://dart-review.googlesource.com/44401
Reviewed-by: Natalie Weizenbaum <nweiz@google.com>
We need to use it in the observable package, which is externally
available, so it needs to be able to access it from pub.
Change-Id: I85a1488decb5ef4acd062e2fb3556e7d589e2c8c
Reviewed-on: https://dart-review.googlesource.com/44385
Reviewed-by: Leaf Petersen <leafp@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
There is no actual implementation here yet (that's your job :) ), but there is:
- An external method in dart:_internal, extractTypeArguments().
- Empty patch methods for that for the VM, dart2js, and DDC. These need to have implementations
filled in.
- A "dart_internal" package to expose a subset of the API. It gives you:
extractListTypeArgument()
extractMapTypeArguments()
We'll bring this into Google, but not publish it externally unless we find we really need to.
- A test for the behavior. It probably has bugs since I can't run it.
See: https://github.com/dart-lang/sdk/issues/31371
Change-Id: I7d9f9a3a36f8e8be106440375c80d584898c83cb
Reviewed-on: https://dart-review.googlesource.com/26467
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Reviewed-by: Régis Crelier <regis@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
Reviewed-by: Vijay Menon <vsm@google.com>
