Switch from using `_tag` naming to `_rev` since Dart team packages
should be synced by commit before publishing and tagging.
Change-Id: Idfa571e89d434fa71b868b1b4b816f54310ca642
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210948
Auto-Submit: Nate Bosch <nbosch@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
This package is no longer used.
Change-Id: Ic79172a0db3ad729700abc973e92d8908b4f72c5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210947
Reviewed-by: Kevin Moore <kevmoo@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Also makes the `pub` shell script (and its .bat counterpart)
forward to a `dart __deprecated_pub` command that implements the
old top-level.
This allows us to get rid of pub.dart.snapshot saving ~15 MB in a
unzipped sdk.
The reason for not forwarding directly to `dart pub` is that the
interface is slightly different (for example there is no `dart pub --version`).
The only new commit in pub is: `3c2ce330 Expose toplevel as a command`
Bug: https://github.com/dart-lang/pub/issues/2736
Change-Id: I6eb08d120c4844b3a12bc29544df6a868cd6fcc8
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210582
Commit-Queue: Sigurd Meldgaard <sigurdm@google.com>
Reviewed-by: Jonas Jensen <jonasfj@google.com>
Dart team packages should be synced first by commit before being
published and tagged. These packages were already using that pattern,
update the naming to match.
Change-Id: I004dba9459897b892af2e5f652d13730c90ad5cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210980
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
This only adds support for the new constructor tear-offs. No existing
formatted code should be changed, so it should be safe to land this
without coordinating a roll of the pre-built SDK.
Change-Id: Ic3fd04f12ef5a1f67760d3edc78c5f419ba1c3c3
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210285
Auto-Submit: Bob Nystrom <rnystrom@google.com>
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This is the first time a native arm64 macOS SDK is used for the
checked-in SDK.
Cq-Include-Trybots: luci.dart.try:dart-sdk-mac-arm64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-precomp-nnbd-mac-release-arm64-try
Change-Id: I1eb58350bdb351e6fbb978e0849ba40bcdf7e724
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/210120
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
2021-08-10 irina.arkhipets@gmail.com Issue 1094: tests corrected, missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: I-2-b test corrected.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4 tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Utils/tests/Expect tests corrected.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint32List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint16List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint8List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Uint9ClampedList tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int16List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int8List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float64List tests updated to check expectations for web correctly. Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tag added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float64List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float32x4List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Float32List tests updated to check expectations correctly for web.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteData tests updated to check expectations correctly for web.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteBuffer tests updated to check expectations correctly for web.
2021-08-10 sgrekhov@unipro.ru 1134. Read Dart --help from stdout on Windows
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes in master moved to pre-nnbd branch for LibTests/math tests.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes in master moved to pre-nnbd branch for LibTests/Isolate.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: LibTests/io/ZlibDecoder, LibTests/io/ZlibDecoder tests corrected.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/WebSocket/isEmpty_A01_t01.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/SystemEncoding folder.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/stdin folder.
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch for LibTests/io/RawSecureServerSocket folder.
2021-08-09 irina.arkhipets@gmail.com Merge branch 'pre-nnbd' of https://github.com/dart-lang/co19 into pre-nnbd
2021-08-09 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd branch.
2021-08-09 sgrekhov@unipro.ru 1100. Fix Link.watch() test to avoid flakiness
2021-08-06 sgrekhov@unipro.ru 1127. Expect compile-time errors in CFE for cyclic redirecting factories participating in a loop
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/ProcessSignal
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/ProcessResult
2021-08-04 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Process
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Link
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io tests: FileSystemModifyEvent, HttpClient, HttpClientBasicCredentials, HttpClientDigestCredentials, HttpClientRequest, HttpClientResponse, HttpServer, IOSink.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Directory, LibTests/io/File, LibTests/io/FileStat folder.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/io/Cookie folder.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/core/double, LibTests/core/int folders.
2021-07-29 irina.arkhipets@gmail.com Issue 1094: changes from master moved to pre-nnbd for LibTests/core folder.
2021-07-26 irina.arkhipets@gmail.com Issue 1094: changes from master merged, tests corrected in co19_2.
2021-07-23 irina.arkhipets@gmail.com Issue 1094: missing issue tags added, changes frim master merged, tests corrected in co19_2.
2021-07-22 irina.arkhipets@gmail.com Issue 1094: test corrected.
2021-07-22 sgrekhov@unipro.ru Fixes 1123. Expect Syntax errors in multitests and rename these tests to 'syntax*'
2021-07-21 irina.arkhipets@gmail.com Issue 1119: Libraries_and_Scripts test updated in pre-nnbd branch, new tests added.
2021-07-01 irina.arkhipets@gmail.com Issue 1094: tests updated.
2021-06-28 irina.arkhipets@gmail.com Issue 1094: test corrected according to the Issue 42393 evaluation.
2021-06-28 irina.arkhipets@gmail.com Issue 1094: Recent master changes merged into pre-nnbd branch, missing Iuuse tags added,test corrected (Language/Generics).
2021-06-28 irina.arkhipets@gmail.com Issue 1094: Recent master changes merged into pre-nnbd branch, missing Iuuse tags added,test corrected.
Change-Id: I00818cae18d84c3e2e7c628ed4370ff31c52d509
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209919
Reviewed-by: William Hesse <whesse@google.com>
2021-08-12 sgrekhov@unipro.ru Fixes 1144. Use Pointer<Int32> on 32-bit platforms
2021-08-12 sgrekhov@unipro.ru Fixes 1142. Fix tests expectations
2021-08-12 sgrekhov@unipro.ru Fixes 1143. Set called flag to true when constructor called
2021-08-12 sgrekhov@unipro.ru Fixes 1141. Fix typedefs in co19/LanguageFeatures/Constructor-tear-offs/summary_A01_t01 test
2021-08-12 sgrekhov@unipro.ru Fixes 1140. Typo fixed
2021-08-12 sgrekhov@unipro.ru Fixes 1139. Fix typo in test expectations
2021-08-11 sgrekhov@unipro.ru Fixes 1136. Make LanguageFeatures/Constructor-tear-offs/tearing_off_from_typedef_A07_t01 test stronger
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4 tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/Int32x4List tests updated to check expectations for web correctly.
2021-08-10 irina.arkhipets@gmail.com Issue 1094: Missing Issue tags added.
2021-08-10 irina.arkhipets@gmail.com Issue 1135: LibTests/typed_data/ByteBuffer tests updated to check expectations correctly for web.
2021-08-10 sgrekhov@unipro.ru 1134. Read Dart --help from stdout on Windows
2021-08-10 sgrekhov@unipro.ru Fixes 1130. Test rewritten to test what is said in description
2021-08-10 sgrekhov@unipro.ru Fixes 1133. Typo in constructor tear-off test fixed
2021-08-10 sgrekhov@unipro.ru Fixes 1132. Typo in test expectations fixed
2021-08-10 sgrekhov@unipro.ru Fixes 1131. Compare lists using 'listEquals'
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: I6681b0a5c75aad70498e920b2fe47fe56d257853
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209918
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Alexander Thomas <athom@google.com>
Note that there was a bug fix to `stringContainsInOrder` which does change the behavior.
Change-Id: I2ee39116f2704e6e196d7ab26d924726d4d801d7
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209844
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
2021-08-09 sgrekhov@unipro.ru 1126. Different roll failures fixed
2021-08-09 sgrekhov@unipro.ru 1100. Fix Link.watch() test to avoid flakiness
2021-08-09 sgrekhov@unipro.ru Fixes 1128. Remove check for '!identical(v1, v2)'
2021-08-06 sgrekhov@unipro.ru 1126. Some of the roll failures fixed or issue numbers added
2021-08-06 sgrekhov@unipro.ru 1127. Expect compile-time errors in CFE for cyclic redirecting factories participating in a loop
2021-08-06 sgrekhov@unipro.ru 1126. Some of the roll failures fixed
2021-08-04 irina.arkhipets@gmail.com Useless libraries removed.
2021-08-04 sgrekhov@unipro.ru 993. PointerPointer tests added
2021-08-03 sgrekhov@unipro.ru 993. IntPtrPointer tests added
2021-08-03 sgrekhov@unipro.ru 993. Work with memory fixed in FFI tests
2021-08-02 sgrekhov@unipro.ru 993. Int64Pointer tests added for FFI library
2021-07-30 sgrekhov@unipro.ru Fixes 993. IntXXPointer tests added for FFI library
2021-07-30 sgrekhov@unipro.ru 1087. More tests for tearing-off constructor of an abstract class
2021-07-29 sgrekhov@unipro.ru Fixes 993. DoublePointer tests added for FFI library
2021-07-29 sgrekhov@unipro.ru Fixes 993. More Union tests for FFI library added
2021-07-28 sgrekhov@unipro.ru Fixes 1125. Test for cascades contained explicitly instantiated tearoffs added
2021-07-28 sgrekhov@unipro.ru 1087. Header comment style fixes
2021-07-27 sgrekhov@unipro.ru 1087. Add tests for tearing-off constructor of an abstract class
2021-07-27 sgrekhov@unipro.ru Fixes 1124. Constructor tear-off tests fixed
2021-07-26 sgrekhov@unipro.ru 1124. Numerous errors and typos in Constructor tear-off tests fixed
2021-07-21 irina.arkhipets@gmail.com Issue 1119: test corrected.
2021-07-20 irina.arkhipets@gmail.com Issue 1109: Libraries_and_Scripts test updated, new tests added.
2021-07-20 sgrekhov@unipro.ru 1123. Constructor tear-off tests fixed to expect syntax errors
2021-07-20 sgrekhov@unipro.ru 1123. Expect syntax errors in tests which check syntax
2021-07-19 sgrekhov@unipro.ru Missed checks added to Language/Generics/syntax_t31 test
2021-07-19 sgrekhov@unipro.ru 1123. Expect syntax errors in tests which check syntax
2021-07-19 sgrekhov@unipro.ru 1123. Syntax error fixed in unnamed constructor tear-off tests
2021-07-19 sgrekhov@unipro.ru 1122. nonfunction-type-aliases tests moved out of type-aliases directory
2021-07-16 sgrekhov@unipro.ru 1122. nonfunction-type-aliases experimental flag removed
2021-07-16 sgrekhov@unipro.ru 1122. nonfunction-type-aliases experimental flag removed
2021-07-15 sgrekhov@unipro.ru Fixes 1121. Update Symbol tests according to the changed specification
2021-07-14 sgrekhov@unipro.ru 932. Issue number added
2021-07-14 irina.arkhipets@gmail.com Fixes 1109: test expectations corrected according to dart-lang/sdk44161, dart-lang/sdk44163 evaluations.
2021-07-14 sgrekhov@unipro.ru 1120. Added test which uses type aliases
2021-07-13 sgrekhov@unipro.ru 993. NativeFunction test added
2021-07-12 sgrekhov@unipro.ru Fixes 1107. Replace multitests by static errors tests
2021-07-12 sgrekhov@unipro.ru 1120. Tests for mixin static members added
2021-07-09 sgrekhov@unipro.ru Fixes 1120. Tests for function object canonicalization added
2021-07-08 sgrekhov@unipro.ru Fixes 1087. More constructor tear-offs tests added
2021-07-07 sgrekhov@unipro.ru 1087. More constructor tear-offs tests added
2021-07-06 sgrekhov@unipro.ru 1087. Added tests that checks factory constructor tear-offs and use of tear-offs in a factory constructors
2021-07-06 sgrekhov@unipro.ru Fixes 1118. Expect an error for Union/Struct subclasses created by generative constructor
2021-07-05 sgrekhov@unipro.ru Fixes 1111. Expect an error for zero-sized arrays
2021-07-05 sgrekhov@unipro.ru Fixes 1116. Expect a compile error for empty setOrMapLiteral for Iterable<Object> context type
2021-07-05 sgrekhov@unipro.ru Fixes 1112. Expect a compile error if mixin is derived from a class other than Object
2021-07-05 sgrekhov@unipro.ru Fixes 1105. Function tear-offs tests fixed
2021-07-05 sgrekhov@unipro.ru Fixes 1106. Use runtime check 'is int' VS 'is String' to check that runtime type is 'int', not 'dynamic'
2021-07-01 irina.arkhipets@gmail.com Fixes 1113: Method signature corrected.
2021-07-01 irina.arkhipets@gmail.com Fixed Issue 1115: test expectation corrected.
2021-07-01 irina.arkhipets@gmail.com Fixes Issue 1117: test corrected.
2021-06-29 irina.arkhipets@gmail.com Issue 1094: Merge changes from pre-nnbd branch.
2021-06-25 sgrekhov@unipro.ru 1087. Added tests for static invocations and type object member ambiguity
2021-06-25 sgrekhov@unipro.ru 1104. Fix type used in onError
2021-06-24 sgrekhov@unipro.ru 1087. Added more tests for resolving ambiguities
2021-06-23 sgrekhov@unipro.ru 1087. Added more tests for resolving ambiguities
2021-06-22 sgrekhov@unipro.ru 1087. Added more tests for resolving ambiguities
2021-06-22 sgrekhov@unipro.ru Fixes 1103. Change expected error range for analyzer according to the changed behaviour
2021-06-22 sgrekhov@unipro.ru Fixes 1102. Change test expected results according to the changed behavior
2021-06-21 sgrekhov@unipro.ru 1087. Added more tests for resolving ambiguities
2021-06-21 sgrekhov@unipro.ru Issue number added to the failing test
2021-06-21 sgrekhov@unipro.ru Fixes 1101. Expect less compile errors
2021-06-18 sgrekhov@unipro.ru 1087. Resolving ambiguities tests added
2021-06-17 sgrekhov@unipro.ru 1087. Resolving ambiguities tests added
2021-06-17 sgrekhov@unipro.ru 1087. Call-method tests added
2021-06-15 sgrekhov@unipro.ru Fixes 1100. Expect file system event not on link itself but on directory it points to
2021-06-15 sgrekhov@unipro.ru 1099. Fixed co19 roll failures
Cq-Include-Trybots: dart/try:analyzer-nnbd-linux-release-try,dart2js-nnbd-linux-x64-chrome-try,ddc-nnbd-linux-release-chrome-try,front-end-nnbd-linux-release-x64-try,vm-kernel-nnbd-linux-debug-x64-try,vm-kernel-nnbd-linux-release-simarm64-try,vm-kernel-nnbd-linux-release-x64-try,vm-kernel-nnbd-mac-release-arm64-try,vm-kernel-nnbd-win-release-x64-try,vm-kernel-precomp-nnbd-linux-release-simarm64-try,vm-kernel-precomp-nnbd-linux-release-x64-try,vm-kernel-precomp-nnbd-win-release-x64-try
Change-Id: Ib18e48d31771b2b70e607951577b9ac90d0b40a6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/209547
Reviewed-by: William Hesse <whesse@google.com>
TEST=ci
Change-Id: I956d681c8d54d52b0c4935d5570ac30d95db5d6c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/208346
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
This allows you to categorize commands, if you do they will be grouped in the usage text by category.
Change-Id: I2576ef76d18691f2fcee1f0f72c29285c4a346cf
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207980
Auto-Submit: Jake Macdonald <jakemac@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Nate Bosch <nbosch@google.com>
Change-Id: I665d6cb353030b69c31c5230381e10202549ab38
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207821
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Change-Id: I4ffe2d1774b65d7e9387b90c766e644a8b843af1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207220
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Change-Id: I36c0b33419189b0002f01420cd88a806ce751347
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207820
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
Note that this adds command suggestions when no command is found, see https://github.com/dart-lang/args/pull/206 for details.
This is likely to affect the output of the dart cli and other clis in the sdk, for that scenario. This may break some integration tests.
Change-Id: Ia64ab6f6c44af6b88f1db62268363820d39c63a9
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207701
Reviewed-by: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Auto-Submit: Jake Macdonald <jakemac@google.com>
Change-Id: I1cb6a5cc348778cbc6fd4969086a42a35da077ef
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207620
Auto-Submit: Nate Bosch <nbosch@google.com>
Commit-Queue: Nate Bosch <nbosch@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Kevin Moore <kevmoo@google.com>
- New version has been migrated to null safety.
- Update tests that are currently broken. It looks like a CFE bug
was fixed and now the private static fields are accessible.
Change-Id: I3d9bde85b65c0e219f756df2d9531539eb7f732b
Issue: https://github.com/dart-lang/sdk/issues/46617
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/207382
Reviewed-by: Mark Zhou <markzipan@google.com>
Commit-Queue: Nicholas Shahan <nshahan@google.com>
* This includes changes to dart format from dart_style 2.0.2
TBR=athom@google.com
Change-Id: I344f90e11b28746cfcb78427556a5f0a7de8611d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206371
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Change-Id: I3d7cb5d3cff30453766a6fcafce8c595a3af89f0
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/206321
Auto-Submit: Kevin Moore <kevmoo@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Commit-Queue: Jake Macdonald <jakemac@google.com>
Reviewed-by: Jake Macdonald <jakemac@google.com>
This relands https://dart-review.googlesource.com/c/sdk/+/205633
but without renaming TARGET_OS_IPHONE to DART_TARGET_OS_IPHONE.
It also changes uses of TARGET_OS_IOS to
DART_TARGET_OS_MACOS_IOS to be consistent with the rest of the
VM.
TargetConditionals.h for XCode 13 defines several
TARGET_OS_* preprocessor symbols that confuse the
Dart build. There is probably a more targeted fix
for this, but renaming the symbols that Dart uses
will also prevent this problem if more symbols
are added to the platform headers in the future.
See: https://github.com/dart-lang/sdk/issues/46499
TEST=It builds.
Change-Id: Ie775c19dd23cfdf5f65e5ebc6ee4ec3a561676fa
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205860
Commit-Queue: Zach Anderson <zra@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
This reverts commit aa9201b76b.
Reason for revert: blocks G3 roll (b/192627187)
Original change's description:
> [vm] Prefix HOST_OS_* and TARGET_OS_* with DART_
>
> TargetConditionals.h for XCode 13 defines several
> TARGET_OS_* preprocessor symbols that confuse the
> Dart build. There is probably a more targeted fix
> for this, but renaming the symbols that Dart uses
> will also prevent this problem if more symbols
> are added to the platform headers in the future.
>
> See: https://github.com/dart-lang/sdk/issues/46499
>
> TEST=It builds.
> Change-Id: I3b33a03b4a9a14b76d55fe12f8cdefec4b3c3664
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205633
> Commit-Queue: Zach Anderson <zra@google.com>
> Reviewed-by: Siva Annamalai <asiva@google.com>
TBR=rmacnak@google.com,zra@google.com,asiva@google.com
Change-Id: Ib06ca418c7e9d3b4df62c72c033cd39f462f7667
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/205790
Reviewed-by: Slava Egorov <vegorov@google.com>
Commit-Queue: Slava Egorov <vegorov@google.com>
