Commit graph

98 commits

Author SHA1 Message Date
Lasse R.H. Nielsen b0f6c4c8b1 Don't deprecate old constant names yet.
Flutter reacts badly to using deprecated members.

Change-Id: Id7933ddbc0c2fa68d9a232e2ad4c74dfd0ecdf35
Reviewed-on: https://dart-review.googlesource.com/21601
Reviewed-by: Erik Ernst <eernst@google.com>
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-17 10:58:33 +00:00
Lasse R.H. Nielsen 0b58c4bd10 Change some constant declarations to lowerCase.
Retain the old values.

Reapply of https://dart-review.googlesource.com/c/sdk/+/20680 with fixes
for VM method fingerprints.

Change-Id: Ie14e7ccc3194d5561983348e6b6752728913ff4d
Reviewed-on: https://dart-review.googlesource.com/20664
Reviewed-by: Erik Ernst <eernst@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 12:59:14 +00:00
Lasse R.H. Nielsen e61fc07b58 Revert "Change some constant declarations to lowerCase."
This reverts commit c048cfb178.

Reason for revert: VM code fingerprints needs update.

Original change's description:
> Change some constant declarations to lowerCase.
> 
> Retain the old values.
> 
> Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
> Reviewed-on: https://dart-review.googlesource.com/11520
> Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
> Reviewed-by: Florian Loitsch <floitsch@google.com>

TBR=lrn@google.com,floitsch@google.com

Change-Id: I095e8198304ca4e59b39d30b0fdf0af4945e5231
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://dart-review.googlesource.com/20680
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-11-14 11:23:08 +00:00
Lasse R.H. Nielsen c048cfb178 Change some constant declarations to lowerCase.
Retain the old values.

Change-Id: I03bd326f379fe5f96d8f6081a7133de956d745c0
Reviewed-on: https://dart-review.googlesource.com/11520
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Florian Loitsch <floitsch@google.com>
2017-11-14 11:13:04 +00:00
Lasse R.H. Nielsen 72d1e2452d Fix documentation of Uint32List and Uint64List
The currently documented maximum value is 2^n, but since 0 should be counted too actual value is only 2^n - 1.

Pull request https://github.com/dart-lang/sdk/pull/30626 by https://github.com/renggli

Change-Id: I85f920929f4cc524b7096f550e4dfdc628306399
Reviewed-on: https://dart-review.googlesource.com/9500
Reviewed-by: Lasse R.H. Nielsen <lrn@google.com>
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
2017-09-29 12:20:12 +00:00
Zachary Anderson 734beef062 [infra] Translate _sources.gypi files to _sources.gni files
Also deletes code that becomes dead as a result.

R=rmacnak@google.com

Review-Url: https://codereview.chromium.org/2996903002 .
2017-08-14 21:54:36 -07:00
Florian Loitsch ee46026671 Don't use LinkedList in the core libraries anymore.
R=lrn@google.com

Committed: fe17b5b2bc
Reverted: 5d4a786f44
Review-Url: https://codereview.chromium.org/2975443002 .
2017-07-28 21:14:11 +02:00
Ryan Macnak ff6a86f9eb Correct range in docs for signed accessors of ByteData.
Fixes #29375.

R=johnmccutchan@google.com

Review-Url: https://codereview.chromium.org/2823363002 .
2017-04-18 13:22:58 -07:00
Jacob Richman ea6991a245 Format all dart: library files
BUG=
R=floitsch@google.com, sra@google.com

Review-Url: https://codereview.chromium.org/2754013002 .
2017-03-16 10:22:19 -07:00
Seth Ladd a875749e82 add library-level docs to help with importing 2016-04-25 12:41:24 -07:00
Lasse R.H. Nielsen 0172094a50 Document truncating behavior of typed_data lists.
R=floitsch@google.com, sra@google.com

Review URL: https://codereview.chromium.org/1422473003 .
2015-10-29 09:56:04 +01:00
Lasse R.H. Nielsen d9a4022ab9 Add documentation to typed-list .fromList constructors saying that values are truncated.
Fixes issue #24708.
BUG= http://dartbug.com/24708
R=floitsch@google.com

Review URL: https://codereview.chromium.org/1416243004 .
2015-10-26 11:22:00 +01:00
Seth Ladd d69cd1dcfd one-liners for typed data
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1231903007 .
2015-07-09 16:47:41 -07:00
sethladd@google.com 31209403af one-line api doc comment for dart:typed_data
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1118123004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45516 260f80e4-7a28-3924-810f-c04153c831b5
2015-05-05 00:18:44 +00:00
lrn@google.com af031d6c0a Document ByteBuffer.asX() methods.
R=johnniwinther@google.com

Review URL: https://codereview.chromium.org//1052373011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45421 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-27 09:06:20 +00:00
sgjesse@google.com 4d85e2a2aa Revert "Fix warnings and hints in the SDK"
This reverts r45331.

TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//1097353003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45338 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 11:08:38 +00:00
sgjesse@google.com f8eaff5b69 Fix warnings and hints in the SDK
BUG=
R=paulberry@google.com, sgjesse@google.com, whesse@google.com

Review URL: https://codereview.chromium.org//996683002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@45331 260f80e4-7a28-3924-810f-c04153c831b5
2015-04-22 10:35:49 +00:00
lrn@google.com 9d8eeb0122 Move typed_data library to external/patch split instead of having an entire separate dart2js library.
R=floitsch@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//363883004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38112 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-10 09:00:55 +00:00
lrn@google.com c1ac924205 Fix type error in dart2js typed data.
Disable as{Int32x4,Float32x4,Float64x2} in dart2js ByteBuffer.
Needs a cleanup to put the ByteBuffer implementation in the same
library as the implementation, since there is no "native"
implementation.

I'll clean up the typed-data library next, to use a patch file instead
of unnecessary duplicating code between dart2js and the VM.

R=sgjesse@google.com

Review URL: https://codereview.chromium.org//368193002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37978 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 09:04:29 +00:00
lrn@google.com 085d99b079 Add typed data view creation functions on ByteBuffer.
This provides a better model and better separation for typed data.

Currently the only thing you can do with a ByteBuffer is pass
it as argument to a typed data .view factory method, which then
uses internal-only functionality to create the view.

With this change, the functionality of creating the view,
and understanding the internals of the ByteBuffer, is put on the
ByteBuffer class itself.

The view constructors on the typed data classes are retained, but
they just forward to the buffer's method. This provides backwards
compatibility and familiarity.

This change allows mocking the ByteData object. There is no hidden
connection between the constructor and the buffer that other objects
can't implement.

The change is non-breaking - it only adds methods to ByteBuffer, and
there have been absolutely no reason to extend ByteBuffer until now,
because it won't work anyway.

R=asiva@google.com, sgjesse@google.com

Review URL: https://codereview.chromium.org//364833002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37974 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-03 07:48:57 +00:00
sra@google.com d9b73a3e53 Tweak dart2js typed_data for a little more shared code.
BUG=
R=herhut@google.com

Review URL: https://codereview.chromium.org//301243003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@37155 260f80e4-7a28-3924-810f-c04153c831b5
2014-06-10 04:24:11 +00:00
sra@google.com 30cb75db52 Tighten dart2js typed_data range check
The check needed to be changed from == to === to avoid being fooled by valueOf.  The added 'cast' eliminates ~1.5k from swarm since the comparison was a generic call.

Review URL: https://codereview.chromium.org//174663002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32924 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-21 20:25:06 +00:00
johnmccutchan@google.com 2bfa3e40ae Doc fixes
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//144863003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32247 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-03 16:32:05 +00:00
johnmccutchan@google.com 9d80608b9c Add Float64x2, Float64x2List, etc... with runtime and dart2js implementations
R=sra@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//148043003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32196 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-31 15:28:05 +00:00
sra@google.com 9f09fcbaac Redo "Make dart2js typed_data implementation classes private"
This time with analyzer suppression for new library/

BUG=

Review URL: https://codereview.chromium.org//141653003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31935 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 23:01:26 +00:00
sra@google.com 9ceaef9d73 Revert "Redo "Make dart2js typed_data implementation classes private""
Revert while I figure out the correct analyzer suppression.

BUG=

Review URL: https://codereview.chromium.org//141523008

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31933 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:54:18 +00:00
sra@google.com 42b1721927 Redo "Make dart2js typed_data implementation classes private"
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//138543005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31930 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-17 21:08:40 +00:00
lrn@google.com 3b3e87cabc Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Committed: https://code.google.com/p/dart/source/detail?r=31827

R=floitsch@google.com

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31877 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 12:06:38 +00:00
lrn@google.com 9357caa547 Revert "Make VM TypedList not implement ByteBuffer."
Html transferable test fails to send buffer as buffer.

Review URL: https://codereview.chromium.org//137783019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31875 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 11:48:07 +00:00
lrn@google.com c2f6609181 Make VM TypedList not implement ByteBuffer.
BUG= http://dartbug.com/10136
R=asiva@google.com, sra@google.com

Review URL: https://codereview.chromium.org//138033002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31873 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 10:18:41 +00:00
sra@google.com 8ffab76c82 Revert "Redo "Make dart2js typed_data implementation classes private""
Review URL: https://codereview.chromium.org//140543002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31866 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 05:03:02 +00:00
sra@google.com 83ae5cfabf Redo "Make dart2js typed_data implementation classes private"
The main library is now private, with the user visible library as small re-export library.

R=blois@google.com, floitsch@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//130563004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31865 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-16 04:27:50 +00:00
lrn@google.com ead87f47e9 Revert "Rename internal library dart:_collection-dev to dart:_internal."
Dartium needs updating too.

Review URL: https://codereview.chromium.org//133273011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31827 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 12:27:44 +00:00
lrn@google.com 0098710559 Rename internal library dart:_collection-dev to dart:_internal.
BUG= http://dartbug.com/14140
R=floitsch@google.com

Review URL: https://codereview.chromium.org//133893007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31823 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-15 09:24:46 +00:00
lrn@google.com 48d4da33ce Change dart2js typed data .fromList constructors to match signatures.
Constructors used to take List<num>. Now takes List<int>/List<double>
for int/float lists.

BUG= http://dartbug.com/10368
R=floitsch@google.com

Review URL: https://codereview.chromium.org//137983004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31778 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-14 11:05:58 +00:00
sra@google.com 3c50ffe450 Revert "Make dart2js typed_data implementation classes private"
Investigating ie10 failures.

Review URL: https://codereview.chromium.org//135253003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31724 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-11 01:21:02 +00:00
sra@google.com 929c9bd2f7 Make dart2js typed_data implementation classes private
We want to be able to tell native typed arrays from classes that implement the interface.  To do this we need to have a non-public implementation hierarchy.

Splitting the classes into interfaces and implementations required some changes to the parts of the compiler that recognize the constructors for typed_data lists.

R=floitsch@google.com, johnmccutchan@google.com

Review URL: https://codereview.chromium.org//130803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31721 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-11 00:00:57 +00:00
sra@google.com 534221778e Redo "dart2js typed data constructor argument validation"
Fix the postmessage test which has an error encouraged by issue 10136

Patch Set 1 is previously reviewed code.

Review URL: https://codereview.chromium.org//129003002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31625 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 20:42:04 +00:00
sra@google.com c417893a72 Revert "dart2js typed data constructor argument validation"
BUG=

Review URL: https://codereview.chromium.org//128983002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31619 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 18:50:16 +00:00
sra@google.com fee8594ff8 dart2js typed data constructor argument validation
Addresses Issue 15951.
Also change parameter names to match documentation.

R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//127313002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31615 260f80e4-7a28-3924-810f-c04153c831b5
2014-01-08 17:30:40 +00:00
sra@google.com d63ae0d867 Redo "Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays""
What has changed here is I split the test to allow Safari to me marked as failing some tests.

Review URL: https://codereview.chromium.org//105273005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30921 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 23:22:04 +00:00
lrn@google.com 84c5f7196d Make Int64List and Uint64List abstract.
They are uninstantiable anyway, and this prevents warnings if they are missing
implementation.

BUG= http://dartbug.com/15418
R=ahe@google.com

Review URL: https://codereview.chromium.org//98103004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30883 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-05 08:58:08 +00:00
sra@google.com 41b9985c8c Revert "Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays""
Undiagnosed problem on Safari.

Review URL: https://codereview.chromium.org//105653005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30877 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 23:36:21 +00:00
sra@google.com 4eddb68e72 Redo "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays"
Use 'abstract' on classes to avoid warning.

BUG=

Review URL: https://codereview.chromium.org//104923005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30872 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 21:29:51 +00:00
sra@google.com fcbf332182 Revert "Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays"
Investigating warnings.

Review URL: https://codereview.chromium.org//105533002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30870 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 21:20:54 +00:00
sra@google.com ebc3203329 Use TypedArray.set for setRange of between similarly typed lists implemented as TypedArrays
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//102543006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30867 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-04 20:50:10 +00:00
ngeoffray@google.com a0b92e0357 Add another type JSPositiveInt to show a range analysis in the inferrer would be very beneficial :-).
R=kasperl@google.com

Review URL: https://codereview.chromium.org//94303002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30759 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-28 11:22:35 +00:00
johnmccutchan@google.com 73f6699559 Add range error paragraph to getUint32
TBR

Review URL: https://codereview.chromium.org//89803002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30687 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-27 00:11:01 +00:00
ngeoffray@google.com d530df2072 Remove hack on typed array length fully: previous CL just removed the length access, not setting the extra field.
R=karlklose@google.com

Review URL: https://codereview.chromium.org//80393003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30497 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-21 08:00:32 +00:00
ngeoffray@google.com 90e57925f0 Remove hack for length access of typed arrays.
R=kasperl@google.com

Review URL: https://codereview.chromium.org//78573003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@30473 260f80e4-7a28-3924-810f-c04153c831b5
2013-11-20 15:02:23 +00:00