Commit graph

53 commits

Author SHA1 Message Date
Alexander Thomas b5c63ce757 [infra] Migrate scripts to python3
* Migrate to python3; drop python support.
* Update Windows toolchain support.
* Remove some unused methods.
* Python 2.7 is still needed on Windows.
* Update gsutil to a version that supports python3.

Fixes: https://github.com/dart-lang/sdk/issues/28793

TEST=Manually tested common user journeys.

Change-Id: I663a22b237a548bb82dc2e601e399e3bc3649211
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/192182
Reviewed-by: William Hesse <whesse@google.com>
Reviewed-by: Alexander Aprelev <aam@google.com>
2021-04-15 10:10:20 +00:00
William Hesse 979c10c5b5 [infra] Rename test.py option to --cleanup-dart-processes
The option is changed from --cleanup_dart_processes to
--cleanup-dart-processes.

Change-Id: I3f9aefea81ac4ea040741d0850a851688f69e1a2
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170084
Reviewed-by: Alexander Thomas <athom@google.com>
2020-11-02 15:22:55 +00:00
William Hesse 5b159f0970 [infra] Add --cleanup_dart_processes to test.py
This is needed for Windows test shards on swarming builders,
    where the task_kill step at the end of the recipe is not sufficient
    to clean up abandoned Dart processes on a single shard task.

BUG=https://github.com/dart-lang/sdk/issues/32138
Change-Id: Id48f29f46350b5496c7427ca043dc5f2445fae37
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/170082
Reviewed-by: Karl Klose <karlklose@google.com>
2020-11-02 13:24:09 +00:00
Nate Bosch 55f81f2210 Mass format python with yapf
- Add `.style.yapf` with configuration to use Google style.
- Run `yapf` on all `.py` files in this repo.
- Manually fix one trailing space in a doc string.
- Run `git cl format runtime` to satisfy presubmit.

Change-Id: I7e6bd11e91f07926b9188362599af398551eed79
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/111600
Commit-Queue: Nate Bosch <nbosch@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
2019-08-05 20:34:31 +00:00
Robert Nystrom 99e8a9fba5 Move the test runner (i.e. "test.dart"/"test.py") to pkg/.
This makes it an actual Pub package like most other code inside the SDK
repo. The main goal is to make it easier to write tests for the test
runner itself.

This change:

- Moves all of the code from tools/testing/dart/ over to
  pkg/test_runner. Most of it ends up under test_runner/lib/src.

- Move tools/testing/dart/main.dart to
  pkg/test_runner/bin/test_runner.dart.

- Move standalone_2/io/test_runner_test.dart to
  pkg/test_runner/test/test_runner_test.dart. I don't think it currently
  works, but it wasn't being run in its old location either.

- Add test_runner to the analysis-server bot. This ensures the
  test_runner package is static error clean.

- Remove standalone_2/io/test_runner_analyze_test.dart which used to
  attempt to do the above and is no longer needed.

- Update test.py to look for the test runner at its new location.

- Add test_runner to the repo .packages file and remove the weird
  test_dart pseudo-package. (I think this fixes #35279.)

- Remove status file entries for the removed standalone_2 tests.

There are no code changes to the test runner itself aside from fixing
up import paths.

Change-Id: I3d05d50d222b291848fa5a30de2846e803bc81e6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/105821
Commit-Queue: Bob Nystrom <rnystrom@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
2019-06-14 23:35:10 +00:00
Martin Kustermann ed73cc379d Increase file descriptor limit when running test.py on MacOS
This is an attempt to solve io test flakiness on MacOS. The symptoms
include "connection refused", "broken pipe" error messages.

Change-Id: If6759f4ef9cd2c1b9bd083db9a469db43f12c4e0
Reviewed-on: https://dart-review.googlesource.com/c/80120
Commit-Queue: Martin Kustermann <kustermann@google.com>
Reviewed-by: Vyacheslav Egorov <vegorov@google.com>
2018-10-16 09:25:10 +00:00
Zach Anderson b15572933d Update checked-in Dart SDK to 2.0.0-dev.64.1
Updated to pass --dfe to invocations of the
checked-in SDK.

Change-Id: I47e122422926d235f166972669c8c2cb18a89735
Reviewed-on: https://dart-review.googlesource.com/62201
Reviewed-by: Siva Annamalai <asiva@google.com>
Commit-Queue: Zach Anderson <zra@google.com>
2018-06-25 21:39:35 +00:00
Zach Anderson 70ac1f90ec Revert "Update checked-in Dart SDK to 2.0.0-dev.64.1"
This reverts commit 47f394d61c.

Change-Id: I95cc7ab3cb9d112748460f793fd8906f216ac056
Reviewed-on: https://dart-review.googlesource.com/61986
Reviewed-by: Alexander Markov <alexmarkov@google.com>
2018-06-22 22:28:39 +00:00
William Hesse 47f394d61c Update checked-in Dart SDK to 2.0.0-dev.64.1
Change-Id: Id4e8f4987f830a4f81fbb4d70afeeb68b3babd67
Reviewed-on: https://dart-review.googlesource.com/61521
Reviewed-by: Zach Anderson <zra@google.com>
2018-06-21 22:42:42 +00:00
Bob Nystrom 53b2ef34ca Move test.dart into testing/dart.
This is mainly so that all of the code relating to test.dart is in one
directory tree so things like "Find All Usages" work a little better.
It felt weird to me to have a .dart file two directories up importing a
bunch of stuff within "testing/dart/".

Also cleaned up the affected code since it could use a little love. I'm
working on getting test.dart running DDC tests, but from poking around,
it seems like it could use some housekeeping as well.

R=vsm@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2848103002 .
2017-05-02 16:48:28 -07:00
Vyacheslav Egorov 6c9ca0cd2b Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage.
This flag now both enables core dump collection by setting appropriate rlimits
and takes care of archiving cores and crashed binaries.

R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2640093005 .
2017-01-19 17:25:39 +01:00
Vyacheslav Egorov e9483132ed Revert "Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage."
This reverts commit dec352c1ac.

Bots are completely broken

BUG=
TBR=kustermann@google.com

Review-Url: https://codereview.chromium.org/2640823005 .
2017-01-19 16:17:23 +01:00
Vyacheslav Egorov dec352c1ac Buildbot: Change --copy-crashdumps to do the actual archiving to CloudStorage.
This flag now both enables core dump collection by setting appropriate rlimits
and takes care of archiving cores and crashed binaries.

BUG=
R=kustermann@google.com

Review-Url: https://codereview.chromium.org/2644593002 .
2017-01-19 16:13:28 +01:00
Martin Kustermann 60087afcf8 Add third_party/android_tools/sdk/platform-tools to PATH if available
R=whesse@google.com

Review URL: https://codereview.chromium.org/1938973002 .
2016-05-02 14:01:44 +02:00
William Hesse 2573093c50 Switch to downloaded SDK executable, drop executables in testing/bin.
BUG=https://github.com/dart-lang/sdk/issues/24311
R=ricow@google.com

Review URL: https://codereview.chromium.org/1697203002 .
2016-02-15 17:10:59 +01:00
whesse@google.com c7d5711688 Build Tools Cleanup
Cleans up Python Code in Build Tools

TEST: build everything and run tests
BUG: https://code.google.com/p/dart/issues/detail?id=19592

R=ricow@google.com

Review URL: https://codereview.chromium.org//350483003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38573 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-25 11:47:59 +00:00
whesse@google.com 266bada744 Remove use of Expect from test scripts and idlparser_test.
BUG=

Review URL: https://codereview.chromium.org//14103003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21287 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-11 15:53:44 +00:00
iposva@google.com e7e42ed61a - Remove test-runtime.dart.
Review URL: https://codereview.chromium.org//12712012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@20125 260f80e4-7a28-3924-810f-c04153c831b5
2013-03-15 23:18:58 +00:00
antonm@google.com f9d8744839 Move a helper function to find out Dart binary into utils.py
R=ricow@google.com

Review URL: https://codereview.chromium.org//11098046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@13538 260f80e4-7a28-3924-810f-c04153c831b5
2012-10-11 13:07:16 +00:00
zundel@google.com 6a7d6b6c8a Building from compiler.deps in the dart/compiler dir is gone
Recent changes make it impossible to get a working build
from building in the compiler/ directory.  The buildbot now uses
all.deps and compiler.deps has been removed.

Review URL: https://chromiumcodereview.appspot.com//9969042

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@6351 260f80e4-7a28-3924-810f-c04153c831b5
2012-04-10 08:40:19 +00:00
ahe@google.com 29f23acca0 Make a VM crash more obvious.
Review URL: https://chromiumcodereview.appspot.com//9838017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@5774 260f80e4-7a28-3924-810f-c04153c831b5
2012-03-23 11:52:43 +00:00
whesse@google.com 6b08fe2894 Replace test.py with test_wrapper.py, a wrapper that calls test.dart.
BUG=
TEST=

Review URL: https://chromiumcodereview.appspot.com//9316094

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3897 260f80e4-7a28-3924-810f-c04153c831b5
2012-02-03 13:32:59 +00:00
whesse@google.com 4e3faf80e4 Revert change 3084.
Review URL: http://codereview.chromium.org//9146003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3086 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 10:47:03 +00:00
whesse@google.com 1b7d7303d8 Replace test.py with test.dart, using test_wrapper.py, temporarily to find problems. Will be reverted immediately.
Review URL: http://codereview.chromium.org//9148002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@3084 260f80e4-7a28-3924-810f-c04153c831b5
2012-01-09 10:35:36 +00:00
ager@google.com 40e896bf17 Fix timing of both dart and python test scripts.
The scripts (in particular the python one) were not counting all
of the setup code that is run before tests are started. The time
reported by the progress indicator now matches the time reported
by 'time test_script'.

R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8609012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1697 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-21 10:36:34 +00:00
efortuna@google.com bb83c227fe Made changes to the test architecture so that we can run frameworks other than
just Firefox from WebDriver.
Review URL: http://codereview.chromium.org//8566021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1555 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-16 00:42:18 +00:00
sigmund@google.com 67a5aded5a Don't increase default timeouts in frogium tests
Review URL: http://codereview.chromium.org//8536046

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1498 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-12 02:28:54 +00:00
sigmund@google.com e024570e01 Adding frogium: a frog-chromium architecture that runs tests in chromium that
were compiled with frog.

Review URL: http://codereview.chromium.org//8523024

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1440 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 02:07:02 +00:00
efortuna@google.com 87b9e83041 Adding in-browser correctness testing via selenium.
Do not, I repeat, DO NOT enable these to run by default on the buildbot yet
(Currently they do not run by default). I am checking this in in its raw state
so that my fellow frog developers can start making fixes to frog for running in
other browsers. You can run these test by running: 

Install WebDriver stuff by following these instructions:
http://code.google.com/p/selenium/wiki/PythonBindings

Then start the server:
java -jar selenium-server-standalone-2.11.0.jar -browserSessionReuse

../tools/test.py --component=webdriver --report --timeout=10 --progress=color
--mode=release language

Frog generates code that fails in Firefox, but passes in Chrome (for example). We
need to fix this eventually, but it shouldn't cause our entire tree to turn red.
Note also that to run selenium, you will need to install the selenium python
library, and ChromeDriver.
Review URL: http://codereview.chromium.org//8469016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1436 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-11 01:24:50 +00:00
ahe@google.com 1b4e839fec Handle co19 @dynamic-type-error better.
Review URL: http://codereview.chromium.org//8518002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1392 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-10 12:12:19 +00:00
ngeoffray@google.com 8c9a64166f Add a leg_only test suite, and make sure to run it in our presubmit script.
Review URL: http://codereview.chromium.org//8496009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1303 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-08 12:34:10 +00:00
ngeoffray@google.com c93b5a40ea Integrate leg as a component in test.py. Also update presubmit script to run tests with leg.
Review URL: http://codereview.chromium.org//8462004

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1187 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-04 10:29:48 +00:00
ngeoffray@google.com 5d6af6602a Bleeding edge change to get frog integrated into the testing infrastructure.
Review URL: http://codereview.chromium.org//8372095

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1140 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-03 12:15:55 +00:00
ahe@google.com a7ebe7f317 Fix broken test.py expression.
Review URL: http://codereview.chromium.org//8386003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1024 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 16:10:32 +00:00
ahe@google.com 8846883321 Update to co19 revision 15.
Review URL: http://codereview.chromium.org//8430028

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@1004 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 13:29:33 +00:00
ngeoffray@google.com 33ec29bf11 Add a new variable environment for testing, to replace the misusage of 'arch'.
Review URL: http://codereview.chromium.org//8408002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@993 260f80e4-7a28-3924-810f-c04153c831b5
2011-11-01 09:12:55 +00:00
zundel@google.com dc5bf070e1 Fixes problem with running test.py --arch dartc --mode release,debug
The --optimize flag was set for all tests at the top level if
release mode was specified.  I pushed this logic down into the
be a part of generating run command for each individual test case.

BUG=5408215

Review URL: http://codereview.chromium.org//8341066

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@768 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 18:12:08 +00:00
ager@google.com 9265136864 Add support for test expectations based on the --checked flag.
R=sgjesse@google.com
BUG=
TEST=

Review URL: http://codereview.chromium.org//8341056

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@751 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-26 14:24:38 +00:00
ngeoffray@google.com fd40730343 Fix testing and buildbot.
Review URL: http://codereview.chromium.org//8283031

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@431 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 12:36:16 +00:00
sgjesse@google.com d2ace1a9da Add back VM_OPTIONS_PATTERN.
TBR=ngeoffray@google.com

BUG=
TEST=

Review URL: http://codereview.chromium.org//8291001

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@430 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 11:54:50 +00:00
sgjesse@google.com 206d15dc03 Make the sample tests run using the standard test configuration
Also run the chat server test with short read/write options.

R=ngeoffray@google.com

BUG=b/5299751
TEST=

Review URL: http://codereview.chromium.org//8274034

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@428 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 11:35:31 +00:00
benl@google.com c0a59669cf Do away with the PromiseQueue.
Instead of queuing messages with promises in them until the promises
are ready, send immediately. This is done by sending a port down which
the receiver sends a port which can be used to signal completion of
the outgoing promise.
Review URL: https://chromereviews.googleplex.com/3573013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@427 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-14 11:18:12 +00:00
ngeoffray@google.com 76ef8258a4 Create a standalone test directory and move tests in runtime/tests/dart (mostly) to that directory.
Review URL: http://codereview.chromium.org//8261009

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@393 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-13 12:44:29 +00:00
zundel@google.com 6bef774e19 Cleans up style problems in architecture.py and test_runner.py
Cleaning these up so I can merge in changes related to
including chromium tests into the mainline test.py.

Review URL: http://codereview.chromium.org//8234029

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@365 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-12 14:12:10 +00:00
zundel@google.com 98c678891c Style cleanups for test.py
This reformats test.py to have consistent Python style.

Review URL: http://codereview.chromium.org//8223016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@353 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-11 22:44:53 +00:00
zundel@google.com 0322aafe87 Migrating guts of run.py to testing/architecture.py
simply moves the bulk for run.py into testing/architecure.py
and updates references.

Review URL: https://chromereviews.googleplex.com/3549014

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@298 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-10 13:52:47 +00:00
zundel@google.com 4ccb7c5810 Add --enable-type-checks to allow certain resolution errors to be non-fatal
This is to match the  behavior outlined in Gilad's
"Optional Types in Dart" document.  Extra type checks are turned
on when --enable-type-checks is passed on the command line *or*
optimization mode is enabled in the compiler.

See also https://chromereviews.googleplex.com/3563014/

Review URL: https://chromereviews.googleplex.com/3561023

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@275 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-08 15:11:10 +00:00
ngeoffray@google.com 84c81a082d Conditionnaly cleanup after running a command.
Review URL: https://chromereviews.googleplex.com/3546016

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@111 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-06 11:04:54 +00:00
ngeoffray@google.com 61486c2267 Small clenaup in the python scripts to make sure all tests get their Cleanup method called.
Review URL: https://chromereviews.googleplex.com/3534013

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@108 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-06 10:47:32 +00:00
srdjan@google.com 5dd35f18ae Fix crash in test.py when timing out.
Review URL: https://chromereviews.googleplex.com/3543017

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@99 260f80e4-7a28-3924-810f-c04153c831b5
2011-10-06 07:59:02 +00:00