languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity
83888 commits 11 branches 6005 tags 1.4 GiB
Commit graph

3 commits

Author SHA1 Message Date
Ryan Macnak a22d5b98fd Reapply "[build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time." 
Use a relative path for the depfile's target to match Ninja's expectation; otherwise it thinks the target is always dirty.

TEST=build twice
Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I4cae7ab55f79b5206521c7090502c0769d2b5277
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198443
Reviewed-by: Ben Konyi <bkonyi@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-05-12 00:27:28 +00:00
Ryan Macnak 5c0ff97acf Revert "[build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time." 
This reverts commit 8d436a2011.

Reason for revert: ninja is always dirty

Original change's description:
> [build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time.
>
> Bug: https://github.com/flutter/flutter/issues/81074
> Change-Id: I3fba7743f89b970dfd8d4d47b21f7d51be7a9cdb
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196981
> Commit-Queue: Ryan Macnak <rmacnak@google.com>
> Reviewed-by: Chinmay Garde <chinmaygarde@google.com>
> Reviewed-by: Ben Konyi <bkonyi@google.com>

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I74c9ce055ad49107ae0d21f2f3b9b74991fc81d1
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/198441
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ryan Macnak <rmacnak@google.com>
 2021-05-05 23:26:14 +00:00
Ryan Macnak 8d436a2011 [build] Track glob dependencies via depfiles, instead of always re-executing scripts at GN time. 
Bug: https://github.com/flutter/flutter/issues/81074
Change-Id: I3fba7743f89b970dfd8d4d47b21f7d51be7a9cdb
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/196981
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Chinmay Garde <chinmaygarde@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
 2021-04-28 23:10:34 +00:00