Commit graph

29 commits

Author SHA1 Message Date
Jacob Richman b5d53b5348 Fix spew when running presubmit which triggers dartfmt.bat on windows. We should also backport this change to the sdks in tools/sdk or roll a new version of the tools/sdk
Error span you otherwise get with each dartfmt invocation:

find: ‘>     bin [’: No such file or directory

Note that the error doesn't occur all times dartfmt is run, only when it is
run from the directory triggered by the presubmit.

BUG=
R=rnystrom@google.com, whesse@google.com

Review-Url: https://codereview.chromium.org/2759333004 .
2017-03-28 08:30:10 -07:00
William Hesse 9941b665bf Tools not running from snapshots should use /.packages
Stray .package files in their source can otherwise cause errors.

BUG=
R=paulberry@google.com, scheglov@google.com

Review URL: https://codereview.chromium.org/2374453002 .
2016-09-26 18:47:32 +02:00
William Hesse 61eee9ee52 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Committed: 5d3e356ca7

Review URL: https://codereview.chromium.org/1746743002 .

Reverted: 6d238ba197
2016-09-16 15:03:18 +02:00
William Hesse 6d238ba197 Revert "Use checked-in .package file for building and testing"
This reverts commit 5d3e356ca7.

BUG=
R=eernst@google.com

Review URL: https://codereview.chromium.org/2340813004 .
2016-09-15 15:46:49 +02:00
William Hesse 5d3e356ca7 Use checked-in .package file for building and testing
Stop creating [build dir]/packages directory with symbolic links.

BUG=https://github.com/dart-lang/sdk/issues/23565
R=rnystrom@google.com

Review URL: https://codereview.chromium.org/1746743002 .
2016-09-15 14:50:30 +02:00
Johnni Winther 40108f661d Update Windows build output path in .bat files
R=asiva@google.com, whesse@google.com

Review URL: https://codereview.chromium.org/2035313004 .
2016-06-07 10:43:13 +02:00
John McDole 8720ec869d Fix windows + gitbash (#25712)
* work with gitbash

* gitbash

* gitbash

* gitbash

* gitbash
2016-05-02 12:47:48 +02:00
William Hesse 73dfc7afe0 Change to X64 default build in tool scripts in sdk/bin
BUG=
R=sgjesse@google.com

Review URL: https://codereview.chromium.org/1535553003 .
2015-12-17 14:49:19 +01:00
Rico Wind f3c6339206 Switch over testing pub seperately from the the normal packages
This will call a new test script that Natalie will fill in the blanks of for pub testing.

This also moves pub from third_party/pkg_tested into third_party/pkg.

The corresponding changes to the buildbot is here:
http://src.chromium.org/viewvc/chrome?revision=295555&view=revision

R=nweiz@google.com, whesse@google.com
BUG=

Review URL: https://codereview.chromium.org//1166093002.
2015-06-09 08:12:51 +02:00
Natalie Weizenbaum 3d8c06c4e9 Start pulling pub from its own repo.
Pub now lives in third_party/pkg/pub (it's in pkg to make it possible to import
using "package:" imports).

R=ricow@google.com, rnystrom@google.com

Review URL: https://codereview.chromium.org//1165473002
2015-05-29 14:50:18 -07:00
johnniwinther@google.com 1728034084 Make unittests work on Windows (again)
BUG=
R=floitsch@google.com

Review URL: https://codereview.chromium.org//1024463007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@44680 260f80e4-7a28-3924-810f-c04153c831b5
2015-03-25 07:59:23 +00:00
rnystrom@google.com 25f3f6733d Remove heap settings from pub scripts for SDK too.
r43821 only does it for the scripts used to run pub from within the source repo.

Also add support to the Windows shell script for passing VM flags to pub similar to
what dart2js and the bash pub scripts allow.

BUG=https://code.google.com/p/dart/issues/detail?id=22461
R=ahe@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//943993005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43925 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-20 20:15:25 +00:00
nweiz@google.com c8de060c54 Revert "Revert "Use native async/await support in pub.""
The VM now fully supports all the weird async stuff pub is doing, and all the
tests pass with native async/await!

Previous CLs were r43484 and r43483.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//937243002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43897 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-19 22:28:54 +00:00
nweiz@google.com 0c78059186 Remove --old_gen_heap_size from the pub scripts.
This was added because it used to be necessary to load dart2js, but
dart2js itself no longer uses it and it's limiting the VM's overall
ability to allocate memory.

R=rnystrom@google.com
BUG=22413

Review URL: https://codereview.chromium.org//931113006

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43821 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-17 21:46:13 +00:00
nweiz@google.com bbe0d9325c Revert "Use native async/await support in pub."
This caused SDK compilation issues that may have obscured pub test failures as
well.

R=rnystrom@google.com

Review URL: https://codereview.chromium.org//887223007

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43484 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 21:15:44 +00:00
nweiz@google.com 1835c63d0a Use native async/await support in pub.
R=rnystrom@google.com

Review URL: https://codereview.chromium.org//896623005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@43483 260f80e4-7a28-3924-810f-c04153c831b5
2015-02-04 20:45:49 +00:00
nweiz@google.com c3ab5d7d7d Don't use pub_packages for running the Windows pub script.
R=rnystrom@google.com
TBR

Review URL: https://codereview.chromium.org//815473003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42473 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-18 19:41:00 +00:00
rnystrom@google.com 379ee11f6d Don't run async/await compiler from bin/pub.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//761173003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@42051 260f80e4-7a28-3924-810f-c04153c831b5
2014-12-01 22:26:11 +00:00
rnystrom@google.com 80a6e8270c Get binstubs working on Windows.
Review URL: https://codereview.chromium.org//599343003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40667 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-25 05:43:21 +00:00
rnystrom@google.com 17c1642748 Store the async-await compiled pub code directly in the repo.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//557563002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@40041 260f80e4-7a28-3924-810f-c04153c831b5
2014-09-09 16:55:16 +00:00
rnystrom@google.com dafe5c5ee4 Run async compiler in pub Windows batch files.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//500253002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@39533 260f80e4-7a28-3924-810f-c04153c831b5
2014-08-25 21:56:13 +00:00
nweiz@google.com d8663eeeda Create a separate packages directory for running pub.
Once issue 6943 is fixed, the http package will start using pub's
cross-platform library support to work with both dart:io and
dart:html. However, this package is also used *within* pub, so we need
a way for pub to import it that doesn't require it being run through
pub.

This change supports this by stripping out and dart:html imports from
the http package and creating a special packages directory only used
by pub that uses this modified version.

BUG=20068
R=floitsch@google.com

Review URL: https://codereview.chromium.org//397773002

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@38255 260f80e4-7a28-3924-810f-c04153c831b5
2014-07-15 20:28:08 +00:00
rnystrom@google.com 3cefa1c834 Bump VM heap size in pub batch files.
BUG=https://code.google.com/p/dart/issues/detail?id=16837
R=ahe@google.com, nweiz@google.com

Review URL: https://codereview.chromium.org//170003003

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@32804 260f80e4-7a28-3924-810f-c04153c831b5
2014-02-19 18:42:33 +00:00
rnystrom@google.com bb58a1b4ad Fix pub batch files on Windows.
They should handle spaces in paths correctly now.

BUG=https://code.google.com/p/dart/issues/detail?id=10104
R=nweiz@google.com

Review URL: https://codereview.chromium.org//100623012

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@31150 260f80e4-7a28-3924-810f-c04153c831b5
2013-12-14 00:09:27 +00:00
rnystrom@google.com aa6ccd2d17 Don't run pub in checked mode in the built SDK.
BUG=https://code.google.com/p/dart/issues/detail?id=11083
R=ahe@google.com

Review URL: https://codereview.chromium.org//17063019

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24372 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-24 22:20:16 +00:00
rnystrom@google.com 4bea84958e Make pub.bat work from within the repo.
R=nweiz@google.com

Review URL: https://codereview.chromium.org//16990005

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@24043 260f80e4-7a28-3924-810f-c04153c831b5
2013-06-14 17:18:42 +00:00
nweiz@google.com cc6e2f7b93 Put a snapshot of pub in the SDK.
BUG=9117

Review URL: https://codereview.chromium.org//13966011

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21979 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-24 20:43:39 +00:00
nweiz@google.com 24213beff5 Move pub into sdk/lib/_internal.
This also converts pub to a more package-like layout, which will help in the
eventual exposing of pub internals as a library. Since pub's sources are now in
lib/src, this also makes them importable from the tests and entrypoint using
"package:" imports.

BUG=6619

Review URL: https://codereview.chromium.org//14297021

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@21907 260f80e4-7a28-3924-810f-c04153c831b5
2013-04-23 21:44:26 +00:00
dgrove@google.com 2d8076e725 Add scripts equivalent to the macos/linux scripts in sdk/bin.
Review URL: https://codereview.chromium.org//11366180

git-svn-id: https://dart.googlecode.com/svn/branches/bleeding_edge/dart@14775 260f80e4-7a28-3924-810f-c04153c831b5
2012-11-10 02:01:46 +00:00