Commit graph

32169 commits

Author SHA1 Message Date
Karl Klose
551fa1fdaa Do not mark type variables as needing a box inside try; they are immutable.
Closes #23650

R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1188103002.
2015-06-16 14:13:01 +02:00
Lasse R.H. Nielsen
80960767e9 Fix timing issue in stream_empty_test, and make analyzer expect it to pass.
Review URL: https://codereview.chromium.org//1188613008.
2015-06-16 13:33:53 +02:00
Kevin Millikin
2e5a132fe1 Fix a typo in the specification of switch cases.
In the grammar, labels must before the word 'case'.  However, in the
description the labels come between the word 'case' and the comparison
expression.  Closes #22127.

BUG=
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1189523004.
2015-06-16 12:02:16 +02:00
Lasse R.H. Nielsen
fbedc2b86f Also iprove Future.value(null) and documentation of some Stream related classes.
R=sgjesse@google.com

Review URL: https://codereview.chromium.org//1177343004.
2015-06-16 11:38:07 +02:00
Gilad Bracha
f71b48a041 Revise static typecheck rules for for-in.
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1184183010.
2015-06-15 17:50:37 -07:00
Gilad Bracha
b34c19d0ce Add missing clause for LUB(Bottom, T)
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1179113010.
2015-06-15 16:20:30 -07:00
Harry Terkelsen
696fbdf440 Update Angular to 0c282e826a3e35e6b6aa2dd430f899d159eaf458
R=ricow@google.com

Review URL: https://codereview.chromium.org//1187903007.
2015-06-15 16:02:48 -07:00
Gilad Bracha
1ab7736b57 Added type rules for e++ and friends
BUG=
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1183493005.
2015-06-15 15:00:55 -07:00
Srdjan Mitrovic
6f07377802 Faster checks in polymorphic instance calls if Smi-s are involved
BUG=
R=zra@google.com

Review URL: https://codereview.chromium.org//1184093004.
2015-06-15 14:54:31 -07:00
Gilad Bracha
2b95ed1ae1 Make use of call on Function exempt from warnings,
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1176853003.
2015-06-15 13:24:10 -07:00
Ryan Macnak
7c1bccb263 Add lib/base64.dart to Observatory's gypi.
Review URL: https://codereview.chromium.org//1179393003.
2015-06-15 12:39:31 -07:00
Ryan Macnak
392a83221f Allow setting break-on-exceptions option over the service protocol. Add command to Observatory's debugger.
Decide whether to cache service objects based on the fixedId property.

Be more tolerant of eval scripts and functions.

BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1174313002.
2015-06-15 12:05:23 -07:00
Ryan Macnak
3e2373e561 Really fix typo to fix the build.
TBR=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1182703005.
2015-06-15 10:26:19 -07:00
keertip
0079275f18 revert cl to run dartdoc on bots
BUG=
R=danrubel@google.com

Review URL: https://codereview.chromium.org//1184153002.
2015-06-15 10:12:56 -07:00
danrubel
db11964b83 refactor Reqest.fromJson for use by performance measurement tests
BUG=
R=brianwilkerson@google.com

Review URL: https://codereview.chromium.org//1181363004.
2015-06-15 12:27:41 -04:00
keertip
91b2281e08 add dartdoc to third_party/pkg, run dartdoc to generate docs for sdk and upload to GCS
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1164423008.
2015-06-15 09:25:44 -07:00
Brian Wilkerson
e85278cdb0 Fix a typo to fix the build
Review URL: https://codereview.chromium.org//1175173004.
2015-06-15 09:20:55 -07:00
Zachary Anderson
1051b3e65a Fix ia32 android build
BUG=
R=johnmccutchan@google.com

Review URL: https://codereview.chromium.org//1184673005.
2015-06-15 08:53:41 -07:00
Søren Gjesse
3c85970637 Update status file
R=ajohnsen@google.com, whesse@google.com
BUG=https://github.com/dart-lang/sdk/issues/23641

Review URL: https://codereview.chromium.org//1186883002.
2015-06-15 17:46:57 +02:00
Brian Wilkerson
1ac16bd2d4 Update dartium deps to include html
R=vsm@google.com

Review URL: https://codereview.chromium.org//1182983003.
2015-06-15 08:45:10 -07:00
Asger Feldthaus
eec1d88d9c dart2js cps: Introduce some built-in operators in type propagation.
There are also a number of somewhat unrelated changes to get
better type information out of the global type inference.
The dependency on TypedSelector is causing a lot of problems there.

BUG=
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1175973005.
2015-06-15 17:31:48 +02:00
Anders Johnsen
9a01a22e96 Revert "Clean up process spawning."
This reverts commits
- bbdc57ebf6
- bd25e641f2
- 5cc8fca131
- ed72caa3cd

BUG=

Review URL: https://codereview.chromium.org//1182423003.
2015-06-15 15:26:56 +02:00
Karl Klose
bb45376735 Update dart2js-cps_ir status files.
R=kmillikin@google.com

Review URL: https://codereview.chromium.org//1191433002.
2015-06-15 12:50:58 +02:00
Soren Gjesse
f9e8852edb Fix test on Windows
Forgot to change Platform.executable to Platform.resolvedExecutable in
one place.

TBR=lrn@google.com
BUG=

Review URL: https://codereview.chromium.org//1181583004.
2015-06-15 11:45:34 +02:00
Søren Gjesse
c05c8c6606 Revert change to Platform.excutable and add Platform.resolvedExecutable
The change to Platform.excutable in
e03ab17437 was a breaking change and it
has been reverted.

A new getter Platform.resolvedExecutable has been added to provide the
the fully qualified path of the executable.

BUG=https://github.com/dart-lang/sdk/issues/16994
R=lrn@google.com, kustermann@google.com, len@google.com

Review URL: https://codereview.chromium.org//1180623006.
2015-06-15 10:13:21 +02:00
Martin Kustermann
9d3e7c3b6d Add (forward-compatible) change to annotated steps of target-arm builder to support sharding
R=ricow@google.com

Review URL: https://codereview.chromium.org//1182103005.
2015-06-15 09:50:07 +02:00
Ivan Posva
7158d5fc26 Landing https://codereview.chromium.org/1171223003/ for Chinmay.
BUG=

Review URL: https://codereview.chromium.org//1174343006.
2015-06-13 06:36:24 -07:00
Stephen Adams
f7263216e4 Better messages for optimized index errors.
Typed list, Array and String indexer methods detect index errors in their own optimized way but now defer to common code to diagnose the error.  This code is shared with the optimized 'ioore' helper, which makes the error message consistent between optimized and unoptimized code.

The main reason for doing this is to ensure that the error messages have as much information as possible to help debug off-line using captured error messages.

BUG=
R=lrn@google.com

Committed: 0d4361fb6d

Reverted: 82215d36f4

Review URL: https://codereview.chromium.org//1180713003.
2015-06-12 18:21:47 -07:00
Gilad Bracha
67b99e4b33 Make sure we use lexical scope consistently when dealing with prefixes.
BUG=
R=lrn@google.com, paulberry@google.com

Review URL: https://codereview.chromium.org//1184583002.
2015-06-12 17:38:42 -07:00
Stephen Adams
82215d36f4 Revert "Better messages for optimized index errors."
TBR=lrn@google.com

Review URL: https://codereview.chromium.org//1187553005.
2015-06-12 16:53:19 -07:00
Ryan Macnak
bac8bc4b18 Fix accessing dart:_ libraries via exports.
R=hausner@google.com

Review URL: https://codereview.chromium.org//1185733003.
2015-06-12 16:50:27 -07:00
Ryan Macnak
b8bad6725c Expand the class id to 32 bits and size field to 16 bits on 64-bit platforms.
Remove misleading suffix from disassembly of some ia32 immediate ops.

R=asiva@google.com, srdjan@google.com

Review URL: https://codereview.chromium.org//1174173007.
2015-06-12 16:42:40 -07:00
Stephen Adams
0d4361fb6d Better messages for optimized index errors.
Typed list, Array and String indexer methods detect index errors in their own optimized way but now defer to common code to diagnose the error.  This code is shared with the optimized 'ioore' helper, which makes the error message consistent between optimized and unoptimized code.

The main reason for doing this is to ensure that the error messages have as much information as possible to help debug off-line using captured error messages.

BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1180713003.
2015-06-12 15:33:58 -07:00
Ryan Macnak
fd1531b4d8 Fix some markup in the mirrors docs.
BUG=http://dartbug.com/21714
R=gbracha@google.com

Review URL: https://codereview.chromium.org//1184623003.
2015-06-12 14:43:38 -07:00
Ryan Macnak
3d190ddd2d Pass -EL for MIPS cross builds to allow for using a bi-endian toolchain and work around CXXFLAGS being passed to both host and target.
R=zra@google.com

Review URL: https://codereview.chromium.org//1184873002.
2015-06-12 14:02:27 -07:00
Konstantin Shcheglov
96670b0e97 Fix for explicit dart:core import.
This fixes the rest of the co19/ tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1181663004.
2015-06-12 13:26:12 -07:00
Konstantin Shcheglov
a16ec77494 Mix VARIABLE_REFERENCE_ERRORS into the full errors list on ChangeNotice.
This fixes 11 tests in language/ and co19/.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1179253002.
2015-06-12 12:52:15 -07:00
Konstantin Shcheglov
5538e1f105 Add self-reference sources into INCLUDED_PARTS.
It's an error of course, but unless we add it in the first place, we
cannot detect this error in the library element building task.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1183773002.
2015-06-12 12:30:09 -07:00
Konstantin Shcheglov
9634a03393 Explicitly compute library errors in tests.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1183723002.
2015-06-12 12:28:24 -07:00
Konstantin Shcheglov
d2ea3330d8 Fix tests with 'part' without 'library'.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1180043006.
2015-06-12 11:27:36 -07:00
Daniel Andersson
1009d587de Assert no allocation during heap iteration; fix unsafe iteration in ObjectGraph.
BUG=https://github.com/dart-lang/sdk/issues/21620
R=asiva@google.com

Review URL: https://codereview.chromium.org//1181943002.
2015-06-12 10:44:06 -07:00
Konstantin Shcheglov
61c01b2231 Fix for computeResolvedCompilationUnitAsync().
This fixes the last Analysis Server unit tests.

R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1181223002.
2015-06-12 10:27:02 -07:00
Florian Schneider
19bb19d716 Fix bug in Dart_GetTypeOfExternalTypedData.
This API function would return true for typed data view objects, even
if the view has a non-external data object underneath.

It is used e.g. by Builtin_LoadSource. This function copies the data
object for internal typed-data objects.
When it wrongly be identifies a view as external, it consequently results
in crash/undefined behavior because GC may interfere with this internal
data pointer.

BUG=
R=asiva@google.com, koda@google.com

Review URL: https://codereview.chromium.org//1182123002.
2015-06-12 18:41:07 +02:00
pq
35e0da2b89 Version constraint cleanup.
R=paulberry@google.com

Review URL: https://codereview.chromium.org//1180943003.
2015-06-12 09:28:27 -07:00
Konstantin Shcheglov
b7b087cecd Schedule unknown priority source analysis.
R=brianwilkerson@google.com
BUG=

Review URL: https://codereview.chromium.org//1179173005.
2015-06-12 09:12:45 -07:00
Johnni Winther
6c8b4bb7af Handle most qualified sends.
BUG=
R=herhut@google.com, karlklose@google.com

Committed: ec40a14019

Reverted: b01c4bd438

Review URL: https://codereview.chromium.org//1182563003.
2015-06-12 15:26:08 +02:00
Seth Ladd
00be3be571 be more explicit about when and how to register for listeners with isolates
BUG=
R=lrn@google.com

Review URL: https://codereview.chromium.org//1181043003
2015-06-12 15:02:11 +02:00
Karl Klose
b01c4bd438 Revert "Handle most qualified sends."
This reverts commit ec40a14019.

TBR=herhut@google.com,johnniwinther@google.com
BUG=

Review URL: https://codereview.chromium.org//1185483004.
2015-06-12 14:03:18 +02:00
Seth Ladd
f1b934d816 make the one-liner for the SDK docs an actual one-liner
BUG=
R=ricow@google.com

Review URL: https://codereview.chromium.org//1183623003
2015-06-12 12:21:52 +02:00
Kevin Moore
90b656946b homebrew: Include version information in resources
Ensures cached files are unique

R=whesse@google.com

Review URL: https://codereview.chromium.org//1179033002.
2015-06-12 09:24:05 +01:00