Sigmund Cherem
5a63b0e339
Add flutter mode to patched_sdk
...
This is needed to create a platform.dill for flutter.
R=aam@google.com
Review-Url: https://codereview.chromium.org/2931773003 .
2017-06-14 17:29:36 -07:00
Emily Fortuna
1e599fd213
Edit docs as per Siggi's feedback.
...
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2937143002 .
2017-06-14 17:13:54 -07:00
Emily Fortuna
7302ea43cf
Make requiresContextBox a getter as per Siggi's suggestion.
...
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2936323003 .
2017-06-14 17:12:33 -07:00
Emily Fortuna
e6d7c0500c
Rename ClosureClassMaps to CLosureDataLookup
...
(doing small tasks while I wait to talk to Siggi).
BUG=
R=sigmund@google.com
Review-Url: https://codereview.chromium.org/2938853004 .
2017-06-14 16:55:57 -07:00
Konstantin Shcheglov
a3d9f5303c
Cache transitive files in FileState.
...
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2937103002 .
2017-06-14 13:53:28 -07:00
Emily Fortuna
a05f5000ad
Modify types in dump_info to make kernel checked mode happy.
...
This is a follow up CL from https://codereview.chromium.org/2933363003
BUG=
Review-Url: https://codereview.chromium.org/2940883006 .
2017-06-14 13:39:46 -07:00
Carlo Bernaschina
e826fdcb6b
Cleaned analysis result for observatory
...
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2940523003 .
2017-06-14 12:23:48 -07:00
Peter von der Ahé
87700d381c
Start making dart2js strong mode clean.
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2938823002 .
2017-06-14 20:34:07 +02:00
Carlo Bernaschina
f5bca80a48
Removed unnecessary string concatenations
...
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2942493002 .
2017-06-14 11:23:12 -07:00
Emily Fortuna
a27ebd0c94
Add ClosureRepresentationInfo, the new public face of ClosureClassMap
...
(removal of methods exposing ClosureClassMap coming in follow up CL).
BUG=
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2933363003 .
2017-06-14 11:15:08 -07:00
Ryan Macnak
08b7b1d060
[fuchsia] Make profile processing resilient to bogus overlaps from dladdr.
...
R=zra@google.com
Review-Url: https://codereview.chromium.org/2939853002 .
2017-06-14 11:14:24 -07:00
Sigmund Cherem
5e5e62f9d8
Remove deps from reloader
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2937983002 .
2017-06-14 10:57:25 -07:00
Paul Berry
e03744a740
Fix fasta testcase to avoid a super call to an abstract method.
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2941813002 .
2017-06-14 10:55:31 -07:00
Régis Crelier
525d66e1bd
Avoid assert fault when using --trace-type-checks
...
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2933983002 .
2017-06-14 10:49:20 -07:00
Bob Nystrom
979026abef
Don't allow "none" as a runtime for dartk.
...
Also, add a little sanity checking in TestCase.
Fix #29842 .
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2941603002 .
2017-06-14 10:31:09 -07:00
Peter von der Ahé
246334011a
Ignore recoverable parser errors in outline_builder to avoid double reporting.
...
R=danrubel@google.com
Review-Url: https://codereview.chromium.org/2940843003 .
2017-06-14 19:14:53 +02:00
Peter von der Ahé
3fd4b27c9d
Update status file.
...
Review-Url: https://codereview.chromium.org/2936223002 .
2017-06-14 18:37:31 +02:00
Dan Rubel
f8655ca568
update invalid hex digit recovery
...
* update invalid hex digit recovery for compatibility with analyzer
* address comments from https://codereview.chromium.org/2915093002
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2941583003 .
2017-06-14 11:18:34 -04:00
Dan Rubel
b03ff5c772
update analyzer tests for fasta scanner
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2940783002 .
2017-06-14 11:17:31 -04:00
Dan Rubel
305f358fa4
update statement completion for fasta scanner
...
R=brianwilkerson@google.com
Review-Url: https://codereview.chromium.org/2936143002 .
2017-06-14 11:15:50 -04:00
Konstantin Shcheglov
8925c68a71
Extract computing UnlinkedUnit(s) and cache them in ByteStore.
...
So, we usually don't have to parse most of the files in order to
compute imports/exports/parts and API signatures.
R=ahe@google.com , paulberry@google.com , sigmund@google.com
BUG=
Review-Url: https://codereview.chromium.org/2939823002 .
2017-06-14 08:09:58 -07:00
Konstantin Shcheglov
b2b98bb8fd
Exclude 'test' and 'testcases' from lib/ packages.
...
R=paulberry@google.com , whesse@google.com
BUG= https://github.com/dart-lang/sdk/issues/29852
Review-Url: https://codereview.chromium.org/2940723002 .
2017-06-14 07:50:06 -07:00
William Hesse
e64ee95959
Move ie11 timeout handling code to BrowserControllerTestOutcome
...
Only content_shell testing uses the BrowserCommandOutputImpl class.
Rename the class to ContentShellCommandOutputImpl.
BUG=https://github.com/dart-lang/sdk/issues/28955
BUG=https://github.com/dart-lang/sdk/issues/29869
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2934243002 .
2017-06-14 15:50:41 +02:00
Jens Johansen
840b3700b7
Fix to 32-bit kernel.
...
BUG=
R=paulberry@google.com , vegorov@google.com
Review-Url: https://codereview.chromium.org/2934263002 .
2017-06-14 15:50:13 +02:00
Peter von der Ahé
3cc27ab40a
[gardening] Mark test as slow.
...
Review-Url: https://codereview.chromium.org/2942603002 .
2017-06-14 15:21:30 +02:00
Paul Berry
92a878f276
Fix argument names for handleIndexedExpression.
...
R=ahe@google.com
Review-Url: https://codereview.chromium.org/2935833002 .
2017-06-14 06:05:53 -07:00
Peter von der Ahé
a189be6786
Copy fasta analyze_test to dart2js.
...
R=johnniwinther@google.com
Review-Url: https://codereview.chromium.org/2942573002 .
2017-06-14 15:00:43 +02:00
Peter von der Ahé
6302a5b31b
Implement metadata on classes and additional semantic checks.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2938793002 .
2017-06-14 14:59:53 +02:00
William Hesse
d98d32b63c
Report ie11 timeouts in debug log, not as errors (attempt 2)
...
BUG=https://github.com/dart-lang/sdk/issues/28955
R=kustermann@google.com
Review-Url: https://codereview.chromium.org/2938813002 .
2017-06-14 14:17:27 +02:00
Peter von der Ahé
fc2f27b52f
[gardening] Undo accidental skip.
...
Review-Url: https://codereview.chromium.org/2937023002 .
2017-06-14 14:04:48 +02:00
Johnni Winther
195470419e
Fix strong mode warning
...
Review-Url: https://codereview.chromium.org/2942583002 .
2017-06-14 13:45:05 +02:00
Peter von der Ahé
a14d98ecf5
[gardening] Skip flaky vm tests.
...
Review-Url: https://codereview.chromium.org/2941733002 .
2017-06-14 13:34:37 +02:00
Johnni Winther
6a6a330623
Parameterize and move JumpTarget/LabelDefition to elements/jumps.dart
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2930293002 .
2017-06-14 12:27:38 +02:00
Johnni Winther
52b1ea04e8
Refactor LoopHandler to avoid calling KernelAstAdapter.getNode
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2932023003 .
2017-06-14 12:18:34 +02:00
Dmitry Stefantsov
32eed0892d
Update expectations for closure conversion tests
...
R=karlklose@google.com
Review-Url: https://codereview.chromium.org/2935223003 .
2017-06-14 11:03:46 +02:00
Jens Johansen
4bbda48a7c
[kernel] Stream everything. Replace .kernel_function with .kernel_offset
...
- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
flowgraph builder.
- Delete big parts of kernel_to_il.
R=kmillikin@google.com
Committed: 948e2f5d79
Review-Url: https://codereview.chromium.org/2901533002 .
2017-06-14 10:59:57 +02:00
Johnni Winther
ea070c7264
Add ClosedWorld.elementEnvironment and remove Compiler.elementEnvironment
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2935063002 .
2017-06-14 10:27:38 +02:00
Johnni Winther
5afe65e891
Remove Compiler.commonElements
...
R=efortuna@google.com
Review-Url: https://codereview.chromium.org/2935663002 .
2017-06-14 10:18:42 +02:00
Jens Johansen
de5ebc5a4e
Revert "[kernel] Stream everything. Replace .kernel_function with .kernel_offset"
...
The commit somehow made e.g. vm-linux-release-ia32-be turn red.
This reverts commit 948e2f5d79
.
BUG=
Review-Url: https://codereview.chromium.org/2941483003 .
2017-06-14 09:12:38 +02:00
Peter von der Ahé
5f3fd3060b
Restore status file comment.
...
R=jensj@google.com
Review-Url: https://codereview.chromium.org/2939713002 .
2017-06-14 08:31:37 +02:00
Jens Johansen
948e2f5d79
[kernel] Stream everything. Replace .kernel_function with .kernel_offset
...
- Put pointer to kernel data into Script.
- Replace function.kernel_function pointer to AstNode with
kernel_offset():
- Replace field.kernel_field pointer to AstNode with kernel_offest().
- Stream the previously unstreamed AstNodes: FunctionDeclaration and
FunctionExpression.
- Move special handling for _buildin.getMainClosure into the streaming
flowgraph builder.
- Delete big parts of kernel_to_il.
R=kmillikin@google.com
Review-Url: https://codereview.chromium.org/2901533002 .
2017-06-14 08:27:21 +02:00
Peter von der Ahé
3c17c44d52
Implement metadata on methods and fields.
...
R=paulberry@google.com
Review-Url: https://codereview.chromium.org/2935993002 .
2017-06-14 08:25:17 +02:00
Brian Wilkerson
a0d7d64f0b
Convert more tests
...
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2936123002 .
2017-06-13 19:38:59 -07:00
Devon Carew
e523061acc
Minor tweaks to the diagnostics page.
...
BUG=
R=scheglov@google.com
Review-Url: https://codereview.chromium.org/2937623005 .
2017-06-13 19:22:28 -07:00
Jennifer Messerly
c848476643
fix super from constructors
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2938713002 .
2017-06-13 16:47:20 -07:00
Max Kim
e57d9b608f
Change to accommade Angular plugin and finalize removal of dependency to analysis_server
...
BUG=
R=brianwilkerson@google.com , mfairhurst@google.com
Review-Url: https://codereview.chromium.org/2934133002 .
2017-06-13 16:31:39 -07:00
Ryan Macnak
e9eeb1a070
[infra] Fix Observatory watchlist.
...
TBR=zra@google.com
Review-Url: https://codereview.chromium.org/2935873004 .
2017-06-13 16:21:35 -07:00
Jennifer Messerly
1f50f0d126
fix mixins with factory constructors
...
R=vsm@google.com
Review-Url: https://codereview.chromium.org/2935933005 .
2017-06-13 15:58:50 -07:00
Devon Carew
9ec724cd6b
Address observatory analysis issues.
...
BUG=
R=rmacnak@google.com
Review-Url: https://codereview.chromium.org/2934973002 .
2017-06-13 15:58:01 -07:00
Siva Chandra
1fe6097cc8
Generate vmservice_io.dill along with platform.dill.
...
R=asiva@google.com
Review-Url: https://codereview.chromium.org/2940473002 .
2017-06-13 15:40:17 -07:00