This is to fix msvc ide warning.
Fixes dartbug.com/55108
TEST=ci
Change-Id: I7430786b6abf255487e99fa878894647594a6a6f
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356140
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Alexander Aprelev <aam@google.com>
More tests, but all nodes yet, not full test coverage.
Change-Id: I66f2949ccba0e5d2c1e8bccffeca46d6ca6c1ca6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355888
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
Fix an issue where DDS would fail to initialize when an isolate in the target process was unable to handle service requests (e.g., when executing FFI code or blocked on a system call).
Fixes b/323386606
Change-Id: I659ebaf750e2c800e9819809d1104e024cb059da
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354681
Reviewed-by: Derek Xu <derekx@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
The data shows a lot of variation by machine. The slowest test samples
bring the p90 above 4s, which explains that we often hit the limit.
I expect that we'll continue seeing flakes, but less often as a result
of this change. That said, some of the e2e test are taking close to 4
minutes, so we may need additional sharding or switch our approach if
that ocurrs more often.
Change-Id: I47c0dbce6f766edf7c2845d26f11ae7c6372a7bc
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355980
Reviewed-by: Nicholas Shahan <nshahan@google.com>
Commit-Queue: Sigmund Cherem <sigmund@google.com>
Fixes https://github.com/dart-lang/sdk/issues/55107
The lack of parentheses around the ternary operator made the check
invalid when there are members that aren't constructors in the
extension type.
Change-Id: I87ce918c478113f682d3df28f148b7f59d4fd075
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355883
Reviewed-by: Sigmund Cherem <sigmund@google.com>
Commit-Queue: Srujan Gaddam <srujzs@google.com>
Opt in to CBuild being green.
Remove denylisted bots now that issue is resolved.
Change-Id: I89c23720eaed78b317067bbdb065fe0cef8ecd75
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/356022
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: William Hesse <whesse@google.com>
These are a new type of test that runs with the SDK under test against what
looks like an external package; they start by running "pub get" then run SDK
build commands to build the package, and check that macros applied correctly.
Add tests for various builds that already pass, plus one that doesn't:
cfe_sdk_cli_test fails because it was switched to run from an AOT snapshot
and that doesn't support macros yet.
Change-Id: Ic801cb61bd414d4876566452e01dd8c8203e9013
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353100
Reviewed-by: Jake Macdonald <jakemac@google.com>
Reviewed-by: William Hesse <whesse@google.com>
Commit-Queue: Morgan :) <davidmorgan@google.com>
And use these new getters inside field reads/writes.
This outlines this currently inlined code into calls to a helper
methods. This may make the kernel a little smaller and easier to
read. Also, it removes the need to compute the (now outlined)
expression on arbitrary call sites in the FFI transformer
TEST=test/ffi
TEST=all the expect files
Bug: https://github.com/dart-lang/sdk/issues/44589
Bug: https://github.com/dart-lang/sdk/issues/41237
Change-Id: I53d69778ee50186944229550f89f10c22452e13f
Cq-Include-Trybots: luci.dart.try:vm-aot-android-release-arm64c-try,vm-aot-android-release-arm_x64-try,vm-aot-linux-debug-x64-try,vm-aot-linux-debug-x64c-try,vm-aot-mac-release-arm64-try,vm-aot-mac-release-x64-try,vm-aot-obfuscate-linux-release-x64-try,vm-aot-optimization-level-linux-release-x64-try,vm-appjit-linux-debug-x64-try,vm-asan-linux-release-x64-try,vm-checked-mac-release-arm64-try,vm-eager-optimization-linux-release-ia32-try,vm-eager-optimization-linux-release-x64-try,vm-ffi-android-debug-arm-try,vm-ffi-android-debug-arm64c-try,vm-ffi-qemu-linux-release-arm-try,vm-ffi-qemu-linux-release-riscv64-try,vm-fuchsia-release-x64-try,vm-kernel-linux-debug-x64-try,vm-kernel-precomp-linux-release-x64-try,vm-linux-debug-ia32-try,vm-linux-debug-x64-try,vm-linux-debug-x64c-try,vm-mac-debug-arm64-try,vm-mac-debug-x64-try,vm-msan-linux-release-x64-try,vm-reload-linux-debug-x64-try,vm-reload-rollback-linux-debug-x64-try,vm-ubsan-linux-release-x64-try
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/353261
Commit-Queue: Daco Harkes <dacoharkes@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This reverts commit 492e40713d.
Reason for revert: too expensive
Original change's description:
> Issue 54468. Use (int, int) as backing storage for EnumSet, up to 60 elements.
>
> Bug: https://github.com/dart-lang/sdk/issues/54468
> Change-Id: I04a221526dcc7e380e7e9c84f8bb8b2fed52f4eb
> Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355823
> Reviewed-by: Brian Wilkerson <brianwilkerson@google.com>
> Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Bug: https://github.com/dart-lang/sdk/issues/54468
Change-Id: I9f8b6755c8f8fce4e23dcb8533ef680eb8516dba
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355885
Auto-Submit: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Phil Quitslund <pquitslund@google.com>
Bot-Commit: Rubber Stamper <rubber-stamper@appspot.gserviceaccount.com>
Commit-Queue: Phil Quitslund <pquitslund@google.com>
So, it can be easily copy / pasted, without shifting manually afterwards.
Change-Id: I7da463226e2c276d41b1eb01226ade620c59d77b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355826
Commit-Queue: Konstantin Shcheglov <scheglov@google.com>
Reviewed-by: Keerti Parthasarathy <keertip@google.com>
Since https://dart-review.googlesource.com/c/sdk/+/355000 landed, we
don't need to special case the coverage collector to ignore throws of
late initialization errors.
TEST=No behavior changes, so using CI
Change-Id: I3bce5409f32f48c53035181dbd4c27e3570fbf2b
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355600
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Liam Appelbe <liama@google.com>
Upgrade to latest recommended lints (excluding a few)
Moved to switch expressions
Added a couple of lints about directives
Change-Id: Ibe84f97e84fb50132e61ac38903090447b058d84
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355547
Commit-Queue: Kevin Moore <kevmoo@google.com>
Reviewed-by: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
This CL copies and modifies hash map and set base class `_HashBase`
currently shared with the VM, to improve types of the fields.
The Wasm struct for hash map and set objects was previously:
(type $_HashBase (sub $Object (struct
(field $field0 i32)
(field $field1 (mut i32))
(field $field2 (mut (ref null $Object))) ;; _index
(field $field3 (mut i64))
(field $field4 (mut (ref $Object))) ;; _data
(field $field5 (mut i64))
(field $field6 (mut i64)))))
Now:
(type $_HashBase (sub $Object (struct
(field $field0 i32)
(field $field1 (mut i32))
(field $field2 (mut (ref $Array<WasmI32>))) ;; _index
(field $field3 (mut i64))
(field $field4 (mut (ref $Array<Object?>))) ;; _data
(field $field5 (mut i64))
(field $field6 (mut i64)))))
_index and _data fields are now non-nullable Wasm arrays. This removes
downcasts and one layer of indirection when accessing the elements. In
addition, when accessing `_index` this eliminates unboxing the integers.
Fixes#54961.
Change-Id: I4e6bd5129c7c57f5716ccb23e46060d73ffca217
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/354843
Commit-Queue: Ömer Ağacan <omersa@google.com>
Reviewed-by: Martin Kustermann <kustermann@google.com>
Also eliminate some inconsistent whitespace
Change-Id: I4daea6d038c0c07e5bd777edc540a24fde49825a
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355623
Reviewed-by: Ömer Ağacan <omersa@google.com>
Commit-Queue: Kevin Moore <kevmoo@google.com>
Fix the case where both Goma and RB is turned on together and conflicts.
Bug: b/296994239
Change-Id: If37fe35dc3d8f025c22a041545cfe0b50cea4be5
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355761
Auto-Submit: Jonas Termansen <sortie@google.com>
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
The avoids the Windows default of using ANSI.
Change-Id: I1a6177729bb4e2453522e763b490396b2f930a42
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355741
Reviewed-by: Jonas Termansen <sortie@google.com>
Commit-Queue: Johnni Winther <johnniwinther@google.com>
The previous implementation always returns "true", making the PR a
no-op as it only does something for AOT runtimes. e2e test coverage
will land in
https://dart-review.googlesource.com/c/sdk/+/353100 to prevent such
mistakes in future.
R=johnniwinther@google.com
Change-Id: I8481187070a0af12a3f3bd77baa471f1a7d3256d
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/355682
Reviewed-by: Johnni Winther <johnniwinther@google.com>
Auto-Submit: Morgan :) <davidmorgan@google.com>
Commit-Queue: Morgan :) <davidmorgan@google.com>
