This changes to the homebrew tooling to modify instead of replace the
formulas. The formulas can now be changed by editing them in the
dart-lang/homebrew-dart repo, rather than in the release tooling.
Also adds a dry-run mode for local testing.
https://github.com/dart-lang/sdk/issues/40990
Change-Id: Ibed90894800e4d84fac3c4558e6f08d629baed62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/141244
Reviewed-by: William Hesse <whesse@google.com>
Found via `brew audit --strict --online dart`
Change-Id: Ib38873f51b169526bf10253422ddf79804930984
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/136703
Auto-Submit: Kevin Moore <kevmoo@google.com>
Reviewed-by: Alexander Thomas <athom@google.com>
This PR modifies update_homebrew to also generate a dart@2 versioned formula. The new file is dropped out right next to the old `dart.rb` file.
The dart@2 formula is a temporary measure to aid application developers
migrating from Dart 1 to Dart 2.
Supersedes https://github.com/dart-lang/homebrew-dart/pull/52.
This looks right by inspection, but I haven't been able to test it yet: my local `dart` environment is all messed up, and I am a Dart newbie. Still, I'm putting this out here as a PR so the discussion from https://github.com/dart-lang/homebrew-dart/pull/52 can proceed.
Closes#33318https://github.com/dart-lang/sdk/pull/33318
GitOrigin-RevId: 5230782aabf4f45199cff9b1fb9c5304e5dcb21c
Change-Id: I78cf5b066d85ac8b0ef51ed44e6eb1a15192b23c
Reviewed-on: https://dart-review.googlesource.com/58120
Commit-Queue: William Hesse <whesse@google.com>
Reviewed-by: William Hesse <whesse@google.com>
This includes Fasta, tools and observatory, so the checked-in SDK must
have the lower-case constants.
Change-Id: I8380ad041ad058f7d02ae19caccfecd434d13d75
Reviewed-on: https://dart-review.googlesource.com/50201
Commit-Queue: Lasse R.H. Nielsen <lrn@google.com>
Reviewed-by: Leaf Petersen <leafp@google.com>
Update the generated `dart.rb` formula file to fix:
```
Warning: Calling <<-EOS.undent is deprecated!
Use <<~EOS instead.
/usr/local/Homebrew/Library/Taps/dart-lang/homebrew-dart/dart.rb:72:in `caveats'
Please report this to the dart-lang/dart tap!
```
being reported by `brew`.
Fixes https://github.com/dart-lang/homebrew-dart/issues/48
Credit for original patch to @fsouza:
06b76e0935Closes#32346https://github.com/dart-lang/sdk/pull/32346
GitOrigin-RevId: 938a696caea21eda193375ad4cce5aab0e7b5e71
Change-Id: I757647a7ef0a373cb0258f0fcf03f89849aeba5e
Reviewed-on: https://dart-review.googlesource.com/44100
Reviewed-by: Kevin Moore <kevmoo@google.com>
Reviewed-by: William Hesse <whesse@google.com>
* basic cleanup to home-brew script
* avoid global variables
* Up a more typical package layout
* add generate binary – make it easy to test the output without dealing with git
* Update output to pass brew audit `brew audit --strict --online dart.rb`
BSD systems don't place bash in /bin and a lot of the dart tools
hardcode a #!/bin/bash shebang that fails the 'all' target build
(not able to execute dart2js since the interpreter is not found).
Solve the issue by using #!/usr/bin/env as the shebang. For scripts
that need to pass arguments to bash modify the script to use the set
command as the first executed line of shell.
BUG=
R=whesse@google.com
Review URL: https://codereview.chromium.org/1552313002 .
