Commit graph

3 commits

Author SHA1 Message Date
Alexander Markov 889d6a9565 [benchmarks/nnbd] Migrate TypedDataDuplicate benchmark to NNBD
Also:

* Clean up lints in both unmigrated and migrated versions of benchmarks.

* Cache lists in local variables in Uint8ListCopyViaLoopBenchmark and
  Float64ListCopyViaLoopBenchmark to make the same number of field
  accesses as in other benchmarks, in order to make comparison between
  different ways of copying typed data more fair.

Change-Id: I1e7e726ebf1f3cf6c199fce515c2a56d94576ba6
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150280
Reviewed-by: Régis Crelier <regis@google.com>
Commit-Queue: Alexander Markov <alexmarkov@google.com>
2020-06-05 22:22:40 +00:00
Jonas Termansen 6f66f82625 [benchmark] Fork benchmarks for null safety and pin internal ones.
This change forks the benchmarks for the null safety feature where there
now is a null safe version at benchmarks/Foo/dart and a legacy Dart 2
version at benchmarks/Foo/dart2. This change allows benchmarks to be
migrated per go/dart-nnbd-benchmark-migration.

Additionally this change pins the internal benchmarks which have been
moved into their own repository and is now versioned along with the Dart
SDK.

The dart2 implementation will be benchmarked instead of the null safe
dart implementation as of this change. The null safe dart implementation
will be used when null safe benchmarking is turned on.

Change-Id: If039fd7100c960169f4161c1d98167aca0af2ded
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/148440
Reviewed-by: Alexander Thomas <athom@google.com>
2020-06-02 12:53:24 +00:00
Alexander Markov a20c9de3e8 [benchmarks] Add typed data copy benchmark
This change adds TypedDataDuplicate benchmark which measures
performance of making a copy of typed data lists.

Issue: https://github.com/dart-lang/sdk/issues/40039
Change-Id: Iadabbe3ca42dab2d2567e36fb1acd83fc2bfeb0c
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/132162
Commit-Queue: Alexander Markov <alexmarkov@google.com>
Reviewed-by: Ryan Macnak <rmacnak@google.com>
2020-01-24 22:04:35 +00:00