languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:10:22 +00:00
Code Issues Projects Releases Packages Wiki Activity

[SDK] Fixes crash in tools/run_abi_tests.py

Browse source 
logRecords is expected to be of type dict, but the fallback value
was previously set to [] (type list).

This CL changes the fallback values to an empty dict.
It also uses the builtin dict.get() to handle to fallback instead
of manually doing so.

Note: This CL will not make the bot go green.
It will change it from purple (infra failure due to crash) to red
since there are tests that are legitimately failing.

Bug: https://github.com/dart-lang/sdk/issues/42625
Cq-Include-Trybots: dart/try:vm-dartkb-linux-release-x64-abi-try
Change-Id: I12ad7688719039566cd16e128997f0f8efc60a69
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/153600
Commit-Queue: Clement Skau <cskau@google.com>
Auto-Submit: Clement Skau <cskau@google.com>
Reviewed-by: Daco Harkes <dacoharkes@google.com>
This commit is contained in:
Clement Skau 2020-07-08 09:56:04 +00:00 committed by commit-bot@chromium.org
parent 2e5e03fe8d
commit fcbf5341f0
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
tools/run_abi_tests.py
View file

@ -195,7 +195,7 @@ def diffAllResults(tests, flags):
flags.configuration_name) flags.configuration_name)
resultFile.write(json.dumps(outResult) + '\n') resultFile.write(json.dumps(outResult) + '\n')
if diffs: if diffs:
logRecords = allLogs[name] if name in allLogs else [] logRecords = allLogs.get(name, {})
logFile.write( logFile.write(
json.dumps( json.dumps(
makeLog(diffs, results, logRecords, flags. makeLog(diffs, results, logRecords, flags.