languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-11-02 10:49:00 +00:00
Code Issues Projects Releases Packages Wiki Activity

Make test.dart always create a result.log file when --write-result-log is set

Browse source 
Before this, if zero tests were run the file wasn't created.

Bug:
Change-Id: I446a90eeb68dca3ee1fe66d473cd55887c206bc1
R=athom@google.com
CC=mkroghj@google.com
Reviewed-on: https://dart-review.googlesource.com/16527
Reviewed-by: Alexander Thomas <athom@google.com>
This commit is contained in:
William Hesse 2017-10-25 17:27:15 +00:00
parent 4c86f98d7a
commit fabb04d47c
2 changed files with 8 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

1
.packages
View file

@ -38,6 +38,7 @@ fasta:pkg/fasta/lib
fixnum:third_party/pkg/fixnum/lib fixnum:third_party/pkg/fixnum/lib
front_end:pkg/front_end/lib front_end:pkg/front_end/lib
func:third_party/pkg/func/lib func:third_party/pkg/func/lib
gardening:tools/gardening/lib
glob:third_party/pkg/glob/lib glob:third_party/pkg/glob/lib
html:third_party/pkg/html/lib html:third_party/pkg/html/lib
http:third_party/pkg/http/lib http:third_party/pkg/http/lib

7
tools/testing/dart/test_configurations.dart
View file

@ -247,6 +247,13 @@ Future testConfigurations(List<Configuration> configurations) async {
if (firstConf.writeResultLog) { if (firstConf.writeResultLog) {
eventListener.add(new ResultLogWriter()); eventListener.add(new ResultLogWriter());
// TODO(mkroghj): The recipe fails if a test.py step doesn't create a
// results.log when no tests are run. Temporary fix to always make a log.
if (firstConf.outputDirectory != null) {
var path = new Path(firstConf.outputDirectory);
new File(path.append(TestUtils.resultLogFileName).toNativePath())
.createSync(recursive: true);
}
} }
if (firstConf.copyCoreDumps) { if (firstConf.copyCoreDumps) {