From fa68d27ef7cc0abd12e1a42977098a3757d67d82 Mon Sep 17 00:00:00 2001 From: William Hesse Date: Fri, 12 Jun 2020 15:58:25 +0000 Subject: [PATCH] [infra] Add explanation to ABI test logs Change-Id: I96ba3fe6bfd294a6b9864973e5e2e9dea20417ba Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/150981 Reviewed-by: Karl Klose Reviewed-by: Alexander Aprelev --- tools/run_abi_tests.py | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/tools/run_abi_tests.py b/tools/run_abi_tests.py index cecf86a8098..1810df82f3d 100644 --- a/tools/run_abi_tests.py +++ b/tools/run_abi_tests.py @@ -166,11 +166,18 @@ def diffResults(results, configuration_name): def makeLog(diffs, results, logRecords, configuration_name): result = pickOne(results) logs = ["%s: %s" % (str(v), l['log']) for v, l in logRecords.items()] + log = ('This test fails if there is a difference in the test results\n' + 'between ABI versions. The expected result is the result on the\n' + 'current ABI: %s\n' + 'These ABI versions reported a different result: %s\n\n' + 'These are the logs of the test runs on different ABI versions.\n' + 'There are no logs for versions where the test passed.\n\n%s' % + (result['result'], repr(diffs), '\n\n\n'.join(logs))) return { 'name': result['name'], 'configuration': configuration_name, 'result': result['result'], - 'log': '\n\n\n'.join([repr(diffs)] + logs), + 'log': log, }