languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[vm] Remove dead library references from the object store.

Browse source 
- dart:_builtin is only available in the standalone embedder, and should have never been referenced by the VM proper.
 - dart:profiler was long ago renamed to dart:developer.

TEST=build
Change-Id: I0743f52efc3331a8500494b2d87f621190566b62
Reviewed-on: https://dart-review.googlesource.com/c/sdk/+/212680
Commit-Queue: Ryan Macnak <rmacnak@google.com>
Reviewed-by: Ben Konyi <bkonyi@google.com>
Reviewed-by: Siva Annamalai <asiva@google.com>
This commit is contained in:
Ryan Macnak 2021-09-08 16:29:19 +00:00 committed by commit-bot@chromium.org
parent ff63fdcba8
commit f9b7ed74dc
4 changed files with 0 additions and 13 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
runtime/vm/bootstrap.cc
View file

@ -138,12 +138,6 @@ static ErrorPtr BootstrapFromKernel(Thread* thread,
return Error::Cast(result).ptr();
}
// The builtin library should be registered with the VM.
const auto& dart_builtin =
String::Handle(zone, String::New("dart:_builtin"));
library = Library::LookupLibrary(thread, dart_builtin);
isolate_group->object_store()->set_builtin_library(library);
if (FLAG_precompiled_mode) {
loader.ReadLoadingUnits();
}

4
runtime/vm/object.cc
View file

@ -13862,10 +13862,6 @@ LibraryPtr Library::NativeWrappersLibrary() {
return IsolateGroup::Current()->object_store()->native_wrappers_library();
}
LibraryPtr Library::ProfilerLibrary() {
return IsolateGroup::Current()->object_store()->profiler_library();
}
LibraryPtr Library::TypedDataLibrary() {
return IsolateGroup::Current()->object_store()->typed_data_library();
}

1
runtime/vm/object.h
View file

@ -4966,7 +4966,6 @@ class Library : public Object {
static LibraryPtr MirrorsLibrary();
#endif
static LibraryPtr NativeWrappersLibrary();
static LibraryPtr ProfilerLibrary();
static LibraryPtr TypedDataLibrary();
static LibraryPtr VMServiceLibrary();

2
runtime/vm/object_store.h
View file

@ -128,7 +128,6 @@ class ObjectPointerVisitor;
RW(Array, canonical_type_parameters) \
RW(Array, canonical_type_arguments) \
RW(Library, async_library) \
RW(Library, builtin_library) \
RW(Library, core_library) \
RW(Library, collection_library) \
RW(Library, convert_library) \
@ -139,7 +138,6 @@ class ObjectPointerVisitor;
RW(Library, math_library) \
RW(Library, mirrors_library) \
RW(Library, native_wrappers_library) \
RW(Library, profiler_library) \
RW(Library, root_library) \
RW(Library, typed_data_library) \
RW(Library, _vmservice_library) \