languages/dart-sdk
languages/dart-sdk
1
0
Fork 0
mirror of https://github.com/dart-lang/sdk synced 2024-09-05 00:13:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

[ VM / Windows ] Removed call to SetThreadDescription which is only supported in new Win 10 builds

Browse source 
This (hopefully) unblocks the Dart SDK roll into Flutter.

Change-Id: I5616fb2ace879f3a0c4532706d472f2cb488267d
Reviewed-on: https://dart-review.googlesource.com/c/94347
Reviewed-by: Ryan Macnak <rmacnak@google.com>
Commit-Queue: Ben Konyi <bkonyi@google.com>
This commit is contained in:
Ben Konyi 2019-02-26 01:00:26 +00:00 committed by commit-bot@chromium.org
parent bf7ecc40f9
commit f7e435ac26
2 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
runtime/bin/thread_win.cc
View file

@ -40,14 +40,10 @@ class ThreadStartData {
static unsigned int __stdcall ThreadEntry(void* data_ptr) {
ThreadStartData* data = reinterpret_cast<ThreadStartData*>(data_ptr);
const char* name = data->name();
Thread::ThreadStartFunction function = data->function();
uword parameter = data->parameter();
delete data;
// Set the thread name.
SetThreadDescription(GetCurrentThread(), reinterpret_cast<PCWSTR>(name));
// Call the supplied thread start function handing it its parameters.
function(parameter);

3
runtime/vm/os_thread_win.cc
View file

@ -51,9 +51,6 @@ static unsigned int __stdcall ThreadEntry(void* data_ptr) {
uword parameter = data->parameter();
delete data;
// Set the thread name.
SetThreadDescription(GetCurrentThread(), reinterpret_cast<PCWSTR>(name));
// Create new OSThread object and set as TLS for new thread.
OSThread* thread = OSThread::CreateOSThread();
if (thread != NULL) {